[INFO] cloning repository https://github.com/NodusCamvein/LiveNAC [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/NodusCamvein/LiveNAC" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNodusCamvein%2FLiveNAC", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNodusCamvein%2FLiveNAC'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fa2ec24c8d6196e798767aae667b1c0580be104c [INFO] linting NodusCamvein/LiveNAC against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNodusCamvein%2FLiveNAC" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/NodusCamvein/LiveNAC [INFO] finished tweaking git repo https://github.com/NodusCamvein/LiveNAC [INFO] tweaked toml for git repo https://github.com/NodusCamvein/LiveNAC written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/NodusCamvein/LiveNAC on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/NodusCamvein/LiveNAC already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded twitch_types v0.4.8 [INFO] [stderr] Downloaded aliri_braid_impl v0.4.0 [INFO] [stderr] Downloaded aliri_braid v0.4.0 [INFO] [stderr] Downloaded thiserror-impl v2.0.15 [INFO] [stderr] Downloaded twitch_oauth2 v0.15.2 [INFO] [stderr] Downloaded toml v0.9.5 [INFO] [stderr] Downloaded egui_glow v0.32.1 [INFO] [stderr] Downloaded emath v0.32.1 [INFO] [stderr] Downloaded egui-wgpu v0.32.1 [INFO] [stderr] Downloaded egui_extras v0.32.1 [INFO] [stderr] Downloaded egui-winit v0.32.1 [INFO] [stderr] Downloaded toml_parser v1.0.2 [INFO] [stderr] Downloaded twitch_api v0.7.2 [INFO] [stderr] Downloaded thiserror v2.0.15 [INFO] [stderr] Downloaded ecolor v0.32.1 [INFO] [stderr] Downloaded eframe v0.32.1 [INFO] [stderr] Downloaded rcgen v0.14.3 [INFO] [stderr] Downloaded epaint v0.32.1 [INFO] [stderr] Downloaded egui v0.32.1 [INFO] [stderr] Downloaded ehttp v0.5.0 [INFO] [stderr] Downloaded epaint_default_fonts v0.32.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 550a78ecb8173780b3ed04493f40ff2de2ef383a0fa561bb724bb215c11c82e7 [INFO] running `Command { std: "docker" "start" "-a" "550a78ecb8173780b3ed04493f40ff2de2ef383a0fa561bb724bb215c11c82e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "550a78ecb8173780b3ed04493f40ff2de2ef383a0fa561bb724bb215c11c82e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "550a78ecb8173780b3ed04493f40ff2de2ef383a0fa561bb724bb215c11c82e7", kill_on_drop: false }` [INFO] [stdout] 550a78ecb8173780b3ed04493f40ff2de2ef383a0fa561bb724bb215c11c82e7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4714f3e4c687a479b0a044e74bda34fecf1238a7705d15a14531940b954bdcd7 [INFO] running `Command { std: "docker" "start" "-a" "4714f3e4c687a479b0a044e74bda34fecf1238a7705d15a14531940b954bdcd7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Checking bitflags v2.9.2 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking libloading v0.8.8 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking winnow v0.7.12 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Checking unicode-ident v1.0.18 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling libm v0.2.15 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Compiling wayland-client v0.31.11 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Compiling rustls v0.23.31 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Checking async-executor v1.13.2 [INFO] [stderr] Compiling xml-rs v0.8.27 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Checking quote v1.0.40 [INFO] [stderr] Checking webpki-roots v1.0.2 [INFO] [stderr] Checking accesskit v0.19.0 [INFO] [stderr] Checking epaint_default_fonts v0.32.1 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking syn v2.0.106 [INFO] [stderr] Checking weezl v0.1.10 [INFO] [stderr] Checking core_maths v0.1.1 [INFO] [stderr] Checking accesskit_consumer v0.28.0 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Compiling serde_json v1.0.142 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Compiling phf v0.11.3 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Compiling thiserror v2.0.15 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling mime_guess2 v2.3.1 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking nix v0.30.1 [INFO] [stderr] Checking memmap2 v0.9.7 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking ab_glyph v0.2.31 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling figment v0.10.19 [INFO] [stderr] Checking data-encoding v2.9.0 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking fontconfig-parser v0.5.8 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking toml_parser v1.0.2 [INFO] [stderr] Checking toml_writer v1.0.2 [INFO] [stderr] Checking indenter v0.3.4 [INFO] [stderr] Checking home v0.5.11 [INFO] [stderr] Checking fontdb v0.23.0 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking yasna v0.5.2 [INFO] [stderr] Checking polling v3.10.0 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking async-io v2.5.0 [INFO] [stderr] Checking rustls-webpki v0.103.4 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rcgen v0.14.3 [INFO] [stderr] Checking async-signal v0.2.12 [INFO] [stderr] Checking async-process v2.4.0 [INFO] [stderr] Checking glutin v0.32.3 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling bytemuck_derive v1.10.1 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling aliri_braid_impl v0.4.0 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Compiling thiserror-impl v2.0.15 [INFO] [stderr] Compiling pear_codegen v0.2.9 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking pear v0.2.9 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking bytemuck v1.23.2 [INFO] [stderr] Checking emath v0.32.1 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking image v0.25.6 [INFO] [stderr] Checking aliri_braid v0.4.0 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking tungstenite v0.27.0 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking ecolor v0.32.1 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking epaint v0.32.1 [INFO] [stderr] Checking arboard v3.6.0 [INFO] [stderr] Checking tracing-appender v0.2.3 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking egui v0.32.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-tungstenite v0.27.0 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking zvariant_utils v3.2.0 [INFO] [stderr] Checking quick-xml v0.36.2 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking twitch_types v0.4.8 [INFO] [stderr] Checking toml_datetime v0.7.0 [INFO] [stderr] Checking serde_path_to_error v0.1.17 [INFO] [stderr] Checking serde_spanned v1.0.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking toml v0.9.5 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking webbrowser v1.0.5 [INFO] [stderr] Checking ureq v2.12.1 [INFO] [stderr] Checking webbrowser v0.8.15 [INFO] [stderr] Checking egui_glow v0.32.1 [INFO] [stderr] Compiling zvariant_derive v5.6.0 [INFO] [stderr] Checking ehttp v0.5.0 [INFO] [stderr] Checking egui_extras v0.32.1 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Compiling zvariant v5.6.0 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stderr] Checking winit v0.30.12 [INFO] [stderr] Checking hyper-util v0.1.16 [INFO] [stderr] Compiling zbus_names v4.2.0 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Compiling zbus_xml v5.0.2 [INFO] [stderr] Checking reqwest v0.12.23 [INFO] [stderr] Compiling zbus_macros v5.9.0 [INFO] [stderr] Compiling zbus-lockstep v0.5.1 [INFO] [stderr] Compiling zbus-lockstep-macros v0.5.1 [INFO] [stderr] Checking twitch_oauth2 v0.15.2 [INFO] [stderr] Checking glutin-winit v0.5.0 [INFO] [stderr] Checking twitch_api v0.7.2 [INFO] [stderr] Checking zbus v5.9.0 [INFO] [stderr] Checking atspi-common v0.9.0 [INFO] [stderr] Checking atspi-proxies v0.9.0 [INFO] [stderr] Checking accesskit_atspi_common v0.12.0 [INFO] [stderr] Checking atspi-connection v0.9.0 [INFO] [stderr] Checking atspi v0.25.0 [INFO] [stderr] Checking accesskit_unix v0.15.0 [INFO] [stderr] Checking accesskit_winit v0.27.0 [INFO] [stderr] Checking egui-winit v0.32.1 [INFO] [stderr] Checking eframe v0.32.1 [INFO] [stderr] Checking livenac v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/config.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | / if !user_config_path.exists() { [INFO] [stdout] 77 | | if let Err(e) = save(&config).await { [INFO] [stdout] 78 | | tracing::warn!("Failed to save initial config: {}", e); [INFO] [stdout] 79 | | } [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 76 ~ if !user_config_path.exists() [INFO] [stdout] 77 ~ && let Err(e) = save(&config).await { [INFO] [stdout] 78 | tracing::warn!("Failed to save initial config: {}", e); [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/config.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | / if let Some(parent) = path.parent() { [INFO] [stdout] 105 | | if !parent.exists() { [INFO] [stdout] 106 | | tokio::fs::create_dir_all(parent) [INFO] [stdout] 107 | | .await [INFO] [stdout] ... | [INFO] [stdout] 110 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 104 ~ if let Some(parent) = path.parent() [INFO] [stdout] 105 ~ && !parent.exists() { [INFO] [stdout] 106 | tokio::fs::create_dir_all(parent) [INFO] [stdout] 107 | .await [INFO] [stdout] 108 | .context("Failed to create config directory")?; [INFO] [stdout] 109 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/reducer.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | / if let Some(profile) = config.profiles.iter_mut().find(|p| &p.name == name) { [INFO] [stdout] 178 | | if profile.twitch_user_id.is_none() { [INFO] [stdout] 179 | | profile.twitch_user_id = Some(user_id.to_string()); [INFO] [stdout] 180 | | } [INFO] [stdout] 181 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 177 ~ if let Some(profile) = config.profiles.iter_mut().find(|p| &p.name == name) [INFO] [stdout] 178 ~ && profile.twitch_user_id.is_none() { [INFO] [stdout] 179 | profile.twitch_user_id = Some(user_id.to_string()); [INFO] [stdout] 180 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `reqwest::Url` [INFO] [stdout] --> src/core/auth.rs:111:28 [INFO] [stdout] | [INFO] [stdout] 111 | let redirect_uri = Url::parse(REDIRECT_URI).expect("is known-good").into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Url::parse(REDIRECT_URI).expect("is known-good")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/auth.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | / if let Some(parent) = path.parent() { [INFO] [stdout] 156 | | if !parent.exists() { [INFO] [stdout] 157 | | tokio::fs::create_dir_all(parent).await?; [INFO] [stdout] 158 | | } [INFO] [stdout] 159 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 155 ~ if let Some(parent) = path.parent() [INFO] [stdout] 156 ~ && !parent.exists() { [INFO] [stdout] 157 | tokio::fs::create_dir_all(parent).await?; [INFO] [stdout] 158 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/auth.rs:232:13 [INFO] [stdout] | [INFO] [stdout] 232 | / if let Some(tx) = tx.lock().unwrap().take() { [INFO] [stdout] 233 | | if tx.send((code, state)).is_err() { [INFO] [stdout] 234 | | tracing::error!("oneshot channel receiver dropped before being used"); [INFO] [stdout] 235 | | } [INFO] [stdout] 236 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 232 ~ if let Some(tx) = tx.lock().unwrap().take() [INFO] [stdout] 233 ~ && tx.send((code, state)).is_err() { [INFO] [stdout] 234 | tracing::error!("oneshot channel receiver dropped before being used"); [INFO] [stdout] 235 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/config.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | / if !user_config_path.exists() { [INFO] [stdout] 77 | | if let Err(e) = save(&config).await { [INFO] [stdout] 78 | | tracing::warn!("Failed to save initial config: {}", e); [INFO] [stdout] 79 | | } [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 76 ~ if !user_config_path.exists() [INFO] [stdout] 77 ~ && let Err(e) = save(&config).await { [INFO] [stdout] 78 | tracing::warn!("Failed to save initial config: {}", e); [INFO] [stdout] 79 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/config.rs:104:5 [INFO] [stdout] | [INFO] [stdout] 104 | / if let Some(parent) = path.parent() { [INFO] [stdout] 105 | | if !parent.exists() { [INFO] [stdout] 106 | | tokio::fs::create_dir_all(parent) [INFO] [stdout] 107 | | .await [INFO] [stdout] ... | [INFO] [stdout] 110 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 104 ~ if let Some(parent) = path.parent() [INFO] [stdout] 105 ~ && !parent.exists() { [INFO] [stdout] 106 | tokio::fs::create_dir_all(parent) [INFO] [stdout] 107 | .await [INFO] [stdout] 108 | .context("Failed to create config directory")?; [INFO] [stdout] 109 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `twitch_api::helix::eventsub::CreateEventSubSubscriptionBody` [INFO] [stdout] --> src/core/eventsub.rs:141:17 [INFO] [stdout] | [INFO] [stdout] 141 | body.into(), [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/eventsub.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | / if let Event::ChannelChatMessageV1(payload) = notification { [INFO] [stdout] 156 | | if let Message::Notification(event_data) = payload.message { [INFO] [stdout] 157 | | let chatter_display_name = event_data.chatter_user_name; [INFO] [stdout] ... | [INFO] [stdout] 206 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 155 ~ if let Event::ChannelChatMessageV1(payload) = notification [INFO] [stdout] 156 ~ && let Message::Notification(event_data) = payload.message { [INFO] [stdout] 157 | let chatter_display_name = event_data.chatter_user_name; [INFO] [stdout] ... [INFO] [stdout] 204 | } [INFO] [stdout] 205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app/reducer.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | / if let Some(profile) = config.profiles.iter_mut().find(|p| &p.name == name) { [INFO] [stdout] 178 | | if profile.twitch_user_id.is_none() { [INFO] [stdout] 179 | | profile.twitch_user_id = Some(user_id.to_string()); [INFO] [stdout] 180 | | } [INFO] [stdout] 181 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 177 ~ if let Some(profile) = config.profiles.iter_mut().find(|p| &p.name == name) [INFO] [stdout] 178 ~ && profile.twitch_user_id.is_none() { [INFO] [stdout] 179 | profile.twitch_user_id = Some(user_id.to_string()); [INFO] [stdout] 180 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/app_layout.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | / if let Some(font_id) = db.query(&query) { [INFO] [stdout] 99 | | if let Some(font_source) = db.face_source(font_id) { [INFO] [stdout] 100 | | let font_data: Option> = match font_source.0 { [INFO] [stdout] 101 | | fontdb::Source::Binary(data) => { [INFO] [stdout] ... | [INFO] [stdout] 134 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 98 ~ if let Some(font_id) = db.query(&query) [INFO] [stdout] 99 ~ && let Some(font_source) = db.face_source(font_id) { [INFO] [stdout] 100 | let font_data: Option> = match font_source.0 { [INFO] [stdout] ... [INFO] [stdout] 132 | } [INFO] [stdout] 133 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `reqwest::Url` [INFO] [stdout] --> src/core/auth.rs:111:28 [INFO] [stdout] | [INFO] [stdout] 111 | let redirect_uri = Url::parse(REDIRECT_URI).expect("is known-good").into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Url::parse(REDIRECT_URI).expect("is known-good")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/app_layout.rs:353:9 [INFO] [stdout] | [INFO] [stdout] 353 | / if let AppState::LoggedOut { [INFO] [stdout] 354 | | show_profile_manager_on_entry, [INFO] [stdout] 355 | | } = &mut self.state [INFO] [stdout] ... | [INFO] [stdout] 361 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 355 ~ } = &mut self.state [INFO] [stdout] 356 ~ && *show_profile_manager_on_entry { [INFO] [stdout] 357 | self.show_profile_manager = true; [INFO] [stdout] 358 | *show_profile_manager_on_entry = false; [INFO] [stdout] 359 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/auth.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | / if let Some(parent) = path.parent() { [INFO] [stdout] 156 | | if !parent.exists() { [INFO] [stdout] 157 | | tokio::fs::create_dir_all(parent).await?; [INFO] [stdout] 158 | | } [INFO] [stdout] 159 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 155 ~ if let Some(parent) = path.parent() [INFO] [stdout] 156 ~ && !parent.exists() { [INFO] [stdout] 157 | tokio::fs::create_dir_all(parent).await?; [INFO] [stdout] 158 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/ui/app_layout.rs:441:28 [INFO] [stdout] | [INFO] [stdout] 441 | || client_id_input_resp [INFO] [stdout] | ____________________________^ [INFO] [stdout] 442 | | .as_ref() [INFO] [stdout] 443 | | .map_or(false, |r| r.lost_focus()) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 443 - .map_or(false, |r| r.lost_focus()) [INFO] [stdout] 443 + .is_some_and(|r| r.lost_focus()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/ui/app_layout.rs:444:28 [INFO] [stdout] | [INFO] [stdout] 444 | || client_secret_input_resp [INFO] [stdout] | ____________________________^ [INFO] [stdout] 445 | | .as_ref() [INFO] [stdout] 446 | | .map_or(false, |r| r.lost_focus())) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 446 - .map_or(false, |r| r.lost_focus())) [INFO] [stdout] 446 + .is_some_and(|r| r.lost_focus())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `profiles::draw_profiles_ui` doesn't need a mutable reference [INFO] [stdout] --> src/ui/app_layout.rs:510:17 [INFO] [stdout] | [INFO] [stdout] 510 | &mut self.profile_manager_error, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 510 - &mut self.profile_manager_error, [INFO] [stdout] 510 + &self.profile_manager_error, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/auth.rs:232:13 [INFO] [stdout] | [INFO] [stdout] 232 | / if let Some(tx) = tx.lock().unwrap().take() { [INFO] [stdout] 233 | | if tx.send((code, state)).is_err() { [INFO] [stdout] 234 | | tracing::error!("oneshot channel receiver dropped before being used"); [INFO] [stdout] 235 | | } [INFO] [stdout] 236 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 232 ~ if let Some(tx) = tx.lock().unwrap().take() [INFO] [stdout] 233 ~ && tx.send((code, state)).is_err() { [INFO] [stdout] 234 | tracing::error!("oneshot channel receiver dropped before being used"); [INFO] [stdout] 235 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/app_layout.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let AppState::LoggedIn { [INFO] [stdout] 742 | | current_channel, [INFO] [stdout] 743 | | send_in_progress, [INFO] [stdout] 744 | | last_error, [INFO] [stdout] ... | [INFO] [stdout] 804 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 750 ~ } = &mut self.state [INFO] [stdout] 751 ~ && let Some(channel) = current_channel.clone() { [INFO] [stdout] 752 | *send_in_progress = true; [INFO] [stdout] ... [INFO] [stdout] 801 | }); [INFO] [stdout] 802 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/ui/chat/user_list.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | sorted_users.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 11 - sorted_users.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 11 + sorted_users.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/profiles.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | / if !is_active { [INFO] [stdout] 36 | | if ui.button("Switch").clicked() { [INFO] [stdout] 37 | | action = Some(ProfileManagerAction::Login(profile.name.clone())); [INFO] [stdout] 38 | | } [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 35 ~ if !is_active [INFO] [stdout] 36 ~ && ui.button("Switch").clicked() { [INFO] [stdout] 37 | action = Some(ProfileManagerAction::Login(profile.name.clone())); [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/profiles.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / if (add_button_clicked || enter_pressed) && !new_profile_name.is_empty() { [INFO] [stdout] 56 | | if !config.profiles.iter().any(|p| p.name == *new_profile_name) { [INFO] [stdout] 57 | | action = Some(ProfileManagerAction::Add(new_profile_name.clone())); [INFO] [stdout] 58 | | new_profile_name.clear(); [INFO] [stdout] ... | [INFO] [stdout] 61 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 55 ~ if (add_button_clicked || enter_pressed) && !new_profile_name.is_empty() [INFO] [stdout] 56 ~ && !config.profiles.iter().any(|p| p.name == *new_profile_name) { [INFO] [stdout] 57 | action = Some(ProfileManagerAction::Add(new_profile_name.clone())); [INFO] [stdout] 58 | new_profile_name.clear(); [INFO] [stdout] 59 | } [INFO] [stdout] 60 ~ // The error will be set in app_layout and displayed on the next frame. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/profiles.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | / if !config [INFO] [stdout] 82 | | .profiles [INFO] [stdout] 83 | | .iter() [INFO] [stdout] 84 | | .any(|p| p.name == *profile_to_remove_name) [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ .any(|p| p.name == *profile_to_remove_name) [INFO] [stdout] 85 ~ && let Some(first_profile) = config.profiles.first() { [INFO] [stdout] 86 | *profile_to_remove_name = first_profile.name.clone(); [INFO] [stdout] 87 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `twitch_api::helix::eventsub::CreateEventSubSubscriptionBody` [INFO] [stdout] --> src/core/eventsub.rs:141:17 [INFO] [stdout] | [INFO] [stdout] 141 | body.into(), [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/eventsub.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | / if let Event::ChannelChatMessageV1(payload) = notification { [INFO] [stdout] 156 | | if let Message::Notification(event_data) = payload.message { [INFO] [stdout] 157 | | let chatter_display_name = event_data.chatter_user_name; [INFO] [stdout] ... | [INFO] [stdout] 206 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 155 ~ if let Event::ChannelChatMessageV1(payload) = notification [INFO] [stdout] 156 ~ && let Message::Notification(event_data) = payload.message { [INFO] [stdout] 157 | let chatter_display_name = event_data.chatter_user_name; [INFO] [stdout] ... [INFO] [stdout] 204 | } [INFO] [stdout] 205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/app_layout.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | / if let Some(font_id) = db.query(&query) { [INFO] [stdout] 99 | | if let Some(font_source) = db.face_source(font_id) { [INFO] [stdout] 100 | | let font_data: Option> = match font_source.0 { [INFO] [stdout] 101 | | fontdb::Source::Binary(data) => { [INFO] [stdout] ... | [INFO] [stdout] 134 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 98 ~ if let Some(font_id) = db.query(&query) [INFO] [stdout] 99 ~ && let Some(font_source) = db.face_source(font_id) { [INFO] [stdout] 100 | let font_data: Option> = match font_source.0 { [INFO] [stdout] ... [INFO] [stdout] 132 | } [INFO] [stdout] 133 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/app_layout.rs:353:9 [INFO] [stdout] | [INFO] [stdout] 353 | / if let AppState::LoggedOut { [INFO] [stdout] 354 | | show_profile_manager_on_entry, [INFO] [stdout] 355 | | } = &mut self.state [INFO] [stdout] ... | [INFO] [stdout] 361 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 355 ~ } = &mut self.state [INFO] [stdout] 356 ~ && *show_profile_manager_on_entry { [INFO] [stdout] 357 | self.show_profile_manager = true; [INFO] [stdout] 358 | *show_profile_manager_on_entry = false; [INFO] [stdout] 359 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/ui/app_layout.rs:441:28 [INFO] [stdout] | [INFO] [stdout] 441 | || client_id_input_resp [INFO] [stdout] | ____________________________^ [INFO] [stdout] 442 | | .as_ref() [INFO] [stdout] 443 | | .map_or(false, |r| r.lost_focus()) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 443 - .map_or(false, |r| r.lost_focus()) [INFO] [stdout] 443 + .is_some_and(|r| r.lost_focus()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/ui/app_layout.rs:444:28 [INFO] [stdout] | [INFO] [stdout] 444 | || client_secret_input_resp [INFO] [stdout] | ____________________________^ [INFO] [stdout] 445 | | .as_ref() [INFO] [stdout] 446 | | .map_or(false, |r| r.lost_focus())) [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 446 - .map_or(false, |r| r.lost_focus())) [INFO] [stdout] 446 + .is_some_and(|r| r.lost_focus())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `profiles::draw_profiles_ui` doesn't need a mutable reference [INFO] [stdout] --> src/ui/app_layout.rs:510:17 [INFO] [stdout] | [INFO] [stdout] 510 | &mut self.profile_manager_error, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 510 - &mut self.profile_manager_error, [INFO] [stdout] 510 + &self.profile_manager_error, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/app_layout.rs:741:9 [INFO] [stdout] | [INFO] [stdout] 741 | / if let AppState::LoggedIn { [INFO] [stdout] 742 | | current_channel, [INFO] [stdout] 743 | | send_in_progress, [INFO] [stdout] 744 | | last_error, [INFO] [stdout] ... | [INFO] [stdout] 804 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 750 ~ } = &mut self.state [INFO] [stdout] 751 ~ && let Some(channel) = current_channel.clone() { [INFO] [stdout] 752 | *send_in_progress = true; [INFO] [stdout] ... [INFO] [stdout] 801 | }); [INFO] [stdout] 802 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/ui/chat/user_list.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | sorted_users.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 11 - sorted_users.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 11 + sorted_users.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/profiles.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | / if !is_active { [INFO] [stdout] 36 | | if ui.button("Switch").clicked() { [INFO] [stdout] 37 | | action = Some(ProfileManagerAction::Login(profile.name.clone())); [INFO] [stdout] 38 | | } [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 35 ~ if !is_active [INFO] [stdout] 36 ~ && ui.button("Switch").clicked() { [INFO] [stdout] 37 | action = Some(ProfileManagerAction::Login(profile.name.clone())); [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/profiles.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / if (add_button_clicked || enter_pressed) && !new_profile_name.is_empty() { [INFO] [stdout] 56 | | if !config.profiles.iter().any(|p| p.name == *new_profile_name) { [INFO] [stdout] 57 | | action = Some(ProfileManagerAction::Add(new_profile_name.clone())); [INFO] [stdout] 58 | | new_profile_name.clear(); [INFO] [stdout] ... | [INFO] [stdout] 61 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 55 ~ if (add_button_clicked || enter_pressed) && !new_profile_name.is_empty() [INFO] [stdout] 56 ~ && !config.profiles.iter().any(|p| p.name == *new_profile_name) { [INFO] [stdout] 57 | action = Some(ProfileManagerAction::Add(new_profile_name.clone())); [INFO] [stdout] 58 | new_profile_name.clear(); [INFO] [stdout] 59 | } [INFO] [stdout] 60 ~ // The error will be set in app_layout and displayed on the next frame. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ui/profiles.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | / if !config [INFO] [stdout] 82 | | .profiles [INFO] [stdout] 83 | | .iter() [INFO] [stdout] 84 | | .any(|p| p.name == *profile_to_remove_name) [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ .any(|p| p.name == *profile_to_remove_name) [INFO] [stdout] 85 ~ && let Some(first_profile) = config.profiles.first() { [INFO] [stdout] 86 | *profile_to_remove_name = first_profile.name.clone(); [INFO] [stdout] 87 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 46s [INFO] running `Command { std: "docker" "inspect" "4714f3e4c687a479b0a044e74bda34fecf1238a7705d15a14531940b954bdcd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4714f3e4c687a479b0a044e74bda34fecf1238a7705d15a14531940b954bdcd7", kill_on_drop: false }` [INFO] [stdout] 4714f3e4c687a479b0a044e74bda34fecf1238a7705d15a14531940b954bdcd7