[INFO] cloning repository https://github.com/NoHaxito/nisq [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/NoHaxito/nisq" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNoHaxito%2Fnisq", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNoHaxito%2Fnisq'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f00d0e4a6ec3124b84a8fa298d80cf8f206361bd [INFO] linting NoHaxito/nisq against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNoHaxito%2Fnisq" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/NoHaxito/nisq [INFO] finished tweaking git repo https://github.com/NoHaxito/nisq [INFO] tweaked toml for git repo https://github.com/NoHaxito/nisq written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/NoHaxito/nisq on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/NoHaxito/nisq already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ctrlc v3.4.4 [INFO] [stderr] Downloaded proc-macro2 v1.0.82 [INFO] [stderr] Downloaded unicode-width v0.1.12 [INFO] [stderr] Downloaded syn v2.0.61 [INFO] [stderr] Downloaded cliclack v0.2.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 621a7d618e0bfd695a67181f89569a69fe33afdaa14f8deb9a9c81944488c774 [INFO] running `Command { std: "docker" "start" "-a" "621a7d618e0bfd695a67181f89569a69fe33afdaa14f8deb9a9c81944488c774", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "621a7d618e0bfd695a67181f89569a69fe33afdaa14f8deb9a9c81944488c774", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "621a7d618e0bfd695a67181f89569a69fe33afdaa14f8deb9a9c81944488c774", kill_on_drop: false }` [INFO] [stdout] 621a7d618e0bfd695a67181f89569a69fe33afdaa14f8deb9a9c81944488c774 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 52c3e2ea8c8e73c32ff49ecfd3a6bd090bc5b061443ddc001c5f2f7f841df4e9 [INFO] running `Command { std: "docker" "start" "-a" "52c3e2ea8c8e73c32ff49ecfd3a6bd090bc5b061443ddc001c5f2f7f841df4e9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.61 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking ctrlc v3.4.4 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking cliclack v0.2.5 [INFO] [stderr] Checking nisq v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:4:24 [INFO] [stdout] | [INFO] [stdout] 4 | Ok(mut dir) => return Ok(dir.next().is_none()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - Ok(mut dir) => return Ok(dir.next().is_none()), [INFO] [stdout] 4 + Ok(mut dir) => Ok(dir.next().is_none()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | return Ok(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 - return Ok(true); [INFO] [stdout] 6 + Ok(true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 60 | let mut directory = if !dir.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `dir.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:65:27 [INFO] [stdout] | [INFO] [stdout] 65 | let mut template = if !tmpl.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `tmpl.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:70:34 [INFO] [stdout] | [INFO] [stdout] 70 | let mut package_manager = if !pkgm.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `pkgm.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dir` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 60 | let mut directory = if !dir.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 61 | dir.unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tmpl` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 65 | let mut template = if !tmpl.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 66 | tmpl.unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `pkgm` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 70 | let mut package_manager = if !pkgm.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 71 | pkgm.unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:101:27 [INFO] [stdout] | [INFO] [stdout] 101 | template = select(format!("Wich template you want to use?")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Wich template you want to use?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:166:11 [INFO] [stdout] | [INFO] [stdout] 166 | outro(format!("Done ✨"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Done ✨".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:4:24 [INFO] [stdout] | [INFO] [stdout] 4 | Ok(mut dir) => return Ok(dir.next().is_none()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 4 - Ok(mut dir) => return Ok(dir.next().is_none()), [INFO] [stdout] 4 + Ok(mut dir) => Ok(dir.next().is_none()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | return Ok(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 6 - return Ok(true); [INFO] [stdout] 6 + Ok(true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 60 | let mut directory = if !dir.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `dir.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:65:27 [INFO] [stdout] | [INFO] [stdout] 65 | let mut template = if !tmpl.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `tmpl.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:70:34 [INFO] [stdout] | [INFO] [stdout] 70 | let mut package_manager = if !pkgm.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `pkgm.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dir` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 60 | let mut directory = if !dir.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 61 | dir.unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tmpl` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 65 | let mut template = if !tmpl.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 66 | tmpl.unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `pkgm` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 70 | let mut package_manager = if !pkgm.is_none() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 71 | pkgm.unwrap().to_string() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:101:27 [INFO] [stdout] | [INFO] [stdout] 101 | template = select(format!("Wich template you want to use?")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Wich template you want to use?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:166:11 [INFO] [stdout] | [INFO] [stdout] 166 | outro(format!("Done ✨"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Done ✨".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.55s [INFO] running `Command { std: "docker" "inspect" "52c3e2ea8c8e73c32ff49ecfd3a6bd090bc5b061443ddc001c5f2f7f841df4e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52c3e2ea8c8e73c32ff49ecfd3a6bd090bc5b061443ddc001c5f2f7f841df4e9", kill_on_drop: false }` [INFO] [stdout] 52c3e2ea8c8e73c32ff49ecfd3a6bd090bc5b061443ddc001c5f2f7f841df4e9