[INFO] cloning repository https://github.com/NithinS74/nesoxide [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/NithinS74/nesoxide" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNithinS74%2Fnesoxide", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNithinS74%2Fnesoxide'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 91268a9105cb4266bcdd51ba2888592561cacb02 [INFO] linting NithinS74/nesoxide against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNithinS74%2Fnesoxide" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/NithinS74/nesoxide [INFO] finished tweaking git repo https://github.com/NithinS74/nesoxide [INFO] tweaked toml for git repo https://github.com/NithinS74/nesoxide written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/NithinS74/nesoxide on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/NithinS74/nesoxide already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1476207facc2e28f7a8c8b48ab471bf8d005dbee8c913c65ffe6fb413b0400ac [INFO] running `Command { std: "docker" "start" "-a" "1476207facc2e28f7a8c8b48ab471bf8d005dbee8c913c65ffe6fb413b0400ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1476207facc2e28f7a8c8b48ab471bf8d005dbee8c913c65ffe6fb413b0400ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1476207facc2e28f7a8c8b48ab471bf8d005dbee8c913c65ffe6fb413b0400ac", kill_on_drop: false }` [INFO] [stdout] 1476207facc2e28f7a8c8b48ab471bf8d005dbee8c913c65ffe6fb413b0400ac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 07be8ba670b1d0683b28d4c040620a83549a76920cdbc546068886f0e6dbd6b5 [INFO] running `Command { std: "docker" "start" "-a" "07be8ba670b1d0683b28d4c040620a83549a76920cdbc546068886f0e6dbd6b5", kill_on_drop: false }` [INFO] [stderr] Checking nesoxide v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constant `CARRY` is never used [INFO] [stdout] --> src/cpu/opcode_implementation.rs:1:7 [INFO] [stdout] | [INFO] [stdout] 1 | const CARRY: u8 = 0b0000_0001; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `ZERO` is never used [INFO] [stdout] --> src/cpu/opcode_implementation.rs:2:7 [INFO] [stdout] | [INFO] [stdout] 2 | const ZERO: u8 = 0b0000_0010; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `INTERRUPT` is never used [INFO] [stdout] --> src/cpu/opcode_implementation.rs:3:7 [INFO] [stdout] | [INFO] [stdout] 3 | const INTERRUPT: u8 = 0b0000_0100; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DECIMAL` is never used [INFO] [stdout] --> src/cpu/opcode_implementation.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | const DECIMAL: u8 = 0b0000_1000; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `OVERFLOW` is never used [INFO] [stdout] --> src/cpu/opcode_implementation.rs:5:7 [INFO] [stdout] | [INFO] [stdout] 5 | const OVERFLOW: u8 = 0b0100_0000; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NEGETIVE` is never used [INFO] [stdout] --> src/cpu/opcode_implementation.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const NEGETIVE: u8 = 0b1000_0000; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `AddressingMode` is never used [INFO] [stdout] --> src/cpu/opcode_implementation.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | pub enum AddressingMode { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CPU` is never constructed [INFO] [stdout] --> src/cpu/opcode_implementation.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct CPU { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/cpu/opcode_implementation.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 32 | impl CPU { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] 33 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | pub fn load_program(&mut self, program: Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub fn run_program(&mut self, program: Vec) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 65 | pub fn interpret(&mut self) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 573 | fn branch_if_true(&mut self, value: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 583 | fn asl(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 592 | fn and(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 599 | fn ora(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 605 | fn eor(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 612 | fn cmp(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 624 | fn cpx(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 636 | fn cpy(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 648 | fn inc(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 655 | fn dec(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 663 | fn stack_pop(&mut self) -> u16 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 671 | fn stack_push(&mut self, addr: u16) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 675 | fn lda(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 681 | fn ldx(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 688 | fn ldy(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 695 | fn lsr(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 703 | fn bit(&mut self, address: u16) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 711 | fn get_operand_address(&mut self, mode: &AddressingMode) -> u16 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 776 | fn mem_read_u16(&mut self, addr: u16) -> u16 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 783 | fn mem_write_u16(&mut self, addr: u16, value: u16) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 790 | fn mem_read(&self, addr: u16) -> u8 { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 794 | fn mem_write(&mut self, addr: u16, value: u8) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 798 | fn set_overflow_flag(&mut self, value: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 805 | fn set_zero_flag(&mut self, value: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 813 | fn set_carry_flag_bit0(&mut self, value: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 820 | fn set_carry_flag_bit7(&mut self, value: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 828 | fn set_negetive_flag(&mut self, value: u8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPU` contains a capitalized acronym [INFO] [stdout] --> src/cpu/opcode_implementation.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct CPU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/cpu/opcode_implementation.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | memory: [0 as u8; 0xFFFF], [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu/opcode_implementation.rs:157:41 [INFO] [stdout] | [INFO] [stdout] 157 | self.branch_if_true(!(self.status_register & ZERO == ZERO)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.status_register & ZERO != ZERO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu/opcode_implementation.rs:161:41 [INFO] [stdout] | [INFO] [stdout] 161 | self.branch_if_true(!(self.status_register & NEGETIVE == NEGETIVE)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.status_register & NEGETIVE != NEGETIVE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu/opcode_implementation.rs:780:9 [INFO] [stdout] | [INFO] [stdout] 779 | let out = u16::from_le_bytes(bytes); [INFO] [stdout] | ------------------------------------ unnecessary `let` binding [INFO] [stdout] 780 | out [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 779 ~ [INFO] [stdout] 780 ~ u16::from_le_bytes(bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/opcode_implementation.rs:791:9 [INFO] [stdout] | [INFO] [stdout] 791 | return self.memory[addr as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 791 - return self.memory[addr as usize]; [INFO] [stdout] 791 + self.memory[addr as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/opcode_implementation.rs:834:9 [INFO] [stdout] | [INFO] [stdout] 834 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 833 - } [INFO] [stdout] 834 - return; [INFO] [stdout] 833 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/./cpu_test.rs:535:9 [INFO] [stdout] | [INFO] [stdout] 535 | let mut scpu = CPU::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/./cpu_test.rs:543:9 [INFO] [stdout] | [INFO] [stdout] 543 | let mut scpu = CPU::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/./cpu_test.rs:551:9 [INFO] [stdout] | [INFO] [stdout] 551 | let mut fcpu = CPU::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/./cpu_test.rs:567:9 [INFO] [stdout] | [INFO] [stdout] 567 | let mut cpu = CPU::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/./cpu_test.rs:589:9 [INFO] [stdout] | [INFO] [stdout] 589 | let mut cpu = CPU::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/./cpu_test.rs:612:9 [INFO] [stdout] | [INFO] [stdout] 612 | let mut cpu = CPU::new(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `DECIMAL` is never used [INFO] [stdout] --> src/cpu/opcode_implementation.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 4 | const DECIMAL: u8 = 0b0000_1000; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NoneAddressing` is never constructed [INFO] [stdout] --> src/cpu/opcode_implementation.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub enum AddressingMode { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 19 | NoneAddressing, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_indirect_value` is never used [INFO] [stdout] --> src/cpu/./cpu_test.rs:874:4 [INFO] [stdout] | [INFO] [stdout] 874 | fn read_indirect_value(cpu: &CPU) -> u8 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPU` contains a capitalized acronym [INFO] [stdout] --> src/cpu/opcode_implementation.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct CPU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/cpu/opcode_implementation.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | memory: [0 as u8; 0xFFFF], [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu/opcode_implementation.rs:157:41 [INFO] [stdout] | [INFO] [stdout] 157 | self.branch_if_true(!(self.status_register & ZERO == ZERO)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.status_register & ZERO != ZERO)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu/opcode_implementation.rs:161:41 [INFO] [stdout] | [INFO] [stdout] 161 | self.branch_if_true(!(self.status_register & NEGETIVE == NEGETIVE)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.status_register & NEGETIVE != NEGETIVE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu/opcode_implementation.rs:780:9 [INFO] [stdout] | [INFO] [stdout] 779 | let out = u16::from_le_bytes(bytes); [INFO] [stdout] | ------------------------------------ unnecessary `let` binding [INFO] [stdout] 780 | out [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 779 ~ [INFO] [stdout] 780 ~ u16::from_le_bytes(bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/opcode_implementation.rs:791:9 [INFO] [stdout] | [INFO] [stdout] 791 | return self.memory[addr as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 791 - return self.memory[addr as usize]; [INFO] [stdout] 791 + self.memory[addr as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/opcode_implementation.rs:834:9 [INFO] [stdout] | [INFO] [stdout] 834 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 833 - } [INFO] [stdout] 834 - return; [INFO] [stdout] 833 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.52s [INFO] running `Command { std: "docker" "inspect" "07be8ba670b1d0683b28d4c040620a83549a76920cdbc546068886f0e6dbd6b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07be8ba670b1d0683b28d4c040620a83549a76920cdbc546068886f0e6dbd6b5", kill_on_drop: false }` [INFO] [stdout] 07be8ba670b1d0683b28d4c040620a83549a76920cdbc546068886f0e6dbd6b5