[INFO] cloning repository https://github.com/Niskarsh/get-student-data [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Niskarsh/get-student-data" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNiskarsh%2Fget-student-data", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNiskarsh%2Fget-student-data'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0f5b19e3b6a3a326a57bd35510f6b83da459854e [INFO] linting Niskarsh/get-student-data against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNiskarsh%2Fget-student-data" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Niskarsh/get-student-data [INFO] finished tweaking git repo https://github.com/Niskarsh/get-student-data [INFO] tweaked toml for git repo https://github.com/Niskarsh/get-student-data written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Niskarsh/get-student-data on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Niskarsh/get-student-data already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded postgres-protocol v0.6.6 [INFO] [stderr] Downloaded postgres-types v0.2.6 [INFO] [stderr] Downloaded tokio-postgres v0.7.10 [INFO] [stderr] Downloaded serde_derive v1.0.201 [INFO] [stderr] Downloaded serde v1.0.201 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fb938e8d1f59cc95a6540b68ab5e9898c8dd17845f1395675779c3846393d818 [INFO] running `Command { std: "docker" "start" "-a" "fb938e8d1f59cc95a6540b68ab5e9898c8dd17845f1395675779c3846393d818", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb938e8d1f59cc95a6540b68ab5e9898c8dd17845f1395675779c3846393d818", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb938e8d1f59cc95a6540b68ab5e9898c8dd17845f1395675779c3846393d818", kill_on_drop: false }` [INFO] [stdout] fb938e8d1f59cc95a6540b68ab5e9898c8dd17845f1395675779c3846393d818 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 98bce5c47981e0195c2175d480324f9e480d6c9fcce1fa21aa0a10391635e856 [INFO] running `Command { std: "docker" "start" "-a" "98bce5c47981e0195c2175d480324f9e480d6c9fcce1fa21aa0a10391635e856", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking finl_unicode v1.2.0 [INFO] [stderr] Compiling serde v1.0.201 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking stringprep v0.1.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling syn v2.0.61 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking postgres-protocol v0.6.6 [INFO] [stderr] Checking postgres-types v0.2.6 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-postgres v0.7.10 [INFO] [stderr] Checking get_student_stats v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:86:16 [INFO] [stdout] | [INFO] [stdout] 86 | if !(rows_date_of_admission.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(rows_date_of_admission.len() != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | if !(rows_last_session_date.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(rows_last_session_date.len() != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:108:16 [INFO] [stdout] | [INFO] [stdout] 108 | if !(rows_total_scheduled_sessions.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(rows_total_scheduled_sessions.len() != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:115:16 [INFO] [stdout] | [INFO] [stdout] 115 | if !(rows_total_attended_sessions.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(rows_total_attended_sessions.len() != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | wtr.write_record(&[ [INFO] [stdout] | ______________________^ [INFO] [stdout] 50 | | "Email", [INFO] [stdout] 51 | | "Date of Admission", [INFO] [stdout] 52 | | "Last Session Date", [INFO] [stdout] 53 | | "Total Sessions scheduled", [INFO] [stdout] 54 | | "Total Sessions Attended", [INFO] [stdout] 55 | | ])?; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 49 ~ wtr.write_record([ [INFO] [stdout] 50 + "Email", [INFO] [stdout] 51 + "Date of Admission", [INFO] [stdout] 52 + "Last Session Date", [INFO] [stdout] 53 + "Total Sessions scheduled", [INFO] [stdout] 54 + "Total Sessions Attended", [INFO] [stdout] 55 ~ ])?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:86:18 [INFO] [stdout] | [INFO] [stdout] 86 | if !(rows_date_of_admission.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rows_date_of_admission.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 94 | if !(rows_last_session_date.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rows_last_session_date.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:108:18 [INFO] [stdout] | [INFO] [stdout] 108 | if !(rows_total_scheduled_sessions.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rows_total_scheduled_sessions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:115:18 [INFO] [stdout] | [INFO] [stdout] 115 | if !(rows_total_attended_sessions.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rows_total_attended_sessions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:86:16 [INFO] [stdout] | [INFO] [stdout] 86 | if !(rows_date_of_admission.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(rows_date_of_admission.len() != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | if !(rows_last_session_date.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(rows_last_session_date.len() != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:108:16 [INFO] [stdout] | [INFO] [stdout] 108 | if !(rows_total_scheduled_sessions.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(rows_total_scheduled_sessions.len() != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:115:16 [INFO] [stdout] | [INFO] [stdout] 115 | if !(rows_total_attended_sessions.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(rows_total_attended_sessions.len() != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 49 | wtr.write_record(&[ [INFO] [stdout] | ______________________^ [INFO] [stdout] 50 | | "Email", [INFO] [stdout] 51 | | "Date of Admission", [INFO] [stdout] 52 | | "Last Session Date", [INFO] [stdout] 53 | | "Total Sessions scheduled", [INFO] [stdout] 54 | | "Total Sessions Attended", [INFO] [stdout] 55 | | ])?; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 49 ~ wtr.write_record([ [INFO] [stdout] 50 + "Email", [INFO] [stdout] 51 + "Date of Admission", [INFO] [stdout] 52 + "Last Session Date", [INFO] [stdout] 53 + "Total Sessions scheduled", [INFO] [stdout] 54 + "Total Sessions Attended", [INFO] [stdout] 55 ~ ])?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:86:18 [INFO] [stdout] | [INFO] [stdout] 86 | if !(rows_date_of_admission.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rows_date_of_admission.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 94 | if !(rows_last_session_date.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rows_last_session_date.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:108:18 [INFO] [stdout] | [INFO] [stdout] 108 | if !(rows_total_scheduled_sessions.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rows_total_scheduled_sessions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:115:18 [INFO] [stdout] | [INFO] [stdout] 115 | if !(rows_total_attended_sessions.len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rows_total_attended_sessions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.97s [INFO] running `Command { std: "docker" "inspect" "98bce5c47981e0195c2175d480324f9e480d6c9fcce1fa21aa0a10391635e856", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98bce5c47981e0195c2175d480324f9e480d6c9fcce1fa21aa0a10391635e856", kill_on_drop: false }` [INFO] [stdout] 98bce5c47981e0195c2175d480324f9e480d6c9fcce1fa21aa0a10391635e856