[INFO] cloning repository https://github.com/Niki123456123456/product-similarity-search [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Niki123456123456/product-similarity-search" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNiki123456123456%2Fproduct-similarity-search", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNiki123456123456%2Fproduct-similarity-search'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3330cd1c6d4ebe32ac4a07d13d8ae898aafdfea3 [INFO] linting Niki123456123456/product-similarity-search against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNiki123456123456%2Fproduct-similarity-search" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Niki123456123456/product-similarity-search [INFO] finished tweaking git repo https://github.com/Niki123456123456/product-similarity-search [INFO] tweaked toml for git repo https://github.com/Niki123456123456/product-similarity-search written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Niki123456123456/product-similarity-search on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Niki123456123456/product-similarity-search already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded poll-promise v0.3.0 [INFO] [stderr] Downloaded toml_edit v0.23.9 [INFO] [stderr] Downloaded egui_plot v0.34.0 [INFO] [stderr] Downloaded rfd v0.16.0 [INFO] [stderr] Downloaded ron v0.10.1 [INFO] [stderr] Downloaded moxcms v0.7.10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de011e70cedebad465d613276596debff87539427f2b122da13eeb6c1f3278a4 [INFO] running `Command { std: "docker" "start" "-a" "de011e70cedebad465d613276596debff87539427f2b122da13eeb6c1f3278a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de011e70cedebad465d613276596debff87539427f2b122da13eeb6c1f3278a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de011e70cedebad465d613276596debff87539427f2b122da13eeb6c1f3278a4", kill_on_drop: false }` [INFO] [stdout] de011e70cedebad465d613276596debff87539427f2b122da13eeb6c1f3278a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f349e37e721921b10bc0725b92100d089f3d61a25a94ce55e438a2d6577992eb [INFO] running `Command { std: "docker" "start" "-a" "f349e37e721921b10bc0725b92100d089f3d61a25a94ce55e438a2d6577992eb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Compiling toml_parser v1.0.4 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Compiling toml_datetime v0.7.3 [INFO] [stderr] Compiling indexmap v2.12.1 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Compiling wayland-client v0.31.11 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking tracing-core v0.1.35 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Compiling cc v1.2.49 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking syn v2.0.111 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Compiling toml_edit v0.23.9 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Checking accesskit v0.21.1 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.106 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Compiling xml-rs v0.8.28 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking epaint_default_fonts v0.33.3 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Compiling bumpalo v3.19.0 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Compiling wasm-bindgen v0.2.106 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Checking accesskit_consumer v0.31.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Compiling phf v0.11.3 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling glutin v0.32.3 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Compiling litrs v1.0.0 [INFO] [stderr] Checking async-fs v2.2.0 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Compiling mime_guess2 v2.3.1 [INFO] [stderr] Compiling rfd v0.16.0 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling document-features v0.2.12 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking poll-promise v0.3.0 [INFO] [stderr] Checking moxcms v0.7.10 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.106 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking async-io v2.6.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking tracing v0.1.43 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking emath v0.33.3 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Checking ecolor v0.33.3 [INFO] [stderr] Checking epaint v0.33.3 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.106 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking egui v0.33.3 [INFO] [stderr] Checking zvariant_utils v3.2.1 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking quick-xml v0.36.2 [INFO] [stderr] Checking ron v0.10.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Compiling zvariant_derive v5.8.0 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking js-sys v0.3.83 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Compiling zvariant v5.8.0 [INFO] [stderr] Checking webbrowser v1.0.6 [INFO] [stderr] Checking egui_glow v0.33.3 [INFO] [stderr] Checking egui_plot v0.34.0 [INFO] [stderr] Checking egui_extras v0.33.3 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking zbus_names v4.2.0 [INFO] [stderr] Checking zbus_xml v5.0.2 [INFO] [stderr] Checking web-sys v0.3.83 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.56 [INFO] [stderr] Checking zbus-lockstep v0.5.2 [INFO] [stderr] Compiling zbus_macros v5.12.0 [INFO] [stderr] Compiling zbus-lockstep-macros v0.5.2 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking wayland-protocols-misc v0.3.9 [INFO] [stderr] Checking zbus v5.12.0 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking atspi-common v0.9.0 [INFO] [stderr] Checking ashpd v0.11.0 [INFO] [stderr] Checking atspi-proxies v0.9.0 [INFO] [stderr] Checking accesskit_atspi_common v0.14.2 [INFO] [stderr] Checking atspi-connection v0.9.0 [INFO] [stderr] Checking atspi v0.25.0 [INFO] [stderr] Checking accesskit_unix v0.17.2 [INFO] [stderr] Checking accesskit_winit v0.29.2 [INFO] [stderr] Checking egui-winit v0.33.3 [INFO] [stderr] Checking eframe v0.33.3 [INFO] [stderr] Checking product-similarity-search v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/main.rs:246:17 [INFO] [stdout] | [INFO] [stdout] 246 | for (f) in content.filters.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 246 - for (f) in content.filters.iter() { [INFO] [stdout] 246 + for f in content.filters.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/main.rs:258:17 [INFO] [stdout] | [INFO] [stdout] 258 | for (f) in content.filters.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 258 - for (f) in content.filters.iter() { [INFO] [stdout] 258 + for f in content.filters.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/main.rs:271:17 [INFO] [stdout] | [INFO] [stdout] 271 | for (f) in content.filters.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 271 - for (f) in content.filters.iter() { [INFO] [stdout] 271 + for f in content.filters.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/main.rs:246:17 [INFO] [stdout] | [INFO] [stdout] 246 | for (f) in content.filters.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 246 - for (f) in content.filters.iter() { [INFO] [stdout] 246 + for f in content.filters.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/main.rs:258:17 [INFO] [stdout] | [INFO] [stdout] 258 | for (f) in content.filters.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 258 - for (f) in content.filters.iter() { [INFO] [stdout] 258 + for f in content.filters.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/main.rs:271:17 [INFO] [stdout] | [INFO] [stdout] 271 | for (f) in content.filters.iter() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 271 - for (f) in content.filters.iter() { [INFO] [stdout] 271 + for f in content.filters.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cc` [INFO] [stdout] --> src/main.rs:161:39 [INFO] [stdout] | [INFO] [stdout] 161 | run("product similarity search", |cc| { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_cc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:358:17 [INFO] [stdout] | [INFO] [stdout] 358 | table.body(|mut body| { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/main.rs:225:39 [INFO] [stdout] | [INFO] [stdout] 225 | Value::String(s) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/main.rs:383:31 [INFO] [stdout] | [INFO] [stdout] 383 | Value::String(s) => {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / impl ToString for Value { [INFO] [stdout] 10 | | fn to_string(&self) -> String { [INFO] [stdout] 11 | | match self { [INFO] [stdout] 12 | | Value::Number(n) => n.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 16 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/main.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | / impl std::cmp::PartialOrd for Value { [INFO] [stdout] 19 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 20 | | match (self, other) { [INFO] [stdout] 21 | | (Value::Number(a), Value::Number(b)) => a.partial_cmp(b), [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 20 - match (self, other) { [INFO] [stdout] 21 - (Value::Number(a), Value::Number(b)) => a.partial_cmp(b), [INFO] [stdout] 22 - (Value::String(a), Value::String(b)) => a.partial_cmp(b), [INFO] [stdout] 23 - _ => None, [INFO] [stdout] 24 - } [INFO] [stdout] 25 - } [INFO] [stdout] 19 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | / return Content { [INFO] [stdout] 144 | | headers, [INFO] [stdout] 145 | | data, [INFO] [stdout] 146 | | filtered_data, [INFO] [stdout] 147 | | filters, [INFO] [stdout] 148 | | shown_data: vec![], [INFO] [stdout] 149 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ Content { [INFO] [stdout] 144 + headers, [INFO] [stdout] 145 + data, [INFO] [stdout] 146 + filtered_data, [INFO] [stdout] 147 + filters, [INFO] [stdout] 148 + shown_data: vec![], [INFO] [stdout] 149 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/main.rs:92:44 [INFO] [stdout] | [INFO] [stdout] 92 | let mut rdr = csv::Reader::from_reader(&d[..]); [INFO] [stdout] | ^^^^^^ help: use the original value instead: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | / for result in rdr.records() { [INFO] [stdout] 99 | | if let Ok(r) = result { [INFO] [stdout] 100 | | let mut values = vec![]; [INFO] [stdout] 101 | | for text in r.iter() { [INFO] [stdout] ... | [INFO] [stdout] 110 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | / if let Ok(r) = result { [INFO] [stdout] 100 | | let mut values = vec![]; [INFO] [stdout] 101 | | for text in r.iter() { [INFO] [stdout] 102 | | if let Ok(n) = text.parse::() { [INFO] [stdout] ... | [INFO] [stdout] 108 | | data.push(Record { values }); [INFO] [stdout] 109 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 98 ~ for r in rdr.records().flatten() { [INFO] [stdout] 99 + let mut values = vec![]; [INFO] [stdout] 100 + for text in r.iter() { [INFO] [stdout] 101 + if let Ok(n) = text.parse::() { [INFO] [stdout] 102 + values.push(Value::Number(n)); [INFO] [stdout] 103 + } else { [INFO] [stdout] 104 + values.push(Value::String(text.to_string())); [INFO] [stdout] 105 + } [INFO] [stdout] 106 + } [INFO] [stdout] 107 + data.push(Record { values }); [INFO] [stdout] 108 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | return f; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return f; [INFO] [stdout] 139 + f [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/main.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | / f.max_found = data [INFO] [stdout] 124 | | .iter() [INFO] [stdout] 125 | | .filter_map(|d| d.values.get(i)) [INFO] [stdout] 126 | | .filter_map(|x| match x { [INFO] [stdout] ... | [INFO] [stdout] 129 | | }) [INFO] [stdout] 130 | | .fold(f64::NEG_INFINITY, f64::max); [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Filter { max_found: data [INFO] [stdout] .iter() [INFO] [stdout] .filter_map(|d| d.values.get(i)) [INFO] [stdout] .filter_map(|x| match x { [INFO] [stdout] Value::String(_) => None, [INFO] [stdout] Value::Number(x) => Some(*x), [INFO] [stdout] }) [INFO] [stdout] .fold(f64::NEG_INFINITY, f64::max), min_found: data [INFO] [stdout] .iter() [INFO] [stdout] .filter_map(|d| d.values.get(i)) [INFO] [stdout] .filter_map(|x| match x { [INFO] [stdout] Value::String(_) => None, [INFO] [stdout] Value::Number(x) => Some(*x), [INFO] [stdout] }) [INFO] [stdout] .fold(f64::INFINITY, f64::min), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/main.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let mut f = Filter::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | / return Box::new(move |ctx| { [INFO] [stdout] 170 | | let ui = ctx.ui; [INFO] [stdout] 171 | | [INFO] [stdout] 172 | | ui.horizontal(|ui| { [INFO] [stdout] ... | [INFO] [stdout] 203 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 ~ Box::new(move |ctx| { [INFO] [stdout] 170 + let ui = ctx.ui; [INFO] [stdout] 171 + [INFO] [stdout] 172 + ui.horizontal(|ui| { [INFO] [stdout] 173 + { [INFO] [stdout] 174 + let content = content.lock(); [INFO] [stdout] 175 + ui.label(format!( [INFO] [stdout] 176 + "{} of {} rows", [INFO] [stdout] 177 + content.filtered_data.len(), [INFO] [stdout] 178 + content.data.len() [INFO] [stdout] 179 + )); [INFO] [stdout] 180 + } [INFO] [stdout] 181 + [INFO] [stdout] 182 + if ui.button("open csv").clicked() { [INFO] [stdout] 183 + let task = rfd::AsyncFileDialog::new().pick_file(); [INFO] [stdout] 184 + let c = content.clone(); [INFO] [stdout] 185 + wasm_bindgen_futures::spawn_local(async move { [INFO] [stdout] 186 + let file = task.await; [INFO] [stdout] 187 + if let Some(file) = file { [INFO] [stdout] 188 + let contents = file.read().await; [INFO] [stdout] 189 + let contents = read_csv(&contents); [INFO] [stdout] 190 + { [INFO] [stdout] 191 + let mut c = c.lock(); [INFO] [stdout] 192 + *c = contents; [INFO] [stdout] 193 + } [INFO] [stdout] 194 + } [INFO] [stdout] 195 + }); [INFO] [stdout] 196 + } [INFO] [stdout] 197 + }); [INFO] [stdout] 198 + [INFO] [stdout] 199 + { [INFO] [stdout] 200 + let mut content = content.lock(); [INFO] [stdout] 201 + show_content(ui, &mut content, &mut sorting); [INFO] [stdout] 202 + } [INFO] [stdout] 203 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:213:34 [INFO] [stdout] | [INFO] [stdout] 213 | .x_axis_formatter(|f, _| format!("{}", &content.headers[f.value as usize])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&content.headers[f.value as usize]).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:313:50 [INFO] [stdout] | [INFO] [stdout] 313 | sort_articles(&content.data, &sorting, &mut content.filtered_data); [INFO] [stdout] | ^^^^^^^^ help: change this to: `sorting` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:354:38 [INFO] [stdout] | [INFO] [stdout] 354 | sort_articles(&content.data, &sorting, &mut content.filtered_data); [INFO] [stdout] | ^^^^^^^^ help: change this to: `sorting` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:376:26 [INFO] [stdout] | [INFO] [stdout] 376 | fn filter_articles(data: &mut Vec, filtered_data: &mut Vec, filters: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 376 - fn filter_articles(data: &mut Vec, filtered_data: &mut Vec, filters: &Vec) { [INFO] [stdout] 376 + fn filter_articles(data: &mut [Record], filtered_data: &mut Vec, filters: &Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:376:85 [INFO] [stdout] | [INFO] [stdout] 376 | fn filter_articles(data: &mut Vec, filtered_data: &mut Vec, filters: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 376 - fn filter_articles(data: &mut Vec, filtered_data: &mut Vec, filters: &Vec) { [INFO] [stdout] 376 + fn filter_articles(data: &mut Vec, filtered_data: &mut Vec, filters: &[Filter]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:395:12 [INFO] [stdout] | [INFO] [stdout] 395 | if r_vec.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!r_vec.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:433:9 [INFO] [stdout] | [INFO] [stdout] 433 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 433 - return true; [INFO] [stdout] 433 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:420:21 [INFO] [stdout] | [INFO] [stdout] 420 | / if let Some(min) = &filters[i].min.value { [INFO] [stdout] 421 | | if v < min { [INFO] [stdout] 422 | | return false; [INFO] [stdout] 423 | | } [INFO] [stdout] 424 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 420 ~ if let Some(min) = &filters[i].min.value [INFO] [stdout] 421 ~ && v < min { [INFO] [stdout] 422 | return false; [INFO] [stdout] 423 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:425:21 [INFO] [stdout] | [INFO] [stdout] 425 | / if let Some(max) = &filters[i].max.value { [INFO] [stdout] 426 | | if v > max { [INFO] [stdout] 427 | | return false; [INFO] [stdout] 428 | | } [INFO] [stdout] 429 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 425 ~ if let Some(max) = &filters[i].max.value [INFO] [stdout] 426 ~ && v > max { [INFO] [stdout] 427 | return false; [INFO] [stdout] 428 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:437:24 [INFO] [stdout] | [INFO] [stdout] 437 | fn sort_articles(data: &Vec, sorting: &TabSorting, filtered_data: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 437 - fn sort_articles(data: &Vec, sorting: &TabSorting, filtered_data: &mut Vec) { [INFO] [stdout] 437 + fn sort_articles(data: &[Record], sorting: &TabSorting, filtered_data: &mut Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:437:75 [INFO] [stdout] | [INFO] [stdout] 437 | fn sort_articles(data: &Vec, sorting: &TabSorting, filtered_data: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 437 - fn sort_articles(data: &Vec, sorting: &TabSorting, filtered_data: &mut Vec) { [INFO] [stdout] 437 + fn sort_articles(data: &Vec, sorting: &TabSorting, filtered_data: &mut [usize]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:442:25 [INFO] [stdout] | [INFO] [stdout] 442 | b_value.cmp(&a_value) [INFO] [stdout] | ^^^^^^^^ help: change this to: `a_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:444:25 [INFO] [stdout] | [INFO] [stdout] 444 | a_value.cmp(&b_value) [INFO] [stdout] | ^^^^^^^^ help: change this to: `b_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cc` [INFO] [stdout] --> src/main.rs:161:39 [INFO] [stdout] | [INFO] [stdout] 161 | run("product similarity search", |cc| { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_cc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:358:17 [INFO] [stdout] | [INFO] [stdout] 358 | table.body(|mut body| { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/main.rs:225:39 [INFO] [stdout] | [INFO] [stdout] 225 | Value::String(s) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/main.rs:383:31 [INFO] [stdout] | [INFO] [stdout] 383 | Value::String(s) => {} [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/main.rs:525:5 [INFO] [stdout] | [INFO] [stdout] 525 | / native_options.viewport = [INFO] [stdout] 526 | | egui::ViewportBuilder::default().with_inner_size(egui::vec2(1200.0, 700.0)); [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `eframe::NativeOptions { viewport: egui::ViewportBuilder::default().with_inner_size(egui::vec2(1200.0, 700.0)), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/main.rs:524:5 [INFO] [stdout] | [INFO] [stdout] 524 | let mut native_options = eframe::NativeOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / impl ToString for Value { [INFO] [stdout] 10 | | fn to_string(&self) -> String { [INFO] [stdout] 11 | | match self { [INFO] [stdout] 12 | | Value::Number(n) => n.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 16 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/main.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | / impl std::cmp::PartialOrd for Value { [INFO] [stdout] 19 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 20 | | match (self, other) { [INFO] [stdout] 21 | | (Value::Number(a), Value::Number(b)) => a.partial_cmp(b), [INFO] [stdout] ... | [INFO] [stdout] 26 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 20 - match (self, other) { [INFO] [stdout] 21 - (Value::Number(a), Value::Number(b)) => a.partial_cmp(b), [INFO] [stdout] 22 - (Value::String(a), Value::String(b)) => a.partial_cmp(b), [INFO] [stdout] 23 - _ => None, [INFO] [stdout] 24 - } [INFO] [stdout] 25 - } [INFO] [stdout] 19 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | / return Content { [INFO] [stdout] 144 | | headers, [INFO] [stdout] 145 | | data, [INFO] [stdout] 146 | | filtered_data, [INFO] [stdout] 147 | | filters, [INFO] [stdout] 148 | | shown_data: vec![], [INFO] [stdout] 149 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ Content { [INFO] [stdout] 144 + headers, [INFO] [stdout] 145 + data, [INFO] [stdout] 146 + filtered_data, [INFO] [stdout] 147 + filters, [INFO] [stdout] 148 + shown_data: vec![], [INFO] [stdout] 149 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/main.rs:92:44 [INFO] [stdout] | [INFO] [stdout] 92 | let mut rdr = csv::Reader::from_reader(&d[..]); [INFO] [stdout] | ^^^^^^ help: use the original value instead: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | / for result in rdr.records() { [INFO] [stdout] 99 | | if let Ok(r) = result { [INFO] [stdout] 100 | | let mut values = vec![]; [INFO] [stdout] 101 | | for text in r.iter() { [INFO] [stdout] ... | [INFO] [stdout] 110 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | / if let Ok(r) = result { [INFO] [stdout] 100 | | let mut values = vec![]; [INFO] [stdout] 101 | | for text in r.iter() { [INFO] [stdout] 102 | | if let Ok(n) = text.parse::() { [INFO] [stdout] ... | [INFO] [stdout] 108 | | data.push(Record { values }); [INFO] [stdout] 109 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 98 ~ for r in rdr.records().flatten() { [INFO] [stdout] 99 + let mut values = vec![]; [INFO] [stdout] 100 + for text in r.iter() { [INFO] [stdout] 101 + if let Ok(n) = text.parse::() { [INFO] [stdout] 102 + values.push(Value::Number(n)); [INFO] [stdout] 103 + } else { [INFO] [stdout] 104 + values.push(Value::String(text.to_string())); [INFO] [stdout] 105 + } [INFO] [stdout] 106 + } [INFO] [stdout] 107 + data.push(Record { values }); [INFO] [stdout] 108 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | return f; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 139 - return f; [INFO] [stdout] 139 + f [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/main.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | / f.max_found = data [INFO] [stdout] 124 | | .iter() [INFO] [stdout] 125 | | .filter_map(|d| d.values.get(i)) [INFO] [stdout] 126 | | .filter_map(|x| match x { [INFO] [stdout] ... | [INFO] [stdout] 129 | | }) [INFO] [stdout] 130 | | .fold(f64::NEG_INFINITY, f64::max); [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `Filter { max_found: data [INFO] [stdout] .iter() [INFO] [stdout] .filter_map(|d| d.values.get(i)) [INFO] [stdout] .filter_map(|x| match x { [INFO] [stdout] Value::String(_) => None, [INFO] [stdout] Value::Number(x) => Some(*x), [INFO] [stdout] }) [INFO] [stdout] .fold(f64::NEG_INFINITY, f64::max), min_found: data [INFO] [stdout] .iter() [INFO] [stdout] .filter_map(|d| d.values.get(i)) [INFO] [stdout] .filter_map(|x| match x { [INFO] [stdout] Value::String(_) => None, [INFO] [stdout] Value::Number(x) => Some(*x), [INFO] [stdout] }) [INFO] [stdout] .fold(f64::INFINITY, f64::min), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/main.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let mut f = Filter::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | / return Box::new(move |ctx| { [INFO] [stdout] 170 | | let ui = ctx.ui; [INFO] [stdout] 171 | | [INFO] [stdout] 172 | | ui.horizontal(|ui| { [INFO] [stdout] ... | [INFO] [stdout] 203 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 ~ Box::new(move |ctx| { [INFO] [stdout] 170 + let ui = ctx.ui; [INFO] [stdout] 171 + [INFO] [stdout] 172 + ui.horizontal(|ui| { [INFO] [stdout] 173 + { [INFO] [stdout] 174 + let content = content.lock(); [INFO] [stdout] 175 + ui.label(format!( [INFO] [stdout] 176 + "{} of {} rows", [INFO] [stdout] 177 + content.filtered_data.len(), [INFO] [stdout] 178 + content.data.len() [INFO] [stdout] 179 + )); [INFO] [stdout] 180 + } [INFO] [stdout] 181 + [INFO] [stdout] 182 + if ui.button("open csv").clicked() { [INFO] [stdout] 183 + let task = rfd::AsyncFileDialog::new().pick_file(); [INFO] [stdout] 184 + let c = content.clone(); [INFO] [stdout] 185 + wasm_bindgen_futures::spawn_local(async move { [INFO] [stdout] 186 + let file = task.await; [INFO] [stdout] 187 + if let Some(file) = file { [INFO] [stdout] 188 + let contents = file.read().await; [INFO] [stdout] 189 + let contents = read_csv(&contents); [INFO] [stdout] 190 + { [INFO] [stdout] 191 + let mut c = c.lock(); [INFO] [stdout] 192 + *c = contents; [INFO] [stdout] 193 + } [INFO] [stdout] 194 + } [INFO] [stdout] 195 + }); [INFO] [stdout] 196 + } [INFO] [stdout] 197 + }); [INFO] [stdout] 198 + [INFO] [stdout] 199 + { [INFO] [stdout] 200 + let mut content = content.lock(); [INFO] [stdout] 201 + show_content(ui, &mut content, &mut sorting); [INFO] [stdout] 202 + } [INFO] [stdout] 203 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:213:34 [INFO] [stdout] | [INFO] [stdout] 213 | .x_axis_formatter(|f, _| format!("{}", &content.headers[f.value as usize])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&content.headers[f.value as usize]).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:313:50 [INFO] [stdout] | [INFO] [stdout] 313 | sort_articles(&content.data, &sorting, &mut content.filtered_data); [INFO] [stdout] | ^^^^^^^^ help: change this to: `sorting` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:354:38 [INFO] [stdout] | [INFO] [stdout] 354 | sort_articles(&content.data, &sorting, &mut content.filtered_data); [INFO] [stdout] | ^^^^^^^^ help: change this to: `sorting` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:376:26 [INFO] [stdout] | [INFO] [stdout] 376 | fn filter_articles(data: &mut Vec, filtered_data: &mut Vec, filters: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 376 - fn filter_articles(data: &mut Vec, filtered_data: &mut Vec, filters: &Vec) { [INFO] [stdout] 376 + fn filter_articles(data: &mut [Record], filtered_data: &mut Vec, filters: &Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:376:85 [INFO] [stdout] | [INFO] [stdout] 376 | fn filter_articles(data: &mut Vec, filtered_data: &mut Vec, filters: &Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 376 - fn filter_articles(data: &mut Vec, filtered_data: &mut Vec, filters: &Vec) { [INFO] [stdout] 376 + fn filter_articles(data: &mut Vec, filtered_data: &mut Vec, filters: &[Filter]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:395:12 [INFO] [stdout] | [INFO] [stdout] 395 | if r_vec.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!r_vec.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:433:9 [INFO] [stdout] | [INFO] [stdout] 433 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 433 - return true; [INFO] [stdout] 433 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:420:21 [INFO] [stdout] | [INFO] [stdout] 420 | / if let Some(min) = &filters[i].min.value { [INFO] [stdout] 421 | | if v < min { [INFO] [stdout] 422 | | return false; [INFO] [stdout] 423 | | } [INFO] [stdout] 424 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 420 ~ if let Some(min) = &filters[i].min.value [INFO] [stdout] 421 ~ && v < min { [INFO] [stdout] 422 | return false; [INFO] [stdout] 423 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:425:21 [INFO] [stdout] | [INFO] [stdout] 425 | / if let Some(max) = &filters[i].max.value { [INFO] [stdout] 426 | | if v > max { [INFO] [stdout] 427 | | return false; [INFO] [stdout] 428 | | } [INFO] [stdout] 429 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 425 ~ if let Some(max) = &filters[i].max.value [INFO] [stdout] 426 ~ && v > max { [INFO] [stdout] 427 | return false; [INFO] [stdout] 428 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:437:24 [INFO] [stdout] | [INFO] [stdout] 437 | fn sort_articles(data: &Vec, sorting: &TabSorting, filtered_data: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 437 - fn sort_articles(data: &Vec, sorting: &TabSorting, filtered_data: &mut Vec) { [INFO] [stdout] 437 + fn sort_articles(data: &[Record], sorting: &TabSorting, filtered_data: &mut Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:437:75 [INFO] [stdout] | [INFO] [stdout] 437 | fn sort_articles(data: &Vec, sorting: &TabSorting, filtered_data: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 437 - fn sort_articles(data: &Vec, sorting: &TabSorting, filtered_data: &mut Vec) { [INFO] [stdout] 437 + fn sort_articles(data: &Vec, sorting: &TabSorting, filtered_data: &mut [usize]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:442:25 [INFO] [stdout] | [INFO] [stdout] 442 | b_value.cmp(&a_value) [INFO] [stdout] | ^^^^^^^^ help: change this to: `a_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:444:25 [INFO] [stdout] | [INFO] [stdout] 444 | a_value.cmp(&b_value) [INFO] [stdout] | ^^^^^^^^ help: change this to: `b_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/main.rs:525:5 [INFO] [stdout] | [INFO] [stdout] 525 | / native_options.viewport = [INFO] [stdout] 526 | | egui::ViewportBuilder::default().with_inner_size(egui::vec2(1200.0, 700.0)); [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `eframe::NativeOptions { viewport: egui::ViewportBuilder::default().with_inner_size(egui::vec2(1200.0, 700.0)), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/main.rs:524:5 [INFO] [stdout] | [INFO] [stdout] 524 | let mut native_options = eframe::NativeOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 23s [INFO] running `Command { std: "docker" "inspect" "f349e37e721921b10bc0725b92100d089f3d61a25a94ce55e438a2d6577992eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f349e37e721921b10bc0725b92100d089f3d61a25a94ce55e438a2d6577992eb", kill_on_drop: false }` [INFO] [stdout] f349e37e721921b10bc0725b92100d089f3d61a25a94ce55e438a2d6577992eb