[INFO] cloning repository https://github.com/NicknameAlwaystaken/tcp-practice [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/NicknameAlwaystaken/tcp-practice" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNicknameAlwaystaken%2Ftcp-practice", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNicknameAlwaystaken%2Ftcp-practice'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b0e7091ee0c680a520080667416b25ae2af7fff2 [INFO] linting NicknameAlwaystaken/tcp-practice against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNicknameAlwaystaken%2Ftcp-practice" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/NicknameAlwaystaken/tcp-practice [INFO] finished tweaking git repo https://github.com/NicknameAlwaystaken/tcp-practice [INFO] tweaked toml for git repo https://github.com/NicknameAlwaystaken/tcp-practice written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/NicknameAlwaystaken/tcp-practice on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/NicknameAlwaystaken/tcp-practice already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9746bb86dbfd7c98c8de91e2295f49c91a0195f5de7d7e85caed636ce5710786 [INFO] running `Command { std: "docker" "start" "-a" "9746bb86dbfd7c98c8de91e2295f49c91a0195f5de7d7e85caed636ce5710786", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9746bb86dbfd7c98c8de91e2295f49c91a0195f5de7d7e85caed636ce5710786", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9746bb86dbfd7c98c8de91e2295f49c91a0195f5de7d7e85caed636ce5710786", kill_on_drop: false }` [INFO] [stdout] 9746bb86dbfd7c98c8de91e2295f49c91a0195f5de7d7e85caed636ce5710786 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 532527108f00894c9af2b9ebc1726eff5fef9f8253de383dff13d8d05b96477c [INFO] running `Command { std: "docker" "start" "-a" "532527108f00894c9af2b9ebc1726eff5fef9f8253de383dff13d8d05b96477c", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking config v0.1.0 (/opt/rustwide/workdir/config) [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> config/src/lib.rs:70:38 [INFO] [stdout] | [INFO] [stdout] 70 | let encoding_and_data_type: u8 = (encoding << 6) as u8 | (DataType::AuthRequest.to_u8() & 0x3F); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(encoding << 6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> config/src/lib.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | return valid_string; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return valid_string; [INFO] [stdout] 98 + valid_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> config/src/lib.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | return '0'.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return '0'.to_string(); [INFO] [stdout] 101 + '0'.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> config/src/lib.rs:109:38 [INFO] [stdout] | [INFO] [stdout] 109 | let encoding_and_data_type: u8 = (encoding << 6) as u8 | (DataType::AuthResponse.to_u8() & 0x3F); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(encoding << 6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> config/src/lib.rs:127:38 [INFO] [stdout] | [INFO] [stdout] 127 | let encoding_and_data_type: u8 = (encoding << 6) as u8 | (data_type.to_u8() & 0x3F); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(encoding << 6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> config/src/lib.rs:145:38 [INFO] [stdout] | [INFO] [stdout] 145 | let encoding_and_data_type: u8 = (encoding << 6) as u8 | (data_type.to_u8() & 0x3F); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(encoding << 6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> config/src/lib.rs:70:38 [INFO] [stdout] | [INFO] [stdout] 70 | let encoding_and_data_type: u8 = (encoding << 6) as u8 | (DataType::AuthRequest.to_u8() & 0x3F); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(encoding << 6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> config/src/lib.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | return valid_string; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return valid_string; [INFO] [stdout] 98 + valid_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> config/src/lib.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | return '0'.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return '0'.to_string(); [INFO] [stdout] 101 + '0'.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> config/src/lib.rs:109:38 [INFO] [stdout] | [INFO] [stdout] 109 | let encoding_and_data_type: u8 = (encoding << 6) as u8 | (DataType::AuthResponse.to_u8() & 0x3F); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(encoding << 6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> config/src/lib.rs:127:38 [INFO] [stdout] | [INFO] [stdout] 127 | let encoding_and_data_type: u8 = (encoding << 6) as u8 | (data_type.to_u8() & 0x3F); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(encoding << 6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> config/src/lib.rs:145:38 [INFO] [stdout] | [INFO] [stdout] 145 | let encoding_and_data_type: u8 = (encoding << 6) as u8 | (data_type.to_u8() & 0x3F); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(encoding << 6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking client v0.1.0 (/opt/rustwide/workdir/client) [INFO] [stdout] warning: the `unexpected_value @ _` pattern can be written as just `unexpected_value` [INFO] [stdout] --> client/src/main.rs:101:33 [INFO] [stdout] | [INFO] [stdout] 101 | ... unexpected_value @ _ => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `unexpected_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `unexpected_value @ _` pattern can be written as just `unexpected_value` [INFO] [stdout] --> client/src/main.rs:240:29 [INFO] [stdout] | [INFO] [stdout] 240 | ... unexpected_value @ _ => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `unexpected_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `unexpected_value @ _` pattern can be written as just `unexpected_value` [INFO] [stdout] --> client/src/main.rs:245:21 [INFO] [stdout] | [INFO] [stdout] 245 | unexpected_value @ _ => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `unexpected_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `unexpected_value @ _` pattern can be written as just `unexpected_value` [INFO] [stdout] --> client/src/main.rs:101:33 [INFO] [stdout] | [INFO] [stdout] 101 | ... unexpected_value @ _ => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `unexpected_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `unexpected_value @ _` pattern can be written as just `unexpected_value` [INFO] [stdout] --> client/src/main.rs:240:29 [INFO] [stdout] | [INFO] [stdout] 240 | ... unexpected_value @ _ => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `unexpected_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `unexpected_value @ _` pattern can be written as just `unexpected_value` [INFO] [stdout] --> client/src/main.rs:245:21 [INFO] [stdout] | [INFO] [stdout] 245 | unexpected_value @ _ => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `unexpected_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> client/src/main.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / if let Some(received_at) = self.received_at { [INFO] [stdout] 30 | | Some(received_at.duration_since(self.sent_at)) [INFO] [stdout] 31 | | } else { [INFO] [stdout] 32 | | None [INFO] [stdout] 33 | | } [INFO] [stdout] | |_________^ help: try: `self.received_at.map(|received_at| received_at.duration_since(self.sent_at))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> client/src/main.rs:107:32 [INFO] [stdout] | [INFO] [stdout] 107 | ... if client.lock().unwrap().retrying == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!client.lock().unwrap().retrying` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> client/src/main.rs:187:24 [INFO] [stdout] | [INFO] [stdout] 187 | if guarded_client.ping.received_at != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `guarded_client.ping.received_at.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> client/src/main.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / if let Some(received_at) = self.received_at { [INFO] [stdout] 30 | | Some(received_at.duration_since(self.sent_at)) [INFO] [stdout] 31 | | } else { [INFO] [stdout] 32 | | None [INFO] [stdout] 33 | | } [INFO] [stdout] | |_________^ help: try: `self.received_at.map(|received_at| received_at.duration_since(self.sent_at))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> client/src/main.rs:107:32 [INFO] [stdout] | [INFO] [stdout] 107 | ... if client.lock().unwrap().retrying == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!client.lock().unwrap().retrying` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> client/src/main.rs:187:24 [INFO] [stdout] | [INFO] [stdout] 187 | if guarded_client.ping.received_at != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `guarded_client.ping.received_at.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking server v0.1.0 (/opt/rustwide/workdir/server) [INFO] [stdout] warning: unused imports: `AUTH_RESPONSE_SIZE` and `create_game_package` [INFO] [stdout] --> server/src/main.rs:9:66 [INFO] [stdout] | [INFO] [stdout] 9 | ...e, create_game_package, get_package_type, unpack_auth_request_package, DataType, AUTH_REQUEST_SIZE, AUTH_REQUEST_VERSION, AUTH_RESPONSE_SIZE, P... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `unexpected_value @ _` pattern can be written as just `unexpected_value` [INFO] [stdout] --> server/src/main.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | unexpected_value @ _ => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `unexpected_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AUTH_RESPONSE_SIZE` and `create_game_package` [INFO] [stdout] --> server/src/main.rs:9:66 [INFO] [stdout] | [INFO] [stdout] 9 | ...e, create_game_package, get_package_type, unpack_auth_request_package, DataType, AUTH_REQUEST_SIZE, AUTH_REQUEST_VERSION, AUTH_RESPONSE_SIZE, P... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `unexpected_value @ _` pattern can be written as just `unexpected_value` [INFO] [stdout] --> server/src/main.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | unexpected_value @ _ => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `unexpected_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.02s [INFO] [stdout] warning: fields `token`, `message_buffer`, and `authenticated` are never read [INFO] [stdout] --> server/src/main.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | struct Client { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 33 | pub token: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | pub message_buffer: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 38 | pub connected: bool, [INFO] [stdout] 39 | pub authenticated: bool, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `token`, `message_buffer`, and `authenticated` are never read [INFO] [stdout] --> server/src/main.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 32 | struct Client { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 33 | pub token: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | pub message_buffer: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 38 | pub connected: bool, [INFO] [stdout] 39 | pub authenticated: bool, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> server/src/main.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | if !version.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `version.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `version` after checking its variant with `is_none` [INFO] [stdout] --> server/src/main.rs:110:45 [INFO] [stdout] | [INFO] [stdout] 109 | if !version.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 110 | let unwrapped_version = version.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> server/src/main.rs:109:20 [INFO] [stdout] | [INFO] [stdout] 109 | if !version.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `version.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `version` after checking its variant with `is_none` [INFO] [stdout] --> server/src/main.rs:110:45 [INFO] [stdout] | [INFO] [stdout] 109 | if !version.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 110 | let unwrapped_version = version.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> server/src/main.rs:216:91 [INFO] [stdout] | [INFO] [stdout] 216 | ... println!("Outside connection! {}", stream.peer_addr().unwrap().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> server/src/main.rs:216:91 [INFO] [stdout] | [INFO] [stdout] 216 | ... println!("Outside connection! {}", stream.peer_addr().unwrap().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "532527108f00894c9af2b9ebc1726eff5fef9f8253de383dff13d8d05b96477c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "532527108f00894c9af2b9ebc1726eff5fef9f8253de383dff13d8d05b96477c", kill_on_drop: false }` [INFO] [stdout] 532527108f00894c9af2b9ebc1726eff5fef9f8253de383dff13d8d05b96477c