[INFO] cloning repository https://github.com/NhanNguyen201/egui_image_viewer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/NhanNguyen201/egui_image_viewer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNhanNguyen201%2Fegui_image_viewer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNhanNguyen201%2Fegui_image_viewer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1e4574021081cbc26ca1028dba2a5ab0c0a3e7da [INFO] linting NhanNguyen201/egui_image_viewer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNhanNguyen201%2Fegui_image_viewer" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/NhanNguyen201/egui_image_viewer [INFO] finished tweaking git repo https://github.com/NhanNguyen201/egui_image_viewer [INFO] tweaked toml for git repo https://github.com/NhanNguyen201/egui_image_viewer written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/NhanNguyen201/egui_image_viewer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/NhanNguyen201/egui_image_viewer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hello_egui_utils v0.9.0 [INFO] [stderr] Downloaded concat-idents v1.1.5 [INFO] [stderr] Downloaded simple-easing v1.0.1 [INFO] [stderr] Downloaded egui_dnd v0.13.0 [INFO] [stderr] Downloaded egui_animation v0.9.0 [INFO] [stderr] Downloaded egui-phosphor v0.10.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 997308c4ddc01524e83f52ae2251a5f4a7b6eae0bf7a3e29d71a4ec8871373a9 [INFO] running `Command { std: "docker" "start" "-a" "997308c4ddc01524e83f52ae2251a5f4a7b6eae0bf7a3e29d71a4ec8871373a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "997308c4ddc01524e83f52ae2251a5f4a7b6eae0bf7a3e29d71a4ec8871373a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "997308c4ddc01524e83f52ae2251a5f4a7b6eae0bf7a3e29d71a4ec8871373a9", kill_on_drop: false }` [INFO] [stdout] 997308c4ddc01524e83f52ae2251a5f4a7b6eae0bf7a3e29d71a4ec8871373a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 356bea3dc68c6e598c4fbdcff3811d87d3e59c92dd471e83bce072d721b6b73f [INFO] running `Command { std: "docker" "start" "-a" "356bea3dc68c6e598c4fbdcff3811d87d3e59c92dd471e83bce072d721b6b73f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.96 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Compiling indexmap v2.10.0 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking unicode-ident v1.0.18 [INFO] [stderr] Compiling cc v1.2.32 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling endi v1.1.0 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Checking winnow v0.7.12 [INFO] [stderr] Compiling wayland-client v0.31.11 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.9 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking accesskit v0.19.0 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking nix v0.30.1 [INFO] [stderr] Checking ab_glyph v0.2.31 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking async-executor v1.13.2 [INFO] [stderr] Checking epaint_default_fonts v0.32.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking memmap2 v0.9.7 [INFO] [stderr] Compiling built v0.7.7 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Checking bitstream-io v2.6.0 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Compiling toml_edit v0.22.27 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking imgref v1.11.0 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Checking weezl v0.1.10 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking accesskit_consumer v0.28.0 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking avif-serialize v0.8.5 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking jpeg-decoder v0.3.2 [INFO] [stderr] Checking image-webp v0.2.3 [INFO] [stderr] Checking zune-jpeg v0.4.20 [INFO] [stderr] Checking exr v1.73.0 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Compiling phf v0.11.3 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Compiling mime_guess2 v2.3.1 [INFO] [stderr] Checking async-fs v2.1.3 [INFO] [stderr] Checking simple-easing v1.0.1 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Compiling rfd v0.15.4 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Checking pollster v0.4.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking glutin v0.32.3 [INFO] [stderr] Compiling proc-macro-crate v3.3.0 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking polling v3.10.0 [INFO] [stderr] Checking async-io v2.5.0 [INFO] [stderr] Checking async-signal v0.2.12 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking async-process v2.4.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling bytemuck_derive v1.10.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling concat-idents v1.1.5 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking bytemuck v1.23.2 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking av1-grain v0.2.4 [INFO] [stderr] Checking emath v0.32.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking ecolor v0.32.0 [INFO] [stderr] Checking epaint v0.32.0 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking egui v0.32.0 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking zvariant_utils v3.2.0 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking quick-xml v0.36.2 [INFO] [stderr] Checking hello_egui_utils v0.9.0 [INFO] [stderr] Checking egui_glow v0.32.0 [INFO] [stderr] Checking egui_extras v0.32.0 [INFO] [stderr] Checking egui-phosphor v0.10.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking egui_animation v0.9.0 [INFO] [stderr] Checking egui_dnd v0.13.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Compiling zvariant_derive v5.6.0 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Compiling zvariant v5.6.0 [INFO] [stderr] Checking webbrowser v1.0.5 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking ravif v0.11.20 [INFO] [stderr] Checking image v0.25.6 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Compiling zbus_names v4.2.0 [INFO] [stderr] Checking arboard v3.6.0 [INFO] [stderr] Compiling zbus_xml v5.0.2 [INFO] [stderr] Compiling zbus_macros v5.9.0 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stderr] Checking zbus-lockstep v0.5.1 [INFO] [stderr] Checking winit v0.30.12 [INFO] [stderr] Compiling zbus-lockstep-macros v0.5.1 [INFO] [stderr] Checking zbus v5.9.0 [INFO] [stderr] Checking glutin-winit v0.5.0 [INFO] [stderr] Checking atspi-common v0.9.0 [INFO] [stderr] Checking ashpd v0.11.0 [INFO] [stderr] Checking atspi-proxies v0.9.0 [INFO] [stderr] Checking accesskit_atspi_common v0.12.0 [INFO] [stderr] Checking atspi-connection v0.9.0 [INFO] [stderr] Checking atspi v0.25.0 [INFO] [stderr] Checking accesskit_unix v0.15.0 [INFO] [stderr] Checking accesskit_winit v0.27.0 [INFO] [stderr] Checking egui-winit v0.32.0 [INFO] [stderr] Checking eframe v0.32.0 [INFO] [stderr] Checking img_viewer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app_ext.rs:91:25 [INFO] [stdout] | [INFO] [stdout] 91 | image_ratio: image_ratio, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_ratio` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app_ext.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 94 | ... original_scale: original_scale, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `original_scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app_ext.rs:91:25 [INFO] [stdout] | [INFO] [stdout] 91 | image_ratio: image_ratio, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_ratio` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app_ext.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 94 | ... original_scale: original_scale, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `original_scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/resource.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | ... !(self.max.x < container.min.x) && !(self.max.y < container.min.y) && !{self.min.x > container.max.x} && !(self.min.y > contai... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] = note: `#[warn(clippy::neg_cmp_op_on_partial_ord)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/resource.rs:12:44 [INFO] [stdout] | [INFO] [stdout] 12 | ... !(self.max.x < container.min.x) && !(self.max.y < container.min.y) && !{self.min.x > container.max.x} && !(self.min.y > contai... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/resource.rs:12:114 [INFO] [stdout] | [INFO] [stdout] 12 | ...ner.min.y) && !{self.min.x > container.max.x} && !(self.min.y > container.max.y) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/resource.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | self.file_path.as_ref().map(|p| p.hash(state)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 126 - self.file_path.as_ref().map(|p| p.hash(state)); [INFO] [stdout] 126 + if let Some(p) = self.file_path.as_ref() { p.hash(state) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/resource.rs:166:1 [INFO] [stdout] | [INFO] [stdout] 166 | / impl Default for ImagePreviewPad { [INFO] [stdout] 167 | | fn default() -> Self { [INFO] [stdout] 168 | | Self { [INFO] [stdout] ... | [INFO] [stdout] 173 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 154 + #[derive(Default)] [INFO] [stdout] 155 | pub struct ImagePreviewPad { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app_ext.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - _ => { [INFO] [stdout] 113 - return; [INFO] [stdout] 112 + _ => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/resource.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | ... !(self.max.x < container.min.x) && !(self.max.y < container.min.y) && !{self.min.x > container.max.x} && !(self.min.y > contai... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] = note: `#[warn(clippy::neg_cmp_op_on_partial_ord)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/resource.rs:12:44 [INFO] [stdout] | [INFO] [stdout] 12 | ... !(self.max.x < container.min.x) && !(self.max.y < container.min.y) && !{self.min.x > container.max.x} && !(self.min.y > contai... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/resource.rs:12:114 [INFO] [stdout] | [INFO] [stdout] 12 | ...ner.min.y) && !{self.min.x > container.max.x} && !(self.min.y > container.max.y) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:75:50 [INFO] [stdout] | [INFO] [stdout] 75 | let image_ratio = calc_ratio(image_size.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `image_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:89:41 [INFO] [stdout] | [INFO] [stdout] 89 | original_scale: original_scale.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `original_scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ImageTranforms` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:102:61 [INFO] [stdout] | [INFO] [stdout] 102 | self.active_image_settings.transforms = loaded_texture.clone().unwrap().transform.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `loaded_texture.clone().unwrap().transform` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ImageTranforms` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:129:49 [INFO] [stdout] | [INFO] [stdout] 129 | self.active_image_settings.transforms = pick_texture.transform.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pick_texture.transform` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ImageProps` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:130:44 [INFO] [stdout] | [INFO] [stdout] 130 | self.active_image_settings.props = pick_texture.image_props.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pick_texture.image_props` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.active_image` after checking its variant with `is_some` [INFO] [stdout] --> src/app_ext.rs:235:28 [INFO] [stdout] | [INFO] [stdout] 233 | ... if self.active_image.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = &self.active_image` [INFO] [stdout] 234 | ... for output_texture in self.output_textures_vec.iter_mut() { [INFO] [stdout] 235 | ... if self.active_image.as_ref().unwrap().get_texture_id() == output_texture.texture_handle.as_ref().unwrap().id() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/resource.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | self.file_path.as_ref().map(|p| p.hash(state)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 126 - self.file_path.as_ref().map(|p| p.hash(state)); [INFO] [stdout] 126 + if let Some(p) = self.file_path.as_ref() { p.hash(state) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pos2` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:236:60 [INFO] [stdout] | [INFO] [stdout] 236 | ... output_texture.transform.pos = self.active_image_settings.transforms.pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/resource.rs:166:1 [INFO] [stdout] | [INFO] [stdout] 166 | / impl Default for ImagePreviewPad { [INFO] [stdout] 167 | | fn default() -> Self { [INFO] [stdout] 168 | | Self { [INFO] [stdout] ... | [INFO] [stdout] 173 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 154 + #[derive(Default)] [INFO] [stdout] 155 | pub struct ImagePreviewPad { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:329:37 [INFO] [stdout] | [INFO] [stdout] 329 | image.transform.scale = self.active_image_settings.transforms.scale.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:330:39 [INFO] [stdout] | [INFO] [stdout] 330 | image.transform.opacity = self.active_image_settings.transforms.opacity.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.opacity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:331:40 [INFO] [stdout] | [INFO] [stdout] 331 | image.transform.rotation = self.active_image_settings.transforms.rotation.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.rotation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pos2` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:332:35 [INFO] [stdout] | [INFO] [stdout] 332 | image.transform.pos = self.active_image_settings.transforms.pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:333:67 [INFO] [stdout] | [INFO] [stdout] 333 | self.active_image_settings.props.to_owned().uv_rect = image.image_props.uv_rect.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `image.image_props.uv_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CropRect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:337:36 [INFO] [stdout] | [INFO] [stdout] 337 | let mut current_modified = self.active_image_settings.croped_modified.current_modified.unwrap_or_default().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.croped_modified.current_modified.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:342:34 [INFO] [stdout] | [INFO] [stdout] 342 | let mut clone_raw_rect = raw_rect.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `raw_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:343:34 [INFO] [stdout] | [INFO] [stdout] 343 | let unclamped_raw_rect = raw_rect.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `raw_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:369:17 [INFO] [stdout] | [INFO] [stdout] 369 | top_left_rect.clone(), Sense::click_and_drag() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `top_left_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app_ext.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - _ => { [INFO] [stdout] 113 - return; [INFO] [stdout] 112 + _ => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CropRect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:399:88 [INFO] [stdout] | [INFO] [stdout] 399 | self.active_image_settings.croped_modified.current_modified = Some(current_modified.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_modified` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:416:38 [INFO] [stdout] | [INFO] [stdout] 416 | ui.painter().rect_filled(bottom_right_rect.clone(), 0.0, Color32::from_rgb(255, 255, 255)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `bottom_right_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:418:17 [INFO] [stdout] | [INFO] [stdout] 418 | bottom_right_rect.clone(), Sense::click_and_drag() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `bottom_right_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CropRect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:448:88 [INFO] [stdout] | [INFO] [stdout] 448 | self.active_image_settings.croped_modified.current_modified = Some(current_modified.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_modified` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/app_ext.rs:458:12 [INFO] [stdout] | [INFO] [stdout] 458 | if !(raw_rect.min.y < main_rect.min.y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/app_ext.rs:475:12 [INFO] [stdout] | [INFO] [stdout] 475 | if !(raw_rect.min.x < main_rect.min.x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/app_ext.rs:492:12 [INFO] [stdout] | [INFO] [stdout] 492 | if !(raw_rect.max.y > main_rect.max.y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/app_ext.rs:509:12 [INFO] [stdout] | [INFO] [stdout] 509 | if !(raw_rect.max.x > main_rect.max.x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:528:28 [INFO] [stdout] | [INFO] [stdout] 528 | let current_crop = self.active_image_settings.croped_modified.current_modified.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.croped_modified.current_modified` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:530:22 [INFO] [stdout] | [INFO] [stdout] 530 | let scaled = self.active_image_settings.croped_modified.max_scale.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.croped_modified.max_scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:538:56 [INFO] [stdout] | [INFO] [stdout] 538 | self.active_image_settings.transforms.croped = self.active_image_settings.croped_modified.dest_modified.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.croped_modified.dest_modified` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:541:51 [INFO] [stdout] | [INFO] [stdout] 541 | output_texture.transform.croped = self.active_image_settings.transforms.croped.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.croped` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:547:25 [INFO] [stdout] | [INFO] [stdout] 547 | let max_scale = self.active_image_settings.croped_modified.max_scale.clone() * image.transform.original_scale; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.croped_modified.max_scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Vec2` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:75:50 [INFO] [stdout] | [INFO] [stdout] 75 | let image_ratio = calc_ratio(image_size.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `image_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:89:41 [INFO] [stdout] | [INFO] [stdout] 89 | original_scale: original_scale.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `original_scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ImageTranforms` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:102:61 [INFO] [stdout] | [INFO] [stdout] 102 | self.active_image_settings.transforms = loaded_texture.clone().unwrap().transform.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `loaded_texture.clone().unwrap().transform` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ImageTranforms` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:129:49 [INFO] [stdout] | [INFO] [stdout] 129 | self.active_image_settings.transforms = pick_texture.transform.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pick_texture.transform` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ImageProps` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:130:44 [INFO] [stdout] | [INFO] [stdout] 130 | self.active_image_settings.props = pick_texture.image_props.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `pick_texture.image_props` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app_ext.rs:648:13 [INFO] [stdout] | [INFO] [stdout] 648 | / if let Some(check_active) = self.active_image.as_ref() { [INFO] [stdout] 649 | | if check_active.get_texture_id() == image_id { [INFO] [stdout] 650 | | self.active_image = None; [INFO] [stdout] 651 | | } [INFO] [stdout] 652 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 648 ~ if let Some(check_active) = self.active_image.as_ref() [INFO] [stdout] 649 ~ && check_active.get_texture_id() == image_id { [INFO] [stdout] 650 | self.active_image = None; [INFO] [stdout] 651 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_ext.rs:786:36 [INFO] [stdout] | [INFO] [stdout] 786 | ... if !(new_idx == current_idx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(new_idx != current_idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.active_image` after checking its variant with `is_some` [INFO] [stdout] --> src/app_ext.rs:235:28 [INFO] [stdout] | [INFO] [stdout] 233 | ... if self.active_image.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = &self.active_image` [INFO] [stdout] 234 | ... for output_texture in self.output_textures_vec.iter_mut() { [INFO] [stdout] 235 | ... if self.active_image.as_ref().unwrap().get_texture_id() == output_texture.texture_handle.as_ref().unwrap().id() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pos2` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:236:60 [INFO] [stdout] | [INFO] [stdout] 236 | ... output_texture.transform.pos = self.active_image_settings.transforms.pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:695:61 [INFO] [stdout] | [INFO] [stdout] 695 | if new_idx > 0. as usize && idx == (new_idx.clone() - 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:700:38 [INFO] [stdout] | [INFO] [stdout] 700 | if new_idx < (image_vec.len().clone() ) && idx == new_idx.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `image_vec.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:700:75 [INFO] [stdout] | [INFO] [stdout] 700 | if new_idx < (image_vec.len().clone() ) && idx == new_idx.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pos2` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:753:47 [INFO] [stdout] | [INFO] [stdout] 753 | ... let mut new_pos = interact_pos.clone().clamp(container_rect.min, container_rect.max); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `interact_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:329:37 [INFO] [stdout] | [INFO] [stdout] 329 | image.transform.scale = self.active_image_settings.transforms.scale.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pos2` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:758:66 [INFO] [stdout] | [INFO] [stdout] 758 | ... self.image_sorting_modify.drag_pos = new_pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:330:39 [INFO] [stdout] | [INFO] [stdout] 330 | image.transform.opacity = self.active_image_settings.transforms.opacity.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.opacity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pos2` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:765:37 [INFO] [stdout] | [INFO] [stdout] 765 | ... new_pos.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:331:40 [INFO] [stdout] | [INFO] [stdout] 331 | image.transform.rotation = self.active_image_settings.transforms.rotation.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.rotation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pos2` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:332:35 [INFO] [stdout] | [INFO] [stdout] 332 | image.transform.pos = self.active_image_settings.transforms.pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:333:67 [INFO] [stdout] | [INFO] [stdout] 333 | self.active_image_settings.props.to_owned().uv_rect = image.image_props.uv_rect.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `image.image_props.uv_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app_ext.rs:785:29 [INFO] [stdout] | [INFO] [stdout] 785 | / ... if let Some(current_idx) = self.image_sorting_modify.from_image { [INFO] [stdout] 786 | | ... if !(new_idx == current_idx) { [INFO] [stdout] 787 | | ... if new_idx < current_idx { [INFO] [stdout] 788 | | ... let clone_image = image_preview.clone(); [INFO] [stdout] ... | [INFO] [stdout] 797 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 785 ~ if let Some(current_idx) = self.image_sorting_modify.from_image [INFO] [stdout] 786 ~ && !(new_idx == current_idx) { [INFO] [stdout] 787 | if new_idx < current_idx { [INFO] [stdout] ... [INFO] [stdout] 795 | } [INFO] [stdout] 796 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CropRect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:337:36 [INFO] [stdout] | [INFO] [stdout] 337 | let mut current_modified = self.active_image_settings.croped_modified.current_modified.unwrap_or_default().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.croped_modified.current_modified.unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:342:34 [INFO] [stdout] | [INFO] [stdout] 342 | let mut clone_raw_rect = raw_rect.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `raw_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:343:34 [INFO] [stdout] | [INFO] [stdout] 343 | let unclamped_raw_rect = raw_rect.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `raw_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:369:17 [INFO] [stdout] | [INFO] [stdout] 369 | top_left_rect.clone(), Sense::click_and_drag() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `top_left_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CropRect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:399:88 [INFO] [stdout] | [INFO] [stdout] 399 | self.active_image_settings.croped_modified.current_modified = Some(current_modified.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_modified` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:416:38 [INFO] [stdout] | [INFO] [stdout] 416 | ui.painter().rect_filled(bottom_right_rect.clone(), 0.0, Color32::from_rgb(255, 255, 255)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `bottom_right_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:418:17 [INFO] [stdout] | [INFO] [stdout] 418 | bottom_right_rect.clone(), Sense::click_and_drag() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `bottom_right_rect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CropRect` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:448:88 [INFO] [stdout] | [INFO] [stdout] 448 | self.active_image_settings.croped_modified.current_modified = Some(current_modified.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current_modified` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/app_ext.rs:458:12 [INFO] [stdout] | [INFO] [stdout] 458 | if !(raw_rect.min.y < main_rect.min.y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/app_ext.rs:475:12 [INFO] [stdout] | [INFO] [stdout] 475 | if !(raw_rect.min.x < main_rect.min.x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:71:85 [INFO] [stdout] | [INFO] [stdout] 71 | ... ui.button(egui::RichText::new(format!("{}", egui_phosphor::regular::ARROWS_DOWN_UP)).size(12.0).color(Color32::WHITE)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `egui_phosphor::regular::ARROWS_DOWN_UP.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/app_ext.rs:492:12 [INFO] [stdout] | [INFO] [stdout] 492 | if !(raw_rect.max.y > main_rect.max.y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the use of negated comparison operators on partially ordered types produces code that is hard to read and refactor, please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable [INFO] [stdout] --> src/app_ext.rs:509:12 [INFO] [stdout] | [INFO] [stdout] 509 | if !(raw_rect.max.x > main_rect.max.x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/main.rs:100:55 [INFO] [stdout] | [INFO] [stdout] 100 | ... frame_width / image_preview.texture_handle.as_ref().unwrap().size_vec2().x as f32 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `image_preview.texture_handle.as_ref().unwrap().size_vec2().x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:528:28 [INFO] [stdout] | [INFO] [stdout] 528 | let current_crop = self.active_image_settings.croped_modified.current_modified.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.croped_modified.current_modified` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/main.rs:102:56 [INFO] [stdout] | [INFO] [stdout] 102 | ... frame_height / image_preview.texture_handle.as_ref().unwrap().size_vec2().y as f32 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `image_preview.texture_handle.as_ref().unwrap().size_vec2().y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:530:22 [INFO] [stdout] | [INFO] [stdout] 530 | let scaled = self.active_image_settings.croped_modified.max_scale.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.croped_modified.max_scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:538:56 [INFO] [stdout] | [INFO] [stdout] 538 | self.active_image_settings.transforms.croped = self.active_image_settings.croped_modified.dest_modified.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.croped_modified.dest_modified` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:541:51 [INFO] [stdout] | [INFO] [stdout] 541 | output_texture.transform.croped = self.active_image_settings.transforms.croped.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.croped` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:547:25 [INFO] [stdout] | [INFO] [stdout] 547 | let max_scale = self.active_image_settings.croped_modified.max_scale.clone() * image.transform.original_scale; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.croped_modified.max_scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/main.rs:107:125 [INFO] [stdout] | [INFO] [stdout] 107 | ...ze_vec2().x * scaled, y: image_preview.texture_handle.as_ref().unwrap().size_vec2().y as f32 * scaled } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `image_preview.texture_handle.as_ref().unwrap().size_vec2().y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:119:95 [INFO] [stdout] | [INFO] [stdout] 119 | ... let remove_button = ui.button(egui::RichText::new(format!("{}", egui_phosphor::regular::TRASH)).size(16.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `egui_phosphor::regular::TRASH.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:125:37 [INFO] [stdout] | [INFO] [stdout] 125 | / ... if let Some(active_img) = &self.active_image { [INFO] [stdout] 126 | | ... if active_img.get_texture_id() == image_preview.texture_handle.as_ref().unwrap().id() { [INFO] [stdout] 127 | | ... [INFO] [stdout] 128 | | ... let points = Vec::from([ [INFO] [stdout] ... | [INFO] [stdout] 137 | | ... }; [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 125 ~ if let Some(active_img) = &self.active_image [INFO] [stdout] 126 ~ && active_img.get_texture_id() == image_preview.texture_handle.as_ref().unwrap().id() { [INFO] [stdout] 127 | [INFO] [stdout] ... [INFO] [stdout] 135 | ui.painter().line(points, Stroke::new(1., Color32::BLACK)); [INFO] [stdout] 136 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:181:28 [INFO] [stdout] | [INFO] [stdout] 181 | if self.active_image_settings.croped_modified.is_modifying == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.active_image_settings.croped_modified.is_modifying` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:186:159 [INFO] [stdout] | [INFO] [stdout] 186 | ....image_plot_rect.size()) / self.active_image_settings.transforms.original_scale.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.original_scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app_ext.rs:648:13 [INFO] [stdout] | [INFO] [stdout] 648 | / if let Some(check_active) = self.active_image.as_ref() { [INFO] [stdout] 649 | | if check_active.get_texture_id() == image_id { [INFO] [stdout] 650 | | self.active_image = None; [INFO] [stdout] 651 | | } [INFO] [stdout] 652 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 648 ~ if let Some(check_active) = self.active_image.as_ref() [INFO] [stdout] 649 ~ && check_active.get_texture_id() == image_id { [INFO] [stdout] 650 | self.active_image = None; [INFO] [stdout] 651 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:189:53 [INFO] [stdout] | [INFO] [stdout] 189 | ... let multiply = max_scale.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `max_scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:202:92 [INFO] [stdout] | [INFO] [stdout] 202 | ... self.active_image_settings.croped_modified.prev_modified = crop.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `crop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app_ext.rs:786:36 [INFO] [stdout] | [INFO] [stdout] 786 | ... if !(new_idx == current_idx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(new_idx != current_idx)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:203:95 [INFO] [stdout] | [INFO] [stdout] 203 | ... self.active_image_settings.croped_modified.current_modified = crop.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `crop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:695:61 [INFO] [stdout] | [INFO] [stdout] 695 | if new_idx > 0. as usize && idx == (new_idx.clone() - 1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:700:38 [INFO] [stdout] | [INFO] [stdout] 700 | if new_idx < (image_vec.len().clone() ) && idx == new_idx.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `image_vec.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:700:75 [INFO] [stdout] | [INFO] [stdout] 700 | if new_idx < (image_vec.len().clone() ) && idx == new_idx.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pos2` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:753:47 [INFO] [stdout] | [INFO] [stdout] 753 | ... let mut new_pos = interact_pos.clone().clamp(container_rect.min, container_rect.max); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `interact_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Pos2` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:758:66 [INFO] [stdout] | [INFO] [stdout] 758 | ... self.image_sorting_modify.drag_pos = new_pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 14s [INFO] [stdout] warning: using `clone` on type `Pos2` which implements the `Copy` trait [INFO] [stdout] --> src/app_ext.rs:765:37 [INFO] [stdout] | [INFO] [stdout] 765 | ... new_pos.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `new_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app_ext.rs:785:29 [INFO] [stdout] | [INFO] [stdout] 785 | / ... if let Some(current_idx) = self.image_sorting_modify.from_image { [INFO] [stdout] 786 | | ... if !(new_idx == current_idx) { [INFO] [stdout] 787 | | ... if new_idx < current_idx { [INFO] [stdout] 788 | | ... let clone_image = image_preview.clone(); [INFO] [stdout] ... | [INFO] [stdout] 797 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 785 ~ if let Some(current_idx) = self.image_sorting_modify.from_image [INFO] [stdout] 786 ~ && !(new_idx == current_idx) { [INFO] [stdout] 787 | if new_idx < current_idx { [INFO] [stdout] ... [INFO] [stdout] 795 | } [INFO] [stdout] 796 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:71:85 [INFO] [stdout] | [INFO] [stdout] 71 | ... ui.button(egui::RichText::new(format!("{}", egui_phosphor::regular::ARROWS_DOWN_UP)).size(12.0).color(Color32::WHITE)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `egui_phosphor::regular::ARROWS_DOWN_UP.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/main.rs:100:55 [INFO] [stdout] | [INFO] [stdout] 100 | ... frame_width / image_preview.texture_handle.as_ref().unwrap().size_vec2().x as f32 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `image_preview.texture_handle.as_ref().unwrap().size_vec2().x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/main.rs:102:56 [INFO] [stdout] | [INFO] [stdout] 102 | ... frame_height / image_preview.texture_handle.as_ref().unwrap().size_vec2().y as f32 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `image_preview.texture_handle.as_ref().unwrap().size_vec2().y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`f32` -> `f32`) [INFO] [stdout] --> src/main.rs:107:125 [INFO] [stdout] | [INFO] [stdout] 107 | ...ze_vec2().x * scaled, y: image_preview.texture_handle.as_ref().unwrap().size_vec2().y as f32 * scaled } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `image_preview.texture_handle.as_ref().unwrap().size_vec2().y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:119:95 [INFO] [stdout] | [INFO] [stdout] 119 | ... let remove_button = ui.button(egui::RichText::new(format!("{}", egui_phosphor::regular::TRASH)).size(16.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `egui_phosphor::regular::TRASH.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:125:37 [INFO] [stdout] | [INFO] [stdout] 125 | / ... if let Some(active_img) = &self.active_image { [INFO] [stdout] 126 | | ... if active_img.get_texture_id() == image_preview.texture_handle.as_ref().unwrap().id() { [INFO] [stdout] 127 | | ... [INFO] [stdout] 128 | | ... let points = Vec::from([ [INFO] [stdout] ... | [INFO] [stdout] 137 | | ... }; [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 125 ~ if let Some(active_img) = &self.active_image [INFO] [stdout] 126 ~ && active_img.get_texture_id() == image_preview.texture_handle.as_ref().unwrap().id() { [INFO] [stdout] 127 | [INFO] [stdout] ... [INFO] [stdout] 135 | ui.painter().line(points, Stroke::new(1., Color32::BLACK)); [INFO] [stdout] 136 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/main.rs:181:28 [INFO] [stdout] | [INFO] [stdout] 181 | if self.active_image_settings.croped_modified.is_modifying == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.active_image_settings.croped_modified.is_modifying` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:186:159 [INFO] [stdout] | [INFO] [stdout] 186 | ....image_plot_rect.size()) / self.active_image_settings.transforms.original_scale.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.active_image_settings.transforms.original_scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:189:53 [INFO] [stdout] | [INFO] [stdout] 189 | ... let multiply = max_scale.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `max_scale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:202:92 [INFO] [stdout] | [INFO] [stdout] 202 | ... self.active_image_settings.croped_modified.prev_modified = crop.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `crop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:203:95 [INFO] [stdout] | [INFO] [stdout] 203 | ... self.active_image_settings.croped_modified.current_modified = crop.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `crop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "356bea3dc68c6e598c4fbdcff3811d87d3e59c92dd471e83bce072d721b6b73f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "356bea3dc68c6e598c4fbdcff3811d87d3e59c92dd471e83bce072d721b6b73f", kill_on_drop: false }` [INFO] [stdout] 356bea3dc68c6e598c4fbdcff3811d87d3e59c92dd471e83bce072d721b6b73f