[INFO] cloning repository https://github.com/NeoScripter/AOC_2018_Rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/NeoScripter/AOC_2018_Rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNeoScripter%2FAOC_2018_Rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNeoScripter%2FAOC_2018_Rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 76856c5bbc8e51f2e6dc6fc161b609ff2c9ab83b [INFO] linting NeoScripter/AOC_2018_Rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNeoScripter%2FAOC_2018_Rust" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/NeoScripter/AOC_2018_Rust [INFO] finished tweaking git repo https://github.com/NeoScripter/AOC_2018_Rust [INFO] tweaked toml for git repo https://github.com/NeoScripter/AOC_2018_Rust written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/NeoScripter/AOC_2018_Rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/NeoScripter/AOC_2018_Rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded id_tree v1.8.0 [INFO] [stderr] Downloaded test-case v3.2.1 [INFO] [stderr] Downloaded test-case-macros v3.2.1 [INFO] [stderr] Downloaded test-case-core v3.2.1 [INFO] [stderr] Downloaded snowflake v1.3.0 [INFO] [stderr] Downloaded sharded-slab v0.1.6 [INFO] [stderr] Downloaded color-spantrace v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 715b559ad91e3c917664b7b707250a17407db377f665dad565f4cf1176b1d9de [INFO] running `Command { std: "docker" "start" "-a" "715b559ad91e3c917664b7b707250a17407db377f665dad565f4cf1176b1d9de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "715b559ad91e3c917664b7b707250a17407db377f665dad565f4cf1176b1d9de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "715b559ad91e3c917664b7b707250a17407db377f665dad565f4cf1176b1d9de", kill_on_drop: false }` [INFO] [stdout] 715b559ad91e3c917664b7b707250a17407db377f665dad565f4cf1176b1d9de [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f70dc232ff4f32b77de22e155e2f00db10f965a0cbd72e123c3d5bb71bae647 [INFO] running `Command { std: "docker" "start" "-a" "0f70dc232ff4f32b77de22e155e2f00db10f965a0cbd72e123c3d5bb71bae647", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking sharded-slab v0.1.6 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling eyre v0.6.8 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Compiling camino v1.1.6 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking snowflake v1.3.0 [INFO] [stderr] Checking hashbrown v0.14.1 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking id_tree v1.8.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking combine v4.6.6 [INFO] [stderr] Checking indexmap v2.0.2 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Compiling test-case-core v3.2.1 [INFO] [stderr] Checking color-spantrace v0.2.0 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Compiling test-case-macros v3.2.1 [INFO] [stderr] Checking test-case v3.2.1 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Checking aoc2018 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this is an `else {..}` but the formatting might hide it [INFO] [stdout] --> src/lib.rs:122:14 [INFO] [stdout] | [INFO] [stdout] 122 | } else [INFO] [stdout] | ______________^ [INFO] [stdout] 123 | | { pq.push_back((y + 1, x)); } [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, remove the `else` or remove the new line between `else` and `{..}` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stdout] = note: `#[warn(clippy::suspicious_else_formatting)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:63:29 [INFO] [stdout] | [INFO] [stdout] 63 | let mut right = nx.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `nx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:74:28 [INFO] [stdout] | [INFO] [stdout] 74 | let mut left = nx.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `nx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lib.rs:125:69 [INFO] [stdout] | [INFO] [stdout] 125 | let ovrl: HashSet<(usize, usize)> = cache.into_iter().chain(mem.into_iter()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 125 - let ovrl: HashSet<(usize, usize)> = cache.into_iter().chain(mem.into_iter()).collect(); [INFO] [stdout] 125 + let ovrl: HashSet<(usize, usize)> = cache.into_iter().chain(mem).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is an `else {..}` but the formatting might hide it [INFO] [stdout] --> src/lib.rs:122:14 [INFO] [stdout] | [INFO] [stdout] 122 | } else [INFO] [stdout] | ______________^ [INFO] [stdout] 123 | | { pq.push_back((y + 1, x)); } [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, remove the `else` or remove the new line between `else` and `{..}` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stdout] = note: `#[warn(clippy::suspicious_else_formatting)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:63:29 [INFO] [stdout] | [INFO] [stdout] 63 | let mut right = nx.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `nx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:74:28 [INFO] [stdout] | [INFO] [stdout] 74 | let mut left = nx.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `nx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lib.rs:125:69 [INFO] [stdout] | [INFO] [stdout] 125 | let ovrl: HashSet<(usize, usize)> = cache.into_iter().chain(mem.into_iter()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 125 - let ovrl: HashSet<(usize, usize)> = cache.into_iter().chain(mem.into_iter()).collect(); [INFO] [stdout] 125 + let ovrl: HashSet<(usize, usize)> = cache.into_iter().chain(mem).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> bin/day16/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `find_first_cart` is never used [INFO] [stdout] --> bin/day13/main.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 51 | impl Tracks { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 82 | fn find_first_cart(&mut self) -> Option<(usize, usize)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> bin/day13/main.rs:79:58 [INFO] [stdout] | [INFO] [stdout] 79 | fn check_collisions(&self, cart: &Cart, moved_carts: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 - fn check_collisions(&self, cart: &Cart, moved_carts: &Vec) -> bool { [INFO] [stdout] 79 + fn check_collisions(&self, cart: &Cart, moved_carts: &[Cart]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> bin/day13/main.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | / match c { [INFO] [stdout] 121 | | '>'|'v'|'^'|'<' => true, [INFO] [stdout] 122 | | _ => false, [INFO] [stdout] 123 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 120 - match c { [INFO] [stdout] 121 - '>'|'v'|'^'|'<' => true, [INFO] [stdout] 122 - _ => false, [INFO] [stdout] 123 - } [INFO] [stdout] 120 + matches!(c, '>'|'v'|'^'|'<') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> bin/day13/main.rs:147:11 [INFO] [stdout] | [INFO] [stdout] 147 | while !crash.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `crash.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `print_hp`, `increase_hit`, and `elves_survived` are never used [INFO] [stdout] --> bin/day15/main.rs:118:8 [INFO] [stdout] | [INFO] [stdout] 39 | impl Battle { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 118 | fn print_hp(&self) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 129 | fn increase_hit(&mut self, new_hit: i32) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 132 | fn elves_survived(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> bin/day15/main.rs:158:4 [INFO] [stdout] | [INFO] [stdout] 158 | fn part2(input: &str) -> i32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> bin/day15/main.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 146 | let battle = Battle { fld , units, rnds: 0 }; [INFO] [stdout] | --------------------------------------------- unnecessary `let` binding [INFO] [stdout] 147 | battle [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 146 ~ [INFO] [stdout] 147 ~ Battle { fld , units, rnds: 0 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> bin/day16/main.rs:103:18 [INFO] [stdout] | [INFO] [stdout] 103 | _ => !unreachable!(), [INFO] [stdout] | ^-------------- [INFO] [stdout] | || [INFO] [stdout] | |any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> bin/day12/main.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | row: row, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `row` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `sum_entries` is never used [INFO] [stdout] --> bin/day8/main.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl Node { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 41 | fn sum_entries(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> bin/day8/main.rs:102:4 [INFO] [stdout] | [INFO] [stdout] 102 | fn part1(input: &str) -> u32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PrettyVec` is never constructed [INFO] [stdout] --> bin/day4/main.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | struct PrettyVec(Vec); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> bin/day4/main.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | writeln!(f, "")?; [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> bin/day4/main.rs:65:20 [INFO] [stdout] | [INFO] [stdout] 65 | fn sort_lines(vec: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 65 - fn sort_lines(vec: &mut Vec) { [INFO] [stdout] 65 + fn sort_lines(vec: &mut [String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> bin/day4/main.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 83 | let mod_line = String::from(&mod_line[2..]); [INFO] [stdout] | -------------------------------------------- unnecessary `let` binding [INFO] [stdout] 84 | mod_line [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 83 ~ [INFO] [stdout] 84 ~ String::from(&mod_line[2..]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> bin/day4/main.rs:136:21 [INFO] [stdout] | [INFO] [stdout] 136 | .interleave(guard.time_asleep.clone().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/itertools-0.11.0/src/lib.rs:449:18 [INFO] [stdout] | [INFO] [stdout] 449 | where J: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 136 - .interleave(guard.time_asleep.clone().into_iter()) [INFO] [stdout] 136 + .interleave(guard.time_asleep.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `idx` is used to index `vec` [INFO] [stdout] --> bin/day4/main.rs:145:20 [INFO] [stdout] | [INFO] [stdout] 145 | for idx in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 145 - for idx in 0..len { [INFO] [stdout] 145 + for (idx, ) in vec.iter().enumerate().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> bin/day4/main.rs:165:37 [INFO] [stdout] | [INFO] [stdout] 165 | let unique_guards: Vec = guard_map.into_iter().map(|(_, v)| v).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `guard_map.into_values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> bin/day12/main.rs:66:4 [INFO] [stdout] | [INFO] [stdout] 66 | fn part1() -> i64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> bin/day16/main.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | while let Some(l) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for l in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashSet` and `VecDeque` [INFO] [stdout] --> bin/day17/main.rs:3:19 [INFO] [stdout] | [INFO] [stdout] 3 | collections::{VecDeque, HashSet}, [INFO] [stdout] | ^^^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> bin/day3/main.rs:33:18 [INFO] [stdout] | [INFO] [stdout] 33 | let re = Regex::new(r"#(\d+) @ (\d+),(\d+): (\d+)x(\d+)").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> bin/day3/main.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | for line in input.lines() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashSet` [INFO] [stdout] --> bin/day16/main.rs:125:57 [INFO] [stdout] | [INFO] [stdout] 125 | if v.len() == 1 { self.ctgs.insert(k, v.into_iter().next().unwrap());} [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> bin/day12/main.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | row: row, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `row` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> bin/day12/main.rs:66:4 [INFO] [stdout] | [INFO] [stdout] 66 | fn part1() -> i64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> bin/day7/main.rs:30:33 [INFO] [stdout] | [INFO] [stdout] 30 | unav.remove(&v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> bin/day7/main.rs:92:24 [INFO] [stdout] | [INFO] [stdout] 92 | fn apply_tick(workers: &mut Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 92 - fn apply_tick(workers: &mut Vec) -> Vec { [INFO] [stdout] 92 + fn apply_tick(workers: &mut [Status]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `index` is only used to index `workers` [INFO] [stdout] --> bin/day7/main.rs:95:18 [INFO] [stdout] | [INFO] [stdout] 95 | for index in 0..workers.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 95 - for index in 0..workers.len() { [INFO] [stdout] 95 + for in &mut workers { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> bin/day7/main.rs:110:30 [INFO] [stdout] | [INFO] [stdout] 110 | fn all_workers_idle(workers: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 110 - fn all_workers_idle(workers: &Vec) -> bool { [INFO] [stdout] 110 + fn all_workers_idle(workers: &[Status]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> bin/day7/main.rs:113:31 [INFO] [stdout] | [INFO] [stdout] 113 | fn available_workers(workers: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 113 - fn available_workers(workers: &Vec) -> Vec { [INFO] [stdout] 113 + fn available_workers(workers: &[Status]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `index` is used to index `workers` [INFO] [stdout] --> bin/day7/main.rs:116:18 [INFO] [stdout] | [INFO] [stdout] 116 | for index in 0..workers.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 116 - for index in 0..workers.len() { [INFO] [stdout] 116 + for (index, ) in workers.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> bin/day17/main.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 62 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> bin/day17/main.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> bin/day17/main.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | let mut right = nx.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `nx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> bin/day17/main.rs:77:28 [INFO] [stdout] | [INFO] [stdout] 77 | let mut left = nx.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `nx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> bin/day7/main.rs:30:33 [INFO] [stdout] | [INFO] [stdout] 30 | unav.remove(&v); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> bin/day7/main.rs:92:24 [INFO] [stdout] | [INFO] [stdout] 92 | fn apply_tick(workers: &mut Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 92 - fn apply_tick(workers: &mut Vec) -> Vec { [INFO] [stdout] 92 + fn apply_tick(workers: &mut [Status]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `index` is only used to index `workers` [INFO] [stdout] --> bin/day7/main.rs:95:18 [INFO] [stdout] | [INFO] [stdout] 95 | for index in 0..workers.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 95 - for index in 0..workers.len() { [INFO] [stdout] 95 + for in &mut workers { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> bin/day7/main.rs:110:30 [INFO] [stdout] | [INFO] [stdout] 110 | fn all_workers_idle(workers: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 110 - fn all_workers_idle(workers: &Vec) -> bool { [INFO] [stdout] 110 + fn all_workers_idle(workers: &[Status]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> bin/day7/main.rs:113:31 [INFO] [stdout] | [INFO] [stdout] 113 | fn available_workers(workers: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 113 - fn available_workers(workers: &Vec) -> Vec { [INFO] [stdout] 113 + fn available_workers(workers: &[Status]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `index` is used to index `workers` [INFO] [stdout] --> bin/day7/main.rs:116:18 [INFO] [stdout] | [INFO] [stdout] 116 | for index in 0..workers.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 116 - for index in 0..workers.len() { [INFO] [stdout] 116 + for (index, ) in workers.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashMap` [INFO] [stdout] --> bin/day18/main.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::{HashMap, HashSet, VecDeque}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> bin/day18/main.rs:17:55 [INFO] [stdout] | [INFO] [stdout] 17 | if !clay.contains(&(point.0, point.1 + 1)) && point.1 + 1 <= max_y { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `point.1 < max_y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `find_score` is never used [INFO] [stdout] --> bin/day14/main.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 7 | impl Recipes { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 26 | fn find_score(&self, rps: usize) -> u64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> bin/day14/main.rs:47:4 [INFO] [stdout] | [INFO] [stdout] 47 | fn part1(rps: &str) -> u64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> bin/day14/main.rs:20:51 [INFO] [stdout] | [INFO] [stdout] 20 | for i in self.elfs.iter_mut() {*i = (*i + self.board[*i] as usize + 1) % self.board.len()} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.board[*i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `find_square_part1` is never used [INFO] [stdout] --> bin/day11/main.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 17 | impl Grid { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 34 | fn find_square_part1(&self) -> (usize, usize, i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> bin/day16/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> bin/day3/main.rs:33:18 [INFO] [stdout] | [INFO] [stdout] 33 | let re = Regex::new(r"#(\d+) @ (\d+),(\d+): (\d+)x(\d+)").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> bin/day3/main.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | for line in input.lines() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> bin/day16/main.rs:103:18 [INFO] [stdout] | [INFO] [stdout] 103 | _ => !unreachable!(), [INFO] [stdout] | ^-------------- [INFO] [stdout] | || [INFO] [stdout] | |any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> bin/day16/main.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | while let Some(l) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for l in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `HashSet` [INFO] [stdout] --> bin/day16/main.rs:125:57 [INFO] [stdout] | [INFO] [stdout] 125 | if v.len() == 1 { self.ctgs.insert(k, v.into_iter().next().unwrap());} [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashMap` [INFO] [stdout] --> bin/day18/main.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::{HashMap, HashSet, VecDeque}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> bin/day18/main.rs:17:55 [INFO] [stdout] | [INFO] [stdout] 17 | if !clay.contains(&(point.0, point.1 + 1)) && point.1 + 1 <= max_y { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `point.1 < max_y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `find_first_cart` is never used [INFO] [stdout] --> bin/day13/main.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 51 | impl Tracks { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 82 | fn find_first_cart(&mut self) -> Option<(usize, usize)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `print_hp`, `increase_hit`, and `elves_survived` are never used [INFO] [stdout] --> bin/day15/main.rs:118:8 [INFO] [stdout] | [INFO] [stdout] 39 | impl Battle { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 118 | fn print_hp(&self) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 129 | fn increase_hit(&mut self, new_hit: i32) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 132 | fn elves_survived(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> bin/day15/main.rs:158:4 [INFO] [stdout] | [INFO] [stdout] 158 | fn part2(input: &str) -> i32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> bin/day15/main.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 146 | let battle = Battle { fld , units, rnds: 0 }; [INFO] [stdout] | --------------------------------------------- unnecessary `let` binding [INFO] [stdout] 147 | battle [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 146 ~ [INFO] [stdout] 147 ~ Battle { fld , units, rnds: 0 } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `find_score` is never used [INFO] [stdout] --> bin/day14/main.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 7 | impl Recipes { [INFO] [stdout] | ------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 26 | fn find_score(&self, rps: usize) -> u64 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> bin/day14/main.rs:47:4 [INFO] [stdout] | [INFO] [stdout] 47 | fn part1(rps: &str) -> u64 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PrettyVec` is never constructed [INFO] [stdout] --> bin/day4/main.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | struct PrettyVec(Vec); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> bin/day13/main.rs:79:58 [INFO] [stdout] | [INFO] [stdout] 79 | fn check_collisions(&self, cart: &Cart, moved_carts: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 79 - fn check_collisions(&self, cart: &Cart, moved_carts: &Vec) -> bool { [INFO] [stdout] 79 + fn check_collisions(&self, cart: &Cart, moved_carts: &[Cart]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> bin/day4/main.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | writeln!(f, "")?; [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> bin/day14/main.rs:20:51 [INFO] [stdout] | [INFO] [stdout] 20 | for i in self.elfs.iter_mut() {*i = (*i + self.board[*i] as usize + 1) % self.board.len()} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.board[*i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> bin/day4/main.rs:65:20 [INFO] [stdout] | [INFO] [stdout] 65 | fn sort_lines(vec: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 65 - fn sort_lines(vec: &mut Vec) { [INFO] [stdout] 65 + fn sort_lines(vec: &mut [String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> bin/day4/main.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 83 | let mod_line = String::from(&mod_line[2..]); [INFO] [stdout] | -------------------------------------------- unnecessary `let` binding [INFO] [stdout] 84 | mod_line [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 83 ~ [INFO] [stdout] 84 ~ String::from(&mod_line[2..]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> bin/day13/main.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | / match c { [INFO] [stdout] 121 | | '>'|'v'|'^'|'<' => true, [INFO] [stdout] 122 | | _ => false, [INFO] [stdout] 123 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 120 - match c { [INFO] [stdout] 121 - '>'|'v'|'^'|'<' => true, [INFO] [stdout] 122 - _ => false, [INFO] [stdout] 123 - } [INFO] [stdout] 120 + matches!(c, '>'|'v'|'^'|'<') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> bin/day13/main.rs:147:11 [INFO] [stdout] | [INFO] [stdout] 147 | while !crash.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `crash.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> bin/day4/main.rs:136:21 [INFO] [stdout] | [INFO] [stdout] 136 | .interleave(guard.time_asleep.clone().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/itertools-0.11.0/src/lib.rs:449:18 [INFO] [stdout] | [INFO] [stdout] 449 | where J: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 136 - .interleave(guard.time_asleep.clone().into_iter()) [INFO] [stdout] 136 + .interleave(guard.time_asleep.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `idx` is used to index `vec` [INFO] [stdout] --> bin/day4/main.rs:145:20 [INFO] [stdout] | [INFO] [stdout] 145 | for idx in 0..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 145 - for idx in 0..len { [INFO] [stdout] 145 + for (idx, ) in vec.iter().enumerate().take(len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> bin/day6/main.rs:41:51 [INFO] [stdout] | [INFO] [stdout] 41 | if self.finite_locations.contains(&location) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `location` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> bin/day4/main.rs:165:37 [INFO] [stdout] | [INFO] [stdout] 165 | let unique_guards: Vec = guard_map.into_iter().map(|(_, v)| v).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `guard_map.into_values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> bin/day2/main.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | fn part1(input: &str) -> u32 { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> bin/day2/main.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | fn part2(input: &str) -> String { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> bin/day2/main.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | fn part1(input: &str) -> u32 { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> bin/day2/main.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | fn part2(input: &str) -> String { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `sum_entries` is never used [INFO] [stdout] --> bin/day8/main.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl Node { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 41 | fn sum_entries(&self) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> bin/day8/main.rs:102:4 [INFO] [stdout] | [INFO] [stdout] 102 | fn part1(input: &str) -> u32 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashSet` and `VecDeque` [INFO] [stdout] --> bin/day17/main.rs:3:19 [INFO] [stdout] | [INFO] [stdout] 3 | collections::{VecDeque, HashSet}, [INFO] [stdout] | ^^^^^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> bin/day5/main.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return result; [INFO] [stdout] 16 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> bin/day6/main.rs:41:51 [INFO] [stdout] | [INFO] [stdout] 41 | if self.finite_locations.contains(&location) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `location` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> bin/day5/main.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return form(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return form(result); [INFO] [stdout] 18 + form(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> bin/day17/main.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 62 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> bin/day17/main.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> bin/day17/main.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | let mut right = nx.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `nx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> bin/day17/main.rs:77:28 [INFO] [stdout] | [INFO] [stdout] 77 | let mut left = nx.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try removing the `clone` call: `nx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `find_square_part1` is never used [INFO] [stdout] --> bin/day11/main.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 17 | impl Grid { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 34 | fn find_square_part1(&self) -> (usize, usize, i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> bin/day5/main.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return result; [INFO] [stdout] 16 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> bin/day5/main.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return form(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return form(result); [INFO] [stdout] 18 + form(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.25s [INFO] running `Command { std: "docker" "inspect" "0f70dc232ff4f32b77de22e155e2f00db10f965a0cbd72e123c3d5bb71bae647", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f70dc232ff4f32b77de22e155e2f00db10f965a0cbd72e123c3d5bb71bae647", kill_on_drop: false }` [INFO] [stdout] 0f70dc232ff4f32b77de22e155e2f00db10f965a0cbd72e123c3d5bb71bae647