[INFO] cloning repository https://github.com/NeoNet-app/NeoNet [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/NeoNet-app/NeoNet" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNeoNet-app%2FNeoNet", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNeoNet-app%2FNeoNet'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0e1f52e8f787c6b3c22e3d38babb2704bb9a7a27 [INFO] linting NeoNet-app/NeoNet against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNeoNet-app%2FNeoNet" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/NeoNet-app/NeoNet [INFO] finished tweaking git repo https://github.com/NeoNet-app/NeoNet [INFO] tweaked toml for git repo https://github.com/NeoNet-app/NeoNet written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/NeoNet-app/NeoNet on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/NeoNet-app/NeoNet already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fancy-regex v0.16.2 [INFO] [stderr] Downloaded comrak v0.24.1 [INFO] [stderr] Downloaded syntect v5.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c26b62f92b325b48344b08399c195c83fe4f7d6d6cb2e4754132d1b73b5f2c67 [INFO] running `Command { std: "docker" "start" "-a" "c26b62f92b325b48344b08399c195c83fe4f7d6d6cb2e4754132d1b73b5f2c67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c26b62f92b325b48344b08399c195c83fe4f7d6d6cb2e4754132d1b73b5f2c67", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c26b62f92b325b48344b08399c195c83fe4f7d6d6cb2e4754132d1b73b5f2c67", kill_on_drop: false }` [INFO] [stdout] c26b62f92b325b48344b08399c195c83fe4f7d6d6cb2e4754132d1b73b5f2c67 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 913f13895976adcd3bd5ef63e0fa03b64aa9a26b68cde4f45522c71ddf6fb1cd [INFO] running `Command { std: "docker" "start" "-a" "913f13895976adcd3bd5ef63e0fa03b64aa9a26b68cde4f45522c71ddf6fb1cd", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Checking tracing-core v0.1.35 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Compiling time-core v0.1.6 [INFO] [stderr] Compiling bytes v1.11.0 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Compiling time-macros v0.2.24 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking bytestring v1.5.0 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking actix-service v2.0.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling regex-lite v0.1.8 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Compiling tracing v0.1.43 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking terminal_size v0.4.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking deunicode v1.6.2 [INFO] [stderr] Checking iri-string v0.7.9 [INFO] [stderr] Checking rustls-pki-types v1.13.1 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking entities v1.0.1 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking slug v0.1.6 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking qstring v0.7.2 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Compiling cc v1.2.48 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling onig_sys v69.9.1 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking cookie v0.16.2 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking onig v6.5.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling derive_more-impl v2.1.0 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling derive_builder_core v0.20.2 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking derive_more v2.1.0 [INFO] [stderr] Compiling derive_builder_macro v0.20.2 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking derive_builder v0.20.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking syntect v5.3.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking comrak v0.24.1 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking actix-rt v2.11.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Checking tower-http v0.6.7 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking actix-http v3.11.2 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking actix-web v4.12.1 [INFO] [stderr] Checking reqwest v0.12.24 [INFO] [stderr] Checking actix-cors v0.7.1 [INFO] [stderr] Checking neonet v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/api/v1/main.rs:38:53 [INFO] [stdout] | [INFO] [stdout] 38 | pub async fn main_hander(request: RequestDataAPIV1, body: Option) -> CustomizeResponder { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_body` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/api/v1/home.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | ApiResult::Json(format!("{{\"message\": \"Hello, anonymous user !\"}}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"{\"message\": \"Hello, anonymous user !\"}".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/api/v1/main.rs:38:53 [INFO] [stdout] | [INFO] [stdout] 38 | pub async fn main_hander(request: RequestDataAPIV1, body: Option) -> CustomizeResponder { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_body` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helper/functions.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | if !body.get(item).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `body.get(item).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/helper/functions.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 20 | / let hash_string = result [INFO] [stdout] 21 | | .iter() [INFO] [stdout] 22 | | .map(|byte| format!("{:02x}", byte)) [INFO] [stdout] 23 | | .collect::(); [INFO] [stdout] | |_____________________________- unnecessary `let` binding [INFO] [stdout] 24 | hash_string [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 20 ~ [INFO] [stdout] 21 ~ result [INFO] [stdout] 22 + .iter() [INFO] [stdout] 23 + .map(|byte| format!("{:02x}", byte)) [INFO] [stdout] 24 + .collect::() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/helper/functions.rs:53:32 [INFO] [stdout] | [INFO] [stdout] 53 | Some(extract_value) => extract_value.as_bool().unwrap_or_else(|| false), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 53 - Some(extract_value) => extract_value.as_bool().unwrap_or_else(|| false), [INFO] [stdout] 53 + Some(extract_value) => extract_value.as_bool().unwrap_or(false), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/functions.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return text.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return text.to_owned(); [INFO] [stdout] 62 + text.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/helper/functions.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | return format!("{}", &text[..length]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&text[..length]).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/functions.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | return random_number; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return random_number; [INFO] [stdout] 70 + random_number [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/functions.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | return random_string; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return random_string; [INFO] [stdout] 79 + random_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/helper/request.rs:35:34 [INFO] [stdout] | [INFO] [stdout] 35 | path: format!("/{}", path.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/request.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return parsed_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return parsed_json; [INFO] [stdout] 76 + parsed_json [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/helper/request.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | / if !raw_query.is_empty() { [INFO] [stdout] 84 | | if let Some(q) = QString::from(raw_query).into_iter().collect::>().into() { [INFO] [stdout] 85 | | return q; [INFO] [stdout] 86 | | } [INFO] [stdout] 87 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 83 ~ if !raw_query.is_empty() [INFO] [stdout] 84 ~ && let Some(q) = QString::from(raw_query).into_iter().collect::>().into() { [INFO] [stdout] 85 | return q; [INFO] [stdout] 86 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `User_ip` should have a snake case name [INFO] [stdout] --> src/helper/request.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | let User_ip = connection_info.realip_remote_addr(); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `user_ip` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/api/v1/home.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | ApiResult::Json(format!("{{\"message\": \"Hello, anonymous user !\"}}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"{\"message\": \"Hello, anonymous user !\"}".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/helper/functions.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | if !body.get(item).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `body.get(item).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/helper/functions.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 20 | / let hash_string = result [INFO] [stdout] 21 | | .iter() [INFO] [stdout] 22 | | .map(|byte| format!("{:02x}", byte)) [INFO] [stdout] 23 | | .collect::(); [INFO] [stdout] | |_____________________________- unnecessary `let` binding [INFO] [stdout] 24 | hash_string [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 20 ~ [INFO] [stdout] 21 ~ result [INFO] [stdout] 22 + .iter() [INFO] [stdout] 23 + .map(|byte| format!("{:02x}", byte)) [INFO] [stdout] 24 + .collect::() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/helper/functions.rs:53:32 [INFO] [stdout] | [INFO] [stdout] 53 | Some(extract_value) => extract_value.as_bool().unwrap_or_else(|| false), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 53 - Some(extract_value) => extract_value.as_bool().unwrap_or_else(|| false), [INFO] [stdout] 53 + Some(extract_value) => extract_value.as_bool().unwrap_or(false), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/functions.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return text.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return text.to_owned(); [INFO] [stdout] 62 + text.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/helper/functions.rs:60:16 [INFO] [stdout] | [INFO] [stdout] 60 | return format!("{}", &text[..length]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&text[..length]).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/functions.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | return random_number; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return random_number; [INFO] [stdout] 70 + random_number [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/functions.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | return random_string; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return random_string; [INFO] [stdout] 79 + random_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/helper/request.rs:35:34 [INFO] [stdout] | [INFO] [stdout] 35 | path: format!("/{}", path.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper/request.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return parsed_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return parsed_json; [INFO] [stdout] 76 + parsed_json [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/helper/request.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | / if !raw_query.is_empty() { [INFO] [stdout] 84 | | if let Some(q) = QString::from(raw_query).into_iter().collect::>().into() { [INFO] [stdout] 85 | | return q; [INFO] [stdout] 86 | | } [INFO] [stdout] 87 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 83 ~ if !raw_query.is_empty() [INFO] [stdout] 84 ~ && let Some(q) = QString::from(raw_query).into_iter().collect::>().into() { [INFO] [stdout] 85 | return q; [INFO] [stdout] 86 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `User_ip` should have a snake case name [INFO] [stdout] --> src/helper/request.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | let User_ip = connection_info.realip_remote_addr(); [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `user_ip` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 58.78s [INFO] running `Command { std: "docker" "inspect" "913f13895976adcd3bd5ef63e0fa03b64aa9a26b68cde4f45522c71ddf6fb1cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "913f13895976adcd3bd5ef63e0fa03b64aa9a26b68cde4f45522c71ddf6fb1cd", kill_on_drop: false }` [INFO] [stdout] 913f13895976adcd3bd5ef63e0fa03b64aa9a26b68cde4f45522c71ddf6fb1cd