[INFO] cloning repository https://github.com/Natoune/open_launcher_rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Natoune/open_launcher_rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNatoune%2Fopen_launcher_rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNatoune%2Fopen_launcher_rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 10b1a0ed57cdc17a5aafd35c1a002aa19529b6a0 [INFO] linting Natoune/open_launcher_rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNatoune%2Fopen_launcher_rs" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Natoune/open_launcher_rs [INFO] removed 0 missing examples [INFO] finished tweaking git repo https://github.com/Natoune/open_launcher_rs [INFO] tweaked toml for git repo https://github.com/Natoune/open_launcher_rs written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Natoune/open_launcher_rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Natoune/open_launcher_rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rustls-pemfile v2.1.2 [INFO] [stderr] Downloaded deflate64 v0.1.8 [INFO] [stderr] Downloaded event-listener-strategy v0.5.1 [INFO] [stderr] Downloaded zstd v0.13.1 [INFO] [stderr] Downloaded async-channel v2.2.1 [INFO] [stderr] Downloaded async-signal v0.2.6 [INFO] [stderr] Downloaded zopfli v0.8.0 [INFO] [stderr] Downloaded async-io v2.3.2 [INFO] [stderr] Downloaded polling v3.7.0 [INFO] [stderr] Downloaded reqwest v0.12.4 [INFO] [stderr] Downloaded async-task v4.7.0 [INFO] [stderr] Downloaded async_zip v0.0.17 [INFO] [stderr] Downloaded async-process v2.2.2 [INFO] [stderr] Downloaded async-compression v0.4.9 [INFO] [stderr] Downloaded hyper v1.3.1 [INFO] [stderr] Downloaded zip v1.1.1 [INFO] [stderr] Downloaded rustls-pki-types v1.4.1 [INFO] [stderr] Downloaded async-recursion v1.1.0 [INFO] [stderr] Downloaded winreg v0.52.0 [INFO] [stderr] Downloaded zstd-safe v7.1.0 [INFO] [stderr] Downloaded libz-ng-sys v1.1.15 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c3578d3742bb8565b1d4a1e0b3b958fa69735ed7fbf152373dfb50f8eae0744 [INFO] running `Command { std: "docker" "start" "-a" "6c3578d3742bb8565b1d4a1e0b3b958fa69735ed7fbf152373dfb50f8eae0744", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c3578d3742bb8565b1d4a1e0b3b958fa69735ed7fbf152373dfb50f8eae0744", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c3578d3742bb8565b1d4a1e0b3b958fa69735ed7fbf152373dfb50f8eae0744", kill_on_drop: false }` [INFO] [stdout] 6c3578d3742bb8565b1d4a1e0b3b958fa69735ed7fbf152373dfb50f8eae0744 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 746d3add98ddc20f91ae30cddac5b299e6850c45d28247d8f16c71d72a1d3317 [INFO] running `Command { std: "docker" "start" "-a" "746d3add98ddc20f91ae30cddac5b299e6850c45d28247d8f16c71d72a1d3317", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Compiling zstd-safe v7.1.0 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking deflate64 v0.1.8 [INFO] [stderr] Compiling jobserver v0.1.30 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking rustls-pki-types v1.4.1 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking zopfli v0.8.0 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking event-listener v5.3.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking event-listener-strategy v0.5.1 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking async-channel v2.2.1 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling libz-ng-sys v1.1.15 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling async-recursion v1.1.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking h2 v0.4.4 [INFO] [stderr] Checking polling v3.7.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking async-io v2.3.2 [INFO] [stderr] Checking async-signal v0.2.6 [INFO] [stderr] Checking async-process v2.2.2 [INFO] [stderr] Checking zstd v0.13.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking async-compression v0.4.9 [INFO] [stderr] Checking zip v1.1.1 [INFO] [stderr] Checking async_zip v0.0.17 [INFO] [stderr] Checking open_launcher v1.5.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/auth.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | / pub fn new(username: &str) -> Auth { [INFO] [stdout] 59 | | let mut uuid = md5::compute(username.as_bytes()); [INFO] [stdout] 60 | | uuid[6] &= 0x0f; [INFO] [stdout] 61 | | uuid[6] |= 0x30; [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:67:19 [INFO] [stdout] | [INFO] [stdout] 67 | .join(&format!("{}.json", id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.json", id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:78:23 [INFO] [stdout] | [INFO] [stdout] 78 | .join(&format!( [INFO] [stdout] | _______________________^ [INFO] [stdout] 79 | | "forge-{}.json", [INFO] [stdout] 80 | | format!("{}-{}", id, loader_version.clone()) [INFO] [stdout] 81 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 ~ .join(format!( [INFO] [stdout] 79 + "forge-{}.json", [INFO] [stdout] 80 + format!("{}-{}", id, loader_version.clone()) [INFO] [stdout] 81 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/version.rs:78:24 [INFO] [stdout] | [INFO] [stdout] 78 | .join(&format!( [INFO] [stdout] | ________________________^ [INFO] [stdout] 79 | | "forge-{}.json", [INFO] [stdout] 80 | | format!("{}-{}", id, loader_version.clone()) [INFO] [stdout] 81 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | .join(&format!("neoforge-{}.json", loader_version.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("neoforge-{}.json", loader_version.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:127:23 [INFO] [stdout] | [INFO] [stdout] 127 | .join(&format!( [INFO] [stdout] | _______________________^ [INFO] [stdout] 128 | | "fabric-loader-{}.json", [INFO] [stdout] 129 | | format!("{}-{}", id, loader_version.clone()) [INFO] [stdout] 130 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 127 ~ .join(format!( [INFO] [stdout] 128 + "fabric-loader-{}.json", [INFO] [stdout] 129 + format!("{}-{}", id, loader_version.clone()) [INFO] [stdout] 130 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/version.rs:127:24 [INFO] [stdout] | [INFO] [stdout] 127 | .join(&format!( [INFO] [stdout] | ________________________^ [INFO] [stdout] 128 | | "fabric-loader-{}.json", [INFO] [stdout] 129 | | format!("{}-{}", id, loader_version.clone()) [INFO] [stdout] 130 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:140:23 [INFO] [stdout] | [INFO] [stdout] 140 | .join(&format!("quilt-loader-{}.json", loader_version.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("quilt-loader-{}.json", loader_version.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/version.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 178 | / if minor < 12 [INFO] [stdout] 179 | | || (minor == 12 && patch < 2) [INFO] [stdout] 180 | | || (minor == 12 && patch == 2 && forge_patch <= 2847) [INFO] [stdout] ... | [INFO] [stdout] 184 | | false [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 178 ~ minor < 12 [INFO] [stdout] 179 + || (minor == 12 && patch < 2) || (minor == 12 && patch == 2 && forge_patch <= 2847) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:232:19 [INFO] [stdout] | [INFO] [stdout] 232 | .join(&format!("{}.json", self.version.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.json", self.version.id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | format!("https://piston-meta.mojang.com/mc/game/version_manifest_v2.json"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"https://piston-meta.mojang.com/mc/game/version_manifest_v2.json".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/auth.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | / pub fn new(username: &str) -> Auth { [INFO] [stdout] 59 | | let mut uuid = md5::compute(username.as_bytes()); [INFO] [stdout] 60 | | uuid[6] &= 0x0f; [INFO] [stdout] 61 | | uuid[6] |= 0x30; [INFO] [stdout] ... | [INFO] [stdout] 76 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:259:19 [INFO] [stdout] | [INFO] [stdout] 259 | .join(&format!("{}.jar", self.version.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.jar", self.version.id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:67:19 [INFO] [stdout] | [INFO] [stdout] 67 | .join(&format!("{}.json", id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.json", id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:283:27 [INFO] [stdout] | [INFO] [stdout] 283 | .join(&format!("{}-installer.jar", self.version.forge.combined)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}-installer.jar", self.version.forge.combined)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:78:23 [INFO] [stdout] | [INFO] [stdout] 78 | .join(&format!( [INFO] [stdout] | _______________________^ [INFO] [stdout] 79 | | "forge-{}.json", [INFO] [stdout] 80 | | format!("{}-{}", id, loader_version.clone()) [INFO] [stdout] 81 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 ~ .join(format!( [INFO] [stdout] 79 + "forge-{}.json", [INFO] [stdout] 80 + format!("{}-{}", id, loader_version.clone()) [INFO] [stdout] 81 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:288:27 [INFO] [stdout] | [INFO] [stdout] 288 | .join(&format!("{}-installer.jar", self.version.neoforge.combined)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}-installer.jar", self.version.neoforge.combined)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/version.rs:78:24 [INFO] [stdout] | [INFO] [stdout] 78 | .join(&format!( [INFO] [stdout] | ________________________^ [INFO] [stdout] 79 | | "forge-{}.json", [INFO] [stdout] 80 | | format!("{}-{}", id, loader_version.clone()) [INFO] [stdout] 81 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | .join(&format!("neoforge-{}.json", loader_version.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("neoforge-{}.json", loader_version.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:345:27 [INFO] [stdout] | [INFO] [stdout] 345 | .join(&format!("{}.jar", self.version.forge.combined)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.jar", self.version.forge.combined)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:127:23 [INFO] [stdout] | [INFO] [stdout] 127 | .join(&format!( [INFO] [stdout] | _______________________^ [INFO] [stdout] 128 | | "fabric-loader-{}.json", [INFO] [stdout] 129 | | format!("{}-{}", id, loader_version.clone()) [INFO] [stdout] 130 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 127 ~ .join(format!( [INFO] [stdout] 128 + "fabric-loader-{}.json", [INFO] [stdout] 129 + format!("{}-{}", id, loader_version.clone()) [INFO] [stdout] 130 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/version.rs:127:24 [INFO] [stdout] | [INFO] [stdout] 127 | .join(&format!( [INFO] [stdout] | ________________________^ [INFO] [stdout] 128 | | "fabric-loader-{}.json", [INFO] [stdout] 129 | | format!("{}-{}", id, loader_version.clone()) [INFO] [stdout] 130 | | )); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:140:23 [INFO] [stdout] | [INFO] [stdout] 140 | .join(&format!("quilt-loader-{}.json", loader_version.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("quilt-loader-{}.json", loader_version.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:406:27 [INFO] [stdout] | [INFO] [stdout] 406 | .join(&format!("{}.json", self.version.fabric.combined)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.json", self.version.fabric.combined)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/version.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 178 | / if minor < 12 [INFO] [stdout] 179 | | || (minor == 12 && patch < 2) [INFO] [stdout] 180 | | || (minor == 12 && patch == 2 && forge_patch <= 2847) [INFO] [stdout] ... | [INFO] [stdout] 184 | | false [INFO] [stdout] 185 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 178 ~ minor < 12 [INFO] [stdout] 179 + || (minor == 12 && patch < 2) || (minor == 12 && patch == 2 && forge_patch <= 2847) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:411:27 [INFO] [stdout] | [INFO] [stdout] 411 | .join(&format!("{}.json", self.version.quilt.combined)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.json", self.version.quilt.combined)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:232:19 [INFO] [stdout] | [INFO] [stdout] 232 | .join(&format!("{}.json", self.version.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.json", self.version.id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | format!("https://piston-meta.mojang.com/mc/game/version_manifest_v2.json"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"https://piston-meta.mojang.com/mc/game/version_manifest_v2.json".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/assets.rs:27:43 [INFO] [stdout] | [INFO] [stdout] 27 | let index_path = indexes_dir.join(&format!( [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 28 | | "{}.json", [INFO] [stdout] 29 | | self.version.profile["assets"].as_str().unwrap() [INFO] [stdout] 30 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 27 ~ let index_path = indexes_dir.join(format!( [INFO] [stdout] 28 + "{}.json", [INFO] [stdout] 29 + self.version.profile["assets"].as_str().unwrap() [INFO] [stdout] 30 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:259:19 [INFO] [stdout] | [INFO] [stdout] 259 | .join(&format!("{}.jar", self.version.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.jar", self.version.id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/assets.rs:51:35 [INFO] [stdout] | [INFO] [stdout] 51 | .any(|object| object["hash"].as_str().unwrap() == &hash) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:283:27 [INFO] [stdout] | [INFO] [stdout] 283 | .join(&format!("{}-installer.jar", self.version.forge.combined)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}-installer.jar", self.version.forge.combined)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:288:27 [INFO] [stdout] | [INFO] [stdout] 288 | .join(&format!("{}-installer.jar", self.version.neoforge.combined)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}-installer.jar", self.version.neoforge.combined)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:345:27 [INFO] [stdout] | [INFO] [stdout] 345 | .join(&format!("{}.jar", self.version.forge.combined)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.jar", self.version.forge.combined)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/events.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | /// The file is the name of the file or the library that is currently being processed. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 15 | /// The file is the name of the file or the library that is currently being processed. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/events.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | /// The total is the total number of bytes/elements to process for the current task. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 16 | /// The total is the total number of bytes/elements to process for the current task. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/events.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | /// The current is the number of bytes/elements that have been processed for the current task. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 17 | /// The current is the number of bytes/elements that have been processed for the current task. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:406:27 [INFO] [stdout] | [INFO] [stdout] 406 | .join(&format!("{}.json", self.version.fabric.combined)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.json", self.version.fabric.combined)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/version.rs:411:27 [INFO] [stdout] | [INFO] [stdout] 411 | .join(&format!("{}.json", self.version.quilt.combined)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.json", self.version.quilt.combined)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/forge.rs:51:15 [INFO] [stdout] | [INFO] [stdout] 51 | game_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 51 - game_dir: &PathBuf, [INFO] [stdout] 51 + game_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/forge.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | let sides = match proc.get("sides") { [INFO] [stdout] | _________________^ [INFO] [stdout] 55 | | Some(sides) => Some(sides.as_array().unwrap()), [INFO] [stdout] 56 | | None => None, [INFO] [stdout] 57 | | }; [INFO] [stdout] | |_____^ help: try: `proc.get("sides").map(|sides| sides.as_array().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/forge.rs:67:41 [INFO] [stdout] | [INFO] [stdout] 67 | let outputs = resolve_outputs(proc, &fields); [INFO] [stdout] | ^^^^^^^ help: change this to: `fields` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/forge.rs:74:58 [INFO] [stdout] | [INFO] [stdout] 74 | path = path.replace(&format!("{{{}}}", key), &value); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/forge.rs:79:56 [INFO] [stdout] | [INFO] [stdout] 79 | sha = sha.replace(&format!("{{{}}}", key), &value); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/forge.rs:84:55 [INFO] [stdout] | [INFO] [stdout] 84 | && format!("{:x}", sha1::Sha1::digest(&fs::read(path).unwrap())) != sha) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `fs::read(path).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/assets.rs:27:43 [INFO] [stdout] | [INFO] [stdout] 27 | let index_path = indexes_dir.join(&format!( [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 28 | | "{}.json", [INFO] [stdout] 29 | | self.version.profile["assets"].as_str().unwrap() [INFO] [stdout] 30 | | )); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 27 ~ let index_path = indexes_dir.join(format!( [INFO] [stdout] 28 + "{}.json", [INFO] [stdout] 29 + self.version.profile["assets"].as_str().unwrap() [INFO] [stdout] 30 ~ )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/assets.rs:51:35 [INFO] [stdout] | [INFO] [stdout] 51 | .any(|object| object["hash"].as_str().unwrap() == &hash) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/forge.rs:190:21 [INFO] [stdout] | [INFO] [stdout] 190 | let sides = match proc.get("sides") { [INFO] [stdout] | _____________________^ [INFO] [stdout] 191 | | Some(sides) => Some(sides.as_array().unwrap()), [INFO] [stdout] 192 | | None => None, [INFO] [stdout] 193 | | }; [INFO] [stdout] | |_________^ help: try: `proc.get("sides").map(|sides| sides.as_array().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/libraries.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | Some(index) => format!("-{}", classifier[..index].to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use this: `&classifier[..index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/libraries.rs:23:46 [INFO] [stdout] | [INFO] [stdout] 23 | None => format!("-{}", classifier.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/events.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | /// The file is the name of the file or the library that is currently being processed. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 15 | /// The file is the name of the file or the library that is currently being processed. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/events.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | /// The total is the total number of bytes/elements to process for the current task. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 16 | /// The total is the total number of bytes/elements to process for the current task. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/events.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | /// The current is the number of bytes/elements that have been processed for the current task. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 17 | /// The current is the number of bytes/elements that have been processed for the current task. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os` after checking its variant with `is_none` [INFO] [stdout] --> src/libraries.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 51 | if os.is_none() { [INFO] [stdout] | --------------- help: try: `if let Some() = os` [INFO] [stdout] ... [INFO] [stdout] 54 | let os = os.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os` after checking its variant with `is_none` [INFO] [stdout] --> src/libraries.rs:64:30 [INFO] [stdout] | [INFO] [stdout] 61 | if os.is_none() { [INFO] [stdout] | --------------- help: try: `if let Some() = os` [INFO] [stdout] ... [INFO] [stdout] 64 | let os = os.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/forge.rs:51:15 [INFO] [stdout] | [INFO] [stdout] 51 | game_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 51 - game_dir: &PathBuf, [INFO] [stdout] 51 + game_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/forge.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | let sides = match proc.get("sides") { [INFO] [stdout] | _________________^ [INFO] [stdout] 55 | | Some(sides) => Some(sides.as_array().unwrap()), [INFO] [stdout] 56 | | None => None, [INFO] [stdout] 57 | | }; [INFO] [stdout] | |_____^ help: try: `proc.get("sides").map(|sides| sides.as_array().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/forge.rs:67:41 [INFO] [stdout] | [INFO] [stdout] 67 | let outputs = resolve_outputs(proc, &fields); [INFO] [stdout] | ^^^^^^^ help: change this to: `fields` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/forge.rs:74:58 [INFO] [stdout] | [INFO] [stdout] 74 | path = path.replace(&format!("{{{}}}", key), &value); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/forge.rs:79:56 [INFO] [stdout] | [INFO] [stdout] 79 | sha = sha.replace(&format!("{{{}}}", key), &value); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/forge.rs:84:55 [INFO] [stdout] | [INFO] [stdout] 84 | && format!("{:x}", sha1::Sha1::digest(&fs::read(path).unwrap())) != sha) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `fs::read(path).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/libraries.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 199 | / &format!( [INFO] [stdout] 200 | | "{}-{}-natives-{}.jar", [INFO] [stdout] 201 | | artifact, [INFO] [stdout] 202 | | version, [INFO] [stdout] ... | [INFO] [stdout] 205 | | .replace("linux", "nix"), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 199 ~ format!( [INFO] [stdout] 200 + "{}-{}-natives-{}.jar", [INFO] [stdout] 201 + artifact, [INFO] [stdout] 202 + version, [INFO] [stdout] 203 + get_os().replace("windows", "win") [INFO] [stdout] 204 + ) [INFO] [stdout] 205 ~ .replace("linux", "nix"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/libraries.rs:224:33 [INFO] [stdout] | [INFO] [stdout] 224 | / ... &fs::read(native["path"].as_str().unwrap_or_else(|| "")) [INFO] [stdout] 225 | | ... .await [INFO] [stdout] 226 | | ... .unwrap() [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 224 ~ fs::read(native["path"].as_str().unwrap_or_else(|| "")) [INFO] [stdout] 225 + .await [INFO] [stdout] 226 + .unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/libraries.rs:224:43 [INFO] [stdout] | [INFO] [stdout] 224 | ... &fs::read(native["path"].as_str().unwrap_or_else(|| "")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 224 - &fs::read(native["path"].as_str().unwrap_or_else(|| "")) [INFO] [stdout] 224 + &fs::read(native["path"].as_str().unwrap_or("")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/forge.rs:190:21 [INFO] [stdout] | [INFO] [stdout] 190 | let sides = match proc.get("sides") { [INFO] [stdout] | _____________________^ [INFO] [stdout] 191 | | Some(sides) => Some(sides.as_array().unwrap()), [INFO] [stdout] 192 | | None => None, [INFO] [stdout] 193 | | }; [INFO] [stdout] | |_________^ help: try: `proc.get("sides").map(|sides| sides.as_array().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:282:37 [INFO] [stdout] | [INFO] [stdout] 282 | let extracted = extract_all(&path, &natives_dir).await?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:282:44 [INFO] [stdout] | [INFO] [stdout] 282 | let extracted = extract_all(&path, &natives_dir).await?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `natives_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/libraries.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | Some(index) => format!("-{}", classifier[..index].to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use this: `&classifier[..index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/libraries.rs:311:15 [INFO] [stdout] | [INFO] [stdout] 311 | game_dir: &std::path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 311 - game_dir: &std::path::PathBuf, [INFO] [stdout] 311 + game_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/libraries.rs:23:46 [INFO] [stdout] | [INFO] [stdout] 23 | None => format!("-{}", classifier.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os` after checking its variant with `is_none` [INFO] [stdout] --> src/libraries.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 51 | if os.is_none() { [INFO] [stdout] | --------------- help: try: `if let Some() = os` [INFO] [stdout] ... [INFO] [stdout] 54 | let os = os.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os` after checking its variant with `is_none` [INFO] [stdout] --> src/libraries.rs:64:30 [INFO] [stdout] | [INFO] [stdout] 61 | if os.is_none() { [INFO] [stdout] | --------------- help: try: `if let Some() = os` [INFO] [stdout] ... [INFO] [stdout] 64 | let os = os.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:353:13 [INFO] [stdout] | [INFO] [stdout] 353 | &self.version.profile["libraries"].as_array().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.version.profile["libraries"].as_array().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:361:17 [INFO] [stdout] | [INFO] [stdout] 361 | &self.version.modded_profile["libraries"].as_array().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.version.modded_profile["libraries"].as_array().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:384:17 [INFO] [stdout] | [INFO] [stdout] 384 | / &self.version.forge.install_profile["libraries"] [INFO] [stdout] 385 | | .as_array() [INFO] [stdout] 386 | | .unwrap(), [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 384 ~ self.version.forge.install_profile["libraries"] [INFO] [stdout] 385 + .as_array() [INFO] [stdout] 386 ~ .unwrap(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:456:13 [INFO] [stdout] | [INFO] [stdout] 456 | &self.version.profile["libraries"].as_array().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.version.profile["libraries"].as_array().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:462:17 [INFO] [stdout] | [INFO] [stdout] 462 | &self.version.modded_profile["libraries"].as_array().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.version.modded_profile["libraries"].as_array().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/libraries.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 199 | / &format!( [INFO] [stdout] 200 | | "{}-{}-natives-{}.jar", [INFO] [stdout] 201 | | artifact, [INFO] [stdout] 202 | | version, [INFO] [stdout] ... | [INFO] [stdout] 205 | | .replace("linux", "nix"), [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 199 ~ format!( [INFO] [stdout] 200 + "{}-{}-natives-{}.jar", [INFO] [stdout] 201 + artifact, [INFO] [stdout] 202 + version, [INFO] [stdout] 203 + get_os().replace("windows", "win") [INFO] [stdout] 204 + ) [INFO] [stdout] 205 ~ .replace("linux", "nix"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:503:13 [INFO] [stdout] | [INFO] [stdout] 503 | &self.version.profile["libraries"].as_array().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.version.profile["libraries"].as_array().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:511:17 [INFO] [stdout] | [INFO] [stdout] 511 | &self.version.modded_profile["libraries"].as_array().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.version.modded_profile["libraries"].as_array().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/libraries.rs:224:33 [INFO] [stdout] | [INFO] [stdout] 224 | / ... &fs::read(native["path"].as_str().unwrap_or_else(|| "")) [INFO] [stdout] 225 | | ... .await [INFO] [stdout] 226 | | ... .unwrap() [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 224 ~ fs::read(native["path"].as_str().unwrap_or_else(|| "")) [INFO] [stdout] 225 + .await [INFO] [stdout] 226 + .unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/libraries.rs:224:43 [INFO] [stdout] | [INFO] [stdout] 224 | ... &fs::read(native["path"].as_str().unwrap_or_else(|| "")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 224 - &fs::read(native["path"].as_str().unwrap_or_else(|| "")) [INFO] [stdout] 224 + &fs::read(native["path"].as_str().unwrap_or("")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:282:37 [INFO] [stdout] | [INFO] [stdout] 282 | let extracted = extract_all(&path, &natives_dir).await?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:282:44 [INFO] [stdout] | [INFO] [stdout] 282 | let extracted = extract_all(&path, &natives_dir).await?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `natives_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/libraries.rs:311:15 [INFO] [stdout] | [INFO] [stdout] 311 | game_dir: &std::path::PathBuf, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 311 - game_dir: &std::path::PathBuf, [INFO] [stdout] 311 + game_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:353:13 [INFO] [stdout] | [INFO] [stdout] 353 | &self.version.profile["libraries"].as_array().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.version.profile["libraries"].as_array().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:361:17 [INFO] [stdout] | [INFO] [stdout] 361 | &self.version.modded_profile["libraries"].as_array().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.version.modded_profile["libraries"].as_array().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:384:17 [INFO] [stdout] | [INFO] [stdout] 384 | / &self.version.forge.install_profile["libraries"] [INFO] [stdout] 385 | | .as_array() [INFO] [stdout] 386 | | .unwrap(), [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 384 ~ self.version.forge.install_profile["libraries"] [INFO] [stdout] 385 + .as_array() [INFO] [stdout] 386 ~ .unwrap(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:456:13 [INFO] [stdout] | [INFO] [stdout] 456 | &self.version.profile["libraries"].as_array().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.version.profile["libraries"].as_array().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:462:17 [INFO] [stdout] | [INFO] [stdout] 462 | &self.version.modded_profile["libraries"].as_array().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.version.modded_profile["libraries"].as_array().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:503:13 [INFO] [stdout] | [INFO] [stdout] 503 | &self.version.profile["libraries"].as_array().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.version.profile["libraries"].as_array().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/libraries.rs:511:17 [INFO] [stdout] | [INFO] [stdout] 511 | &self.version.modded_profile["libraries"].as_array().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.version.modded_profile["libraries"].as_array().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `rules` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:57:33 [INFO] [stdout] | [INFO] [stdout] 47 | if rules.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = rules` [INFO] [stdout] ... [INFO] [stdout] 57 | for rule in rules.unwrap().as_array().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:66:42 [INFO] [stdout] | [INFO] [stdout] 63 | ... if os.is_none() { [INFO] [stdout] | --------------- help: try: `if let Some() = os` [INFO] [stdout] ... [INFO] [stdout] 66 | ... let os = os.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:80:42 [INFO] [stdout] | [INFO] [stdout] 77 | ... if os.is_none() { [INFO] [stdout] | --------------- help: try: `if let Some() = os` [INFO] [stdout] ... [INFO] [stdout] 80 | ... let os = os.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:138:32 [INFO] [stdout] | [INFO] [stdout] 138 | ... if !cond_features.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cond_features.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:157:39 [INFO] [stdout] | [INFO] [stdout] 157 | ... } else if !os.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `os.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `rules` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:131:33 [INFO] [stdout] | [INFO] [stdout] 121 | if rules.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = rules` [INFO] [stdout] ... [INFO] [stdout] 131 | for rule in rules.unwrap().as_array().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cond_features` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:139:53 [INFO] [stdout] | [INFO] [stdout] 138 | ... if !cond_features.is_none() { [INFO] [stdout] | ----------------------- the check is happening here [INFO] [stdout] 139 | ... let cond_features = cond_features.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:158:42 [INFO] [stdout] | [INFO] [stdout] 157 | ... } else if !os.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 158 | ... let os = os.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:170:42 [INFO] [stdout] | [INFO] [stdout] 167 | ... if os.is_none() { [INFO] [stdout] | --------------- help: try: `if let Some() = os` [INFO] [stdout] ... [INFO] [stdout] 170 | ... let os = os.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/lib.rs:143:44 [INFO] [stdout] | [INFO] [stdout] 143 | ... if &features[key] [INFO] [stdout] | ^------------- [INFO] [stdout] | | [INFO] [stdout] | __________________________help: use the left value directly: `features[key]` [INFO] [stdout] | | [INFO] [stdout] 144 | | ... != serde_json::to_string(value).unwrap().as_str() [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:380:23 [INFO] [stdout] | [INFO] [stdout] 380 | .join(&format!("{}.jar", self.version.id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.jar", self.version.id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `rules` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:57:33 [INFO] [stdout] | [INFO] [stdout] 47 | if rules.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = rules` [INFO] [stdout] ... [INFO] [stdout] 57 | for rule in rules.unwrap().as_array().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:66:42 [INFO] [stdout] | [INFO] [stdout] 63 | ... if os.is_none() { [INFO] [stdout] | --------------- help: try: `if let Some() = os` [INFO] [stdout] ... [INFO] [stdout] 66 | ... let os = os.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:80:42 [INFO] [stdout] | [INFO] [stdout] 77 | ... if os.is_none() { [INFO] [stdout] | --------------- help: try: `if let Some() = os` [INFO] [stdout] ... [INFO] [stdout] 80 | ... let os = os.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:435:14 [INFO] [stdout] | [INFO] [stdout] 435 | &format!("-Djava.library.path=${{natives_directory}}",), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-Djava.library.path=${natives_directory}".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:138:32 [INFO] [stdout] | [INFO] [stdout] 138 | ... if !cond_features.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cond_features.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:157:39 [INFO] [stdout] | [INFO] [stdout] 157 | ... } else if !os.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `os.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `rules` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:131:33 [INFO] [stdout] | [INFO] [stdout] 121 | if rules.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = rules` [INFO] [stdout] ... [INFO] [stdout] 131 | for rule in rules.unwrap().as_array().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cond_features` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:139:53 [INFO] [stdout] | [INFO] [stdout] 138 | ... if !cond_features.is_none() { [INFO] [stdout] | ----------------------- the check is happening here [INFO] [stdout] 139 | ... let cond_features = cond_features.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:158:42 [INFO] [stdout] | [INFO] [stdout] 157 | ... } else if !os.is_none() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 158 | ... let os = os.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:170:42 [INFO] [stdout] | [INFO] [stdout] 167 | ... if os.is_none() { [INFO] [stdout] | --------------- help: try: `if let Some() = os` [INFO] [stdout] ... [INFO] [stdout] 170 | ... let os = os.unwrap().as_object().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/lib.rs:143:44 [INFO] [stdout] | [INFO] [stdout] 143 | ... if &features[key] [INFO] [stdout] | ^------------- [INFO] [stdout] | | [INFO] [stdout] | __________________________help: use the left value directly: `features[key]` [INFO] [stdout] | | [INFO] [stdout] 144 | | ... != serde_json::to_string(value).unwrap().as_str() [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:380:23 [INFO] [stdout] | [INFO] [stdout] 380 | .join(&format!("{}.jar", self.version.id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{}.jar", self.version.id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:435:14 [INFO] [stdout] | [INFO] [stdout] 435 | &format!("-Djava.library.path=${{natives_directory}}",), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-Djava.library.path=${natives_directory}".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 40.75s [INFO] running `Command { std: "docker" "inspect" "746d3add98ddc20f91ae30cddac5b299e6850c45d28247d8f16c71d72a1d3317", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "746d3add98ddc20f91ae30cddac5b299e6850c45d28247d8f16c71d72a1d3317", kill_on_drop: false }` [INFO] [stdout] 746d3add98ddc20f91ae30cddac5b299e6850c45d28247d8f16c71d72a1d3317