[INFO] cloning repository https://github.com/Nat1anWasTaken/fortis [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Nat1anWasTaken/fortis" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNat1anWasTaken%2Ffortis", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNat1anWasTaken%2Ffortis'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8901492517852889cfb555745239fc6572fe3b5b [INFO] linting Nat1anWasTaken/fortis against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNat1anWasTaken%2Ffortis" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Nat1anWasTaken/fortis [INFO] finished tweaking git repo https://github.com/Nat1anWasTaken/fortis [INFO] tweaked toml for git repo https://github.com/Nat1anWasTaken/fortis written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Nat1anWasTaken/fortis on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Nat1anWasTaken/fortis already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio-tungstenite v0.27.0 [INFO] [stderr] Downloaded tungstenite v0.27.0 [INFO] [stderr] Downloaded directories v5.0.1 [INFO] [stderr] Downloaded deepgram v0.7.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4b02544ae20aaed7a8c9cbc6b73b4b5cd5859fa3a14531d5e829fb155cb851a8 [INFO] running `Command { std: "docker" "start" "-a" "4b02544ae20aaed7a8c9cbc6b73b4b5cd5859fa3a14531d5e829fb155cb851a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4b02544ae20aaed7a8c9cbc6b73b4b5cd5859fa3a14531d5e829fb155cb851a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b02544ae20aaed7a8c9cbc6b73b4b5cd5859fa3a14531d5e829fb155cb851a8", kill_on_drop: false }` [INFO] [stdout] 4b02544ae20aaed7a8c9cbc6b73b4b5cd5859fa3a14531d5e829fb155cb851a8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 16adcea70af67507ae31d8c0967e64b44d261cd5695cf0c230a79931e61e62d2 [INFO] running `Command { std: "docker" "start" "-a" "16adcea70af67507ae31d8c0967e64b44d261cd5695cf0c230a79931e61e62d2", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Compiling cc v1.2.44 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking litemap v0.8.1 [INFO] [stderr] Checking writeable v0.6.2 [INFO] [stderr] Compiling rustls v0.23.34 [INFO] [stderr] Compiling icu_properties_data v2.1.1 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking rustls-pki-types v1.13.0 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling instability v0.3.9 [INFO] [stderr] Checking data-encoding v2.9.0 [INFO] [stderr] Checking webpki-roots v1.0.4 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Compiling cpal v0.13.5 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking iana-time-zone v0.1.64 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking nix v0.23.2 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking alsa v0.6.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Checking tungstenite v0.27.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-util v0.7.17 [INFO] [stderr] Checking sha256 v1.6.0 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking tokio-tungstenite v0.27.0 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.12.24 [INFO] [stderr] Checking deepgram v0.7.0 [INFO] [stderr] Checking fortis v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `has_custom_name` is never used [INFO] [stdout] --> src/state.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 55 | impl AppState { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 200 | pub fn has_custom_name(&self, speaker_id: i32) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `close` is never used [INFO] [stdout] --> src/transcribers.rs:20:14 [INFO] [stdout] | [INFO] [stdout] 15 | pub trait AudioTranscriber: Send + Sync { [INFO] [stdout] | ---------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 20 | async fn close(&mut self) -> Result<(), Box>; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/transcribers/deepgram.rs:79:28 [INFO] [stdout] | [INFO] [stdout] 79 | if !speaker_message.is_empty() && !(last_was_cjk && current_is_cjk) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(speaker_message.is_empty() || last_was_cjk && current_is_cjk)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/widgets/settings_dialog.rs:159:21 [INFO] [stdout] | [INFO] [stdout] 159 | / if edit_state.cursor > 0 { [INFO] [stdout] 160 | | if let Some((idx, _)) = edit_state [INFO] [stdout] 161 | | .buffer [INFO] [stdout] 162 | | .char_indices() [INFO] [stdout] ... | [INFO] [stdout] 169 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 158 ~ KeyCode::Backspace [INFO] [stdout] 159 ~ if edit_state.cursor > 0 => { [INFO] [stdout] 160 | if let Some((idx, _)) = edit_state [INFO] [stdout] ... [INFO] [stdout] 168 | } [INFO] [stdout] 169 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/widgets/settings_dialog.rs:172:21 [INFO] [stdout] | [INFO] [stdout] 172 | / if edit_state.cursor < edit_state.buffer.len() { [INFO] [stdout] 173 | | if let Some((offset, ch)) = [INFO] [stdout] 174 | | edit_state.buffer[edit_state.cursor..].char_indices().next() [INFO] [stdout] ... | [INFO] [stdout] 180 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 171 ~ KeyCode::Delete [INFO] [stdout] 172 ~ if edit_state.cursor < edit_state.buffer.len() => { [INFO] [stdout] 173 | if let Some((offset, ch)) = [INFO] [stdout] ... [INFO] [stdout] 179 | } [INFO] [stdout] 180 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/widgets/settings_dialog.rs:196:21 [INFO] [stdout] | [INFO] [stdout] 196 | / if !c.is_control() [INFO] [stdout] 197 | | && edit_state [INFO] [stdout] 198 | | .max_length [INFO] [stdout] 199 | | .map_or(true, |max| edit_state.buffer.chars().count() < max) [INFO] [stdout] ... | [INFO] [stdout] 202 | | edit_state.cursor += c.len_utf8(); [INFO] [stdout] 203 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 195 ~ KeyCode::Char(c) [INFO] [stdout] 196 | if !c.is_control() [INFO] [stdout] ... [INFO] [stdout] 199 | .map_or(true, |max| edit_state.buffer.chars().count() < max) [INFO] [stdout] 200 ~ => { [INFO] [stdout] 201 | edit_state.buffer.insert(edit_state.cursor, c); [INFO] [stdout] 202 | edit_state.cursor += c.len_utf8(); [INFO] [stdout] 203 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/widgets/settings_dialog.rs:197:28 [INFO] [stdout] | [INFO] [stdout] 197 | && edit_state [INFO] [stdout] | ____________________________^ [INFO] [stdout] 198 | | .max_length [INFO] [stdout] 199 | | .map_or(true, |max| edit_state.buffer.chars().count() < max) [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 199 - .map_or(true, |max| edit_state.buffer.chars().count() < max) [INFO] [stdout] 199 + .is_none_or(|max| edit_state.buffer.chars().count() < max) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/widgets/settings_dialog.rs:334:20 [INFO] [stdout] | [INFO] [stdout] 334 | && field [INFO] [stdout] | ____________________^ [INFO] [stdout] 335 | | .max_length [INFO] [stdout] 336 | | .map_or(true, |max| buffer.chars().count() < max) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 336 - .map_or(true, |max| buffer.chars().count() < max) [INFO] [stdout] 336 + .is_none_or(|max| buffer.chars().count() < max) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `has_custom_name` is never used [INFO] [stdout] --> src/state.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 55 | impl AppState { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 200 | pub fn has_custom_name(&self, speaker_id: i32) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `close` is never used [INFO] [stdout] --> src/transcribers.rs:20:14 [INFO] [stdout] | [INFO] [stdout] 15 | pub trait AudioTranscriber: Send + Sync { [INFO] [stdout] | ---------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 20 | async fn close(&mut self) -> Result<(), Box>; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/widgets/footer.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 9 | let controls = vec![ [INFO] [stdout] | ________________________^ [INFO] [stdout] 10 | | ("SPACE", "Pause/Resume"), [INFO] [stdout] 11 | | ("↑/↓", "Scroll"), [INFO] [stdout] 12 | | ("←/→", "Focus Speaker/Message"), [INFO] [stdout] ... | [INFO] [stdout] 15 | | ("q/ESC", "Quit"), [INFO] [stdout] 16 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 9 ~ let controls = [("SPACE", "Pause/Resume"), [INFO] [stdout] 10 ~ ("↑/↓", "Scroll"), [INFO] [stdout] 11 ~ ("←/→", "Focus Speaker/Message"), [INFO] [stdout] 12 + ("ENTER", "Edit"), [INFO] [stdout] 13 + ("S", "Settings"), [INFO] [stdout] 14 ~ ("q/ESC", "Quit")]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/transcribers/deepgram.rs:79:28 [INFO] [stdout] | [INFO] [stdout] 79 | if !speaker_message.is_empty() && !(last_was_cjk && current_is_cjk) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(speaker_message.is_empty() || last_was_cjk && current_is_cjk)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/widgets/settings_dialog.rs:159:21 [INFO] [stdout] | [INFO] [stdout] 159 | / if edit_state.cursor > 0 { [INFO] [stdout] 160 | | if let Some((idx, _)) = edit_state [INFO] [stdout] 161 | | .buffer [INFO] [stdout] 162 | | .char_indices() [INFO] [stdout] ... | [INFO] [stdout] 169 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 158 ~ KeyCode::Backspace [INFO] [stdout] 159 ~ if edit_state.cursor > 0 => { [INFO] [stdout] 160 | if let Some((idx, _)) = edit_state [INFO] [stdout] ... [INFO] [stdout] 168 | } [INFO] [stdout] 169 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/widgets/settings_dialog.rs:172:21 [INFO] [stdout] | [INFO] [stdout] 172 | / if edit_state.cursor < edit_state.buffer.len() { [INFO] [stdout] 173 | | if let Some((offset, ch)) = [INFO] [stdout] 174 | | edit_state.buffer[edit_state.cursor..].char_indices().next() [INFO] [stdout] ... | [INFO] [stdout] 180 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 171 ~ KeyCode::Delete [INFO] [stdout] 172 ~ if edit_state.cursor < edit_state.buffer.len() => { [INFO] [stdout] 173 | if let Some((offset, ch)) = [INFO] [stdout] ... [INFO] [stdout] 179 | } [INFO] [stdout] 180 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/widgets/settings_dialog.rs:196:21 [INFO] [stdout] | [INFO] [stdout] 196 | / if !c.is_control() [INFO] [stdout] 197 | | && edit_state [INFO] [stdout] 198 | | .max_length [INFO] [stdout] 199 | | .map_or(true, |max| edit_state.buffer.chars().count() < max) [INFO] [stdout] ... | [INFO] [stdout] 202 | | edit_state.cursor += c.len_utf8(); [INFO] [stdout] 203 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 195 ~ KeyCode::Char(c) [INFO] [stdout] 196 | if !c.is_control() [INFO] [stdout] ... [INFO] [stdout] 199 | .map_or(true, |max| edit_state.buffer.chars().count() < max) [INFO] [stdout] 200 ~ => { [INFO] [stdout] 201 | edit_state.buffer.insert(edit_state.cursor, c); [INFO] [stdout] 202 | edit_state.cursor += c.len_utf8(); [INFO] [stdout] 203 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/widgets/settings_dialog.rs:197:28 [INFO] [stdout] | [INFO] [stdout] 197 | && edit_state [INFO] [stdout] | ____________________________^ [INFO] [stdout] 198 | | .max_length [INFO] [stdout] 199 | | .map_or(true, |max| edit_state.buffer.chars().count() < max) [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 199 - .map_or(true, |max| edit_state.buffer.chars().count() < max) [INFO] [stdout] 199 + .is_none_or(|max| edit_state.buffer.chars().count() < max) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/widgets/settings_dialog.rs:334:20 [INFO] [stdout] | [INFO] [stdout] 334 | && field [INFO] [stdout] | ____________________^ [INFO] [stdout] 335 | | .max_length [INFO] [stdout] 336 | | .map_or(true, |max| buffer.chars().count() < max) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 336 - .map_or(true, |max| buffer.chars().count() < max) [INFO] [stdout] 336 + .is_none_or(|max| buffer.chars().count() < max) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/widgets/footer.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 9 | let controls = vec![ [INFO] [stdout] | ________________________^ [INFO] [stdout] 10 | | ("SPACE", "Pause/Resume"), [INFO] [stdout] 11 | | ("↑/↓", "Scroll"), [INFO] [stdout] 12 | | ("←/→", "Focus Speaker/Message"), [INFO] [stdout] ... | [INFO] [stdout] 15 | | ("q/ESC", "Quit"), [INFO] [stdout] 16 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 9 ~ let controls = [("SPACE", "Pause/Resume"), [INFO] [stdout] 10 ~ ("↑/↓", "Scroll"), [INFO] [stdout] 11 ~ ("←/→", "Focus Speaker/Message"), [INFO] [stdout] 12 + ("ENTER", "Edit"), [INFO] [stdout] 13 + ("S", "Settings"), [INFO] [stdout] 14 ~ ("q/ESC", "Quit")]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 42.70s [INFO] running `Command { std: "docker" "inspect" "16adcea70af67507ae31d8c0967e64b44d261cd5695cf0c230a79931e61e62d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16adcea70af67507ae31d8c0967e64b44d261cd5695cf0c230a79931e61e62d2", kill_on_drop: false }` [INFO] [stdout] 16adcea70af67507ae31d8c0967e64b44d261cd5695cf0c230a79931e61e62d2