[INFO] cloning repository https://github.com/Nareshix/NightPDF [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Nareshix/NightPDF" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNareshix%2FNightPDF", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNareshix%2FNightPDF'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] be824808accb9d0b0cab91587a599673c6e2c6ff [INFO] linting Nareshix/NightPDF against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNareshix%2FNightPDF" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Nareshix/NightPDF [INFO] finished tweaking git repo https://github.com/Nareshix/NightPDF [INFO] tweaked toml for git repo https://github.com/Nareshix/NightPDF written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Nareshix/NightPDF on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Nareshix/NightPDF already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded maybe-owned v0.3.4 [INFO] [stderr] Downloaded wayland-backend v0.3.14 [INFO] [stderr] Downloaded wayland-protocols-misc v0.3.11 [INFO] [stderr] Downloaded zvariant_derive v5.10.0 [INFO] [stderr] Downloaded wayland-scanner v0.31.9 [INFO] [stderr] Downloaded uds_windows v1.2.0 [INFO] [stderr] Downloaded zbus_macros v5.14.0 [INFO] [stderr] Downloaded jni-macros v0.22.2 [INFO] [stderr] Downloaded wayland-protocols v0.32.11 [INFO] [stderr] Downloaded zvariant v5.10.0 [INFO] [stderr] Downloaded zune-jpeg v0.5.13 [INFO] [stderr] Downloaded tiff v0.11.3 [INFO] [stderr] Downloaded calloop v0.14.4 [INFO] [stderr] Downloaded quick-xml v0.39.2 [INFO] [stderr] Downloaded wayland-protocols-plasma v0.3.11 [INFO] [stderr] Downloaded zbus v5.14.0 [INFO] [stderr] Downloaded jni v0.22.3 [INFO] [stderr] Downloaded image v0.25.10 [INFO] [stderr] Downloaded moxcms v0.8.1 [INFO] [stderr] Downloaded wayland-client v0.31.13 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.3.11 [INFO] [stderr] Downloaded wayland-cursor v0.31.13 [INFO] [stderr] Downloaded wayland-sys v0.31.10 [INFO] [stderr] Downloaded orbclient v0.3.51 [INFO] [stderr] Downloaded pdfium-render v0.8.37 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4383fe8db0451bb2abdd467ed8cbe56cf41a2a65873bef41bd1f34afb99db79b [INFO] running `Command { std: "docker" "start" "-a" "4383fe8db0451bb2abdd467ed8cbe56cf41a2a65873bef41bd1f34afb99db79b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4383fe8db0451bb2abdd467ed8cbe56cf41a2a65873bef41bd1f34afb99db79b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4383fe8db0451bb2abdd467ed8cbe56cf41a2a65873bef41bd1f34afb99db79b", kill_on_drop: false }` [INFO] [stdout] 4383fe8db0451bb2abdd467ed8cbe56cf41a2a65873bef41bd1f34afb99db79b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c8e696c257ac4599ff60d952ea7dc73f89409f1d4a84a8e1fa9d7f7b6d9bf8c9 [INFO] running `Command { std: "docker" "start" "-a" "c8e696c257ac4599ff60d952ea7dc73f89409f1d4a84a8e1fa9d7f7b6d9bf8c9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling winnow v0.7.15 [INFO] [stderr] Compiling wayland-sys v0.31.10 [INFO] [stderr] Checking dlib v0.5.3 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Compiling toml_datetime v1.0.0+spec-1.1.0 [INFO] [stderr] Compiling quick-xml v0.39.2 [INFO] [stderr] Compiling wayland-backend v0.3.14 [INFO] [stderr] Compiling wayland-client v0.31.13 [INFO] [stderr] Checking unicode-ident v1.0.24 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Compiling endi v1.1.1 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Checking piper v0.2.5 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking uuid v1.22.0 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking syn v2.0.117 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking accesskit v0.21.1 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Compiling winit v0.30.13 [INFO] [stderr] Checking pxfm v0.1.28 [INFO] [stderr] Checking zune-jpeg v0.5.13 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking async-executor v1.14.0 [INFO] [stderr] Checking png v0.18.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking accesskit_consumer v0.31.0 [INFO] [stderr] Compiling rfd v0.17.2 [INFO] [stderr] Compiling pdfium-render v0.8.37 [INFO] [stderr] Compiling wayland-scanner v0.31.9 [INFO] [stderr] Checking utf16string v0.2.0 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking libloading v0.9.0 [INFO] [stderr] Checking pollster v0.4.0 [INFO] [stderr] Checking maybe-owned v0.3.4 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking memmap2 v0.9.10 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling toml_parser v1.0.9+spec-1.1.0 [INFO] [stderr] Checking moxcms v0.8.1 [INFO] [stderr] Compiling toml_edit v0.25.4+spec-1.1.0 [INFO] [stderr] Checking glutin_glx_sys v0.6.1 [INFO] [stderr] Checking glutin v0.32.3 [INFO] [stderr] Compiling proc-macro-crate v3.5.0 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Checking wayland-protocols v0.32.11 [INFO] [stderr] Checking wayland-cursor v0.31.13 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking calloop v0.14.4 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking emath v0.33.3 [INFO] [stderr] Checking image v0.25.10 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking ecolor v0.33.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking epaint v0.33.3 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking egui v0.33.3 [INFO] [stderr] Checking zvariant_utils v3.3.0 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking quick-xml v0.38.4 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Compiling zvariant_derive v5.10.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling zvariant v5.10.0 [INFO] [stderr] Checking webbrowser v1.2.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.11 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.11 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking wayland-protocols-misc v0.3.11 [INFO] [stderr] Checking egui_glow v0.33.3 [INFO] [stderr] Compiling zbus_names v4.3.1 [INFO] [stderr] Compiling zbus_xml v5.1.0 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking smithay-client-toolkit v0.20.0 [INFO] [stderr] Compiling zbus_macros v5.14.0 [INFO] [stderr] Compiling zbus-lockstep v0.5.2 [INFO] [stderr] Compiling zbus-lockstep-macros v0.5.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking zbus v5.14.0 [INFO] [stderr] Checking glutin-winit v0.5.0 [INFO] [stderr] Checking atspi-common v0.9.0 [INFO] [stderr] Checking atspi-proxies v0.9.0 [INFO] [stderr] Checking accesskit_atspi_common v0.14.2 [INFO] [stderr] Checking atspi-connection v0.9.0 [INFO] [stderr] Checking atspi v0.25.0 [INFO] [stderr] Checking accesskit_unix v0.17.2 [INFO] [stderr] Checking accesskit_winit v0.29.2 [INFO] [stderr] Checking egui-winit v0.33.3 [INFO] [stderr] Checking eframe v0.33.3 [INFO] [stderr] Checking NightPDF v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated associated function `eframe::egui::Frame::none`: Use `Frame::NONE` or `Frame::new()` instead. [INFO] [stdout] --> src/app.rs:394:33 [INFO] [stdout] | [INFO] [stdout] 394 | .frame(egui::Frame::none()) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `eframe::egui::Frame::none`: Use `Frame::NONE` or `Frame::new()` instead. [INFO] [stdout] --> src/app.rs:394:33 [INFO] [stdout] | [INFO] [stdout] 394 | .frame(egui::Frame::none()) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app.rs:353:24 [INFO] [stdout] | [INFO] [stdout] 353 | if (resp.has_focus() || (resp.lost_focus() && enter_pressed)) && enter_pressed { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 353 - if (resp.has_focus() || (resp.lost_focus() && enter_pressed)) && enter_pressed { [INFO] [stdout] 353 + if !(!enter_pressed || !resp.has_focus() && !resp.lost_focus()) { [INFO] [stdout] | [INFO] [stdout] 353 - if (resp.has_focus() || (resp.lost_focus() && enter_pressed)) && enter_pressed { [INFO] [stdout] 353 + if (resp.lost_focus() || resp.has_focus()) && enter_pressed { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app.rs:353:24 [INFO] [stdout] | [INFO] [stdout] 353 | if (resp.has_focus() || (resp.lost_focus() && enter_pressed)) && enter_pressed { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 353 - if (resp.has_focus() || (resp.lost_focus() && enter_pressed)) && enter_pressed { [INFO] [stdout] 353 + if !(!enter_pressed || !resp.has_focus() && !resp.lost_focus()) { [INFO] [stdout] | [INFO] [stdout] 353 - if (resp.has_focus() || (resp.lost_focus() && enter_pressed)) && enter_pressed { [INFO] [stdout] 353 + if (resp.lost_focus() || resp.has_focus()) && enter_pressed { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `chars` [INFO] [stdout] --> src/viewer.rs:465:18 [INFO] [stdout] | [INFO] [stdout] 465 | for i in start..=end { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 465 - for i in start..=end { [INFO] [stdout] 465 + for in chars.iter().take(end + 1).skip(start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `chars` [INFO] [stdout] --> src/viewer.rs:465:18 [INFO] [stdout] | [INFO] [stdout] 465 | for i in start..=end { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 465 - for i in start..=end { [INFO] [stdout] 465 + for in chars.iter().take(end + 1).skip(start) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 06s [INFO] running `Command { std: "docker" "inspect" "c8e696c257ac4599ff60d952ea7dc73f89409f1d4a84a8e1fa9d7f7b6d9bf8c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c8e696c257ac4599ff60d952ea7dc73f89409f1d4a84a8e1fa9d7f7b6d9bf8c9", kill_on_drop: false }` [INFO] [stdout] c8e696c257ac4599ff60d952ea7dc73f89409f1d4a84a8e1fa9d7f7b6d9bf8c9