[INFO] cloning repository https://github.com/Nandith-Narayan/Game-Boy-Advance-Emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Nandith-Narayan/Game-Boy-Advance-Emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNandith-Narayan%2FGame-Boy-Advance-Emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNandith-Narayan%2FGame-Boy-Advance-Emulator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6c1266aff6ec5dbfec7c9ff2ae2a4b4286a1425c [INFO] linting Nandith-Narayan/Game-Boy-Advance-Emulator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNandith-Narayan%2FGame-Boy-Advance-Emulator" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Nandith-Narayan/Game-Boy-Advance-Emulator [INFO] finished tweaking git repo https://github.com/Nandith-Narayan/Game-Boy-Advance-Emulator [INFO] tweaked toml for git repo https://github.com/Nandith-Narayan/Game-Boy-Advance-Emulator written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Nandith-Narayan/Game-Boy-Advance-Emulator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Nandith-Narayan/Game-Boy-Advance-Emulator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4cc580fbedc18f5c90a961408871a10274521b2cc652c175b1973218689836d4 [INFO] running `Command { std: "docker" "start" "-a" "4cc580fbedc18f5c90a961408871a10274521b2cc652c175b1973218689836d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4cc580fbedc18f5c90a961408871a10274521b2cc652c175b1973218689836d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4cc580fbedc18f5c90a961408871a10274521b2cc652c175b1973218689836d4", kill_on_drop: false }` [INFO] [stdout] 4cc580fbedc18f5c90a961408871a10274521b2cc652c175b1973218689836d4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bed32663f482ecbe271e621668256419cfbcb76e8ef4d1f3d2b3e587c994a2c1 [INFO] running `Command { std: "docker" "start" "-a" "bed32663f482ecbe271e621668256419cfbcb76e8ef4d1f3d2b3e587c994a2c1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling zmij v1.0.18 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking gba_emu v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:6:34 [INFO] [stdout] | [INFO] [stdout] 6 | if (inst & 0x0F_F0_00_F0) == 0b0000_0001__0010_0000__0000_0000__0001_0000 {return BranchAndExchange;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0001_0010_0000_0000_0000_0001_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] = note: `#[warn(clippy::unusual_byte_groupings)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:7:34 [INFO] [stdout] | [INFO] [stdout] 7 | if (inst & 0x0F_00_00_00) == 0b0000_1010__0000_0000__0000_0000__0000_0000 {return Branch;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_1010_0000_0000_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:8:34 [INFO] [stdout] | [INFO] [stdout] 8 | if (inst & 0x0F_00_00_00) == 0b0000_1011__0000_0000__0000_0000__0000_0000 {return BranchWithLink;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_1011_0000_0000_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:10:34 [INFO] [stdout] | [INFO] [stdout] 10 | if (inst & 0x0F_B0_00_F0) == 0b0000_0001__0000_0000__0000_0000__1001_0000 {return SingleDataSwap;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0001_0000_0000_0000_0000_1001_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:11:34 [INFO] [stdout] | [INFO] [stdout] 11 | if (inst & 0x0E_00_00_00) == 0b0000_0110__0000_0000__0000_0000__0000_0000 {return SingleDataTransferReg;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0110_0000_0000_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:12:34 [INFO] [stdout] | [INFO] [stdout] 12 | if (inst & 0x0E_00_00_00) == 0b0000_0100__0000_0000__0000_0000__0000_0000 {return SingleDataTransferImmediate;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0100_0000_0000_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:14:34 [INFO] [stdout] | [INFO] [stdout] 14 | if (inst & 0x0F_C0_00_F0) == 0b0000_0000__0000_0000__0000_0000__1001_0000 {return Multiply;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_0000_0000_0000_1001_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:15:34 [INFO] [stdout] | [INFO] [stdout] 15 | if (inst & 0x0F_80_00_F0) == 0b0000_0000__1000_0000__0000_0000__1001_0000 {return MultiplyLong;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_1000_0000_0000_0000_1001_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:17:34 [INFO] [stdout] | [INFO] [stdout] 17 | if (inst & 0x0D_B0_F0_00) == 0b0000_0001__0010_0000__1111_0000__0000_0000 {return TransferToPSR;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0001_0010_0000_1111_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:18:34 [INFO] [stdout] | [INFO] [stdout] 18 | if (inst & 0x0F_BF_0F_FF) == 0b0000_0001__0000_1111__0000_0000__0000_0000 {return TransferFromPSR;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0001_0000_1111_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:20:34 [INFO] [stdout] | [INFO] [stdout] 20 | if (inst & 0x0E_00_00_00) == 0b0000_0000__0000_0000__0000_0000__0000_0000 {return DataProcessingReg;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_0000_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:21:34 [INFO] [stdout] | [INFO] [stdout] 21 | if (inst & 0x0C_00_00_00) == 0b0000_0000__0000_0000__0000_0000__0000_0000 {return DataProcessingImmediate;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_0000_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:57:7 [INFO] [stdout] | [INFO] [stdout] 57 | if(path.to_string().eq("skip")){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 57 - if(path.to_string().eq("skip")){ [INFO] [stdout] 57 + if path.to_string().eq("skip") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::thread; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | if (cpu.r[12] ==224){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - if (cpu.r[12] ==224){ [INFO] [stdout] 25 + if cpu.r[12] ==224 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:6:34 [INFO] [stdout] | [INFO] [stdout] 6 | if (inst & 0x0F_F0_00_F0) == 0b0000_0001__0010_0000__0000_0000__0001_0000 {return BranchAndExchange;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0001_0010_0000_0000_0000_0001_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] = note: `#[warn(clippy::unusual_byte_groupings)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:7:34 [INFO] [stdout] | [INFO] [stdout] 7 | if (inst & 0x0F_00_00_00) == 0b0000_1010__0000_0000__0000_0000__0000_0000 {return Branch;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_1010_0000_0000_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:8:34 [INFO] [stdout] | [INFO] [stdout] 8 | if (inst & 0x0F_00_00_00) == 0b0000_1011__0000_0000__0000_0000__0000_0000 {return BranchWithLink;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_1011_0000_0000_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:10:34 [INFO] [stdout] | [INFO] [stdout] 10 | if (inst & 0x0F_B0_00_F0) == 0b0000_0001__0000_0000__0000_0000__1001_0000 {return SingleDataSwap;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0001_0000_0000_0000_0000_1001_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:11:34 [INFO] [stdout] | [INFO] [stdout] 11 | if (inst & 0x0E_00_00_00) == 0b0000_0110__0000_0000__0000_0000__0000_0000 {return SingleDataTransferReg;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0110_0000_0000_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:12:34 [INFO] [stdout] | [INFO] [stdout] 12 | if (inst & 0x0E_00_00_00) == 0b0000_0100__0000_0000__0000_0000__0000_0000 {return SingleDataTransferImmediate;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0100_0000_0000_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:14:34 [INFO] [stdout] | [INFO] [stdout] 14 | if (inst & 0x0F_C0_00_F0) == 0b0000_0000__0000_0000__0000_0000__1001_0000 {return Multiply;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_0000_0000_0000_1001_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:15:34 [INFO] [stdout] | [INFO] [stdout] 15 | if (inst & 0x0F_80_00_F0) == 0b0000_0000__1000_0000__0000_0000__1001_0000 {return MultiplyLong;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_1000_0000_0000_0000_1001_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:17:34 [INFO] [stdout] | [INFO] [stdout] 17 | if (inst & 0x0D_B0_F0_00) == 0b0000_0001__0010_0000__1111_0000__0000_0000 {return TransferToPSR;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0001_0010_0000_1111_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:18:34 [INFO] [stdout] | [INFO] [stdout] 18 | if (inst & 0x0F_BF_0F_FF) == 0b0000_0001__0000_1111__0000_0000__0000_0000 {return TransferFromPSR;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0001_0000_1111_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:20:34 [INFO] [stdout] | [INFO] [stdout] 20 | if (inst & 0x0E_00_00_00) == 0b0000_0000__0000_0000__0000_0000__0000_0000 {return DataProcessingReg;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_0000_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/cpu/arm_decode.rs:21:34 [INFO] [stdout] | [INFO] [stdout] 21 | if (inst & 0x0C_00_00_00) == 0b0000_0000__0000_0000__0000_0000__0000_0000 {return DataProcessingImmediate;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0000_0000_0000_0000_0000_0000_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/cpu/mod.rs:57:7 [INFO] [stdout] | [INFO] [stdout] 57 | if(path.to_string().eq("skip")){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 57 - if(path.to_string().eq("skip")){ [INFO] [stdout] 57 + if path.to_string().eq("skip") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::Value::String` [INFO] [stdout] --> src/run_tests.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | use serde_json::Value::String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::thread; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/main.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 25 | if (cpu.r[12] ==224){ [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - if (cpu.r[12] ==224){ [INFO] [stdout] 25 + if cpu.r[12] ==224 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/arm_instructions/branches.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | let mut rn: usize = (inst & 0xF) as usize; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `r_irq` is never read [INFO] [stdout] --> src/cpu/mod.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Cpu{ [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 28 | pub r_irq: [u32; 16], [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `THUMB` is never constructed [INFO] [stdout] --> src/cpu/enums.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 1 | pub enum InstructionSet { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 2 | ARM, [INFO] [stdout] 3 | THUMB, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `PSRTransferFromReg` and `PSRTransferFlagsOnly` are never constructed [INFO] [stdout] --> src/cpu/enums.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub enum ARMInstruction { [INFO] [stdout] | -------------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 27 | PSRTransferFromReg, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 28 | PSRTransferFlagsOnly, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ARMInstruction` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `write_16` is never used [INFO] [stdout] --> src/memory/writes.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 3 | impl Memory{ [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn write_16(&mut self, address:u32, value:u16) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `set_u16` is never used [INFO] [stdout] --> src/memory/writes.rs:96:4 [INFO] [stdout] | [INFO] [stdout] 96 | fn set_u16(arr: &mut [u8], index:usize, value:u16) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read_16` is never used [INFO] [stdout] --> src/memory/reads.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 3 | impl Memory{ [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn read_16(&mut self, address:u32) -> u16{ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_u16` is never used [INFO] [stdout] --> src/memory/reads.rs:93:4 [INFO] [stdout] | [INFO] [stdout] 93 | fn get_u16(arr:&[u8], index:usize) -> u16{ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:83:30 [INFO] [stdout] | [INFO] [stdout] 83 | self.c = !((result & 0x100000000) != 0); // Carry Flag on subtraction is reversed [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((result & 0x100000000) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 228 | / if rd == 15{ [INFO] [stdout] 229 | | if set_flags{ [INFO] [stdout] 230 | | match self.mode{ [INFO] [stdout] 231 | | FIQ =>{ [INFO] [stdout] ... | [INFO] [stdout] 240 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 228 ~ if rd == 15 [INFO] [stdout] 229 ~ && set_flags{ [INFO] [stdout] 230 | match self.mode{ [INFO] [stdout] ... [INFO] [stdout] 238 | self.flush_pipeline(); [INFO] [stdout] 239 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:254:17 [INFO] [stdout] | [INFO] [stdout] 254 | return shifted_val as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 ~ shifted_val as u32 [INFO] [stdout] 255 | } [INFO] [stdout] ... [INFO] [stdout] 310 | } [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:272:17 [INFO] [stdout] | [INFO] [stdout] 272 | return (shifted_val>>1) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 272 ~ (shifted_val>>1) as u32 [INFO] [stdout] 273 | } [INFO] [stdout] ... [INFO] [stdout] 310 | } [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:289:17 [INFO] [stdout] | [INFO] [stdout] 289 | return (shifted_val >> 1) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 ~ (shifted_val >> 1) as u32 [INFO] [stdout] 290 | } [INFO] [stdout] ... [INFO] [stdout] 310 | } [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:301:21 [INFO] [stdout] | [INFO] [stdout] 301 | return (value >> 1) | carry_in; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 ~ (value >> 1) | carry_in [INFO] [stdout] 302 | } else { [INFO] [stdout] ... [INFO] [stdout] 310 | } [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:305:21 [INFO] [stdout] | [INFO] [stdout] 305 | return value.rotate_right(shift_amount); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 305 ~ value.rotate_right(shift_amount) [INFO] [stdout] 306 | } [INFO] [stdout] ... [INFO] [stdout] 310 | } [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:309:17 [INFO] [stdout] | [INFO] [stdout] 309 | return value; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 309 ~ value [INFO] [stdout] 310 | } [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:341:17 [INFO] [stdout] | [INFO] [stdout] 341 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 341 - return 0; [INFO] [stdout] 341 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:346:17 [INFO] [stdout] | [INFO] [stdout] 346 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 346 - return 0; [INFO] [stdout] 346 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:351:17 [INFO] [stdout] | [INFO] [stdout] 351 | return if (value & (1<<31)) != 0 {0xFFFFFFFF} else {0}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 351 - return if (value & (1<<31)) != 0 {0xFFFFFFFF} else {0}; [INFO] [stdout] 351 + if (value & (1<<31)) != 0 {0xFFFFFFFF} else {0} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:356:17 [INFO] [stdout] | [INFO] [stdout] 356 | return value; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 356 - return value; [INFO] [stdout] 356 + value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:359:19 [INFO] [stdout] | [INFO] [stdout] 359 | _ => {return value;} [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 359 - _ => {return value;} [INFO] [stdout] 359 + _ => {value} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/cpu/arm_instructions/psr_transfers.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let operand; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `operand` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 10 ~ [INFO] [stdout] 11 ~ let operand = if operand_is_immediate { [INFO] [stdout] 12 | let rotate = (inst & 0xF00) >> 8; [INFO] [stdout] 13 | let immediate = inst & 0xFF; [INFO] [stdout] 14 ~ immediate.rotate_right(rotate * 2) [INFO] [stdout] 15 | }else{ [INFO] [stdout] 16 | let rm = inst & 0xF; [INFO] [stdout] 17 ~ self.r[rm as usize] [INFO] [stdout] 18 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/cpu/arm_instructions/multiply.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `result` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 14 ~ [INFO] [stdout] 15 ~ let result = if accumulate{ [INFO] [stdout] 16 ~ (((self.r[rm as usize] as u64 * self.r[rs as usize] as u64) & 0xFFFFFFFF) as u32).wrapping_add(self.r[rn as usize]) [INFO] [stdout] 17 | }else{ [INFO] [stdout] 18 ~ ((self.r[rm as usize] as u64 * self.r[rs as usize] as u64) & 0xFFFFFFFF) as u32 [INFO] [stdout] 19 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/arm_instructions/single_data_transfers.rs:87:21 [INFO] [stdout] | [INFO] [stdout] 87 | offset = offset >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/arm_instructions/single_data_transfers.rs:88:21 [INFO] [stdout] | [INFO] [stdout] 88 | offset = offset | carry_in; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset |= carry_in` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | / return match n{ [INFO] [stdout] 17 | | 0b10000 => USER, [INFO] [stdout] 18 | | 0b10001 => FIQ, [INFO] [stdout] 19 | | 0b10010 => IRQ, [INFO] [stdout] ... | [INFO] [stdout] 24 | | _ => UNDEFINED, [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ match n{ [INFO] [stdout] 17 + 0b10000 => USER, [INFO] [stdout] 18 + 0b10001 => FIQ, [INFO] [stdout] 19 + 0b10010 => IRQ, [INFO] [stdout] 20 + 0b10011 => SUPERVISOR, [INFO] [stdout] 21 + 0b10111 => ABORT, [INFO] [stdout] 22 + 0b11011 => UNDEFINED, [INFO] [stdout] 23 + 0b11111 => SYSTEM, [INFO] [stdout] 24 + _ => UNDEFINED, [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cpu/arm_instructions/branches.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | let mut rn: usize = (inst & 0xF) as usize; [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | return cpsr; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return cpsr; [INFO] [stdout] 142 + cpsr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ARM` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | ARM, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Arm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `THUMB` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | THUMB, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Thumb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `USER` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | USER = 0b10000, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `User` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FIQ` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | FIQ = 0b10001, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Fiq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IRQ` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | IRQ = 0b10010, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Irq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUPERVISOR` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | SUPERVISOR = 0b10011, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Supervisor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ABORT` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | ABORT = 0b10111, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Abort` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UNDEFINED` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | UNDEFINED = 0b11011, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Undefined` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SYSTEM` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | SYSTEM = 0b11111, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `System` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UNREACHABLE` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | UNREACHABLE, [INFO] [stdout] | ^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Unreachable` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | NOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EMPTY` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | EMPTY, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Empty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_decode.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return UNREACHABLE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return UNREACHABLE; [INFO] [stdout] 23 + UNREACHABLE [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/mod.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | return cpu; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return cpu; [INFO] [stdout] 66 + cpu [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/reads.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | return u32::from_le_bytes(bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return u32::from_le_bytes(bytes); [INFO] [stdout] 90 + u32::from_le_bytes(bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/reads.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return u16::from_le_bytes(bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return u16::from_le_bytes(bytes); [INFO] [stdout] 96 + u16::from_le_bytes(bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/reads.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | return arr[index]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return arr[index]; [INFO] [stdout] 100 + arr[index] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / return Memory{ [INFO] [stdout] 23 | | // General Memory [INFO] [stdout] 24 | | bios: [0; 1<<14], [INFO] [stdout] 25 | | wram_on_board: vec![0; 1<<18], [INFO] [stdout] ... | [INFO] [stdout] 35 | | sram: [0; 1<<16], [INFO] [stdout] 36 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 ~ Memory{ [INFO] [stdout] 23 + // General Memory [INFO] [stdout] 24 + bios: [0; 1<<14], [INFO] [stdout] 25 + wram_on_board: vec![0; 1<<18], [INFO] [stdout] 26 + wram_on_chip: [0; 1<<15], [INFO] [stdout] 27 + [INFO] [stdout] 28 + // Display Memory [INFO] [stdout] 29 + palette_ram: [0; 1<<10], [INFO] [stdout] 30 + vram: [0; 3*(1<<15)], [INFO] [stdout] 31 + oam: [0; 1<<10], [INFO] [stdout] 32 + [INFO] [stdout] 33 + // Game Pak Memory [INFO] [stdout] 34 + rom: vec![0; 3*(1<<25)], [INFO] [stdout] 35 + sram: [0; 1<<16], [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `r_irq` is never read [INFO] [stdout] --> src/cpu/mod.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Cpu{ [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 28 | pub r_irq: [u32; 16], [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `THUMB` is never constructed [INFO] [stdout] --> src/cpu/enums.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 1 | pub enum InstructionSet { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 2 | ARM, [INFO] [stdout] 3 | THUMB, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `PSRTransferFromReg` and `PSRTransferFlagsOnly` are never constructed [INFO] [stdout] --> src/cpu/enums.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub enum ARMInstruction { [INFO] [stdout] | -------------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 27 | PSRTransferFromReg, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 28 | PSRTransferFlagsOnly, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ARMInstruction` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `write_16` is never used [INFO] [stdout] --> src/memory/writes.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 3 | impl Memory{ [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn write_16(&mut self, address:u32, value:u16) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `set_u16` is never used [INFO] [stdout] --> src/memory/writes.rs:96:4 [INFO] [stdout] | [INFO] [stdout] 96 | fn set_u16(arr: &mut [u8], index:usize, value:u16) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `read_16` is never used [INFO] [stdout] --> src/memory/reads.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 3 | impl Memory{ [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 30 | pub fn read_16(&mut self, address:u32) -> u16{ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_u16` is never used [INFO] [stdout] --> src/memory/reads.rs:93:4 [INFO] [stdout] | [INFO] [stdout] 93 | fn get_u16(arr:&[u8], index:usize) -> u16{ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TransactionData` is never constructed [INFO] [stdout] --> src/run_tests.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | struct TransactionData { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `State` is never constructed [INFO] [stdout] --> src/run_tests.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | struct State { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TestData` is never constructed [INFO] [stdout] --> src/run_tests.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | struct TestData { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `test_json` is never used [INFO] [stdout] --> src/run_tests.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | fn test_json() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `run_test` is never used [INFO] [stdout] --> src/run_tests.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | fn run_test(n:usize, data: &TestData) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `format_regs` is never used [INFO] [stdout] --> src/run_tests.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 133 | fn format_regs(r:[u32; 16]) -> std::string::String { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:83:30 [INFO] [stdout] | [INFO] [stdout] 83 | self.c = !((result & 0x100000000) != 0); // Carry Flag on subtraction is reversed [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((result & 0x100000000) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 228 | / if rd == 15{ [INFO] [stdout] 229 | | if set_flags{ [INFO] [stdout] 230 | | match self.mode{ [INFO] [stdout] 231 | | FIQ =>{ [INFO] [stdout] ... | [INFO] [stdout] 240 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 228 ~ if rd == 15 [INFO] [stdout] 229 ~ && set_flags{ [INFO] [stdout] 230 | match self.mode{ [INFO] [stdout] ... [INFO] [stdout] 238 | self.flush_pipeline(); [INFO] [stdout] 239 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:254:17 [INFO] [stdout] | [INFO] [stdout] 254 | return shifted_val as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 ~ shifted_val as u32 [INFO] [stdout] 255 | } [INFO] [stdout] ... [INFO] [stdout] 310 | } [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:272:17 [INFO] [stdout] | [INFO] [stdout] 272 | return (shifted_val>>1) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 272 ~ (shifted_val>>1) as u32 [INFO] [stdout] 273 | } [INFO] [stdout] ... [INFO] [stdout] 310 | } [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:289:17 [INFO] [stdout] | [INFO] [stdout] 289 | return (shifted_val >> 1) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 ~ (shifted_val >> 1) as u32 [INFO] [stdout] 290 | } [INFO] [stdout] ... [INFO] [stdout] 310 | } [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:301:21 [INFO] [stdout] | [INFO] [stdout] 301 | return (value >> 1) | carry_in; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 301 ~ (value >> 1) | carry_in [INFO] [stdout] 302 | } else { [INFO] [stdout] ... [INFO] [stdout] 310 | } [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:305:21 [INFO] [stdout] | [INFO] [stdout] 305 | return value.rotate_right(shift_amount); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 305 ~ value.rotate_right(shift_amount) [INFO] [stdout] 306 | } [INFO] [stdout] ... [INFO] [stdout] 310 | } [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:309:17 [INFO] [stdout] | [INFO] [stdout] 309 | return value; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 309 ~ value [INFO] [stdout] 310 | } [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:341:17 [INFO] [stdout] | [INFO] [stdout] 341 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 341 - return 0; [INFO] [stdout] 341 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:346:17 [INFO] [stdout] | [INFO] [stdout] 346 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 346 - return 0; [INFO] [stdout] 346 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:351:17 [INFO] [stdout] | [INFO] [stdout] 351 | return if (value & (1<<31)) != 0 {0xFFFFFFFF} else {0}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 351 - return if (value & (1<<31)) != 0 {0xFFFFFFFF} else {0}; [INFO] [stdout] 351 + if (value & (1<<31)) != 0 {0xFFFFFFFF} else {0} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:356:17 [INFO] [stdout] | [INFO] [stdout] 356 | return value; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 356 - return value; [INFO] [stdout] 356 + value [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions/alu_operations.rs:359:19 [INFO] [stdout] | [INFO] [stdout] 359 | _ => {return value;} [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 359 - _ => {return value;} [INFO] [stdout] 359 + _ => {value} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/cpu/arm_instructions/psr_transfers.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | let operand; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `operand` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 10 ~ [INFO] [stdout] 11 ~ let operand = if operand_is_immediate { [INFO] [stdout] 12 | let rotate = (inst & 0xF00) >> 8; [INFO] [stdout] 13 | let immediate = inst & 0xFF; [INFO] [stdout] 14 ~ immediate.rotate_right(rotate * 2) [INFO] [stdout] 15 | }else{ [INFO] [stdout] 16 | let rm = inst & 0xF; [INFO] [stdout] 17 ~ self.r[rm as usize] [INFO] [stdout] 18 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/cpu/arm_instructions/multiply.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let result; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `result` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 14 ~ [INFO] [stdout] 15 ~ let result = if accumulate{ [INFO] [stdout] 16 ~ (((self.r[rm as usize] as u64 * self.r[rs as usize] as u64) & 0xFFFFFFFF) as u32).wrapping_add(self.r[rn as usize]) [INFO] [stdout] 17 | }else{ [INFO] [stdout] 18 ~ ((self.r[rm as usize] as u64 * self.r[rs as usize] as u64) & 0xFFFFFFFF) as u32 [INFO] [stdout] 19 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/arm_instructions/single_data_transfers.rs:87:21 [INFO] [stdout] | [INFO] [stdout] 87 | offset = offset >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu/arm_instructions/single_data_transfers.rs:88:21 [INFO] [stdout] | [INFO] [stdout] 88 | offset = offset | carry_in; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `offset |= carry_in` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_instructions.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | / return match n{ [INFO] [stdout] 17 | | 0b10000 => USER, [INFO] [stdout] 18 | | 0b10001 => FIQ, [INFO] [stdout] 19 | | 0b10010 => IRQ, [INFO] [stdout] ... | [INFO] [stdout] 24 | | _ => UNDEFINED, [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ match n{ [INFO] [stdout] 17 + 0b10000 => USER, [INFO] [stdout] 18 + 0b10001 => FIQ, [INFO] [stdout] 19 + 0b10010 => IRQ, [INFO] [stdout] 20 + 0b10011 => SUPERVISOR, [INFO] [stdout] 21 + 0b10111 => ABORT, [INFO] [stdout] 22 + 0b11011 => UNDEFINED, [INFO] [stdout] 23 + 0b11111 => SYSTEM, [INFO] [stdout] 24 + _ => UNDEFINED, [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | return cpsr; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return cpsr; [INFO] [stdout] 142 + cpsr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ARM` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | ARM, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Arm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `THUMB` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | THUMB, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Thumb` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `USER` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | USER = 0b10000, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `User` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FIQ` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | FIQ = 0b10001, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Fiq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IRQ` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | IRQ = 0b10010, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Irq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUPERVISOR` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | SUPERVISOR = 0b10011, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Supervisor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ABORT` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | ABORT = 0b10111, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Abort` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UNDEFINED` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | UNDEFINED = 0b11011, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Undefined` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SYSTEM` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | SYSTEM = 0b11111, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `System` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UNREACHABLE` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | UNREACHABLE, [INFO] [stdout] | ^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Unreachable` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | NOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EMPTY` contains a capitalized acronym [INFO] [stdout] --> src/cpu/enums.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | EMPTY, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Empty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/arm_decode.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return UNREACHABLE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return UNREACHABLE; [INFO] [stdout] 23 + UNREACHABLE [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu/mod.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | return cpu; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return cpu; [INFO] [stdout] 66 + cpu [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/reads.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | return u32::from_le_bytes(bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return u32::from_le_bytes(bytes); [INFO] [stdout] 90 + u32::from_le_bytes(bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/reads.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return u16::from_le_bytes(bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return u16::from_le_bytes(bytes); [INFO] [stdout] 96 + u16::from_le_bytes(bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/reads.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | return arr[index]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return arr[index]; [INFO] [stdout] 100 + arr[index] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / return Memory{ [INFO] [stdout] 23 | | // General Memory [INFO] [stdout] 24 | | bios: [0; 1<<14], [INFO] [stdout] 25 | | wram_on_board: vec![0; 1<<18], [INFO] [stdout] ... | [INFO] [stdout] 35 | | sram: [0; 1<<16], [INFO] [stdout] 36 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 ~ Memory{ [INFO] [stdout] 23 + // General Memory [INFO] [stdout] 24 + bios: [0; 1<<14], [INFO] [stdout] 25 + wram_on_board: vec![0; 1<<18], [INFO] [stdout] 26 + wram_on_chip: [0; 1<<15], [INFO] [stdout] 27 + [INFO] [stdout] 28 + // Display Memory [INFO] [stdout] 29 + palette_ram: [0; 1<<10], [INFO] [stdout] 30 + vram: [0; 3*(1<<15)], [INFO] [stdout] 31 + oam: [0; 1<<10], [INFO] [stdout] 32 + [INFO] [stdout] 33 + // Game Pak Memory [INFO] [stdout] 34 + rom: vec![0; 3*(1<<25)], [INFO] [stdout] 35 + sram: [0; 1<<16], [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/run_tests.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / mod run_tests { [INFO] [stdout] 3 | | use std::fs; [INFO] [stdout] 4 | | use serde::{Deserialize, Serialize}; [INFO] [stdout] 5 | | use serde_json::Value::String; [INFO] [stdout] ... | [INFO] [stdout] 141 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `d` [INFO] [stdout] --> src/run_tests.rs:71:18 [INFO] [stdout] | [INFO] [stdout] 71 | for i in 0..N{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 71 - for i in 0..N{ [INFO] [stdout] 71 + for (i, ) in d.iter().enumerate().take(N){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/run_tests.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return true; [INFO] [stdout] 130 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u32; 16]` which implements the `Copy` trait [INFO] [stdout] --> src/run_tests.rs:83:17 [INFO] [stdout] | [INFO] [stdout] 83 | cpu.r = data.initial.r.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `data.initial.r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/run_tests.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | return s; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 - return s; [INFO] [stdout] 138 + s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `r` [INFO] [stdout] --> src/run_tests.rs:135:18 [INFO] [stdout] | [INFO] [stdout] 135 | for i in 0..16{ [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 135 - for i in 0..16{ [INFO] [stdout] 135 + for (i, ) in r.iter().enumerate(){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/run_tests.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | let N = 50; [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.25s [INFO] running `Command { std: "docker" "inspect" "bed32663f482ecbe271e621668256419cfbcb76e8ef4d1f3d2b3e587c994a2c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bed32663f482ecbe271e621668256419cfbcb76e8ef4d1f3d2b3e587c994a2c1", kill_on_drop: false }` [INFO] [stdout] bed32663f482ecbe271e621668256419cfbcb76e8ef4d1f3d2b3e587c994a2c1