[INFO] cloning repository https://github.com/NChitty/chersed [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/NChitty/chersed" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNChitty%2Fchersed", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNChitty%2Fchersed'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 79d44b7d14db97dcdd3810b6a23cef158092ddc1 [INFO] linting NChitty/chersed against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNChitty%2Fchersed" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/NChitty/chersed [INFO] finished tweaking git repo https://github.com/NChitty/chersed [INFO] tweaked toml for git repo https://github.com/NChitty/chersed written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/NChitty/chersed on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/NChitty/chersed already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 115302db21e407d185befa0422125c391d600cf9a8177041dc35c804224e90ae [INFO] running `Command { std: "docker" "start" "-a" "115302db21e407d185befa0422125c391d600cf9a8177041dc35c804224e90ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "115302db21e407d185befa0422125c391d600cf9a8177041dc35c804224e90ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "115302db21e407d185befa0422125c391d600cf9a8177041dc35c804224e90ae", kill_on_drop: false }` [INFO] [stdout] 115302db21e407d185befa0422125c391d600cf9a8177041dc35c804224e90ae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 52cc84fd42bd9f235c8af1de33b9abbcd8c3121b158740596a2c755867ca6c95 [INFO] running `Command { std: "docker" "start" "-a" "52cc84fd42bd9f235c8af1de33b9abbcd8c3121b158740596a2c755867ca6c95", kill_on_drop: false }` [INFO] [stderr] Checking chersed v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `get_bitboard` is never used [INFO] [stdout] --> src/lib.rs:314:12 [INFO] [stdout] | [INFO] [stdout] 313 | impl GameState { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 314 | pub fn get_bitboard(&self, piece: Piece) -> &Bitboard { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/lib.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | str.chars().nth(0)?.to_digit(16)? as u8 - 10 * 8 + str.chars().nth(1)?.to_digit(10)? as u8 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `str.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/lib.rs:66:28 [INFO] [stdout] | [INFO] [stdout] 66 | Pawn(color) => 0 + color.index(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider reducing it to: `color.index()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:240:12 [INFO] [stdout] | [INFO] [stdout] 240 | if buffer == "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `splits.get(0)` [INFO] [stdout] --> src/lib.rs:265:27 [INFO] [stdout] | [INFO] [stdout] 265 | let board: &str = splits.get(0).ok_or("No board state")?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `splits.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `rank` is used to index `board` [INFO] [stdout] --> src/lib.rs:332:21 [INFO] [stdout] | [INFO] [stdout] 332 | for rank in 0..8 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 332 - for rank in 0..8 { [INFO] [stdout] 332 + for (rank, ) in board.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `file` is used to index `board` [INFO] [stdout] --> src/lib.rs:333:25 [INFO] [stdout] | [INFO] [stdout] 333 | for file in 0..8 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 333 - for file in 0..8 { [INFO] [stdout] 333 + for (file, ) in board.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:359:17 [INFO] [stdout] | [INFO] [stdout] 359 | assert!(!actual.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `actual.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Bitboard` is never used [INFO] [stdout] --> src/lib.rs:3:6 [INFO] [stdout] | [INFO] [stdout] 3 | type Bitboard = u64; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `FILES` is never used [INFO] [stdout] --> src/lib.rs:5:7 [INFO] [stdout] | [INFO] [stdout] 5 | const FILES: [u64; 8] = [ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `RANKS` is never used [INFO] [stdout] --> src/lib.rs:16:7 [INFO] [stdout] | [INFO] [stdout] 16 | const RANKS: [u64; 8] = [ [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `RANK_MATRIX` is never used [INFO] [stdout] --> src/lib.rs:27:7 [INFO] [stdout] | [INFO] [stdout] 27 | const RANK_MATRIX: [&str; 8] = ["a", "b", "c", "d", "e", "f", "g", "h"]; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `square_number_from_str` is never used [INFO] [stdout] --> src/lib.rs:29:4 [INFO] [stdout] | [INFO] [stdout] 29 | fn square_number_from_str(str: &str) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Color` is never used [INFO] [stdout] --> src/lib.rs:37:6 [INFO] [stdout] | [INFO] [stdout] 37 | enum Color { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `index` is never used [INFO] [stdout] --> src/lib.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 42 | impl Color { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] 43 | fn index(&self) -> usize { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Piece` is never used [INFO] [stdout] --> src/lib.rs:54:6 [INFO] [stdout] | [INFO] [stdout] 54 | enum Piece { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `index`, `fen`, `from_index`, and `from_char` are never used [INFO] [stdout] --> src/lib.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 63 | impl Piece { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 64 | fn index(&self) -> usize { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 75 | pub fn fen(&self) -> String { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 122 | fn from_index(index: usize) -> Option { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 140 | fn from_char(char: char) -> Option { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GameState` is never constructed [INFO] [stdout] --> src/lib.rs:162:8 [INFO] [stdout] | [INFO] [stdout] 162 | struct GameState { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_bitboard`, `get_piece_at`, and `get_board_state` are never used [INFO] [stdout] --> src/lib.rs:314:12 [INFO] [stdout] | [INFO] [stdout] 313 | impl GameState { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] 314 | pub fn get_bitboard(&self, piece: Piece) -> &Bitboard { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 318 | pub fn get_piece_at(&self, rank: usize, file: usize) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 330 | pub fn get_board_state(&self) -> [[Option; 8]; 8] { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/lib.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | str.chars().nth(0)?.to_digit(16)? as u8 - 10 * 8 + str.chars().nth(1)?.to_digit(10)? as u8 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `str.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/lib.rs:66:28 [INFO] [stdout] | [INFO] [stdout] 66 | Pawn(color) => 0 + color.index(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider reducing it to: `color.index()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:240:12 [INFO] [stdout] | [INFO] [stdout] 240 | if buffer == "" { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `splits.get(0)` [INFO] [stdout] --> src/lib.rs:265:27 [INFO] [stdout] | [INFO] [stdout] 265 | let board: &str = splits.get(0).ok_or("No board state")?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `splits.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `rank` is used to index `board` [INFO] [stdout] --> src/lib.rs:332:21 [INFO] [stdout] | [INFO] [stdout] 332 | for rank in 0..8 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 332 - for rank in 0..8 { [INFO] [stdout] 332 + for (rank, ) in board.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `file` is used to index `board` [INFO] [stdout] --> src/lib.rs:333:25 [INFO] [stdout] | [INFO] [stdout] 333 | for file in 0..8 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 333 - for file in 0..8 { [INFO] [stdout] 333 + for (file, ) in board.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.36s [INFO] running `Command { std: "docker" "inspect" "52cc84fd42bd9f235c8af1de33b9abbcd8c3121b158740596a2c755867ca6c95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52cc84fd42bd9f235c8af1de33b9abbcd8c3121b158740596a2c755867ca6c95", kill_on_drop: false }` [INFO] [stdout] 52cc84fd42bd9f235c8af1de33b9abbcd8c3121b158740596a2c755867ca6c95