[INFO] cloning repository https://github.com/MysticDoll/wasmdump [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MysticDoll/wasmdump" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMysticDoll%2Fwasmdump", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMysticDoll%2Fwasmdump'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 442e4f983bd24f7c4ab0887ef68ac9baef0b56b8 [INFO] linting MysticDoll/wasmdump against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMysticDoll%2Fwasmdump" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MysticDoll/wasmdump [INFO] finished tweaking git repo https://github.com/MysticDoll/wasmdump [INFO] tweaked toml for git repo https://github.com/MysticDoll/wasmdump written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MysticDoll/wasmdump on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MysticDoll/wasmdump already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7ad2d7d4a0d3ba1f89544d51e2f67186b84019ef5286d74fd16ea1612c33053b [INFO] running `Command { std: "docker" "start" "-a" "7ad2d7d4a0d3ba1f89544d51e2f67186b84019ef5286d74fd16ea1612c33053b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7ad2d7d4a0d3ba1f89544d51e2f67186b84019ef5286d74fd16ea1612c33053b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ad2d7d4a0d3ba1f89544d51e2f67186b84019ef5286d74fd16ea1612c33053b", kill_on_drop: false }` [INFO] [stdout] 7ad2d7d4a0d3ba1f89544d51e2f67186b84019ef5286d74fd16ea1612c33053b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f42e3b2486f8cbbef52d7216852bf0e60d7b27dfabb666e19e55bf3694db84bd [INFO] running `Command { std: "docker" "start" "-a" "f42e3b2486f8cbbef52d7216852bf0e60d7b27dfabb666e19e55bf3694db84bd", kill_on_drop: false }` [INFO] [stderr] Checking leb128 v0.2.4 [INFO] [stderr] Checking wasmdump v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/converter/func_type.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 ~ Ok(()) [INFO] [stdout] 73 | } else { [INFO] [stdout] 74 | panic!("Invalid behavior: Current WebAssembly cannot use multi-value return") [INFO] [stdout] 75 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/converter/limits.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 83 | if !result.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/export_desc.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | let src = vec![0x00u8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x00u8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/export_desc.rs:42:19 [INFO] [stdout] | [INFO] [stdout] 42 | let src = vec![0x01u8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x01u8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/export_desc.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | let src = vec![0x02u8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x02u8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/export_desc.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 64 | let src = vec![0x03u8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x03u8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/export_desc.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 75 | let src = vec![0x04u8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x04u8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/global.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 22 | let src = vec![0x7eu8, 0x01u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x7eu8, 0x01u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/global.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | let src = vec![0x7fu8, 0x01u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x7fu8, 0x01u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/global.rs:40:19 [INFO] [stdout] | [INFO] [stdout] 40 | let src = vec![0x7cu8, 0x01u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x7cu8, 0x01u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/global.rs:49:19 [INFO] [stdout] | [INFO] [stdout] 49 | let src = vec![0x7du8, 0x01u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x7du8, 0x01u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/global.rs:58:19 [INFO] [stdout] | [INFO] [stdout] 58 | let src = vec![0x7eu8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x7eu8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/global.rs:67:19 [INFO] [stdout] | [INFO] [stdout] 67 | let src = vec![0x7fu8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x7fu8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/global.rs:76:19 [INFO] [stdout] | [INFO] [stdout] 76 | let src = vec![0x7cu8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x7cu8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/global.rs:85:19 [INFO] [stdout] | [INFO] [stdout] 85 | let src = vec![0x7du8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x7du8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/import_desc.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | let src = vec![0x00u8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x00u8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/import_desc.rs:42:19 [INFO] [stdout] | [INFO] [stdout] 42 | let src = vec![0x01u8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x01u8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/import_desc.rs:53:19 [INFO] [stdout] | [INFO] [stdout] 53 | let src = vec![0x02u8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x02u8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/import_desc.rs:64:19 [INFO] [stdout] | [INFO] [stdout] 64 | let src = vec![0x03u8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x03u8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/import_desc.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 75 | let src = vec![0x04u8, 0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x04u8, 0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/string.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 22 | let src = vec![0x05u8, 0x6fu8, 0x74u8, 0x61u8, 0x6bu8, 0x75u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x05u8, 0x6fu8, 0x74u8, 0x61u8, 0x6bu8, 0x75u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/table.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | let src = vec![0x70, 0x00, 0x01]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x70, 0x00, 0x01]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/table.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | let src = vec![0x70, 0x01, 0x01, 0x02]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x70, 0x01, 0x01, 0x02]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/vectors.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | let src = vec![0x04u8, 0x7fu8, 0x7eu8, 0x7du8, 0x7cu8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x04u8, 0x7fu8, 0x7eu8, 0x7du8, 0x7cu8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/vectors.rs:44:19 [INFO] [stdout] | [INFO] [stdout] 44 | let src = vec![0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use an array directly: `[0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converter/vectors.rs:75:19 [INFO] [stdout] | [INFO] [stdout] 75 | let src = vec![0x00u8]; [INFO] [stdout] | ^^^^^^^^^^^^ help: you can use an array directly: `[0x00u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `Command { std: "docker" "inspect" "f42e3b2486f8cbbef52d7216852bf0e60d7b27dfabb666e19e55bf3694db84bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f42e3b2486f8cbbef52d7216852bf0e60d7b27dfabb666e19e55bf3694db84bd", kill_on_drop: false }` [INFO] [stdout] f42e3b2486f8cbbef52d7216852bf0e60d7b27dfabb666e19e55bf3694db84bd