[INFO] cloning repository https://github.com/MrSiir/rust-st-webserver [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MrSiir/rust-st-webserver" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrSiir%2Frust-st-webserver", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrSiir%2Frust-st-webserver'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 77048f06dd4b44f16568b3990f02dca471de6e45 [INFO] linting MrSiir/rust-st-webserver against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrSiir%2Frust-st-webserver" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MrSiir/rust-st-webserver [INFO] finished tweaking git repo https://github.com/MrSiir/rust-st-webserver [INFO] tweaked toml for git repo https://github.com/MrSiir/rust-st-webserver written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MrSiir/rust-st-webserver on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MrSiir/rust-st-webserver already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed2cdc0a570aeb46ed4fce8f34168b7ca9a82b399dc59843dc01c01f31891acf [INFO] running `Command { std: "docker" "start" "-a" "ed2cdc0a570aeb46ed4fce8f34168b7ca9a82b399dc59843dc01c01f31891acf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed2cdc0a570aeb46ed4fce8f34168b7ca9a82b399dc59843dc01c01f31891acf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed2cdc0a570aeb46ed4fce8f34168b7ca9a82b399dc59843dc01c01f31891acf", kill_on_drop: false }` [INFO] [stdout] ed2cdc0a570aeb46ed4fce8f34168b7ca9a82b399dc59843dc01c01f31891acf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5a8eb5fd587594f72edad1f169eac6cca28f7a779c190a7345fccfeed03f693 [INFO] running `Command { std: "docker" "start" "-a" "c5a8eb5fd587594f72edad1f169eac6cca28f7a779c190a7345fccfeed03f693", kill_on_drop: false }` [INFO] [stderr] Checking st-webserver v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/lib.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | Some(arg) => arg [INFO] [stdout] | __________________________^ [INFO] [stdout] 16 | | .parse::() [INFO] [stdout] 17 | | .ok() [INFO] [stdout] 18 | | .expect("The port must be a number"), [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] = note: `#[warn(clippy::ok_expect)]` on by default [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 16 - .parse::() [INFO] [stdout] 17 - .ok() [INFO] [stdout] 18 - .expect("The port must be a number"), [INFO] [stdout] 16 + .parse::().expect("The port must be a number"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/lib.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | Some(arg) => arg [INFO] [stdout] | __________________________^ [INFO] [stdout] 16 | | .parse::() [INFO] [stdout] 17 | | .ok() [INFO] [stdout] 18 | | .expect("The port must be a number"), [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] = note: `#[warn(clippy::ok_expect)]` on by default [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 16 - .parse::() [INFO] [stdout] 17 - .ok() [INFO] [stdout] 18 - .expect("The port must be a number"), [INFO] [stdout] 16 + .parse::().expect("The port must be a number"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | if !fs::metadata(&page_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&page_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:51:8 [INFO] [stdout] | [INFO] [stdout] 51 | if !fs::metadata(&page_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&page_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.36s [INFO] running `Command { std: "docker" "inspect" "c5a8eb5fd587594f72edad1f169eac6cca28f7a779c190a7345fccfeed03f693", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5a8eb5fd587594f72edad1f169eac6cca28f7a779c190a7345fccfeed03f693", kill_on_drop: false }` [INFO] [stdout] c5a8eb5fd587594f72edad1f169eac6cca28f7a779c190a7345fccfeed03f693