[INFO] cloning repository https://github.com/MrRTi/projector-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MrRTi/projector-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrRTi%2Fprojector-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrRTi%2Fprojector-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 84da914846acd6119c4f3ff7998df2609fdd3dce [INFO] linting MrRTi/projector-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrRTi%2Fprojector-rust" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MrRTi/projector-rust [INFO] finished tweaking git repo https://github.com/MrRTi/projector-rust [INFO] tweaked toml for git repo https://github.com/MrRTi/projector-rust written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MrRTi/projector-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MrRTi/projector-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anyhow v1.0.79 [INFO] [stderr] Downloaded strsim v0.11.0 [INFO] [stderr] Downloaded clap v4.5.1 [INFO] [stderr] Downloaded anstream v0.6.11 [INFO] [stderr] Downloaded clap_derive v4.5.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.78 [INFO] [stderr] Downloaded collection_macros v0.2.0 [INFO] [stderr] Downloaded clap_builder v4.5.1 [INFO] [stderr] Downloaded syn v2.0.49 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3196584056b29666e5579fd90467dff9ba57448d38241126e08b467aebc37f48 [INFO] running `Command { std: "docker" "start" "-a" "3196584056b29666e5579fd90467dff9ba57448d38241126e08b467aebc37f48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3196584056b29666e5579fd90467dff9ba57448d38241126e08b467aebc37f48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3196584056b29666e5579fd90467dff9ba57448d38241126e08b467aebc37f48", kill_on_drop: false }` [INFO] [stdout] 3196584056b29666e5579fd90467dff9ba57448d38241126e08b467aebc37f48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b2733d0d024d1790bd36fac069869205db845878696fb73500e21770456dfb42 [INFO] running `Command { std: "docker" "start" "-a" "b2733d0d024d1790bd36fac069869205db845878696fb73500e21770456dfb42", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking collection_macros v0.2.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.49 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking projector-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/config.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if value.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `value.get(0)` [INFO] [stdout] --> src/config.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | let term = value.get(0).expect("expect to exist"); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/projector.rs:65:29 [INFO] [stdout] | [INFO] [stdout] 65 | .or_insert_with(|| HashMap::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `HashMap::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/projector.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / self.data.projector.get_mut(&self.pwd).map(|x| { [INFO] [stdout] 71 | | x.remove(key); [INFO] [stdout] 72 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 70 - self.data.projector.get_mut(&self.pwd).map(|x| { [INFO] [stdout] 71 - x.remove(key); [INFO] [stdout] 72 - }); [INFO] [stdout] 70 + if let Some(x) = self.data.projector.get_mut(&self.pwd) { x.remove(key); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projector.rs:77:16 [INFO] [stdout] | [INFO] [stdout] 77 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&p).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/projector.rs:77:35 [INFO] [stdout] | [INFO] [stdout] 77 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^ help: change this to: `p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/config.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if value.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `value.get(0)` [INFO] [stdout] --> src/config.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | let term = value.get(0).expect("expect to exist"); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/projector.rs:65:29 [INFO] [stdout] | [INFO] [stdout] 65 | .or_insert_with(|| HashMap::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `HashMap::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/projector.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / self.data.projector.get_mut(&self.pwd).map(|x| { [INFO] [stdout] 71 | | x.remove(key); [INFO] [stdout] 72 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 70 - self.data.projector.get_mut(&self.pwd).map(|x| { [INFO] [stdout] 71 - x.remove(key); [INFO] [stdout] 72 - }); [INFO] [stdout] 70 + if let Some(x) = self.data.projector.get_mut(&self.pwd) { x.remove(key); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projector.rs:77:16 [INFO] [stdout] | [INFO] [stdout] 77 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&p).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/projector.rs:77:35 [INFO] [stdout] | [INFO] [stdout] 77 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^ help: change this to: `p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bin/projector.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / proj.get_value(&k).map(|x| { [INFO] [stdout] 22 | | println!("{}", x); [INFO] [stdout] 23 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 21 - proj.get_value(&k).map(|x| { [INFO] [stdout] 22 - println!("{}", x); [INFO] [stdout] 23 - }); [INFO] [stdout] 21 + if let Some(x) = proj.get_value(&k) { println!("{}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bin/projector.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / proj.get_value(&k).map(|x| { [INFO] [stdout] 22 | | println!("{}", x); [INFO] [stdout] 23 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 21 - proj.get_value(&k).map(|x| { [INFO] [stdout] 22 - println!("{}", x); [INFO] [stdout] 23 - }); [INFO] [stdout] 21 + if let Some(x) = proj.get_value(&k) { println!("{}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.84s [INFO] running `Command { std: "docker" "inspect" "b2733d0d024d1790bd36fac069869205db845878696fb73500e21770456dfb42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2733d0d024d1790bd36fac069869205db845878696fb73500e21770456dfb42", kill_on_drop: false }` [INFO] [stdout] b2733d0d024d1790bd36fac069869205db845878696fb73500e21770456dfb42