[INFO] cloning repository https://github.com/MoustafaMal1moud/Ric [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MoustafaMal1moud/Ric" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMoustafaMal1moud%2FRic", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMoustafaMal1moud%2FRic'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 24599289738da1a8f51bdb5c179146a5fc7b3df5 [INFO] linting MoustafaMal1moud/Ric against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMoustafaMal1moud%2FRic" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MoustafaMal1moud/Ric [INFO] finished tweaking git repo https://github.com/MoustafaMal1moud/Ric [INFO] tweaked toml for git repo https://github.com/MoustafaMal1moud/Ric written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MoustafaMal1moud/Ric on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MoustafaMal1moud/Ric already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zerocopy-derive v0.8.28 [INFO] [stderr] Downloaded font-kit v0.14.3 [INFO] [stderr] Downloaded zerocopy v0.8.28 [INFO] [stderr] Downloaded cc v1.2.47 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0880aac6f26371701370330fe4b24067e0ada42ee72d445cf85f4c7f82ec2c5a [INFO] running `Command { std: "docker" "start" "-a" "0880aac6f26371701370330fe4b24067e0ada42ee72d445cf85f4c7f82ec2c5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0880aac6f26371701370330fe4b24067e0ada42ee72d445cf85f4c7f82ec2c5a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0880aac6f26371701370330fe4b24067e0ada42ee72d445cf85f4c7f82ec2c5a", kill_on_drop: false }` [INFO] [stdout] 0880aac6f26371701370330fe4b24067e0ada42ee72d445cf85f4c7f82ec2c5a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6f53fabb6078c2415721bb62ea00565213a623369a367b5154a6b9a794ec293a [INFO] running `Command { std: "docker" "start" "-a" "6f53fabb6078c2415721bb62ea00565213a623369a367b5154a6b9a794ec293a", kill_on_drop: false }` [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Compiling syn v2.0.110 [INFO] [stderr] Compiling yeslogic-fontconfig-sys v6.0.0 [INFO] [stderr] Compiling pathfinder_simd v0.5.5 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Compiling cc v1.2.47 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Compiling zerocopy v0.8.28 [INFO] [stderr] Compiling font-kit v0.14.3 [INFO] [stderr] Checking jpeg-decoder v0.3.2 [INFO] [stderr] Checking pathfinder_geometry v0.5.1 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking ttf-parser v0.20.0 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Compiling freetype-sys v0.20.1 [INFO] [stderr] Compiling blake3 v1.8.2 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking plotters-bitmap v0.3.7 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerocopy-derive v0.8.28 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking ric v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config/schema.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / impl Default for Config { [INFO] [stdout] 17 | | fn default() -> Self { [INFO] [stdout] 18 | | Self { [INFO] [stdout] 19 | | input: InputConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Default)] [INFO] [stdout] 7 | pub struct Config { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/input/detector.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | counts.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 20 - counts.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 20 + counts.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/input/detector.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | !f.trim().parse::().is_ok() && !f.is_empty() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f.trim().parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/input/reader.rs:74:47 [INFO] [stdout] | [INFO] [stdout] 74 | row.entry(header.clone()).or_insert_with(|| "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/input/reader.rs:92:59 [INFO] [stdout] | [INFO] [stdout] 92 | ... row.entry(header.clone()).or_insert_with(|| "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/input/reader.rs:128:51 [INFO] [stdout] | [INFO] [stdout] 128 | row.entry(header.clone()).or_insert_with(|| "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/input/reader.rs:186:47 [INFO] [stdout] | [INFO] [stdout] 186 | row.entry(header.clone()).or_insert_with(|| "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/output/toon.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | while let Some(ch) = chars.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for ch in chars` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pipeline/shard.rs:33:45 [INFO] [stdout] | [INFO] [stdout] 33 | shard.metadata.pipeline_stages.push(format!("shard (row_count)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"shard (row_count)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pipeline/shard.rs:57:57 [INFO] [stdout] | [INFO] [stdout] 57 | current_shard.metadata.pipeline_stages.push(format!("shard (file_size)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"shard (file_size)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pipeline/shard.rs:69:53 [INFO] [stdout] | [INFO] [stdout] 69 | current_shard.metadata.pipeline_stages.push(format!("shard (file_size)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"shard (file_size)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pipeline/shard.rs:99:45 [INFO] [stdout] | [INFO] [stdout] 99 | shard.metadata.pipeline_stages.push(format!("shard (hash)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"shard (hash)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/viz/stats.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | distribution.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 96 - distribution.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 96 + distribution.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/viz/stats.rs:104:6 [INFO] [stdout] | [INFO] [stdout] 104 | ) -> (Option, Option, Option, Option, Option) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/viz/stats.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | let median = if sorted.len() % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `sorted.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/viz/stats.rs:212:26 [INFO] [stdout] | [INFO] [stdout] 212 | .map(|h| row.get(h).map_or(true, |v| v.is_empty())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 212 - .map(|h| row.get(h).map_or(true, |v| v.is_empty())) [INFO] [stdout] 212 + .map(|h| row.get(h).is_none_or(|v| v.is_empty())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/viz/charts.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / if col_stats.data_type == DataType::Integer || col_stats.data_type == DataType::Float { [INFO] [stdout] 26 | | if col_stats.min.is_some() && col_stats.max.is_some() { [INFO] [stdout] 27 | | let path = output_dir.join(format!("{}_histogram.png", col_stats.name)); [INFO] [stdout] 28 | | draw_histogram(col_stats, &path)?; [INFO] [stdout] ... | [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 25 ~ if (col_stats.data_type == DataType::Integer || col_stats.data_type == DataType::Float) { [INFO] [stdout] 26 ~ && col_stats.min.is_some() && col_stats.max.is_some() { [INFO] [stdout] 27 | let path = output_dir.join(format!("{}_histogram.png", col_stats.name)); [INFO] [stdout] 28 | draw_histogram(col_stats, &path)?; [INFO] [stdout] 29 | chart_paths.push(path.to_string_lossy().to_string()); [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/viz/report.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / format!( [INFO] [stdout] 39 | | r#" [INFO] [stdout] 40 | | [INFO] [stdout] 41 | | [INFO] [stdout] ... | [INFO] [stdout] 217 | | .collect::() [INFO] [stdout] 218 | | ) + &format!( [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/input/detector.rs:14:22 [INFO] [stdout] | [INFO] [stdout] 14 | let delimiters = vec![b',', b';', b'\t', b'|']; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[b',', b';', b'\t', b'|']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/pipeline/normalize.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 49 | let _date_patterns = vec![ [INFO] [stdout] | __________________________^ [INFO] [stdout] 50 | | r"\d{4}-\d{2}-\d{2}", // YYYY-MM-DD [INFO] [stdout] 51 | | r"\d{2}/\d{2}/\d{4}", // MM/DD/YYYY [INFO] [stdout] 52 | | r"\d{2}-\d{2}-\d{4}", // DD-MM-YYYY [INFO] [stdout] 53 | | r"\d{4}/\d{2}/\d{2}", // YYYY/MM/DD [INFO] [stdout] 54 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 49 ~ let _date_patterns = [r"\d{4}-\d{2}-\d{2}", // YYYY-MM-DD [INFO] [stdout] 50 + r"\d{2}/\d{2}/\d{4}", // MM/DD/YYYY [INFO] [stdout] 51 + r"\d{2}-\d{2}-\d{4}", // DD-MM-YYYY [INFO] [stdout] 52 ~ r"\d{4}/\d{2}/\d{2}"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use tracing_subscriber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/main.rs:124:1 [INFO] [stdout] | [INFO] [stdout] 124 | / fn process_files( [INFO] [stdout] 125 | | input_files: Vec, [INFO] [stdout] 126 | | output_dir: PathBuf, [INFO] [stdout] 127 | | config_file: Option, [INFO] [stdout] ... | [INFO] [stdout] 134 | | generate_viz: bool, [INFO] [stdout] 135 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> tests/integration_tests.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | use tracing_subscriber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/main.rs:124:1 [INFO] [stdout] | [INFO] [stdout] 124 | / fn process_files( [INFO] [stdout] 125 | | input_files: Vec, [INFO] [stdout] 126 | | output_dir: PathBuf, [INFO] [stdout] 127 | | config_file: Option, [INFO] [stdout] ... | [INFO] [stdout] 134 | | generate_viz: bool, [INFO] [stdout] 135 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/config/schema.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / impl Default for Config { [INFO] [stdout] 17 | | fn default() -> Self { [INFO] [stdout] 18 | | Self { [INFO] [stdout] 19 | | input: InputConfig::default(), [INFO] [stdout] ... | [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 6 + #[derive(Default)] [INFO] [stdout] 7 | pub struct Config { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/input/detector.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | counts.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 20 - counts.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 20 + counts.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/input/detector.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | !f.trim().parse::().is_ok() && !f.is_empty() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f.trim().parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/input/reader.rs:74:47 [INFO] [stdout] | [INFO] [stdout] 74 | row.entry(header.clone()).or_insert_with(|| "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/input/reader.rs:92:59 [INFO] [stdout] | [INFO] [stdout] 92 | ... row.entry(header.clone()).or_insert_with(|| "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/input/reader.rs:128:51 [INFO] [stdout] | [INFO] [stdout] 128 | row.entry(header.clone()).or_insert_with(|| "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/input/reader.rs:186:47 [INFO] [stdout] | [INFO] [stdout] 186 | row.entry(header.clone()).or_insert_with(|| "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/output/toon.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | while let Some(ch) = chars.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for ch in chars` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pipeline/shard.rs:33:45 [INFO] [stdout] | [INFO] [stdout] 33 | shard.metadata.pipeline_stages.push(format!("shard (row_count)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"shard (row_count)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pipeline/shard.rs:57:57 [INFO] [stdout] | [INFO] [stdout] 57 | current_shard.metadata.pipeline_stages.push(format!("shard (file_size)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"shard (file_size)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pipeline/shard.rs:69:53 [INFO] [stdout] | [INFO] [stdout] 69 | current_shard.metadata.pipeline_stages.push(format!("shard (file_size)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"shard (file_size)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pipeline/shard.rs:99:45 [INFO] [stdout] | [INFO] [stdout] 99 | shard.metadata.pipeline_stages.push(format!("shard (hash)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"shard (hash)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/viz/stats.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | distribution.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 96 - distribution.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 96 + distribution.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/viz/stats.rs:104:6 [INFO] [stdout] | [INFO] [stdout] 104 | ) -> (Option, Option, Option, Option, Option) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/viz/stats.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | let median = if sorted.len() % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `sorted.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/viz/stats.rs:212:26 [INFO] [stdout] | [INFO] [stdout] 212 | .map(|h| row.get(h).map_or(true, |v| v.is_empty())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 212 - .map(|h| row.get(h).map_or(true, |v| v.is_empty())) [INFO] [stdout] 212 + .map(|h| row.get(h).is_none_or(|v| v.is_empty())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/viz/charts.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / if col_stats.data_type == DataType::Integer || col_stats.data_type == DataType::Float { [INFO] [stdout] 26 | | if col_stats.min.is_some() && col_stats.max.is_some() { [INFO] [stdout] 27 | | let path = output_dir.join(format!("{}_histogram.png", col_stats.name)); [INFO] [stdout] 28 | | draw_histogram(col_stats, &path)?; [INFO] [stdout] ... | [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 25 ~ if (col_stats.data_type == DataType::Integer || col_stats.data_type == DataType::Float) { [INFO] [stdout] 26 ~ && col_stats.min.is_some() && col_stats.max.is_some() { [INFO] [stdout] 27 | let path = output_dir.join(format!("{}_histogram.png", col_stats.name)); [INFO] [stdout] 28 | draw_histogram(col_stats, &path)?; [INFO] [stdout] 29 | chart_paths.push(path.to_string_lossy().to_string()); [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/viz/report.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / format!( [INFO] [stdout] 39 | | r#" [INFO] [stdout] 40 | | [INFO] [stdout] 41 | | [INFO] [stdout] ... | [INFO] [stdout] 217 | | .collect::() [INFO] [stdout] 218 | | ) + &format!( [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/input/detector.rs:14:22 [INFO] [stdout] | [INFO] [stdout] 14 | let delimiters = vec![b',', b';', b'\t', b'|']; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[b',', b';', b'\t', b'|']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/pipeline/normalize.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 49 | let _date_patterns = vec![ [INFO] [stdout] | __________________________^ [INFO] [stdout] 50 | | r"\d{4}-\d{2}-\d{2}", // YYYY-MM-DD [INFO] [stdout] 51 | | r"\d{2}/\d{2}/\d{4}", // MM/DD/YYYY [INFO] [stdout] 52 | | r"\d{2}-\d{2}-\d{4}", // DD-MM-YYYY [INFO] [stdout] 53 | | r"\d{4}/\d{2}/\d{2}", // YYYY/MM/DD [INFO] [stdout] 54 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 49 ~ let _date_patterns = [r"\d{4}-\d{2}-\d{2}", // YYYY-MM-DD [INFO] [stdout] 50 + r"\d{2}/\d{2}/\d{4}", // MM/DD/YYYY [INFO] [stdout] 51 + r"\d{2}-\d{2}-\d{4}", // DD-MM-YYYY [INFO] [stdout] 52 ~ r"\d{4}/\d{2}/\d{2}"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 55.13s [INFO] running `Command { std: "docker" "inspect" "6f53fabb6078c2415721bb62ea00565213a623369a367b5154a6b9a794ec293a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f53fabb6078c2415721bb62ea00565213a623369a367b5154a6b9a794ec293a", kill_on_drop: false }` [INFO] [stdout] 6f53fabb6078c2415721bb62ea00565213a623369a367b5154a6b9a794ec293a