[INFO] cloning repository https://github.com/Molkars/simpl [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Molkars/simpl" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMolkars%2Fsimpl", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMolkars%2Fsimpl'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3994bd2531f207e2a5f30f92d2b327f74abe4cf8 [INFO] linting Molkars/simpl against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMolkars%2Fsimpl" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Molkars/simpl [INFO] finished tweaking git repo https://github.com/Molkars/simpl [INFO] tweaked toml for git repo https://github.com/Molkars/simpl written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Molkars/simpl on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Molkars/simpl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9632e619d84f8563fc5e05bac5cf7c26acdbe6ce69f08f7274994a580b921298 [INFO] running `Command { std: "docker" "start" "-a" "9632e619d84f8563fc5e05bac5cf7c26acdbe6ce69f08f7274994a580b921298", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9632e619d84f8563fc5e05bac5cf7c26acdbe6ce69f08f7274994a580b921298", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9632e619d84f8563fc5e05bac5cf7c26acdbe6ce69f08f7274994a580b921298", kill_on_drop: false }` [INFO] [stdout] 9632e619d84f8563fc5e05bac5cf7c26acdbe6ce69f08f7274994a580b921298 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f9796669ce3ff9e159aa042ae25f53c5624c58949d3fde75dfcd9c86a00cdab [INFO] running `Command { std: "docker" "start" "-a" "1f9796669ce3ff9e159aa042ae25f53c5624c58949d3fde75dfcd9c86a00cdab", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Checking simpl v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `span` and `kind` are never read [INFO] [stdout] --> src/lex/mod.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Token { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 13 | pub span: Span, [INFO] [stdout] | ^^^^ [INFO] [stdout] 14 | pub kind: TokenKind, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lex/mod.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | Punct(Punct), [INFO] [stdout] | ----- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `TokenKind` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 19 - Punct(Punct), [INFO] [stdout] 19 + Punct(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lex/mod.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 20 | Ident(String), [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `TokenKind` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 20 - Ident(String), [INFO] [stdout] 20 + Ident(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lex/mod.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | Integer(u64), [INFO] [stdout] | ------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `TokenKind` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 21 - Integer(u64), [INFO] [stdout] 21 + Integer(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lex/mod.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | Decimal(f64), [INFO] [stdout] | ------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `TokenKind` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 22 - Decimal(f64), [INFO] [stdout] 22 + Decimal(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lex/mod.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | String(String), [INFO] [stdout] | ------ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `TokenKind` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 23 - String(String), [INFO] [stdout] 23 + String(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `inner` and `kind` are never read [INFO] [stdout] --> src/lex/mod.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 24 | Group { [INFO] [stdout] | ----- fields in this variant [INFO] [stdout] 25 | inner: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 26 | kind: GroupKind, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenKind` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lex/mod.rs:186:16 [INFO] [stdout] | [INFO] [stdout] 186 | if !tok.peek().is_some_and(|c| c != terminator) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tok.peek().is_none_or(|c| c == terminator)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/lex/mod.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | / let Some(c) = tok.peek() else { [INFO] [stdout] 87 | | return None; [INFO] [stdout] 88 | | }; [INFO] [stdout] | |______^ help: replace it with: `let c = tok.peek()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `skip(..).next()` on an iterator [INFO] [stdout] --> src/lex/mod.rs:306:42 [INFO] [stdout] | [INFO] [stdout] 306 | self.source[self.index..].chars().skip(n).next() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `nth` instead: `.nth(n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stdout] = note: `#[warn(clippy::iter_skip_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `span` and `kind` are never read [INFO] [stdout] --> src/lex/mod.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Token { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 13 | pub span: Span, [INFO] [stdout] | ^^^^ [INFO] [stdout] 14 | pub kind: TokenKind, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lex/mod.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 19 | Punct(Punct), [INFO] [stdout] | ----- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `TokenKind` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 19 - Punct(Punct), [INFO] [stdout] 19 + Punct(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lex/mod.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 20 | Ident(String), [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `TokenKind` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 20 - Ident(String), [INFO] [stdout] 20 + Ident(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lex/mod.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | Integer(u64), [INFO] [stdout] | ------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `TokenKind` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 21 - Integer(u64), [INFO] [stdout] 21 + Integer(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lex/mod.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | Decimal(f64), [INFO] [stdout] | ------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `TokenKind` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 22 - Decimal(f64), [INFO] [stdout] 22 + Decimal(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lex/mod.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 23 | String(String), [INFO] [stdout] | ------ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `TokenKind` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 23 - String(String), [INFO] [stdout] 23 + String(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `inner` and `kind` are never read [INFO] [stdout] --> src/lex/mod.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 24 | Group { [INFO] [stdout] | ----- fields in this variant [INFO] [stdout] 25 | inner: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 26 | kind: GroupKind, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenKind` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lex/mod.rs:186:16 [INFO] [stdout] | [INFO] [stdout] 186 | if !tok.peek().is_some_and(|c| c != terminator) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tok.peek().is_none_or(|c| c == terminator)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/lex/mod.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | / let Some(c) = tok.peek() else { [INFO] [stdout] 87 | | return None; [INFO] [stdout] 88 | | }; [INFO] [stdout] | |______^ help: replace it with: `let c = tok.peek()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `skip(..).next()` on an iterator [INFO] [stdout] --> src/lex/mod.rs:306:42 [INFO] [stdout] | [INFO] [stdout] 306 | self.source[self.index..].chars().skip(n).next() [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `nth` instead: `.nth(n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stdout] = note: `#[warn(clippy::iter_skip_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.36s [INFO] running `Command { std: "docker" "inspect" "1f9796669ce3ff9e159aa042ae25f53c5624c58949d3fde75dfcd9c86a00cdab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f9796669ce3ff9e159aa042ae25f53c5624c58949d3fde75dfcd9c86a00cdab", kill_on_drop: false }` [INFO] [stdout] 1f9796669ce3ff9e159aa042ae25f53c5624c58949d3fde75dfcd9c86a00cdab