[INFO] cloning repository https://github.com/Mojo703/waveshare_serial_servo_rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Mojo703/waveshare_serial_servo_rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMojo703%2Fwaveshare_serial_servo_rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMojo703%2Fwaveshare_serial_servo_rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bf838ffbb5b90cd78d89961d768d5ebaa2f4c094 [INFO] linting Mojo703/waveshare_serial_servo_rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMojo703%2Fwaveshare_serial_servo_rs" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Mojo703/waveshare_serial_servo_rs [INFO] finished tweaking git repo https://github.com/Mojo703/waveshare_serial_servo_rs [INFO] tweaked toml for git repo https://github.com/Mojo703/waveshare_serial_servo_rs written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Mojo703/waveshare_serial_servo_rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Mojo703/waveshare_serial_servo_rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded unescaper v0.1.5 [INFO] [stderr] Downloaded libudev v0.3.0 [INFO] [stderr] Downloaded angle v0.5.0 [INFO] [stderr] Downloaded serialport v4.7.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 03933c9ab2e730cbdf79478009fd87a3d99cfae30f8351e271f74d048e3f067b [INFO] running `Command { std: "docker" "start" "-a" "03933c9ab2e730cbdf79478009fd87a3d99cfae30f8351e271f74d048e3f067b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "03933c9ab2e730cbdf79478009fd87a3d99cfae30f8351e271f74d048e3f067b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03933c9ab2e730cbdf79478009fd87a3d99cfae30f8351e271f74d048e3f067b", kill_on_drop: false }` [INFO] [stdout] 03933c9ab2e730cbdf79478009fd87a3d99cfae30f8351e271f74d048e3f067b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24bf1a5b59062739abca0bfbf6ca40c1092380a2bd64333ad1255b942455db38 [INFO] running `Command { std: "docker" "start" "-a" "24bf1a5b59062739abca0bfbf6ca40c1092380a2bd64333ad1255b942455db38", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.16 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling thiserror v2.0.11 [INFO] [stderr] Checking bitflags v2.8.0 [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling syn v2.0.96 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking libudev v0.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.11 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling enumn v0.1.14 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking unescaper v0.1.5 [INFO] [stderr] Checking serialport v4.7.0 [INFO] [stderr] Checking angle v0.5.0 [INFO] [stderr] Checking waveshare_serial_servo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/hardware.rs:45:32 [INFO] [stdout] | [INFO] [stdout] 45 | Self::Single(x) => x.into(), [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/hardware.rs:287:13 [INFO] [stdout] | [INFO] [stdout] 287 | / (start..end) [INFO] [stdout] 288 | | .all(|i| address_from(i).is_some_and(|a| a.access().can_write())) [INFO] [stdout] 289 | | .then(|| Self { start, data }) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 289 - .then(|| Self { start, data }) [INFO] [stdout] 289 + .then_some(Self { start, data }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/hardware.rs:309:13 [INFO] [stdout] | [INFO] [stdout] 309 | / (start..end) [INFO] [stdout] 310 | | .all(|i| address_from(i).is_some_and(|a| a.access().can_read())) [INFO] [stdout] 311 | | .then(|| Self { start, length }) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 311 - .then(|| Self { start, length }) [INFO] [stdout] 311 + .then_some(Self { start, length }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/hardware.rs:413:52 [INFO] [stdout] | [INFO] [stdout] 413 | Self::Read(region) => Vec::from([0x02, region.start as u8, region.length]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `region.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/hardware.rs:415:39 [INFO] [stdout] | [INFO] [stdout] 415 | Vec::from_iter([0x03, region.start as u8].into_iter().chain(region.data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `region.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/hardware.rs:45:32 [INFO] [stdout] | [INFO] [stdout] 45 | Self::Single(x) => x.into(), [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/hardware.rs:287:13 [INFO] [stdout] | [INFO] [stdout] 287 | / (start..end) [INFO] [stdout] 288 | | .all(|i| address_from(i).is_some_and(|a| a.access().can_write())) [INFO] [stdout] 289 | | .then(|| Self { start, data }) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 289 - .then(|| Self { start, data }) [INFO] [stdout] 289 + .then_some(Self { start, data }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/hardware.rs:309:13 [INFO] [stdout] | [INFO] [stdout] 309 | / (start..end) [INFO] [stdout] 310 | | .all(|i| address_from(i).is_some_and(|a| a.access().can_read())) [INFO] [stdout] 311 | | .then(|| Self { start, length }) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 311 - .then(|| Self { start, length }) [INFO] [stdout] 311 + .then_some(Self { start, length }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/servo.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | / (Self::MIN..=Self::MAX) [INFO] [stdout] 147 | | .contains(&value) [INFO] [stdout] 148 | | .then(|| Self(value)) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 148 - .then(|| Self(value)) [INFO] [stdout] 148 + .then_some(Self(value)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/servo.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | / (Self::MIN..=Self::MAX) [INFO] [stdout] 178 | | .contains(&value) [INFO] [stdout] 179 | | .then(|| Self(value)) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 179 - .then(|| Self(value)) [INFO] [stdout] 179 + .then_some(Self(value)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/servo.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | / (Self::MIN..=Self::MAX) [INFO] [stdout] 204 | | .contains(&value) [INFO] [stdout] 205 | | .then(|| Self(value)) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 205 - .then(|| Self(value)) [INFO] [stdout] 205 + .then_some(Self(value)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/servo.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 277 | Ok(expect_response(serial::packet_tx_rx(read, port))?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 277 - Ok(expect_response(serial::packet_tx_rx(read, port))?) [INFO] [stdout] 277 + expect_response(serial::packet_tx_rx(read, port)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/hardware.rs:413:52 [INFO] [stdout] | [INFO] [stdout] 413 | Self::Read(region) => Vec::from([0x02, region.start as u8, region.length]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `region.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/hardware.rs:415:39 [INFO] [stdout] | [INFO] [stdout] 415 | Vec::from_iter([0x03, region.start as u8].into_iter().chain(region.data)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `region.start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/servo.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | / (Self::MIN..=Self::MAX) [INFO] [stdout] 147 | | .contains(&value) [INFO] [stdout] 148 | | .then(|| Self(value)) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 148 - .then(|| Self(value)) [INFO] [stdout] 148 + .then_some(Self(value)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/servo.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | / (Self::MIN..=Self::MAX) [INFO] [stdout] 178 | | .contains(&value) [INFO] [stdout] 179 | | .then(|| Self(value)) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 179 - .then(|| Self(value)) [INFO] [stdout] 179 + .then_some(Self(value)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/servo.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | / (Self::MIN..=Self::MAX) [INFO] [stdout] 204 | | .contains(&value) [INFO] [stdout] 205 | | .then(|| Self(value)) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 205 - .then(|| Self(value)) [INFO] [stdout] 205 + .then_some(Self(value)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/servo.rs:277:9 [INFO] [stdout] | [INFO] [stdout] 277 | Ok(expect_response(serial::packet_tx_rx(read, port))?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 277 - Ok(expect_response(serial::packet_tx_rx(read, port))?) [INFO] [stdout] 277 + expect_response(serial::packet_tx_rx(read, port)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> examples/solenoid_winder.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | if !previous_layer.is_some_and(|previous_layer| layer_index <= previous_layer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `previous_layer.is_none_or(|previous_layer| layer_index > previous_layer)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.06s [INFO] running `Command { std: "docker" "inspect" "24bf1a5b59062739abca0bfbf6ca40c1092380a2bd64333ad1255b942455db38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24bf1a5b59062739abca0bfbf6ca40c1092380a2bd64333ad1255b942455db38", kill_on_drop: false }` [INFO] [stdout] 24bf1a5b59062739abca0bfbf6ca40c1092380a2bd64333ad1255b942455db38