[INFO] cloning repository https://github.com/Mohiiit/kopiatan [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Mohiiit/kopiatan" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMohiiit%2Fkopiatan", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMohiiit%2Fkopiatan'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 100ce65122ca9eace472a944f3cf0c69b94ee83c [INFO] linting Mohiiit/kopiatan against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMohiiit%2Fkopiatan" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Mohiiit/kopiatan [INFO] finished tweaking git repo https://github.com/Mohiiit/kopiatan [INFO] tweaked toml for git repo https://github.com/Mohiiit/kopiatan written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Mohiiit/kopiatan on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Mohiiit/kopiatan already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zerocopy-derive v0.8.38 [INFO] [stderr] Downloaded zerocopy v0.8.38 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 547a2fec6690e3bf05ea084a0f953f8fb19a0f306e5c7287fdf6d72626d89f51 [INFO] running `Command { std: "docker" "start" "-a" "547a2fec6690e3bf05ea084a0f953f8fb19a0f306e5c7287fdf6d72626d89f51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "547a2fec6690e3bf05ea084a0f953f8fb19a0f306e5c7287fdf6d72626d89f51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "547a2fec6690e3bf05ea084a0f953f8fb19a0f306e5c7287fdf6d72626d89f51", kill_on_drop: false }` [INFO] [stdout] 547a2fec6690e3bf05ea084a0f953f8fb19a0f306e5c7287fdf6d72626d89f51 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a7f700520f855724fe8786471bcb892b5e745effb3969cd1cdc72c6d90aea15 [INFO] running `Command { std: "docker" "start" "-a" "8a7f700520f855724fe8786471bcb892b5e745effb3969cd1cdc72c6d90aea15", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling zerocopy v0.8.38 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling zmij v1.0.19 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking regex-syntax v0.8.9 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking catan-core v0.1.0 (/opt/rustwide/workdir/crates/catan-core) [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> crates/catan-core/src/board.rs:490:67 [INFO] [stdout] | [INFO] [stdout] 490 | for (edge, harbor_type) in selected_edges.into_iter().zip(harbor_types.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 490 - for (edge, harbor_type) in selected_edges.into_iter().zip(harbor_types.into_iter()) { [INFO] [stdout] 490 + for (edge, harbor_type) in selected_edges.into_iter().zip(harbor_types) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/catan-core/src/bot.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 288 - scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 288 + scored.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/catan-core/src/bot.rs:338:9 [INFO] [stdout] | [INFO] [stdout] 338 | scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 338 - scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 338 + scored.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/catan-core/src/bot.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 399 - scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 399 + scored.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/catan-core/src/bot.rs:427:9 [INFO] [stdout] | [INFO] [stdout] 427 | scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 427 - scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 427 + scored.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/catan-core/src/bot.rs:505:9 [INFO] [stdout] | [INFO] [stdout] 505 | scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 505 - scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 505 + scored.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> crates/catan-core/src/board.rs:490:67 [INFO] [stdout] | [INFO] [stdout] 490 | for (edge, harbor_type) in selected_edges.into_iter().zip(harbor_types.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 490 - for (edge, harbor_type) in selected_edges.into_iter().zip(harbor_types.into_iter()) { [INFO] [stdout] 490 + for (edge, harbor_type) in selected_edges.into_iter().zip(harbor_types) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/catan-core/src/board.rs:1254:33 [INFO] [stdout] | [INFO] [stdout] 1254 | / ... !(number == 6 && neighbor_number == 8) [INFO] [stdout] 1255 | | ... && !(number == 8 && neighbor_number == 6), [INFO] [stdout] | |___________________________________________________________________^ help: try: `!(number == 6 && neighbor_number == 8 || number == 8 && neighbor_number == 6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> crates/catan-core/src/player.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 67 | deck.extend(std::iter::repeat(DevelopmentCard::Knight).take(14)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(DevelopmentCard::Knight, 14)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> crates/catan-core/src/player.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | deck.extend(std::iter::repeat(DevelopmentCard::VictoryPoint).take(5)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(DevelopmentCard::VictoryPoint, 5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> crates/catan-core/src/player.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | deck.extend(std::iter::repeat(DevelopmentCard::RoadBuilding).take(2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(DevelopmentCard::RoadBuilding, 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> crates/catan-core/src/player.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | deck.extend(std::iter::repeat(DevelopmentCard::YearOfPlenty).take(2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(DevelopmentCard::YearOfPlenty, 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> crates/catan-core/src/player.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | deck.extend(std::iter::repeat(DevelopmentCard::Monopoly).take(2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(DevelopmentCard::Monopoly, 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/catan-core/src/bot.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 288 - scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 288 + scored.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/catan-core/src/bot.rs:338:9 [INFO] [stdout] | [INFO] [stdout] 338 | scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 338 - scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 338 + scored.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/catan-core/src/bot.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 399 - scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 399 + scored.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/catan-core/src/bot.rs:427:9 [INFO] [stdout] | [INFO] [stdout] 427 | scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 427 - scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 427 + scored.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/catan-core/src/bot.rs:505:9 [INFO] [stdout] | [INFO] [stdout] 505 | scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 505 - scored.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 505 + scored.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> crates/catan-core/src/player.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 423 | self.dev_cards.iter().any(|c| *c == card_type) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dev_cards.contains(&card_type)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> crates/catan-core/tests/integration_tests.rs:354:9 [INFO] [stdout] | [INFO] [stdout] 354 | let p = &game.players[player as usize]; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> crates/catan-core/tests/integration_tests.rs:272:13 [INFO] [stdout] | [INFO] [stdout] 272 | give_count >= 2 && give_count <= 4, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(2..=4).contains(&give_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> crates/catan-core/src/player.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 67 | deck.extend(std::iter::repeat(DevelopmentCard::Knight).take(14)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(DevelopmentCard::Knight, 14)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> crates/catan-core/src/player.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 70 | deck.extend(std::iter::repeat(DevelopmentCard::VictoryPoint).take(5)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(DevelopmentCard::VictoryPoint, 5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> crates/catan-core/src/player.rs:73:21 [INFO] [stdout] | [INFO] [stdout] 73 | deck.extend(std::iter::repeat(DevelopmentCard::RoadBuilding).take(2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(DevelopmentCard::RoadBuilding, 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> crates/catan-core/src/player.rs:76:21 [INFO] [stdout] | [INFO] [stdout] 76 | deck.extend(std::iter::repeat(DevelopmentCard::YearOfPlenty).take(2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(DevelopmentCard::YearOfPlenty, 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> crates/catan-core/src/player.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | deck.extend(std::iter::repeat(DevelopmentCard::Monopoly).take(2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(DevelopmentCard::Monopoly, 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> crates/catan-core/src/player.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 423 | self.dev_cards.iter().any(|c| *c == card_type) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.dev_cards.contains(&card_type)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking catan-server v0.1.0 (/opt/rustwide/workdir/crates/catan-server) [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> crates/catan-server/src/server.rs:115:34 [INFO] [stdout] | [INFO] [stdout] 115 | ws_sender.send(Message::Text(msg_text.into())).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `msg_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> crates/catan-server/src/server.rs:121:49 [INFO] [stdout] | [INFO] [stdout] 121 | if ws_sender.send(Message::Text(text.into())).await.is_err() { [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> crates/catan-server/src/server.rs:115:34 [INFO] [stdout] | [INFO] [stdout] 115 | ws_sender.send(Message::Text(msg_text.into())).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `msg_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> crates/catan-server/src/server.rs:121:49 [INFO] [stdout] | [INFO] [stdout] 121 | if ws_sender.send(Message::Text(text.into())).await.is_err() { [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `player_count` is never used [INFO] [stdout] --> crates/catan-server/src/room.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 83 | impl GameRoom { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 100 | pub fn player_count(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> crates/catan-server/src/server.rs:115:34 [INFO] [stdout] | [INFO] [stdout] 115 | ws_sender.send(Message::Text(msg_text.into())).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `msg_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> crates/catan-server/src/server.rs:121:49 [INFO] [stdout] | [INFO] [stdout] 121 | if ws_sender.send(Message::Text(text.into())).await.is_err() { [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> crates/catan-server/src/server.rs:115:34 [INFO] [stdout] | [INFO] [stdout] 115 | ws_sender.send(Message::Text(msg_text.into())).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `msg_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> crates/catan-server/src/server.rs:121:49 [INFO] [stdout] | [INFO] [stdout] 121 | if ws_sender.send(Message::Text(text.into())).await.is_err() { [INFO] [stdout] | ^^^^^^^^^^^ help: consider removing `.into()`: `text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 55.71s [INFO] running `Command { std: "docker" "inspect" "8a7f700520f855724fe8786471bcb892b5e745effb3969cd1cdc72c6d90aea15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a7f700520f855724fe8786471bcb892b5e745effb3969cd1cdc72c6d90aea15", kill_on_drop: false }` [INFO] [stdout] 8a7f700520f855724fe8786471bcb892b5e745effb3969cd1cdc72c6d90aea15