[INFO] cloning repository https://github.com/MoeexT/runslate [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MoeexT/runslate" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMoeexT%2Frunslate", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMoeexT%2Frunslate'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7a295a60b5d25e1b7d0440ccee1c4517787c2649 [INFO] linting MoeexT/runslate against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMoeexT%2Frunslate" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MoeexT/runslate [INFO] finished tweaking git repo https://github.com/MoeexT/runslate [INFO] tweaked toml for git repo https://github.com/MoeexT/runslate written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MoeexT/runslate on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MoeexT/runslate already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rustls-pki-types v1.13.1 [INFO] [stderr] Downloaded uuid-macro-internal v1.3.4 [INFO] [stderr] Downloaded sha256 v1.4.0 [INFO] [stderr] Downloaded ouroboros v0.18.5 [INFO] [stderr] Downloaded sea-schema-derive v0.3.0 [INFO] [stderr] Downloaded ouroboros_macro v0.18.5 [INFO] [stderr] Downloaded sea-query-derive v1.0.0-rc.11 [INFO] [stderr] Downloaded csv-core v0.1.13 [INFO] [stderr] Downloaded sea-orm-cli v2.0.0-rc.20 [INFO] [stderr] Downloaded sea-orm-macros v2.0.0-rc.18 [INFO] [stderr] Downloaded openssl-sys v0.9.90 [INFO] [stderr] Downloaded rsa v0.9.9 [INFO] [stderr] Downloaded rust_decimal v1.39.0 [INFO] [stderr] Downloaded bigdecimal v0.4.9 [INFO] [stderr] Downloaded h2 v0.3.19 [INFO] [stderr] Downloaded serde_json v1.0.99 [INFO] [stderr] Downloaded cc v1.2.48 [INFO] [stderr] Downloaded webpki-roots v1.0.4 [INFO] [stderr] Downloaded sea-orm-migration v2.0.0-rc.18 [INFO] [stderr] Downloaded pgvector v0.4.1 [INFO] [stderr] Downloaded sea-query-sqlx v0.8.0-rc.9 [INFO] [stderr] Downloaded openssl v0.10.55 [INFO] [stderr] Downloaded windows-core v0.50.0 [INFO] [stderr] Downloaded sea-query v1.0.0-rc.22 [INFO] [stderr] Downloaded uuid v1.3.4 [INFO] [stderr] Downloaded csv v1.4.0 [INFO] [stderr] Downloaded sea-schema v0.17.0-rc.16 [INFO] [stderr] Downloaded sea-orm v2.0.0-rc.18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c42f4f6dcb7f495c5ea1d0e9c04f0fd356da7037795442c64b577b286195d4d [INFO] running `Command { std: "docker" "start" "-a" "2c42f4f6dcb7f495c5ea1d0e9c04f0fd356da7037795442c64b577b286195d4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c42f4f6dcb7f495c5ea1d0e9c04f0fd356da7037795442c64b577b286195d4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c42f4f6dcb7f495c5ea1d0e9c04f0fd356da7037795442c64b577b286195d4d", kill_on_drop: false }` [INFO] [stdout] 2c42f4f6dcb7f495c5ea1d0e9c04f0fd356da7037795442c64b577b286195d4d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9d039a56e0901bd6bef864e0bb46c25ada436d94c60845e5945cb9fbedbde07b [INFO] running `Command { std: "docker" "start" "-a" "9d039a56e0901bd6bef864e0bb46c25ada436d94c60845e5945cb9fbedbde07b", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking value-bag v1.12.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling tokio v1.28.2 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling cc v1.2.48 [INFO] [stderr] Checking tracing-core v0.1.35 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling serde_json v1.0.99 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking rustls-pki-types v1.13.1 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling bigdecimal v0.4.9 [INFO] [stderr] Compiling rust_decimal v1.39.0 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cpufeatures v0.2.11 [INFO] [stderr] Compiling rustls v0.23.35 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Checking crc v3.4.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking webpki-roots v1.0.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking flume v0.11.1 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling async-trait v0.1.68 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling openssl v0.10.55 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling openssl-sys v0.9.90 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking clap_builder v4.4.7 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking futures-intrusive v0.5.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Compiling rustix v0.37.20 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Compiling indoc v2.0.7 [INFO] [stderr] Checking glob v0.3.3 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking encoding_rs v0.8.32 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Checking ipnet v2.7.2 [INFO] [stderr] Checking home v0.5.5 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking is-terminal v0.4.7 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling uuid-macro-internal v1.3.4 [INFO] [stderr] Compiling inherent v1.0.13 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling sea-bae v0.2.1 [INFO] [stderr] Compiling ouroboros_macro v0.18.5 [INFO] [stderr] Compiling sea-schema-derive v0.3.0 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling sea-orm-macros v2.0.0-rc.18 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking tracing v0.1.43 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking ouroboros v0.18.5 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking clap v4.4.7 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling sea-query-derive v1.0.0-rc.11 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Checking uuid v1.3.4 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking sea-query v1.0.0-rc.22 [INFO] [stderr] Checking sea-orm-cli v2.0.0-rc.20 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking sha256 v1.4.0 [INFO] [stderr] Checking async-std v1.13.2 [INFO] [stderr] Checking sqlx-core v0.8.6 [INFO] [stderr] Checking h2 v0.3.19 [INFO] [stderr] Checking sqlx-sqlite v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking sea-query-sqlx v0.8.0-rc.9 [INFO] [stderr] Checking sea-schema v0.17.0-rc.16 [INFO] [stderr] Checking hyper v0.14.26 [INFO] [stderr] Checking sea-orm v2.0.0-rc.18 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.18 [INFO] [stderr] Checking sea-orm-migration v2.0.0-rc.18 [INFO] [stderr] Checking migration v0.1.0 (/opt/rustwide/workdir/migration) [INFO] [stdout] warning: unused import: `schema::*` [INFO] [stdout] --> migration/src/m20220101_000001_create_table.rs:1:37 [INFO] [stdout] | [INFO] [stdout] 1 | use sea_orm_migration::{prelude::*, schema::*}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking runslate v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `pub(self)` [INFO] [stdout] --> src/cache/mod.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | pub(self) mod util; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self [INFO] [stdout] = note: `#[warn(clippy::needless_pub_self)]` on by default [INFO] [stdout] = help: remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/utils/file.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | const UNITS: &'static [&str; 4] = &["B", "KB", "MB", "GB"]; [INFO] [stdout] | -^^^^^^^---------- help: consider removing `'static`: `&[&str; 4]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `pub(self)` [INFO] [stdout] --> src/cache/mod.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | pub(self) mod util; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self [INFO] [stdout] = note: `#[warn(clippy::needless_pub_self)]` on by default [INFO] [stdout] = help: remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/utils/file.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | const UNITS: &'static [&str; 4] = &["B", "KB", "MB", "GB"]; [INFO] [stdout] | -^^^^^^^---------- help: consider removing `'static`: `&[&str; 4]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/cache/mod.rs:37:19 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn get<'a, T>(key: String) -> Result [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cache/mod.rs:52:22 [INFO] [stdout] | [INFO] [stdout] 52 | Ok(value) => return Ok(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - Ok(value) => return Ok(value), [INFO] [stdout] 52 + Ok(value) => Ok(value), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cache/mod.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | return Err(Error::DeserializeFailed(msg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return Err(Error::DeserializeFailed(msg)); [INFO] [stdout] 56 + Err(Error::DeserializeFailed(msg)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cache/mod.rs:44:23 [INFO] [stdout] | [INFO] [stdout] 44 | let msg = format!("Cache expired or not found"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Cache expired or not found".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/translators/dictionaryapi.rs:52:37 [INFO] [stdout] | [INFO] [stdout] 52 | ... phonetic_str.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `phonetic_str.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `sentences.get(0)` [INFO] [stdout] --> src/translators/google.rs:62:52 [INFO] [stdout] | [INFO] [stdout] 62 | if let Some(Value::Object(sentence)) = sentences.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `sentences.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/translators/google.rs:78:49 [INFO] [stdout] | [INFO] [stdout] 78 | for (idx, entry) in entries.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/translators/youdao.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | / if let Value::Array(phrases) = v { [INFO] [stdout] 91 | | let mut original_phrase = String::new(); [INFO] [stdout] 92 | | for phrase in phrases { [INFO] [stdout] 93 | | original_phrase.push_str(&phrase.to_string()); [INFO] [stdout] 94 | | } [INFO] [stdout] 95 | | println!("{}", original_phrase.dye(Colors::BrightBlack)); [INFO] [stdout] 96 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/translators/youdao.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | if let Some(v) = response.get("returnPhrase") { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 90 | if let Value::Array(phrases) = v { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/translators/youdao.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | / if let Value::Array(phrases) = v { [INFO] [stdout] 103 | | let mut original_phrase = String::new(); [INFO] [stdout] 104 | | for phrase in phrases { [INFO] [stdout] 105 | | original_phrase.push_str(&phrase.to_string()); [INFO] [stdout] 106 | | } [INFO] [stdout] 107 | | println!("{}", original_phrase.dye(Colors::BrightWhite)); [INFO] [stdout] 108 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/translators/youdao.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | if let Some(v) = response.get("translation") { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 102 | if let Value::Array(phrases) = v { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/translators/youdao.rs:121:16 [INFO] [stdout] | [INFO] [stdout] 121 | if phonetics.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!phonetics.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/translators/youdao.rs:177:33 [INFO] [stdout] | [INFO] [stdout] 177 | ... original_phrase.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `original_phrase.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/translators/youdao.rs:180:60 [INFO] [stdout] | [INFO] [stdout] 180 | ... for (idx, value) in values.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/translators/youdao.rs:184:45 [INFO] [stdout] | [INFO] [stdout] 184 | ... original_phrase.push_str("；") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `original_phrase.push('；')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/cache/mod.rs:37:19 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn get<'a, T>(key: String) -> Result [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cache/mod.rs:52:22 [INFO] [stdout] | [INFO] [stdout] 52 | Ok(value) => return Ok(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - Ok(value) => return Ok(value), [INFO] [stdout] 52 + Ok(value) => Ok(value), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cache/mod.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | return Err(Error::DeserializeFailed(msg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return Err(Error::DeserializeFailed(msg)); [INFO] [stdout] 56 + Err(Error::DeserializeFailed(msg)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cache/mod.rs:44:23 [INFO] [stdout] | [INFO] [stdout] 44 | let msg = format!("Cache expired or not found"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Cache expired or not found".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/translators/dictionaryapi.rs:52:37 [INFO] [stdout] | [INFO] [stdout] 52 | ... phonetic_str.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `phonetic_str.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/dyer.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | c + &self + COLOR_END [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/env_loader.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | if value.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/env_loader.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | return if value.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/utils/env_loader.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if let None = dotenvy::from_path(&file_path).ok() { [INFO] [stdout] | -------^^^^-------------------------------------- help: try: `if dotenvy::from_path(&file_path).ok().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/env_loader.rs:60:38 [INFO] [stdout] | [INFO] [stdout] 60 | if let None = dotenvy::from_path(&file_path).ok() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/env_loader.rs:72:16 [INFO] [stdout] | [INFO] [stdout] 72 | if value.trim().len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/file.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return true; [INFO] [stdout] 26 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/file.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return false; [INFO] [stdout] 30 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/file.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return false; [INFO] [stdout] 35 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/utils/file.rs:53:16 [INFO] [stdout] | [INFO] [stdout] 53 | if let Ok(_) = file.read_to_string(&mut content) { [INFO] [stdout] | -------^^^^^------------------------------------ help: try: `if file.read_to_string(&mut content).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/utils/file.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | / for pth in paths { [INFO] [stdout] 87 | | if let Ok(de) = pth { [INFO] [stdout] 88 | | if de.path().is_dir() { [INFO] [stdout] 89 | | debug!("{:?} is a directory.", de.path()); [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/utils/file.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | / if let Ok(de) = pth { [INFO] [stdout] 88 | | if de.path().is_dir() { [INFO] [stdout] 89 | | debug!("{:?} is a directory.", de.path()); [INFO] [stdout] 90 | | continue [INFO] [stdout] ... | [INFO] [stdout] 95 | | sum += 1; [INFO] [stdout] 96 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 86 ~ for de in paths.flatten() { [INFO] [stdout] 87 + if de.path().is_dir() { [INFO] [stdout] 88 + debug!("{:?} is a directory.", de.path()); [INFO] [stdout] 89 + continue [INFO] [stdout] 90 + } [INFO] [stdout] 91 + if f(de) { [INFO] [stdout] 92 + success += 1; [INFO] [stdout] 93 + } [INFO] [stdout] 94 + sum += 1; [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/utils/env_loader.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | let paths = vec![ [INFO] [stdout] | _________________^ [INFO] [stdout] 43 | | env::current_dir().unwrap().join(file_name), [INFO] [stdout] 44 | | home::home_dir().unwrap().join(file_name), [INFO] [stdout] 45 | | home::home_dir() [INFO] [stdout] ... | [INFO] [stdout] 53 | | .join(file_name), [INFO] [stdout] 54 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 42 ~ let paths = [env::current_dir().unwrap().join(file_name), [INFO] [stdout] 43 + home::home_dir().unwrap().join(file_name), [INFO] [stdout] 44 + home::home_dir() [INFO] [stdout] 45 + .unwrap() [INFO] [stdout] 46 + .join(".config/runslate") [INFO] [stdout] 47 + .join(file_name), [INFO] [stdout] 48 + env::current_exe() [INFO] [stdout] 49 + .unwrap() [INFO] [stdout] 50 + .parent() [INFO] [stdout] 51 + .ok_or(Error::FileNotExist("current exe parent".to_string()))? [INFO] [stdout] 52 ~ .join(file_name)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `sentences.get(0)` [INFO] [stdout] --> src/translators/google.rs:62:52 [INFO] [stdout] | [INFO] [stdout] 62 | if let Some(Value::Object(sentence)) = sentences.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `sentences.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/translators/google.rs:78:49 [INFO] [stdout] | [INFO] [stdout] 78 | for (idx, entry) in entries.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/translators/youdao.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | / if let Value::Array(phrases) = v { [INFO] [stdout] 91 | | let mut original_phrase = String::new(); [INFO] [stdout] 92 | | for phrase in phrases { [INFO] [stdout] 93 | | original_phrase.push_str(&phrase.to_string()); [INFO] [stdout] 94 | | } [INFO] [stdout] 95 | | println!("{}", original_phrase.dye(Colors::BrightBlack)); [INFO] [stdout] 96 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/translators/youdao.rs:89:25 [INFO] [stdout] | [INFO] [stdout] 89 | if let Some(v) = response.get("returnPhrase") { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 90 | if let Value::Array(phrases) = v { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/translators/youdao.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | / if let Value::Array(phrases) = v { [INFO] [stdout] 103 | | let mut original_phrase = String::new(); [INFO] [stdout] 104 | | for phrase in phrases { [INFO] [stdout] 105 | | original_phrase.push_str(&phrase.to_string()); [INFO] [stdout] 106 | | } [INFO] [stdout] 107 | | println!("{}", original_phrase.dye(Colors::BrightWhite)); [INFO] [stdout] 108 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/translators/youdao.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | if let Some(v) = response.get("translation") { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 102 | if let Value::Array(phrases) = v { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/translators/youdao.rs:121:16 [INFO] [stdout] | [INFO] [stdout] 121 | if phonetics.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!phonetics.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/translators/youdao.rs:177:33 [INFO] [stdout] | [INFO] [stdout] 177 | ... original_phrase.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `original_phrase.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/translators/youdao.rs:180:60 [INFO] [stdout] | [INFO] [stdout] 180 | ... for (idx, value) in values.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/translators/youdao.rs:184:45 [INFO] [stdout] | [INFO] [stdout] 184 | ... original_phrase.push_str("；") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `original_phrase.push('；')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/dyer.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | c + &self + COLOR_END [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/env_loader.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | if value.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/env_loader.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 30 | return if value.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/utils/env_loader.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if let None = dotenvy::from_path(&file_path).ok() { [INFO] [stdout] | -------^^^^-------------------------------------- help: try: `if dotenvy::from_path(&file_path).ok().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils/env_loader.rs:60:38 [INFO] [stdout] | [INFO] [stdout] 60 | if let None = dotenvy::from_path(&file_path).ok() { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/env_loader.rs:72:16 [INFO] [stdout] | [INFO] [stdout] 72 | if value.trim().len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/file.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return true; [INFO] [stdout] 26 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/file.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return false; [INFO] [stdout] 30 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/file.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return false; [INFO] [stdout] 35 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/utils/file.rs:53:16 [INFO] [stdout] | [INFO] [stdout] 53 | if let Ok(_) = file.read_to_string(&mut content) { [INFO] [stdout] | -------^^^^^------------------------------------ help: try: `if file.read_to_string(&mut content).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/utils/file.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | / for pth in paths { [INFO] [stdout] 87 | | if let Ok(de) = pth { [INFO] [stdout] 88 | | if de.path().is_dir() { [INFO] [stdout] 89 | | debug!("{:?} is a directory.", de.path()); [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/utils/file.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | / if let Ok(de) = pth { [INFO] [stdout] 88 | | if de.path().is_dir() { [INFO] [stdout] 89 | | debug!("{:?} is a directory.", de.path()); [INFO] [stdout] 90 | | continue [INFO] [stdout] ... | [INFO] [stdout] 95 | | sum += 1; [INFO] [stdout] 96 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 86 ~ for de in paths.flatten() { [INFO] [stdout] 87 + if de.path().is_dir() { [INFO] [stdout] 88 + debug!("{:?} is a directory.", de.path()); [INFO] [stdout] 89 + continue [INFO] [stdout] 90 + } [INFO] [stdout] 91 + if f(de) { [INFO] [stdout] 92 + success += 1; [INFO] [stdout] 93 + } [INFO] [stdout] 94 + sum += 1; [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/utils/env_loader.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | let paths = vec![ [INFO] [stdout] | _________________^ [INFO] [stdout] 43 | | env::current_dir().unwrap().join(file_name), [INFO] [stdout] 44 | | home::home_dir().unwrap().join(file_name), [INFO] [stdout] 45 | | home::home_dir() [INFO] [stdout] ... | [INFO] [stdout] 53 | | .join(file_name), [INFO] [stdout] 54 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 42 ~ let paths = [env::current_dir().unwrap().join(file_name), [INFO] [stdout] 43 + home::home_dir().unwrap().join(file_name), [INFO] [stdout] 44 + home::home_dir() [INFO] [stdout] 45 + .unwrap() [INFO] [stdout] 46 + .join(".config/runslate") [INFO] [stdout] 47 + .join(file_name), [INFO] [stdout] 48 + env::current_exe() [INFO] [stdout] 49 + .unwrap() [INFO] [stdout] 50 + .parent() [INFO] [stdout] 51 + .ok_or(Error::FileNotExist("current exe parent".to_string()))? [INFO] [stdout] 52 ~ .join(file_name)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 09s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.55 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 4` [INFO] running `Command { std: "docker" "inspect" "9d039a56e0901bd6bef864e0bb46c25ada436d94c60845e5945cb9fbedbde07b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d039a56e0901bd6bef864e0bb46c25ada436d94c60845e5945cb9fbedbde07b", kill_on_drop: false }` [INFO] [stdout] 9d039a56e0901bd6bef864e0bb46c25ada436d94c60845e5945cb9fbedbde07b