[INFO] cloning repository https://github.com/Modulus/RandomNamegenerator2 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Modulus/RandomNamegenerator2" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FModulus%2FRandomNamegenerator2", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FModulus%2FRandomNamegenerator2'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bb28194d6b92396e5fa792dbe6214bd50ff53f6d [INFO] linting Modulus/RandomNamegenerator2 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FModulus%2FRandomNamegenerator2" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Modulus/RandomNamegenerator2 [INFO] finished tweaking git repo https://github.com/Modulus/RandomNamegenerator2 [INFO] tweaked toml for git repo https://github.com/Modulus/RandomNamegenerator2 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Modulus/RandomNamegenerator2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Modulus/RandomNamegenerator2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded mockall v0.12.1 [INFO] [stderr] Downloaded mockall_derive v0.12.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e4fecb9aa36d8e575189e1a8cc061a3611c955bac810463b6180c1d7cde8550d [INFO] running `Command { std: "docker" "start" "-a" "e4fecb9aa36d8e575189e1a8cc061a3611c955bac810463b6180c1d7cde8550d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e4fecb9aa36d8e575189e1a8cc061a3611c955bac810463b6180c1d7cde8550d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4fecb9aa36d8e575189e1a8cc061a3611c955bac810463b6180c1d7cde8550d", kill_on_drop: false }` [INFO] [stdout] e4fecb9aa36d8e575189e1a8cc061a3611c955bac810463b6180c1d7cde8550d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7f67f9e27063c13582230ea5a0ec19155784810ed6014860e42b584e839a652 [INFO] running `Command { std: "docker" "start" "-a" "f7f67f9e27063c13582230ea5a0ec19155784810ed6014860e42b584e839a652", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Compiling mockall_derive v0.12.1 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking mockall v0.12.1 [INFO] [stderr] Checking backend v0.1.0 (/opt/rustwide/workdir/backend) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> backend/src/names/common.rs:34:89 [INFO] [stdout] | [INFO] [stdout] 34 | Self { first_name: String::from(first_name), sur_name: String::from(last_name), gender: gender } [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `gender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> backend/src/names/common.rs:34:89 [INFO] [stdout] | [INFO] [stdout] 34 | Self { first_name: String::from(first_name), sur_name: String::from(last_name), gender: gender } [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `gender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> backend/src/names/common.rs:57:74 [INFO] [stdout] | [INFO] [stdout] 57 | .map(|e| e.replace("\t", "").replace("\r", "").replace("\n", "")) [INFO] [stdout] | __________________________________________________________________________^ [INFO] [stdout] | |__________________________________________________________________________| [INFO] [stdout] 58 | || .map(String::from) [INFO] [stdout] | ||__________________________^ [INFO] [stdout] 59 | | .collect(); [INFO] [stdout] | |_________- help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> backend/src/names/common.rs:55:45 [INFO] [stdout] | [INFO] [stdout] 55 | let filtered_names: Vec = words.into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> backend/src/names/common.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | assert!(!element.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `element.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | return generate_male(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return generate_male(); [INFO] [stdout] 15 + generate_male() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | return generate_female(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return generate_female(); [INFO] [stdout] 18 + generate_female() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:24:25 [INFO] [stdout] | [INFO] [stdout] 24 | return generate_male(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return generate_male(); [INFO] [stdout] 24 + generate_male() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:27:25 [INFO] [stdout] | [INFO] [stdout] 27 | return generate_female(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return generate_female(); [INFO] [stdout] 27 + generate_female() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return common::get_random_element(&names); [INFO] [stdout] 58 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return common::get_random_element(&names); [INFO] [stdout] 64 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return common::get_random_element(&names); [INFO] [stdout] 70 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return common::get_random_element(&names); [INFO] [stdout] 76 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norsk.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | return generate_male(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return generate_male(); [INFO] [stdout] 16 + generate_male() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norsk.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | return generate_female(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return generate_female(); [INFO] [stdout] 19 + generate_female() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norsk.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return common::get_random_element(&names); [INFO] [stdout] 52 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norsk.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return common::get_random_element(&names); [INFO] [stdout] 58 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norsk.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return common::get_random_element(&names); [INFO] [stdout] 63 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/lib.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return RandomAnimalGenerator::generate(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return RandomAnimalGenerator::generate(); [INFO] [stdout] 13 + RandomAnimalGenerator::generate() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/lib.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | return RandomNynorskGenerator::generate(gender); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return RandomNynorskGenerator::generate(gender); [INFO] [stdout] 17 + RandomNynorskGenerator::generate(gender) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/lib.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return RandomNorseGenerator::generate(gender); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return RandomNorseGenerator::generate(gender); [INFO] [stdout] 21 + RandomNorseGenerator::generate(gender) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return RandomNorskGenerator::generate(gender); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return RandomNorskGenerator::generate(gender); [INFO] [stdout] 25 + RandomNorskGenerator::generate(gender) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> backend/src/names/common.rs:57:74 [INFO] [stdout] | [INFO] [stdout] 57 | .map(|e| e.replace("\t", "").replace("\r", "").replace("\n", "")) [INFO] [stdout] | __________________________________________________________________________^ [INFO] [stdout] | |__________________________________________________________________________| [INFO] [stdout] 58 | || .map(String::from) [INFO] [stdout] | ||__________________________^ [INFO] [stdout] 59 | | .collect(); [INFO] [stdout] | |_________- help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> backend/src/names/common.rs:55:45 [INFO] [stdout] | [INFO] [stdout] 55 | let filtered_names: Vec = words.into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | return generate_male(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return generate_male(); [INFO] [stdout] 15 + generate_male() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | return generate_female(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return generate_female(); [INFO] [stdout] 18 + generate_female() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:24:25 [INFO] [stdout] | [INFO] [stdout] 24 | return generate_male(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return generate_male(); [INFO] [stdout] 24 + generate_male() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:27:25 [INFO] [stdout] | [INFO] [stdout] 27 | return generate_female(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return generate_female(); [INFO] [stdout] 27 + generate_female() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return common::get_random_element(&names); [INFO] [stdout] 58 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return common::get_random_element(&names); [INFO] [stdout] 64 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return common::get_random_element(&names); [INFO] [stdout] 70 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norse.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return common::get_random_element(&names); [INFO] [stdout] 76 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norsk.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | return generate_male(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return generate_male(); [INFO] [stdout] 16 + generate_male() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norsk.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | return generate_female(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return generate_female(); [INFO] [stdout] 19 + generate_female() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norsk.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return common::get_random_element(&names); [INFO] [stdout] 52 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norsk.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return common::get_random_element(&names); [INFO] [stdout] 58 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/names/norsk.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return common::get_random_element(&names); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return common::get_random_element(&names); [INFO] [stdout] 63 + common::get_random_element(&names) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/lib.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return RandomAnimalGenerator::generate(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return RandomAnimalGenerator::generate(); [INFO] [stdout] 13 + RandomAnimalGenerator::generate() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/lib.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | return RandomNynorskGenerator::generate(gender); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return RandomNynorskGenerator::generate(gender); [INFO] [stdout] 17 + RandomNynorskGenerator::generate(gender) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/lib.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return RandomNorseGenerator::generate(gender); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return RandomNorseGenerator::generate(gender); [INFO] [stdout] 21 + RandomNorseGenerator::generate(gender) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return RandomNorskGenerator::generate(gender); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return RandomNorskGenerator::generate(gender); [INFO] [stdout] 25 + RandomNorskGenerator::generate(gender) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking frontend v0.1.0 (/opt/rustwide/workdir/frontend) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/tests/names/test_animal.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return animal; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return animal; [INFO] [stdout] 13 + animal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/tests/names/test_animal.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return adjectives; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return adjectives; [INFO] [stdout] 22 + adjectives [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> backend/tests/names/test_animal.rs:19:42 [INFO] [stdout] | [INFO] [stdout] 19 | .filter(|e| !e.contains("adjective")) [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 20 | | .map(String::from).collect(); [INFO] [stdout] | |______________________^ help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> backend/tests/names/test_animal.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | assert!(animals.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!animals.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> backend/tests/names/test_animal.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | assert!(animals.contains(&r) == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!animals.contains(&r)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/tests/names/test_norse.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return animal; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return animal; [INFO] [stdout] 12 + animal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> backend/tests/names/test_norse.rs:9:35 [INFO] [stdout] | [INFO] [stdout] 9 | .map(| e |e.replace("\t", "")) [INFO] [stdout] | ___________________________________^ [INFO] [stdout] | |___________________________________| [INFO] [stdout] 10 | || .map(String::from) [INFO] [stdout] | ||______________________^ [INFO] [stdout] 11 | | .collect(); [INFO] [stdout] | |_____- help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> backend/tests/names/test_norse.rs:6:32 [INFO] [stdout] | [INFO] [stdout] 6 | let animal : Vec = include_str!("../../resources/norse_female.csv").split("\n") [INFO] [stdout] | ________________________________^ [INFO] [stdout] 7 | | .into_iter() [INFO] [stdout] | |________________^ help: consider removing `.into_iter()`: `include_str!("../../resources/norse_female.csv").split("\n")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/tests/names/test_norse.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return animal [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return animal [INFO] [stdout] 22 + animal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> backend/tests/names/test_norse.rs:19:35 [INFO] [stdout] | [INFO] [stdout] 19 | .map(| e |e.replace("\t", "")) [INFO] [stdout] | ___________________________________^ [INFO] [stdout] | |___________________________________| [INFO] [stdout] 20 | || .map(String::from) [INFO] [stdout] | ||______________________^ [INFO] [stdout] 21 | | .collect(); [INFO] [stdout] | |_____- help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> backend/tests/names/test_norse.rs:16:32 [INFO] [stdout] | [INFO] [stdout] 16 | let animal : Vec = include_str!("../../resources/norse_male.csv").split("\n") [INFO] [stdout] | ________________________________^ [INFO] [stdout] 17 | | .into_iter() [INFO] [stdout] | |________________^ help: consider removing `.into_iter()`: `include_str!("../../resources/norse_male.csv").split("\n")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/tests/names/test_norse.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return animal; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return animal; [INFO] [stdout] 33 + animal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> backend/tests/names/test_norse.rs:29:35 [INFO] [stdout] | [INFO] [stdout] 29 | .map(| e |e.replace("\t", "")) [INFO] [stdout] | ___________________________________^ [INFO] [stdout] | |___________________________________| [INFO] [stdout] 30 | || .map(String::from) [INFO] [stdout] | ||______________________^ [INFO] [stdout] 31 | | [INFO] [stdout] 32 | | .collect(); [INFO] [stdout] | |_____- help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/tests/names/test_norse.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return animal; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return animal; [INFO] [stdout] 42 + animal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> backend/tests/names/test_norse.rs:40:35 [INFO] [stdout] | [INFO] [stdout] 40 | .map(| e |e.replace("\t", "")) [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 41 | | .map(String::from).collect(); [INFO] [stdout] | |______________________^ help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> backend/tests/names/test_norse.rs:37:32 [INFO] [stdout] | [INFO] [stdout] 37 | let animal : Vec = include_str!("../../resources/norse_male_last.csv").split("\n") [INFO] [stdout] | ________________________________^ [INFO] [stdout] 38 | | .into_iter() [INFO] [stdout] | |________________^ help: consider removing `.into_iter()`: `include_str!("../../resources/norse_male_last.csv").split("\n")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/tests/names/test_nynorsk.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return combine_vectors(part1, part2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return combine_vectors(part1, part2); [INFO] [stdout] 14 + combine_vectors(part1, part2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/tests/names/test_nynorsk.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return all.into_iter().map(| e | e.replace("\r", "")).map(| e | e.replace("\t", "")).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return all.into_iter().map(| e | e.replace("\r", "")).map(| e | e.replace("\t", "")).collect(); [INFO] [stdout] 29 + all.into_iter().map(| e | e.replace("\r", "")).map(| e | e.replace("\t", "")).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/tests/names/test_nynorsk.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return combine_vectors(part1, part2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return combine_vectors(part1, part2); [INFO] [stdout] 36 + combine_vectors(part1, part2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/tests/names/test_nynorsk.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return combine_vectors(part1, part2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return combine_vectors(part1, part2); [INFO] [stdout] 43 + combine_vectors(part1, part2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> backend/tests/names/test_nynorsk.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | assert!(name.is_empty() == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> backend/tests/names/test_nynorsk.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 99 | assert!(name.is_empty() == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> backend/tests/names/test_nynorsk.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | assert!(name.is_empty() == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/tests/names/test_norsk.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return animal; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return animal; [INFO] [stdout] 12 + animal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> backend/tests/names/test_norsk.rs:9:36 [INFO] [stdout] | [INFO] [stdout] 9 | .map(| e | e.replace("\t", "")) [INFO] [stdout] | ____________________________________^ [INFO] [stdout] | |____________________________________| [INFO] [stdout] 10 | || .map(String::from) [INFO] [stdout] | ||______________________^ [INFO] [stdout] 11 | | .collect(); [INFO] [stdout] | |_____- help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Split<'_, &str>` [INFO] [stdout] --> backend/tests/names/test_norsk.rs:6:32 [INFO] [stdout] | [INFO] [stdout] 6 | let animal : Vec = include_str!("../../resources/norwegian_girls.csv").split("\n") [INFO] [stdout] | ________________________________^ [INFO] [stdout] 7 | | .into_iter() [INFO] [stdout] | |________________^ help: consider removing `.into_iter()`: `include_str!("../../resources/norwegian_girls.csv").split("\n")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/tests/names/test_norsk.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return animal; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return animal; [INFO] [stdout] 22 + animal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> backend/tests/names/test_norsk.rs:19:36 [INFO] [stdout] | [INFO] [stdout] 19 | .map(| e | e.replace("\t", "")) [INFO] [stdout] | ____________________________________^ [INFO] [stdout] | |____________________________________| [INFO] [stdout] 20 | || .map(String::from) [INFO] [stdout] | ||______________________^ [INFO] [stdout] 21 | | .collect(); [INFO] [stdout] | |_____- help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> backend/tests/names/test_norsk.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return animal; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return animal; [INFO] [stdout] 31 + animal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> backend/tests/names/test_norsk.rs:28:36 [INFO] [stdout] | [INFO] [stdout] 28 | .map(| e | e.replace("\t", "")) [INFO] [stdout] | ____________________________________^ [INFO] [stdout] | |____________________________________| [INFO] [stdout] 29 | || .map(String::from) [INFO] [stdout] | ||______________________^ [INFO] [stdout] 30 | | .collect(); [INFO] [stdout] | |_____- help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.18s [INFO] running `Command { std: "docker" "inspect" "f7f67f9e27063c13582230ea5a0ec19155784810ed6014860e42b584e839a652", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7f67f9e27063c13582230ea5a0ec19155784810ed6014860e42b584e839a652", kill_on_drop: false }` [INFO] [stdout] f7f67f9e27063c13582230ea5a0ec19155784810ed6014860e42b584e839a652