[INFO] cloning repository https://github.com/MobitoHitako/cli_todo-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MobitoHitako/cli_todo-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMobitoHitako%2Fcli_todo-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMobitoHitako%2Fcli_todo-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c2a174ce183b1d608dc908d38f095effdf8040df [INFO] linting MobitoHitako/cli_todo-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMobitoHitako%2Fcli_todo-rust" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MobitoHitako/cli_todo-rust [INFO] finished tweaking git repo https://github.com/MobitoHitako/cli_todo-rust [INFO] tweaked toml for git repo https://github.com/MobitoHitako/cli_todo-rust written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MobitoHitako/cli_todo-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MobitoHitako/cli_todo-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 19212079804a620af955a62eb85e8f522cb7127f51bc01528c8a9f2ccb313b20 [INFO] running `Command { std: "docker" "start" "-a" "19212079804a620af955a62eb85e8f522cb7127f51bc01528c8a9f2ccb313b20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "19212079804a620af955a62eb85e8f522cb7127f51bc01528c8a9f2ccb313b20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19212079804a620af955a62eb85e8f522cb7127f51bc01528c8a9f2ccb313b20", kill_on_drop: false }` [INFO] [stdout] 19212079804a620af955a62eb85e8f522cb7127f51bc01528c8a9f2ccb313b20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 40db91e5cf17907a661d4a5c29420ddbb664a11b8e5777d9c605ebd518a53477 [INFO] running `Command { std: "docker" "start" "-a" "40db91e5cf17907a661d4a5c29420ddbb664a11b8e5777d9c605ebd518a53477", kill_on_drop: false }` [INFO] [stderr] Checking cli_todoapp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: name `TODO` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | struct TODO { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Todo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:19:31 [INFO] [stdout] | [INFO] [stdout] 19 | fn add(&mut self, inputs: &Vec<&str>) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn add(&mut self, inputs: &Vec<&str>) { [INFO] [stdout] 19 + fn add(&mut self, inputs: &[&str]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:59:24 [INFO] [stdout] | [INFO] [stdout] 59 | if !(id >= self.todo_list.len()) || (!id == self.todo_list.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(id < self.todo_list.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | / match is_parsable { [INFO] [stdout] 58 | | Some(id) => { [INFO] [stdout] 59 | | if !(id >= self.todo_list.len()) || (!id == self.todo_list.len()) { [INFO] [stdout] 60 | | println!("removing: {:?} at index: {}!", self.todo_list.get(id).unwrap(), id); [INFO] [stdout] ... | [INFO] [stdout] 65 | | None => {} [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 ~ if let Some(id) = is_parsable { [INFO] [stdout] 58 + if !(id >= self.todo_list.len()) || (!id == self.todo_list.len()) { [INFO] [stdout] 59 + println!("removing: {:?} at index: {}!", self.todo_list.get(id).unwrap(), id); [INFO] [stdout] 60 + self.todo_list.remove(id); [INFO] [stdout] 61 + self.amount -= 1; [INFO] [stdout] 62 + } else { println!("Cannot Remove, because ID is higher/Equal or in the minus") } [INFO] [stdout] 63 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:89:23 [INFO] [stdout] | [INFO] [stdout] 89 | let binding = String::from(input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TODO` contains a capitalized acronym [INFO] [stdout] --> src/main.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | struct TODO { [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Todo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:19:31 [INFO] [stdout] | [INFO] [stdout] 19 | fn add(&mut self, inputs: &Vec<&str>) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 19 - fn add(&mut self, inputs: &Vec<&str>) { [INFO] [stdout] 19 + fn add(&mut self, inputs: &[&str]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:59:24 [INFO] [stdout] | [INFO] [stdout] 59 | if !(id >= self.todo_list.len()) || (!id == self.todo_list.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(id < self.todo_list.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | / match is_parsable { [INFO] [stdout] 58 | | Some(id) => { [INFO] [stdout] 59 | | if !(id >= self.todo_list.len()) || (!id == self.todo_list.len()) { [INFO] [stdout] 60 | | println!("removing: {:?} at index: {}!", self.todo_list.get(id).unwrap(), id); [INFO] [stdout] ... | [INFO] [stdout] 65 | | None => {} [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 ~ if let Some(id) = is_parsable { [INFO] [stdout] 58 + if !(id >= self.todo_list.len()) || (!id == self.todo_list.len()) { [INFO] [stdout] 59 + println!("removing: {:?} at index: {}!", self.todo_list.get(id).unwrap(), id); [INFO] [stdout] 60 + self.todo_list.remove(id); [INFO] [stdout] 61 + self.amount -= 1; [INFO] [stdout] 62 + } else { println!("Cannot Remove, because ID is higher/Equal or in the minus") } [INFO] [stdout] 63 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:89:23 [INFO] [stdout] | [INFO] [stdout] 89 | let binding = String::from(input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s [INFO] running `Command { std: "docker" "inspect" "40db91e5cf17907a661d4a5c29420ddbb664a11b8e5777d9c605ebd518a53477", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "40db91e5cf17907a661d4a5c29420ddbb664a11b8e5777d9c605ebd518a53477", kill_on_drop: false }` [INFO] [stdout] 40db91e5cf17907a661d4a5c29420ddbb664a11b8e5777d9c605ebd518a53477