[INFO] cloning repository https://github.com/MisterFuntikov/rust_adventofcode_2025 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MisterFuntikov/rust_adventofcode_2025" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMisterFuntikov%2Frust_adventofcode_2025", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMisterFuntikov%2Frust_adventofcode_2025'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e6cb63965705ccd255bc753b446cab5cfd009601 [INFO] linting MisterFuntikov/rust_adventofcode_2025 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMisterFuntikov%2Frust_adventofcode_2025" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MisterFuntikov/rust_adventofcode_2025 [INFO] finished tweaking git repo https://github.com/MisterFuntikov/rust_adventofcode_2025 [INFO] tweaked toml for git repo https://github.com/MisterFuntikov/rust_adventofcode_2025 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MisterFuntikov/rust_adventofcode_2025 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MisterFuntikov/rust_adventofcode_2025 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c11214164c5f0279fb2c757805a9962837e3d3ea2ce82f80eb3632bb586625c3 [INFO] running `Command { std: "docker" "start" "-a" "c11214164c5f0279fb2c757805a9962837e3d3ea2ce82f80eb3632bb586625c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c11214164c5f0279fb2c757805a9962837e3d3ea2ce82f80eb3632bb586625c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c11214164c5f0279fb2c757805a9962837e3d3ea2ce82f80eb3632bb586625c3", kill_on_drop: false }` [INFO] [stdout] c11214164c5f0279fb2c757805a9962837e3d3ea2ce82f80eb3632bb586625c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7bf9cfcaba7e64aa22a87d8ace7482664363c92b83ff4afca4862dae4662cefd [INFO] running `Command { std: "docker" "start" "-a" "7bf9cfcaba7e64aa22a87d8ace7482664363c92b83ff4afca4862dae4662cefd", kill_on_drop: false }` [INFO] [stderr] Checking rust_adventofcode_2025 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/day9.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | a: a, [INFO] [stdout] | ^^^^ help: replace it with: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/day9.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | y1: y1, [INFO] [stdout] | ^^^^^^ help: replace it with: `y1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/day9.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | y2: y2, [INFO] [stdout] | ^^^^^^ help: replace it with: `y2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/day9.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | x1: x1, [INFO] [stdout] | ^^^^^^ help: replace it with: `x1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/day9.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | x2: x2, [INFO] [stdout] | ^^^^^^ help: replace it with: `x2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/day9.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | a: a, [INFO] [stdout] | ^^^^ help: replace it with: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/day9.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | y1: y1, [INFO] [stdout] | ^^^^^^ help: replace it with: `y1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/day9.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | y2: y2, [INFO] [stdout] | ^^^^^^ help: replace it with: `y2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/day9.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | x1: x1, [INFO] [stdout] | ^^^^^^ help: replace it with: `x1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/day9.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | x2: x2, [INFO] [stdout] | ^^^^^^ help: replace it with: `x2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/day1.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | pos -= line[1..].trim().parse::().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/day1.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | if line.starts_with('L') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 10 ~ if let Some() = line.strip_prefix('L') { [INFO] [stdout] 11 | let mut has_zero = pos == 0; [INFO] [stdout] 12 ~ pos -= .trim().parse::().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day10.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | state = state ^ ml.buttons[pos]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state ^= ml.buttons[pos]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day10.rs:15:34 [INFO] [stdout] | [INFO] [stdout] 15 | best = part1(&ml, best, i, state, cur + 1); [INFO] [stdout] | ^^^ help: change this to: `ml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `state` [INFO] [stdout] --> src/day10.rs:58:22 [INFO] [stdout] | [INFO] [stdout] 58 | for i in 0..state.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 58 - for i in 0..state.len() { [INFO] [stdout] 58 + for (i, ) in state.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `state` [INFO] [stdout] --> src/day10.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | for i in 0..state.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 73 - for i in 0..state.len() { [INFO] [stdout] 73 + for (i, ) in state.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/day11.rs:49:38 [INFO] [stdout] | [INFO] [stdout] 49 | let next: Vec = rest.trim().split_whitespace().map(String::from).collect(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `lines` [INFO] [stdout] --> src/day12.rs:21:14 [INFO] [stdout] | [INFO] [stdout] 21 | for i in 0..6 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 21 - for i in 0..6 { [INFO] [stdout] 21 + for in lines.iter().take(6) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `presents` [INFO] [stdout] --> src/day12.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for i in 0..presents.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 50 - for i in 0..presents.len() { [INFO] [stdout] 50 + for (i, ) in presents.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | fn helper(data: &Vec>, i: usize, j: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - fn helper(data: &Vec>, i: usize, j: usize) -> bool { [INFO] [stdout] 1 + fn helper(data: &[Vec], i: usize, j: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/day5.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | fn helper(data: &mut Vec<[u64; 2]>, checki: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - fn helper(data: &mut Vec<[u64; 2]>, checki: usize) -> bool { [INFO] [stdout] 1 + fn helper(data: &mut [[u64; 2]], checki: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `data` [INFO] [stdout] --> src/day5.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | for i in 0..data.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 3 - for i in 0..data.len() { [INFO] [stdout] 3 + for (i, ) in data.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day6.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | fn helper(data: &Vec>, i: usize, ans: u64, value: &str) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - fn helper(data: &Vec>, i: usize, ans: u64, value: &str) -> u64 { [INFO] [stdout] 1 + fn helper(data: &[Vec<&str>], i: usize, ans: u64, value: &str) -> u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DSU` contains a capitalized acronym [INFO] [stdout] --> src/day8.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | struct DSU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Dsu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/day1.rs:12:20 [INFO] [stdout] | [INFO] [stdout] 12 | pos -= line[1..].trim().parse::().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/day1.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | if line.starts_with('L') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 10 ~ if let Some() = line.strip_prefix('L') { [INFO] [stdout] 11 | let mut has_zero = pos == 0; [INFO] [stdout] 12 ~ pos -= .trim().parse::().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/day10.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | state = state ^ ml.buttons[pos]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state ^= ml.buttons[pos]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day10.rs:15:34 [INFO] [stdout] | [INFO] [stdout] 15 | best = part1(&ml, best, i, state, cur + 1); [INFO] [stdout] | ^^^ help: change this to: `ml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `state` [INFO] [stdout] --> src/day10.rs:58:22 [INFO] [stdout] | [INFO] [stdout] 58 | for i in 0..state.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 58 - for i in 0..state.len() { [INFO] [stdout] 58 + for (i, ) in state.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `state` [INFO] [stdout] --> src/day10.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | for i in 0..state.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 73 - for i in 0..state.len() { [INFO] [stdout] 73 + for (i, ) in state.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day9.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | if (s.is_vertical && p.x == s.a.x && p.y >= s.y1 && p.y <= s.y2) [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | || (!s.is_vertical || p.y == s.a.y && p.x >= s.x1 && p.x <= s.x2) [INFO] [stdout] | |_____________________________________________________________________________^ help: try: `!s.is_vertical || p.x == s.a.x && p.y >= s.y1 && p.y <= s.y2 || p.y == s.a.y && p.x >= s.x1 && p.x <= s.x2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/day11.rs:49:38 [INFO] [stdout] | [INFO] [stdout] 49 | let next: Vec = rest.trim().split_whitespace().map(String::from).collect(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `lines` [INFO] [stdout] --> src/day12.rs:21:14 [INFO] [stdout] | [INFO] [stdout] 21 | for i in 0..6 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 21 - for i in 0..6 { [INFO] [stdout] 21 + for in lines.iter().take(6) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `presents` [INFO] [stdout] --> src/day12.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | for i in 0..presents.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 50 - for i in 0..presents.len() { [INFO] [stdout] 50 + for (i, ) in presents.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | fn helper(data: &Vec>, i: usize, j: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - fn helper(data: &Vec>, i: usize, j: usize) -> bool { [INFO] [stdout] 1 + fn helper(data: &[Vec], i: usize, j: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/day5.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | fn helper(data: &mut Vec<[u64; 2]>, checki: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - fn helper(data: &mut Vec<[u64; 2]>, checki: usize) -> bool { [INFO] [stdout] 1 + fn helper(data: &mut [[u64; 2]], checki: usize) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `data` [INFO] [stdout] --> src/day5.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | for i in 0..data.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 3 - for i in 0..data.len() { [INFO] [stdout] 3 + for (i, ) in data.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day6.rs:1:17 [INFO] [stdout] | [INFO] [stdout] 1 | fn helper(data: &Vec>, i: usize, ans: u64, value: &str) -> u64 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - fn helper(data: &Vec>, i: usize, ans: u64, value: &str) -> u64 { [INFO] [stdout] 1 + fn helper(data: &[Vec<&str>], i: usize, ans: u64, value: &str) -> u64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DSU` contains a capitalized acronym [INFO] [stdout] --> src/day8.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | struct DSU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Dsu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day9.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | if (s.is_vertical && p.x == s.a.x && p.y >= s.y1 && p.y <= s.y2) [INFO] [stdout] | ____________^ [INFO] [stdout] 37 | | || (!s.is_vertical || p.y == s.a.y && p.x >= s.x1 && p.x <= s.x2) [INFO] [stdout] | |_____________________________________________________________________________^ help: try: `!s.is_vertical || p.x == s.a.x && p.y >= s.y1 && p.y <= s.y2 || p.y == s.a.y && p.x >= s.x1 && p.x <= s.x2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.38s [INFO] running `Command { std: "docker" "inspect" "7bf9cfcaba7e64aa22a87d8ace7482664363c92b83ff4afca4862dae4662cefd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7bf9cfcaba7e64aa22a87d8ace7482664363c92b83ff4afca4862dae4662cefd", kill_on_drop: false }` [INFO] [stdout] 7bf9cfcaba7e64aa22a87d8ace7482664363c92b83ff4afca4862dae4662cefd