[INFO] cloning repository https://github.com/Mikaio/projector-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Mikaio/projector-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMikaio%2Fprojector-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMikaio%2Fprojector-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] de64ccb2d1baa34ae1945deda8c959033073e59d [INFO] linting Mikaio/projector-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMikaio%2Fprojector-rs" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Mikaio/projector-rs [INFO] finished tweaking git repo https://github.com/Mikaio/projector-rs [INFO] tweaked toml for git repo https://github.com/Mikaio/projector-rs written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Mikaio/projector-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Mikaio/projector-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded collection_macros v0.2.0 [INFO] [stderr] Downloaded is-terminal v0.4.7 [INFO] [stderr] Downloaded clap v4.3.8 [INFO] [stderr] Downloaded clap_builder v4.3.8 [INFO] [stderr] Downloaded rustix v0.37.20 [INFO] [stderr] Downloaded libc v0.2.146 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3372245fd11127f762ff47ceef3c2763fe0fcfaaf7235b55ecbd0e350e0158e0 [INFO] running `Command { std: "docker" "start" "-a" "3372245fd11127f762ff47ceef3c2763fe0fcfaaf7235b55ecbd0e350e0158e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3372245fd11127f762ff47ceef3c2763fe0fcfaaf7235b55ecbd0e350e0158e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3372245fd11127f762ff47ceef3c2763fe0fcfaaf7235b55ecbd0e350e0158e0", kill_on_drop: false }` [INFO] [stdout] 3372245fd11127f762ff47ceef3c2763fe0fcfaaf7235b55ecbd0e350e0158e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7cb44589e3def8ca4c9b41b42f8e9160f27c991abc4fd2e765d2942830559b9d [INFO] running `Command { std: "docker" "start" "-a" "7cb44589e3def8ca4c9b41b42f8e9160f27c991abc4fd2e765d2942830559b9d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling rustix v0.37.20 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Compiling serde_json v1.0.103 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking collection_macros v0.2.0 [INFO] [stderr] Compiling syn v2.0.26 [INFO] [stderr] Checking is-terminal v0.4.7 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.8 [INFO] [stderr] Compiling serde_derive v1.0.171 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Checking clap v4.3.8 [INFO] [stderr] Checking serde v1.0.171 [INFO] [stderr] Checking projector-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / return Ok(Config { [INFO] [stdout] 22 | | operation, [INFO] [stdout] 23 | | pwd, [INFO] [stdout] 24 | | config, [INFO] [stdout] 25 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Ok(Config { [INFO] [stdout] 22 + operation, [INFO] [stdout] 23 + pwd, [INFO] [stdout] 24 + config, [INFO] [stdout] 25 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return Ok(Operation::Print(arg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return Ok(Operation::Print(arg)); [INFO] [stdout] 85 + Ok(Operation::Print(arg)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/config.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if value.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `value.get(0)` [INFO] [stdout] --> src/config.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 45 | let term = value.get(0).expect("to exist"); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | return Ok(loc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return Ok(loc); [INFO] [stdout] 100 + Ok(loc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | return Ok(std::env::current_dir().context("errored getting current dir")?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - return Ok(std::env::current_dir().context("errored getting current dir")?); [INFO] [stdout] 108 + Ok(std::env::current_dir().context("errored getting current dir")?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/config.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 108 | return Ok(std::env::current_dir().context("errored getting current dir")?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 108 - return Ok(std::env::current_dir().context("errored getting current dir")?); [INFO] [stdout] 108 + return std::env::current_dir().context("errored getting current dir"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return Ok(()); [INFO] [stdout] 130 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 146 - return Ok(()); [INFO] [stdout] 146 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return Ok(()); [INFO] [stdout] 164 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 181 - return Ok(()); [INFO] [stdout] 181 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / return Data { [INFO] [stdout] 20 | | projector: HashMap::new(), [INFO] [stdout] 21 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ Data { [INFO] [stdout] 20 + projector: HashMap::new(), [INFO] [stdout] 21 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return out; [INFO] [stdout] 39 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return out; [INFO] [stdout] 58 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projector.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 78 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&p).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return Ok(()); [INFO] [stdout] 86 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/projector.rs:78:35 [INFO] [stdout] | [INFO] [stdout] 78 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^ help: change this to: `p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | / return Projector { [INFO] [stdout] 100 | | config, [INFO] [stdout] 101 | | pwd, [INFO] [stdout] 102 | | data: default_data(), [INFO] [stdout] 103 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 ~ Projector { [INFO] [stdout] 100 + config, [INFO] [stdout] 101 + pwd, [INFO] [stdout] 102 + data: default_data(), [INFO] [stdout] 103 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | / return hashmap! { [INFO] [stdout] 117 | | PathBuf::from("/") => hashmap! { [INFO] [stdout] 118 | | "foo".into() => "bar1".into(), [INFO] [stdout] 119 | | "fm".into() => "is_good".into(), [INFO] [stdout] ... | [INFO] [stdout] 126 | | }, [INFO] [stdout] 127 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 116 ~ hashmap! { [INFO] [stdout] 117 + PathBuf::from("/") => hashmap! { [INFO] [stdout] 118 + "foo".into() => "bar1".into(), [INFO] [stdout] 119 + "fm".into() => "is_good".into(), [INFO] [stdout] 120 + }, [INFO] [stdout] 121 + PathBuf::from("/foo") => hashmap! { [INFO] [stdout] 122 + "foo".into() => "bar2".into(), [INFO] [stdout] 123 + }, [INFO] [stdout] 124 + PathBuf::from("/foo/bar") => hashmap!{ [INFO] [stdout] 125 + "foo".into() => "bar3".into(), [INFO] [stdout] 126 + }, [INFO] [stdout] 127 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | / return Projector { [INFO] [stdout] 132 | | config: PathBuf::from(""), [INFO] [stdout] 133 | | pwd, [INFO] [stdout] 134 | | data: Data { [INFO] [stdout] 135 | | projector: get_data(), [INFO] [stdout] 136 | | }, [INFO] [stdout] 137 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 ~ Projector { [INFO] [stdout] 132 + config: PathBuf::from(""), [INFO] [stdout] 133 + pwd, [INFO] [stdout] 134 + data: Data { [INFO] [stdout] 135 + projector: get_data(), [INFO] [stdout] 136 + }, [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / return Ok(Config { [INFO] [stdout] 22 | | operation, [INFO] [stdout] 23 | | pwd, [INFO] [stdout] 24 | | config, [INFO] [stdout] 25 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ Ok(Config { [INFO] [stdout] 22 + operation, [INFO] [stdout] 23 + pwd, [INFO] [stdout] 24 + config, [INFO] [stdout] 25 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return Ok(Operation::Print(arg)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return Ok(Operation::Print(arg)); [INFO] [stdout] 85 + Ok(Operation::Print(arg)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/config.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if value.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `value.get(0)` [INFO] [stdout] --> src/config.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 45 | let term = value.get(0).expect("to exist"); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | return Ok(loc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 100 - return Ok(loc); [INFO] [stdout] 100 + Ok(loc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | return Ok(std::env::current_dir().context("errored getting current dir")?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - return Ok(std::env::current_dir().context("errored getting current dir")?); [INFO] [stdout] 108 + Ok(std::env::current_dir().context("errored getting current dir")?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/config.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 108 | return Ok(std::env::current_dir().context("errored getting current dir")?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 108 - return Ok(std::env::current_dir().context("errored getting current dir")?); [INFO] [stdout] 108 + return std::env::current_dir().context("errored getting current dir"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / return Data { [INFO] [stdout] 20 | | projector: HashMap::new(), [INFO] [stdout] 21 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 ~ Data { [INFO] [stdout] 20 + projector: HashMap::new(), [INFO] [stdout] 21 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return out; [INFO] [stdout] 39 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return out; [INFO] [stdout] 58 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projector.rs:78:16 [INFO] [stdout] | [INFO] [stdout] 78 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&p).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return Ok(()); [INFO] [stdout] 86 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/projector.rs:78:35 [INFO] [stdout] | [INFO] [stdout] 78 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^ help: change this to: `p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | / return Projector { [INFO] [stdout] 100 | | config, [INFO] [stdout] 101 | | pwd, [INFO] [stdout] 102 | | data: default_data(), [INFO] [stdout] 103 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 ~ Projector { [INFO] [stdout] 100 + config, [INFO] [stdout] 101 + pwd, [INFO] [stdout] 102 + data: default_data(), [INFO] [stdout] 103 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/projector.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return Ok(()); [INFO] [stdout] 31 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/projector.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return Ok(()); [INFO] [stdout] 31 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bin/projector.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | / proj.get_value(&k).map(|x| { [INFO] [stdout] 18 | | println!("{}", x); [INFO] [stdout] 19 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 17 - proj.get_value(&k).map(|x| { [INFO] [stdout] 18 - println!("{}", x); [INFO] [stdout] 19 - }); [INFO] [stdout] 17 + if let Some(x) = proj.get_value(&k) { println!("{}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bin/projector.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | / proj.get_value(&k).map(|x| { [INFO] [stdout] 18 | | println!("{}", x); [INFO] [stdout] 19 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 17 - proj.get_value(&k).map(|x| { [INFO] [stdout] 18 - println!("{}", x); [INFO] [stdout] 19 - }); [INFO] [stdout] 17 + if let Some(x) = proj.get_value(&k) { println!("{}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.13s [INFO] running `Command { std: "docker" "inspect" "7cb44589e3def8ca4c9b41b42f8e9160f27c991abc4fd2e765d2942830559b9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7cb44589e3def8ca4c9b41b42f8e9160f27c991abc4fd2e765d2942830559b9d", kill_on_drop: false }` [INFO] [stdout] 7cb44589e3def8ca4c9b41b42f8e9160f27c991abc4fd2e765d2942830559b9d