[INFO] cloning repository https://github.com/MicheleCioccarelli/blob-dl [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MicheleCioccarelli/blob-dl" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMicheleCioccarelli%2Fblob-dl", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMicheleCioccarelli%2Fblob-dl'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b52af12c5383fa8519e7602db21759f68440d96f [INFO] linting MicheleCioccarelli/blob-dl against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMicheleCioccarelli%2Fblob-dl" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MicheleCioccarelli/blob-dl [INFO] finished tweaking git repo https://github.com/MicheleCioccarelli/blob-dl [INFO] tweaked toml for git repo https://github.com/MicheleCioccarelli/blob-dl written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MicheleCioccarelli/blob-dl on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MicheleCioccarelli/blob-dl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded execute-command-macro v0.1.9 [INFO] [stderr] Downloaded generic-array v1.2.0 [INFO] [stderr] Downloaded execute v0.2.13 [INFO] [stderr] Downloaded execute-command-macro-impl v0.1.10 [INFO] [stderr] Downloaded execute-command-tokens v0.1.7 [INFO] [stderr] Downloaded spinoff v0.8.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 522900e407cdc5d1ec97c21c5c732fe140817a8900259dc09cfa93079e96fb76 [INFO] running `Command { std: "docker" "start" "-a" "522900e407cdc5d1ec97c21c5c732fe140817a8900259dc09cfa93079e96fb76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "522900e407cdc5d1ec97c21c5c732fe140817a8900259dc09cfa93079e96fb76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "522900e407cdc5d1ec97c21c5c732fe140817a8900259dc09cfa93079e96fb76", kill_on_drop: false }` [INFO] [stdout] 522900e407cdc5d1ec97c21c5c732fe140817a8900259dc09cfa93079e96fb76 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c6099ba0919204c862fe76bd07e26cd0310d2ae5cfb7c8b396ddec864b51025f [INFO] running `Command { std: "docker" "start" "-a" "c6099ba0919204c862fe76bd07e26cd0310d2ae5cfb7c8b396ddec864b51025f", kill_on_drop: false }` [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Compiling rustix v1.0.5 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Compiling getrandom v0.3.2 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling execute-command-tokens v0.1.7 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking home v0.5.11 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking spinoff v0.8.0 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking clap_builder v4.5.37 [INFO] [stderr] Checking directories v6.0.0 [INFO] [stderr] Checking generic-array v1.2.0 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Checking tempfile v3.19.1 [INFO] [stderr] Checking dialoguer v0.10.4 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling execute-command-macro-impl v0.1.10 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking execute-command-macro v0.1.9 [INFO] [stderr] Checking execute v0.2.13 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking clap v4.5.37 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking blob-dl v1.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `Format` is never constructed [INFO] [stdout] --> src/assembling/youtube.rs:121:8 [INFO] [stdout] | [INFO] [stdout] 121 | struct Format { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Format` is never constructed [INFO] [stdout] --> src/assembling/youtube.rs:121:8 [INFO] [stdout] | [INFO] [stdout] 121 | struct Format { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembling/youtube/yt_playlist.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | if !which("ffmpeg").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `which("ffmpeg").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembling/youtube/yt_playlist.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | if !which("ffmpeg").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `which("ffmpeg").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembling/youtube/yt_video.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if !which("ffmpeg").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `which("ffmpeg").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/assembling/youtube/yt_video.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 34 | if !which("ffmpeg").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `which("ffmpeg").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/run.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 105 | let mut youtube_dl = command.stdout(Stdio::piped()) [INFO] [stdout] | __________________________^ [INFO] [stdout] 106 | | .stderr(Stdio::piped()) [INFO] [stdout] 107 | | .spawn() [INFO] [stdout] 108 | | .expect("Failed to start yt-dlp process"); // TODO Should take away this expect in a future release [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/run.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 105 | let mut youtube_dl = command.stdout(Stdio::piped()) [INFO] [stdout] | __________________________^ [INFO] [stdout] 106 | | .stderr(Stdio::piped()) [INFO] [stdout] 107 | | .spawn() [INFO] [stdout] 108 | | .expect("Failed to start yt-dlp process"); // TODO Should take away this expect in a future release [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider calling `.wait()` [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.21s [INFO] running `Command { std: "docker" "inspect" "c6099ba0919204c862fe76bd07e26cd0310d2ae5cfb7c8b396ddec864b51025f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6099ba0919204c862fe76bd07e26cd0310d2ae5cfb7c8b396ddec864b51025f", kill_on_drop: false }` [INFO] [stdout] c6099ba0919204c862fe76bd07e26cd0310d2ae5cfb7c8b396ddec864b51025f