[INFO] cloning repository https://github.com/MichaelLeith/cargo-tests [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MichaelLeith/cargo-tests" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMichaelLeith%2Fcargo-tests", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMichaelLeith%2Fcargo-tests'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6d0f0e97325c78daaf64870107feee3a20445ad6 [INFO] linting MichaelLeith/cargo-tests against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMichaelLeith%2Fcargo-tests" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MichaelLeith/cargo-tests [INFO] finished tweaking git repo https://github.com/MichaelLeith/cargo-tests [INFO] tweaked toml for git repo https://github.com/MichaelLeith/cargo-tests written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MichaelLeith/cargo-tests on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MichaelLeith/cargo-tests already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 94cf38631e3c8ad28de7ffd5f86413948b0625a57d4066f824ec2e2bdd20892d [INFO] running `Command { std: "docker" "start" "-a" "94cf38631e3c8ad28de7ffd5f86413948b0625a57d4066f824ec2e2bdd20892d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "94cf38631e3c8ad28de7ffd5f86413948b0625a57d4066f824ec2e2bdd20892d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94cf38631e3c8ad28de7ffd5f86413948b0625a57d4066f824ec2e2bdd20892d", kill_on_drop: false }` [INFO] [stdout] 94cf38631e3c8ad28de7ffd5f86413948b0625a57d4066f824ec2e2bdd20892d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d03d07e2d66a7586afea12a3fe456559998d2fcabb23e1b756d17034750c5d27 [INFO] running `Command { std: "docker" "start" "-a" "d03d07e2d66a7586afea12a3fe456559998d2fcabb23e1b756d17034750c5d27", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.88 [INFO] [stderr] Compiling serde v1.0.124 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking simple_logger v1.11.0 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking cargo-tests v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:137:8 [INFO] [stdout] | [INFO] [stdout] 137 | if !fs::metadata(&html).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&html).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:171:76 [INFO] [stdout] | [INFO] [stdout] 171 | && path.file_name().unwrap().to_str().unwrap().starts_with(&exec) { [INFO] [stdout] | ^^^^^ help: change this to: `exec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:184:40 [INFO] [stdout] | [INFO] [stdout] 184 | let file = std::fs::read_to_string(&path).expect("failed to read Cargo.toml"); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:137:8 [INFO] [stdout] | [INFO] [stdout] 137 | if !fs::metadata(&html).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&html).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:171:76 [INFO] [stdout] | [INFO] [stdout] 171 | && path.file_name().unwrap().to_str().unwrap().starts_with(&exec) { [INFO] [stdout] | ^^^^^ help: change this to: `exec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:184:40 [INFO] [stdout] | [INFO] [stdout] 184 | let file = std::fs::read_to_string(&path).expect("failed to read Cargo.toml"); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.73s [INFO] running `Command { std: "docker" "inspect" "d03d07e2d66a7586afea12a3fe456559998d2fcabb23e1b756d17034750c5d27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d03d07e2d66a7586afea12a3fe456559998d2fcabb23e1b756d17034750c5d27", kill_on_drop: false }` [INFO] [stdout] d03d07e2d66a7586afea12a3fe456559998d2fcabb23e1b756d17034750c5d27