[INFO] cloning repository https://github.com/MegaAntiCheat/client-backend [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MegaAntiCheat/client-backend" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMegaAntiCheat%2Fclient-backend", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMegaAntiCheat%2Fclient-backend'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b5dd75a01ad8b068568e9bb4d20a921624694735 [INFO] linting MegaAntiCheat/client-backend against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMegaAntiCheat%2Fclient-backend" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-7-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/MegaAntiCheat/client-backend [INFO] finished tweaking git repo https://github.com/MegaAntiCheat/client-backend [INFO] tweaked toml for git repo https://github.com/MegaAntiCheat/client-backend written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MegaAntiCheat/client-backend on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MegaAntiCheat/client-backend already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/MegaAntiCheat/rust-rcon` [INFO] [stderr] Updating git repository `https://github.com/saskenuba/SteamHelper-rs` [INFO] [stderr] Updating git submodule `https://github.com/SteamRE/SteamKit.git` [INFO] [stderr] Updating git submodule `https://github.com/steamdatabase/protobufs.git` [INFO] [stderr] Updating git repository `https://github.com/MegaAntiCheat/parser` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio-tungstenite v0.23.1 [INFO] [stderr] Downloaded tracing-appender v0.2.3 [INFO] [stderr] Downloaded num v0.3.1 [INFO] [stderr] Downloaded uuid v1.10.0 [INFO] [stderr] Downloaded steamid-ng v1.0.0 [INFO] [stderr] Downloaded tungstenite v0.23.0 [INFO] [stderr] Downloaded crc v3.2.1 [INFO] [stderr] Downloaded bitbuffer_derive v0.11.0 [INFO] [stderr] Downloaded anstyle-query v1.0.3 [INFO] [stderr] Downloaded include_dir_macros v0.7.4 [INFO] [stderr] Downloaded merge_derive v0.1.0 [INFO] [stderr] Downloaded protoc-rust v2.28.0 [INFO] [stderr] Downloaded include_dir v0.7.4 [INFO] [stderr] Downloaded is-docker v0.2.0 [INFO] [stderr] Downloaded substring v1.4.5 [INFO] [stderr] Downloaded protoc v2.28.0 [INFO] [stderr] Downloaded vswhom-sys v0.1.2 [INFO] [stderr] Downloaded is-wsl v0.4.0 [INFO] [stderr] Downloaded keyvalues-serde v0.2.1 [INFO] [stderr] Downloaded atomic-write-file v0.1.4 [INFO] [stderr] Downloaded pot v3.0.0 [INFO] [stderr] Downloaded clap v4.5.9 [INFO] [stderr] Downloaded hyper-util v0.1.6 [INFO] [stderr] Downloaded backtrace v0.3.72 [INFO] [stderr] Downloaded ico v0.3.0 [INFO] [stderr] Downloaded serde_with v1.14.0 [INFO] [stderr] Downloaded clap_builder v4.5.9 [INFO] [stderr] Downloaded hyper v1.4.1 [INFO] [stderr] Downloaded rustls-webpki v0.102.6 [INFO] [stderr] Downloaded reqwest v0.12.5 [INFO] [stderr] Downloaded protobuf v2.28.0 [INFO] [stderr] Downloaded serde_json v1.0.120 [INFO] [stderr] Downloaded object v0.35.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.84 [INFO] [stderr] Downloaded enum_dispatch v0.3.13 [INFO] [stderr] Downloaded protobuf-codegen v2.28.0 [INFO] [stderr] Downloaded bitbuffer v0.11.0 [INFO] [stderr] Downloaded num-complex v0.3.1 [INFO] [stderr] Downloaded clap_derive v4.5.8 [INFO] [stderr] Downloaded clap_lex v0.7.1 [INFO] [stderr] Downloaded embed-resource v2.4.2 [INFO] [stderr] Downloaded rustls v0.23.11 [INFO] [stderr] Downloaded open v5.3.0 [INFO] [stderr] Downloaded keyvalues-parser v0.2.0 [INFO] [stderr] Downloaded steamlocate v2.0.0-beta.2 [INFO] [stderr] Downloaded merge v0.1.0 [INFO] [stderr] Downloaded winreg v0.51.0 [INFO] [stderr] Downloaded serde_with_macros v1.5.2 [INFO] [stderr] Downloaded err-derive v0.3.1 [INFO] [stderr] Downloaded parse-display-derive v0.9.1 [INFO] [stderr] Downloaded main_error v0.1.2 [INFO] [stderr] Downloaded structmeta v0.3.0 [INFO] [stderr] Downloaded parse-display v0.9.1 [INFO] [stderr] Downloaded enum_primitive v0.1.1 [INFO] [stderr] Downloaded derive-new v0.5.9 [INFO] [stderr] Downloaded structmeta-derive v0.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 77d6cd9199b5663fb7846890ce0c953cef6b96d5414cef96b6831598bfcb5ac6 [INFO] running `Command { std: "docker" "start" "-a" "77d6cd9199b5663fb7846890ce0c953cef6b96d5414cef96b6831598bfcb5ac6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "77d6cd9199b5663fb7846890ce0c953cef6b96d5414cef96b6831598bfcb5ac6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77d6cd9199b5663fb7846890ce0c953cef6b96d5414cef96b6831598bfcb5ac6", kill_on_drop: false }` [INFO] [stdout] 77d6cd9199b5663fb7846890ce0c953cef6b96d5414cef96b6831598bfcb5ac6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b5363b5160d95a5053308f284976df07cb110e72f67a2b77b9dfbe0f3f717aa [INFO] running `Command { std: "docker" "start" "-a" "0b5363b5160d95a5053308f284976df07cb110e72f67a2b77b9dfbe0f3f717aa", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.84 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking once_cell v1.20.3 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling protobuf v2.28.0 [INFO] [stderr] Compiling simd-adler32 v0.3.7 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling toml_datetime v0.6.6 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling num-bigint v0.3.3 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Compiling miniz_oxide v0.7.3 [INFO] [stderr] Compiling crc32fast v1.4.2 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Compiling serde_spanned v0.6.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling winnow v0.6.13 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling merge_derive v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling pest v2.7.10 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling structmeta-derive v0.3.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling toml_edit v0.22.14 [INFO] [stderr] Compiling structmeta v0.3.0 [INFO] [stderr] Compiling pest_meta v2.7.10 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling pest_generator v2.7.10 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling flate2 v1.0.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking protoc v2.28.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling fdeflate v0.3.4 [INFO] [stderr] Compiling err-derive v0.3.1 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling unicode-xid v0.2.4 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Compiling png v0.17.13 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling merge v0.1.0 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Compiling pest_derive v2.7.10 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Compiling toml v0.8.14 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Compiling backtrace v0.3.72 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Compiling ico v0.3.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking num v0.3.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Compiling parse-display-derive v0.9.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Compiling embed-resource v2.4.2 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling serde_with_macros v1.5.2 [INFO] [stderr] Compiling num_enum_derive v0.7.2 [INFO] [stderr] Checking keyvalues-parser v0.2.0 [INFO] [stderr] Compiling bitbuffer_derive v0.11.0 [INFO] [stderr] Checking protobuf-codegen v2.28.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Compiling enumflags2_derive v0.7.9 [INFO] [stderr] Compiling steam-language-gen-derive v0.1.2 (https://github.com/saskenuba/SteamHelper-rs?rev=208a6ad5e2484f9cea101110dc8e29d220475821#208a6ad5) [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking protoc-rust v2.28.0 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Checking steam-protobuf v0.1.2 (https://github.com/saskenuba/SteamHelper-rs?rev=208a6ad5e2484f9cea101110dc8e29d220475821#208a6ad5) [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking object v0.35.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Compiling substring v1.4.5 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking clap_builder v4.5.9 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking tungstenite v0.23.0 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking enumflags2 v0.7.9 [INFO] [stderr] Checking parse-display v0.9.1 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking bitbuffer v0.11.0 [INFO] [stderr] Checking num_enum v0.7.2 [INFO] [stderr] Checking serde_with v1.14.0 [INFO] [stderr] Checking keyvalues-serde v0.2.1 [INFO] [stderr] Compiling client-backend v0.2.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking steamid-ng v1.0.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Compiling tappet-derive v0.3.2 (https://github.com/saskenuba/SteamHelper-rs?rev=208a6ad5e2484f9cea101110dc8e29d220475821#208a6ad5) [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Compiling include_dir_macros v0.7.4 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking main_error v0.1.2 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking include_dir v0.7.4 [INFO] [stderr] Checking open v5.3.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking pot v3.0.0 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking directories-next v2.0.0 [INFO] [stderr] Checking steam-language-gen v0.1.2 (https://github.com/saskenuba/SteamHelper-rs?rev=208a6ad5e2484f9cea101110dc8e29d220475821#208a6ad5) [INFO] [stderr] Checking atomic-write-file v0.1.4 [INFO] [stderr] Checking clap v4.5.9 [INFO] [stderr] Checking steamlocate v2.0.0-beta.2 [INFO] [stderr] Checking tracing-appender v0.2.3 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking tokio-tungstenite v0.23.1 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking rcon v0.5.2 (https://github.com/MegaAntiCheat/rust-rcon#aef1cb15) [INFO] [stderr] Checking event_loop v0.1.0 (/opt/rustwide/workdir/event_loop) [INFO] [stderr] Checking tf-demo-parser v0.5.1 (https://github.com/MegaAntiCheat/parser?branch=Depends-update#ab33fca4) [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking tappet v0.5.0 (https://github.com/saskenuba/SteamHelper-rs?rev=208a6ad5e2484f9cea101110dc8e29d220475821#208a6ad5) [INFO] [stdout] warning: unexpected `cfg` condition value: `include-ui` [INFO] [stdout] --> src/settings.rs:21:7 [INFO] [stdout] | [INFO] [stdout] 21 | #[cfg(feature = "include-ui")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `include-ui` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `include-ui` [INFO] [stdout] --> src/settings.rs:23:11 [INFO] [stdout] | [INFO] [stdout] 23 | #[cfg(not(feature = "include-ui"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `include-ui` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `include-ui` [INFO] [stdout] --> src/settings.rs:21:7 [INFO] [stdout] | [INFO] [stdout] 21 | #[cfg(feature = "include-ui")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `include-ui` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `include-ui` [INFO] [stdout] --> src/settings.rs:23:11 [INFO] [stdout] | [INFO] [stdout] 23 | #[cfg(not(feature = "include-ui"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `include-ui` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/command_manager.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / impl Default for KickReason { [INFO] [stdout] 32 | | fn default() -> Self { [INFO] [stdout] 33 | | Self::None [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Default)] [INFO] [stdout] 25 | pub enum KickReason { [INFO] [stdout] 26 ~ #[default] [INFO] [stdout] 27 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> src/command_manager.rs:176:22 [INFO] [stdout] | [INFO] [stdout] 176 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> src/command_manager.rs:202:26 [INFO] [stdout] | [INFO] [stdout] 202 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map_err` over `inspect_err` [INFO] [stdout] --> src/command_manager.rs:210:60 [INFO] [stdout] | [INFO] [stdout] 210 | let result = rcon.cmd(&format!("{cmd}")).await.map_err(|e| { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 210 ~ let result = rcon.cmd(&format!("{cmd}")).await.inspect_err(|e| { [INFO] [stdout] 211 ~ self.connection = None; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> src/command_manager.rs:234:10 [INFO] [stdout] | [INFO] [stdout] 234 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constructing a `Duration` using a smaller unit when a larger unit would be more readable [INFO] [stdout] --> src/command_manager.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 240 | Duration::from_millis(3000), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_suboptimal_units [INFO] [stdout] = note: `-W clippy::duration-suboptimal-units` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::duration_suboptimal_units)]` [INFO] [stdout] help: try using from_secs [INFO] [stdout] | [INFO] [stdout] 240 - Duration::from_millis(3000), [INFO] [stdout] 240 + Duration::from_secs(3), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/demo.rs:189:28 [INFO] [stdout] | [INFO] [stdout] 189 | if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 189 - if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] 189 + if path.extension().is_some_and(|ext| ext == "dem") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/demo.rs:198:35 [INFO] [stdout] | [INFO] [stdout] 198 | } else if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 198 - } else if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] 198 + } else if path.extension().is_some_and(|ext| ext == "dem") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/demo.rs:524:12 [INFO] [stdout] | [INFO] [stdout] 524 | if self [INFO] [stdout] | ____________^ [INFO] [stdout] 525 | | .current_demo [INFO] [stdout] 526 | | .as_ref() [INFO] [stdout] 527 | | .map_or(true, |d| !(d.file_path == msg.file_path && d.id == msg.id)) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 527 - .map_or(true, |d| !(d.file_path == msg.file_path && d.id == msg.id)) [INFO] [stdout] 527 + .is_none_or(|d| !(d.file_path == msg.file_path && d.id == msg.id)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/command_manager.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / impl Default for KickReason { [INFO] [stdout] 32 | | fn default() -> Self { [INFO] [stdout] 33 | | Self::None [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Default)] [INFO] [stdout] 25 | pub enum KickReason { [INFO] [stdout] 26 ~ #[default] [INFO] [stdout] 27 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> src/command_manager.rs:176:22 [INFO] [stdout] | [INFO] [stdout] 176 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it is more idiomatic to use `Option<&T>` instead of `&Option` [INFO] [stdout] --> src/demo.rs:826:5 [INFO] [stdout] | [INFO] [stdout] 826 | / fn get_vote_cast_event_message( [INFO] [stdout] 827 | | &self, [INFO] [stdout] 828 | | event: &VoteCastEvent, [INFO] [stdout] 829 | | steamid: &Option, [INFO] [stdout] ... | [INFO] [stdout] 842 | | vote.map(|matched_vote| format!("{matched_vote} - {name}")) [INFO] [stdout] 843 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_option [INFO] [stdout] = note: `-W clippy::ref-option` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::ref_option)]` [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 829 - steamid: &Option, [INFO] [stdout] 829 + steamid: Option<&SteamID>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> src/command_manager.rs:202:26 [INFO] [stdout] | [INFO] [stdout] 202 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map_err` over `inspect_err` [INFO] [stdout] --> src/command_manager.rs:210:60 [INFO] [stdout] | [INFO] [stdout] 210 | let result = rcon.cmd(&format!("{cmd}")).await.map_err(|e| { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 210 ~ let result = rcon.cmd(&format!("{cmd}")).await.inspect_err(|e| { [INFO] [stdout] 211 ~ self.connection = None; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> src/command_manager.rs:234:10 [INFO] [stdout] | [INFO] [stdout] 234 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constructing a `Duration` using a smaller unit when a larger unit would be more readable [INFO] [stdout] --> src/command_manager.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 240 | Duration::from_millis(3000), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_suboptimal_units [INFO] [stdout] = note: `-W clippy::duration-suboptimal-units` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::duration_suboptimal_units)]` [INFO] [stdout] help: try using from_secs [INFO] [stdout] | [INFO] [stdout] 240 - Duration::from_millis(3000), [INFO] [stdout] 240 + Duration::from_secs(3), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/demo.rs:189:28 [INFO] [stdout] | [INFO] [stdout] 189 | if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 189 - if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] 189 + if path.extension().is_some_and(|ext| ext == "dem") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/demo.rs:198:35 [INFO] [stdout] | [INFO] [stdout] 198 | } else if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 198 - } else if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] 198 + } else if path.extension().is_some_and(|ext| ext == "dem") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/demo.rs:524:12 [INFO] [stdout] | [INFO] [stdout] 524 | if self [INFO] [stdout] | ____________^ [INFO] [stdout] 525 | | .current_demo [INFO] [stdout] 526 | | .as_ref() [INFO] [stdout] 527 | | .map_or(true, |d| !(d.file_path == msg.file_path && d.id == msg.id)) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 527 - .map_or(true, |d| !(d.file_path == msg.file_path && d.id == msg.id)) [INFO] [stdout] 527 + .is_none_or(|d| !(d.file_path == msg.file_path && d.id == msg.id)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it is more idiomatic to use `Option<&T>` instead of `&Option` [INFO] [stdout] --> src/demo.rs:826:5 [INFO] [stdout] | [INFO] [stdout] 826 | / fn get_vote_cast_event_message( [INFO] [stdout] 827 | | &self, [INFO] [stdout] 828 | | event: &VoteCastEvent, [INFO] [stdout] 829 | | steamid: &Option, [INFO] [stdout] ... | [INFO] [stdout] 842 | | vote.map(|matched_vote| format!("{matched_vote} - {name}")) [INFO] [stdout] 843 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_option [INFO] [stdout] = note: `-W clippy::ref-option` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::ref_option)]` [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 829 - steamid: &Option, [INFO] [stdout] 829 + steamid: Option<&SteamID>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `Debug` formatting in `format!` args [INFO] [stdout] --> src/launchoptions.rs:55:51 [INFO] [stdout] | [INFO] [stdout] 55 | .context(format!("Failed to read {config_path:?}"))?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use `Display` formatting and change this to `config_path.display()` [INFO] [stdout] = note: switching to `Display` formatting will change how the value is shown; escaped characters will no longer be escaped and surrounding quotes will be removed [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_debug_formatting [INFO] [stdout] = note: `-W clippy::unnecessary-debug-formatting` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_debug_formatting)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `Debug` formatting in `format!` args [INFO] [stdout] --> src/launchoptions.rs:55:51 [INFO] [stdout] | [INFO] [stdout] 55 | .context(format!("Failed to read {config_path:?}"))?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use `Display` formatting and change this to `config_path.display()` [INFO] [stdout] = note: switching to `Display` formatting will change how the value is shown; escaped characters will no longer be escaped and surrounding quotes will be removed [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_debug_formatting [INFO] [stdout] = note: `-W clippy::unnecessary-debug-formatting` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_debug_formatting)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/player.rs:158:16 [INFO] [stdout] | [INFO] [stdout] 158 | if friends.len() == 0 && friends.public.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `friends.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/player.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | if friends.len() == 0 && friends.public.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `friends.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/player.rs:249:26 [INFO] [stdout] | [INFO] [stdout] 249 | .filter(|&s| self.game_info.get(s).map_or(true, GameInfo::should_prune)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 249 - .filter(|&s| self.game_info.get(s).map_or(true, GameInfo::should_prune)) [INFO] [stdout] 249 + .filter(|&s| self.game_info.get(s).is_none_or(GameInfo::should_prune)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/player.rs:158:16 [INFO] [stdout] | [INFO] [stdout] 158 | if friends.len() == 0 && friends.public.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `friends.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/player.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | if friends.len() == 0 && friends.public.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `friends.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/player_records.rs:304:1 [INFO] [stdout] | [INFO] [stdout] 304 | / impl Default for Verdict { [INFO] [stdout] 305 | | fn default() -> Self { [INFO] [stdout] 306 | | Self::Player [INFO] [stdout] 307 | | } [INFO] [stdout] 308 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 290 + #[derive(Default)] [INFO] [stdout] 291 | pub enum Verdict { [INFO] [stdout] 292 ~ #[default] [INFO] [stdout] 293 ~ Player, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/player.rs:249:26 [INFO] [stdout] | [INFO] [stdout] 249 | .filter(|&s| self.game_info.get(s).map_or(true, GameInfo::should_prune)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 249 - .filter(|&s| self.game_info.get(s).map_or(true, GameInfo::should_prune)) [INFO] [stdout] 249 + .filter(|&s| self.game_info.get(s).is_none_or(GameInfo::should_prune)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map` over `inspect` [INFO] [stdout] --> src/settings.rs:284:44 [INFO] [stdout] | [INFO] [stdout] 284 | self.override_web_port = args.port.map(|val| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 284 ~ self.override_web_port = args.port.inspect(|&val| { [INFO] [stdout] 285 | tracing::info!( [INFO] [stdout] ... [INFO] [stdout] 288 | val [INFO] [stdout] 289 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map` over `inspect` [INFO] [stdout] --> src/settings.rs:322:50 [INFO] [stdout] | [INFO] [stdout] 322 | self.override_rcon_port = args.rcon_port.map(|val| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 322 ~ self.override_rcon_port = args.rcon_port.inspect(|&val| { [INFO] [stdout] 323 | tracing::info!( [INFO] [stdout] ... [INFO] [stdout] 326 | val [INFO] [stdout] 327 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/player_records.rs:304:1 [INFO] [stdout] | [INFO] [stdout] 304 | / impl Default for Verdict { [INFO] [stdout] 305 | | fn default() -> Self { [INFO] [stdout] 306 | | Self::Player [INFO] [stdout] 307 | | } [INFO] [stdout] 308 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 290 + #[derive(Default)] [INFO] [stdout] 291 | pub enum Verdict { [INFO] [stdout] 292 ~ #[default] [INFO] [stdout] 293 ~ Player, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/steam_api.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | / !state [INFO] [stdout] 179 | | .players [INFO] [stdout] 180 | | .steam_info [INFO] [stdout] 181 | | .get(s) [INFO] [stdout] 182 | | .is_some_and(|si| !si.expired()) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 178 ~ state [INFO] [stdout] 179 + .players [INFO] [stdout] 180 + .steam_info [INFO] [stdout] 181 + .get(s).is_none_or(|si| si.expired()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/steam_api.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | / !state [INFO] [stdout] 296 | | .players [INFO] [stdout] 297 | | .friend_info [INFO] [stdout] 298 | | .get(s) [INFO] [stdout] 299 | | .is_some_and(|f| f.public.is_some()) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 295 ~ state [INFO] [stdout] 296 + .players [INFO] [stdout] 297 + .friend_info [INFO] [stdout] 298 + .get(s).is_none_or(|f| f.public.is_none()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/steam_api.rs:475:65 [INFO] [stdout] | [INFO] [stdout] 475 | country_code: summary.loccountrycode.clone().map(Into::into), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/web.rs:207:24 [INFO] [stdout] | [INFO] [stdout] 207 | || state [INFO] [stdout] | ________________________^ [INFO] [stdout] 208 | | .players [INFO] [stdout] 209 | | .steam_info [INFO] [stdout] 210 | | .get(s) [INFO] [stdout] 211 | | .map_or(true, SteamInfo::expired) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 211 - .map_or(true, SteamInfo::expired) [INFO] [stdout] 211 + .is_none_or(SteamInfo::expired) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map` over `inspect` [INFO] [stdout] --> src/settings.rs:284:44 [INFO] [stdout] | [INFO] [stdout] 284 | self.override_web_port = args.port.map(|val| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 284 ~ self.override_web_port = args.port.inspect(|&val| { [INFO] [stdout] 285 | tracing::info!( [INFO] [stdout] ... [INFO] [stdout] 288 | val [INFO] [stdout] 289 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map` over `inspect` [INFO] [stdout] --> src/settings.rs:322:50 [INFO] [stdout] | [INFO] [stdout] 322 | self.override_rcon_port = args.rcon_port.map(|val| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 322 ~ self.override_rcon_port = args.rcon_port.inspect(|&val| { [INFO] [stdout] 323 | tracing::info!( [INFO] [stdout] ... [INFO] [stdout] 326 | val [INFO] [stdout] 327 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/demo.rs:272:22 [INFO] [stdout] | [INFO] [stdout] 272 | pub async fn get(&mut self) -> MutexGuard> { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 272 | pub async fn get(&mut self) -> MutexGuard<'_, Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/player.rs:286:36 [INFO] [stdout] | [INFO] [stdout] 286 | pub fn get_serializable_player(&self, steamid: SteamID) -> Player { [INFO] [stdout] | ^^^^^ ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 286 | pub fn get_serializable_player(&self, steamid: SteamID) -> Player<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/steam_api.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | / !state [INFO] [stdout] 179 | | .players [INFO] [stdout] 180 | | .steam_info [INFO] [stdout] 181 | | .get(s) [INFO] [stdout] 182 | | .is_some_and(|si| !si.expired()) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 178 ~ state [INFO] [stdout] 179 + .players [INFO] [stdout] 180 + .steam_info [INFO] [stdout] 181 + .get(s).is_none_or(|si| si.expired()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/steam_api.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | / !state [INFO] [stdout] 296 | | .players [INFO] [stdout] 297 | | .friend_info [INFO] [stdout] 298 | | .get(s) [INFO] [stdout] 299 | | .is_some_and(|f| f.public.is_some()) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 295 ~ state [INFO] [stdout] 296 + .players [INFO] [stdout] 297 + .friend_info [INFO] [stdout] 298 + .get(s).is_none_or(|f| f.public.is_none()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/steam_api.rs:475:65 [INFO] [stdout] | [INFO] [stdout] 475 | country_code: summary.loccountrycode.clone().map(Into::into), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/web.rs:207:24 [INFO] [stdout] | [INFO] [stdout] 207 | || state [INFO] [stdout] | ________________________^ [INFO] [stdout] 208 | | .players [INFO] [stdout] 209 | | .steam_info [INFO] [stdout] 210 | | .get(s) [INFO] [stdout] 211 | | .map_or(true, SteamInfo::expired) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 211 - .map_or(true, SteamInfo::expired) [INFO] [stdout] 211 + .is_none_or(SteamInfo::expired) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/demo.rs:272:22 [INFO] [stdout] | [INFO] [stdout] 272 | pub async fn get(&mut self) -> MutexGuard> { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 272 | pub async fn get(&mut self) -> MutexGuard<'_, Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/player.rs:286:36 [INFO] [stdout] | [INFO] [stdout] 286 | pub fn get_serializable_player(&self, steamid: SteamID) -> Player { [INFO] [stdout] | ^^^^^ ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 286 | pub fn get_serializable_player(&self, steamid: SteamID) -> Player<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `include-ui` [INFO] [stdout] --> src/settings.rs:21:7 [INFO] [stdout] | [INFO] [stdout] 21 | #[cfg(feature = "include-ui")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `include-ui` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `include-ui` [INFO] [stdout] --> src/settings.rs:23:11 [INFO] [stdout] | [INFO] [stdout] 23 | #[cfg(not(feature = "include-ui"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `include-ui` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `include-ui` [INFO] [stdout] --> src/settings.rs:21:7 [INFO] [stdout] | [INFO] [stdout] 21 | #[cfg(feature = "include-ui")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `include-ui` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `include-ui` [INFO] [stdout] --> src/settings.rs:23:11 [INFO] [stdout] | [INFO] [stdout] 23 | #[cfg(not(feature = "include-ui"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `include-ui` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/command_manager.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / impl Default for KickReason { [INFO] [stdout] 32 | | fn default() -> Self { [INFO] [stdout] 33 | | Self::None [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Default)] [INFO] [stdout] 25 | pub enum KickReason { [INFO] [stdout] 26 ~ #[default] [INFO] [stdout] 27 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> src/command_manager.rs:176:22 [INFO] [stdout] | [INFO] [stdout] 176 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> src/command_manager.rs:202:26 [INFO] [stdout] | [INFO] [stdout] 202 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map_err` over `inspect_err` [INFO] [stdout] --> src/command_manager.rs:210:60 [INFO] [stdout] | [INFO] [stdout] 210 | let result = rcon.cmd(&format!("{cmd}")).await.map_err(|e| { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 210 ~ let result = rcon.cmd(&format!("{cmd}")).await.inspect_err(|e| { [INFO] [stdout] 211 ~ self.connection = None; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> src/command_manager.rs:234:10 [INFO] [stdout] | [INFO] [stdout] 234 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constructing a `Duration` using a smaller unit when a larger unit would be more readable [INFO] [stdout] --> src/command_manager.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 240 | Duration::from_millis(3000), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_suboptimal_units [INFO] [stdout] = note: `-W clippy::duration-suboptimal-units` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::duration_suboptimal_units)]` [INFO] [stdout] help: try using from_secs [INFO] [stdout] | [INFO] [stdout] 240 - Duration::from_millis(3000), [INFO] [stdout] 240 + Duration::from_secs(3), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/demo.rs:189:28 [INFO] [stdout] | [INFO] [stdout] 189 | if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 189 - if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] 189 + if path.extension().is_some_and(|ext| ext == "dem") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/demo.rs:198:35 [INFO] [stdout] | [INFO] [stdout] 198 | } else if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 198 - } else if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] 198 + } else if path.extension().is_some_and(|ext| ext == "dem") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/demo.rs:524:12 [INFO] [stdout] | [INFO] [stdout] 524 | if self [INFO] [stdout] | ____________^ [INFO] [stdout] 525 | | .current_demo [INFO] [stdout] 526 | | .as_ref() [INFO] [stdout] 527 | | .map_or(true, |d| !(d.file_path == msg.file_path && d.id == msg.id)) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 527 - .map_or(true, |d| !(d.file_path == msg.file_path && d.id == msg.id)) [INFO] [stdout] 527 + .is_none_or(|d| !(d.file_path == msg.file_path && d.id == msg.id)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it is more idiomatic to use `Option<&T>` instead of `&Option` [INFO] [stdout] --> src/demo.rs:826:5 [INFO] [stdout] | [INFO] [stdout] 826 | / fn get_vote_cast_event_message( [INFO] [stdout] 827 | | &self, [INFO] [stdout] 828 | | event: &VoteCastEvent, [INFO] [stdout] 829 | | steamid: &Option, [INFO] [stdout] ... | [INFO] [stdout] 842 | | vote.map(|matched_vote| format!("{matched_vote} - {name}")) [INFO] [stdout] 843 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_option [INFO] [stdout] = note: `-W clippy::ref-option` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::ref_option)]` [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 829 - steamid: &Option, [INFO] [stdout] 829 + steamid: Option<&SteamID>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/command_manager.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / impl Default for KickReason { [INFO] [stdout] 32 | | fn default() -> Self { [INFO] [stdout] 33 | | Self::None [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 24 + #[derive(Default)] [INFO] [stdout] 25 | pub enum KickReason { [INFO] [stdout] 26 ~ #[default] [INFO] [stdout] 27 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> src/command_manager.rs:176:22 [INFO] [stdout] | [INFO] [stdout] 176 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] = note: `-W clippy::unnecessary-semicolon` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_semicolon)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> src/command_manager.rs:202:26 [INFO] [stdout] | [INFO] [stdout] 202 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map_err` over `inspect_err` [INFO] [stdout] --> src/command_manager.rs:210:60 [INFO] [stdout] | [INFO] [stdout] 210 | let result = rcon.cmd(&format!("{cmd}")).await.map_err(|e| { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 210 ~ let result = rcon.cmd(&format!("{cmd}")).await.inspect_err(|e| { [INFO] [stdout] 211 ~ self.connection = None; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary semicolon [INFO] [stdout] --> src/command_manager.rs:234:10 [INFO] [stdout] | [INFO] [stdout] 234 | }; [INFO] [stdout] | ^ help: remove [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constructing a `Duration` using a smaller unit when a larger unit would be more readable [INFO] [stdout] --> src/command_manager.rs:240:13 [INFO] [stdout] | [INFO] [stdout] 240 | Duration::from_millis(3000), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_suboptimal_units [INFO] [stdout] = note: `-W clippy::duration-suboptimal-units` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::duration_suboptimal_units)]` [INFO] [stdout] help: try using from_secs [INFO] [stdout] | [INFO] [stdout] 240 - Duration::from_millis(3000), [INFO] [stdout] 240 + Duration::from_secs(3), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `Debug` formatting in `format!` args [INFO] [stdout] --> src/launchoptions.rs:55:51 [INFO] [stdout] | [INFO] [stdout] 55 | .context(format!("Failed to read {config_path:?}"))?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use `Display` formatting and change this to `config_path.display()` [INFO] [stdout] = note: switching to `Display` formatting will change how the value is shown; escaped characters will no longer be escaped and surrounding quotes will be removed [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_debug_formatting [INFO] [stdout] = note: `-W clippy::unnecessary-debug-formatting` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_debug_formatting)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/demo.rs:189:28 [INFO] [stdout] | [INFO] [stdout] 189 | if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 189 - if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] 189 + if path.extension().is_some_and(|ext| ext == "dem") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/demo.rs:198:35 [INFO] [stdout] | [INFO] [stdout] 198 | } else if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 198 - } else if path.extension().map_or(false, |ext| ext == "dem") { [INFO] [stdout] 198 + } else if path.extension().is_some_and(|ext| ext == "dem") { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/demo.rs:524:12 [INFO] [stdout] | [INFO] [stdout] 524 | if self [INFO] [stdout] | ____________^ [INFO] [stdout] 525 | | .current_demo [INFO] [stdout] 526 | | .as_ref() [INFO] [stdout] 527 | | .map_or(true, |d| !(d.file_path == msg.file_path && d.id == msg.id)) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 527 - .map_or(true, |d| !(d.file_path == msg.file_path && d.id == msg.id)) [INFO] [stdout] 527 + .is_none_or(|d| !(d.file_path == msg.file_path && d.id == msg.id)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it is more idiomatic to use `Option<&T>` instead of `&Option` [INFO] [stdout] --> src/demo.rs:826:5 [INFO] [stdout] | [INFO] [stdout] 826 | / fn get_vote_cast_event_message( [INFO] [stdout] 827 | | &self, [INFO] [stdout] 828 | | event: &VoteCastEvent, [INFO] [stdout] 829 | | steamid: &Option, [INFO] [stdout] ... | [INFO] [stdout] 842 | | vote.map(|matched_vote| format!("{matched_vote} - {name}")) [INFO] [stdout] 843 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_option [INFO] [stdout] = note: `-W clippy::ref-option` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::ref_option)]` [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 829 - steamid: &Option, [INFO] [stdout] 829 + steamid: Option<&SteamID>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/player.rs:158:16 [INFO] [stdout] | [INFO] [stdout] 158 | if friends.len() == 0 && friends.public.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `friends.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/player.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | if friends.len() == 0 && friends.public.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `friends.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/player.rs:249:26 [INFO] [stdout] | [INFO] [stdout] 249 | .filter(|&s| self.game_info.get(s).map_or(true, GameInfo::should_prune)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 249 - .filter(|&s| self.game_info.get(s).map_or(true, GameInfo::should_prune)) [INFO] [stdout] 249 + .filter(|&s| self.game_info.get(s).is_none_or(GameInfo::should_prune)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it is more idiomatic to use `Option<&T>` instead of `&Option` [INFO] [stdout] --> src/player.rs:737:1 [INFO] [stdout] | [INFO] [stdout] 737 | / pub fn serialize_maybe_steamid_as_string( [INFO] [stdout] 738 | | steamid: &Option, [INFO] [stdout] 739 | | s: S, [INFO] [stdout] 740 | | ) -> Result { [INFO] [stdout] ... | [INFO] [stdout] 745 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_option [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 738 - steamid: &Option, [INFO] [stdout] 738 + steamid: Option<&SteamID>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `Debug` formatting in `format!` args [INFO] [stdout] --> src/launchoptions.rs:55:51 [INFO] [stdout] | [INFO] [stdout] 55 | .context(format!("Failed to read {config_path:?}"))?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use `Display` formatting and change this to `config_path.display()` [INFO] [stdout] = note: switching to `Display` formatting will change how the value is shown; escaped characters will no longer be escaped and surrounding quotes will be removed [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_debug_formatting [INFO] [stdout] = note: `-W clippy::unnecessary-debug-formatting` implied by `-W clippy::pedantic` [INFO] [stdout] = help: to override `-W clippy::pedantic` add `#[allow(clippy::unnecessary_debug_formatting)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/player_records.rs:304:1 [INFO] [stdout] | [INFO] [stdout] 304 | / impl Default for Verdict { [INFO] [stdout] 305 | | fn default() -> Self { [INFO] [stdout] 306 | | Self::Player [INFO] [stdout] 307 | | } [INFO] [stdout] 308 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 290 + #[derive(Default)] [INFO] [stdout] 291 | pub enum Verdict { [INFO] [stdout] 292 ~ #[default] [INFO] [stdout] 293 ~ Player, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map` over `inspect` [INFO] [stdout] --> src/settings.rs:284:44 [INFO] [stdout] | [INFO] [stdout] 284 | self.override_web_port = args.port.map(|val| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 284 ~ self.override_web_port = args.port.inspect(|&val| { [INFO] [stdout] 285 | tracing::info!( [INFO] [stdout] ... [INFO] [stdout] 288 | val [INFO] [stdout] 289 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map` over `inspect` [INFO] [stdout] --> src/settings.rs:322:50 [INFO] [stdout] | [INFO] [stdout] 322 | self.override_rcon_port = args.rcon_port.map(|val| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 322 ~ self.override_rcon_port = args.rcon_port.inspect(|&val| { [INFO] [stdout] 323 | tracing::info!( [INFO] [stdout] ... [INFO] [stdout] 326 | val [INFO] [stdout] 327 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/player.rs:158:16 [INFO] [stdout] | [INFO] [stdout] 158 | if friends.len() == 0 && friends.public.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `friends.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/player.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | if friends.len() == 0 && friends.public.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `friends.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/player.rs:249:26 [INFO] [stdout] | [INFO] [stdout] 249 | .filter(|&s| self.game_info.get(s).map_or(true, GameInfo::should_prune)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 249 - .filter(|&s| self.game_info.get(s).map_or(true, GameInfo::should_prune)) [INFO] [stdout] 249 + .filter(|&s| self.game_info.get(s).is_none_or(GameInfo::should_prune)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it is more idiomatic to use `Option<&T>` instead of `&Option` [INFO] [stdout] --> src/player.rs:737:1 [INFO] [stdout] | [INFO] [stdout] 737 | / pub fn serialize_maybe_steamid_as_string( [INFO] [stdout] 738 | | steamid: &Option, [INFO] [stdout] 739 | | s: S, [INFO] [stdout] 740 | | ) -> Result { [INFO] [stdout] ... | [INFO] [stdout] 745 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ref_option [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 738 - steamid: &Option, [INFO] [stdout] 738 + steamid: Option<&SteamID>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/steam_api.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | / !state [INFO] [stdout] 179 | | .players [INFO] [stdout] 180 | | .steam_info [INFO] [stdout] 181 | | .get(s) [INFO] [stdout] 182 | | .is_some_and(|si| !si.expired()) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 178 ~ state [INFO] [stdout] 179 + .players [INFO] [stdout] 180 + .steam_info [INFO] [stdout] 181 + .get(s).is_none_or(|si| si.expired()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/steam_api.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | / !state [INFO] [stdout] 296 | | .players [INFO] [stdout] 297 | | .friend_info [INFO] [stdout] 298 | | .get(s) [INFO] [stdout] 299 | | .is_some_and(|f| f.public.is_some()) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 295 ~ state [INFO] [stdout] 296 + .players [INFO] [stdout] 297 + .friend_info [INFO] [stdout] 298 + .get(s).is_none_or(|f| f.public.is_none()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/player_records.rs:304:1 [INFO] [stdout] | [INFO] [stdout] 304 | / impl Default for Verdict { [INFO] [stdout] 305 | | fn default() -> Self { [INFO] [stdout] 306 | | Self::Player [INFO] [stdout] 307 | | } [INFO] [stdout] 308 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 290 + #[derive(Default)] [INFO] [stdout] 291 | pub enum Verdict { [INFO] [stdout] 292 ~ #[default] [INFO] [stdout] 293 ~ Player, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/steam_api.rs:475:65 [INFO] [stdout] | [INFO] [stdout] 475 | country_code: summary.loccountrycode.clone().map(Into::into), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/web.rs:207:24 [INFO] [stdout] | [INFO] [stdout] 207 | || state [INFO] [stdout] | ________________________^ [INFO] [stdout] 208 | | .players [INFO] [stdout] 209 | | .steam_info [INFO] [stdout] 210 | | .get(s) [INFO] [stdout] 211 | | .map_or(true, SteamInfo::expired) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 211 - .map_or(true, SteamInfo::expired) [INFO] [stdout] 211 + .is_none_or(SteamInfo::expired) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map` over `inspect` [INFO] [stdout] --> src/settings.rs:284:44 [INFO] [stdout] | [INFO] [stdout] 284 | self.override_web_port = args.port.map(|val| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 284 ~ self.override_web_port = args.port.inspect(|&val| { [INFO] [stdout] 285 | tracing::info!( [INFO] [stdout] ... [INFO] [stdout] 288 | val [INFO] [stdout] 289 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map` over `inspect` [INFO] [stdout] --> src/settings.rs:322:50 [INFO] [stdout] | [INFO] [stdout] 322 | self.override_rcon_port = args.rcon_port.map(|val| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 322 ~ self.override_rcon_port = args.rcon_port.inspect(|&val| { [INFO] [stdout] 323 | tracing::info!( [INFO] [stdout] ... [INFO] [stdout] 326 | val [INFO] [stdout] 327 ~ ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/steam_api.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | / !state [INFO] [stdout] 179 | | .players [INFO] [stdout] 180 | | .steam_info [INFO] [stdout] 181 | | .get(s) [INFO] [stdout] 182 | | .is_some_and(|si| !si.expired()) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 178 ~ state [INFO] [stdout] 179 + .players [INFO] [stdout] 180 + .steam_info [INFO] [stdout] 181 + .get(s).is_none_or(|si| si.expired()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/steam_api.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | / !state [INFO] [stdout] 296 | | .players [INFO] [stdout] 297 | | .friend_info [INFO] [stdout] 298 | | .get(s) [INFO] [stdout] 299 | | .is_some_and(|f| f.public.is_some()) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 295 ~ state [INFO] [stdout] 296 + .players [INFO] [stdout] 297 + .friend_info [INFO] [stdout] 298 + .get(s).is_none_or(|f| f.public.is_none()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/steam_api.rs:475:65 [INFO] [stdout] | [INFO] [stdout] 475 | country_code: summary.loccountrycode.clone().map(Into::into), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/web.rs:207:24 [INFO] [stdout] | [INFO] [stdout] 207 | || state [INFO] [stdout] | ________________________^ [INFO] [stdout] 208 | | .players [INFO] [stdout] 209 | | .steam_info [INFO] [stdout] 210 | | .get(s) [INFO] [stdout] 211 | | .map_or(true, SteamInfo::expired) [INFO] [stdout] | |_________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 211 - .map_or(true, SteamInfo::expired) [INFO] [stdout] 211 + .is_none_or(SteamInfo::expired) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/demo.rs:272:22 [INFO] [stdout] | [INFO] [stdout] 272 | pub async fn get(&mut self) -> MutexGuard> { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 272 | pub async fn get(&mut self) -> MutexGuard<'_, Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/player.rs:286:36 [INFO] [stdout] | [INFO] [stdout] 286 | pub fn get_serializable_player(&self, steamid: SteamID) -> Player { [INFO] [stdout] | ^^^^^ ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 286 | pub fn get_serializable_player(&self, steamid: SteamID) -> Player<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/demo.rs:272:22 [INFO] [stdout] | [INFO] [stdout] 272 | pub async fn get(&mut self) -> MutexGuard> { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 272 | pub async fn get(&mut self) -> MutexGuard<'_, Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/player.rs:286:36 [INFO] [stdout] | [INFO] [stdout] 286 | pub fn get_serializable_player(&self, steamid: SteamID) -> Player { [INFO] [stdout] | ^^^^^ ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 286 | pub fn get_serializable_player(&self, steamid: SteamID) -> Player<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4m 03s [INFO] running `Command { std: "docker" "inspect" "0b5363b5160d95a5053308f284976df07cb110e72f67a2b77b9dfbe0f3f717aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b5363b5160d95a5053308f284976df07cb110e72f67a2b77b9dfbe0f3f717aa", kill_on_drop: false }` [INFO] [stdout] 0b5363b5160d95a5053308f284976df07cb110e72f67a2b77b9dfbe0f3f717aa