[INFO] cloning repository https://github.com/McGIllicuddy7/estro [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/McGIllicuddy7/estro" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMcGIllicuddy7%2Festro", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMcGIllicuddy7%2Festro'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9e06b6b26ddf97cb66463995b6b916d2159c5c85 [INFO] linting McGIllicuddy7/estro against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMcGIllicuddy7%2Festro" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/McGIllicuddy7/estro [INFO] finished tweaking git repo https://github.com/McGIllicuddy7/estro [INFO] tweaked toml for git repo https://github.com/McGIllicuddy7/estro written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/McGIllicuddy7/estro on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/McGIllicuddy7/estro already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rmp v0.8.15 [INFO] [stderr] Downloaded rmp-serde v1.3.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c1bdce296c400420e7a89b85a3bc3ba88d0d43750d3f56571c3d4f70d824152c [INFO] running `Command { std: "docker" "start" "-a" "c1bdce296c400420e7a89b85a3bc3ba88d0d43750d3f56571c3d4f70d824152c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c1bdce296c400420e7a89b85a3bc3ba88d0d43750d3f56571c3d4f70d824152c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1bdce296c400420e7a89b85a3bc3ba88d0d43750d3f56571c3d4f70d824152c", kill_on_drop: false }` [INFO] [stdout] c1bdce296c400420e7a89b85a3bc3ba88d0d43750d3f56571c3d4f70d824152c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2815fc82096a00c581129246657cf32d2a98976a05e206483ae474d2e3c7fcf7 [INFO] running `Command { std: "docker" "start" "-a" "2815fc82096a00c581129246657cf32d2a98976a05e206483ae474d2e3c7fcf7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking rmp v0.8.15 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking rmp-serde v1.3.1 [INFO] [stderr] Checking estro v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Literal` [INFO] [stdout] --> src/asm.rs:4:37 [INFO] [stdout] | [INFO] [stdout] 4 | BinOpKind, BinopType, Function, Literal, Operand, Static, TranslationUnit, Variable, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/asm.rs:252:13 [INFO] [stdout] | [INFO] [stdout] 252 | offset: offset, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/asm.rs:259:13 [INFO] [stdout] | [INFO] [stdout] 259 | offset: offset, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/asm.rs:273:13 [INFO] [stdout] | [INFO] [stdout] 273 | offset: offset, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/asm.rs:279:13 [INFO] [stdout] | [INFO] [stdout] 279 | offset: offset, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/est.rs:521:17 [INFO] [stdout] | [INFO] [stdout] 521 | args: args, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Literal` [INFO] [stdout] --> src/asm.rs:4:37 [INFO] [stdout] | [INFO] [stdout] 4 | BinOpKind, BinopType, Function, Literal, Operand, Static, TranslationUnit, Variable, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/asm.rs:252:13 [INFO] [stdout] | [INFO] [stdout] 252 | offset: offset, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/asm.rs:259:13 [INFO] [stdout] | [INFO] [stdout] 259 | offset: offset, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/asm.rs:273:13 [INFO] [stdout] | [INFO] [stdout] 273 | offset: offset, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/asm.rs:279:13 [INFO] [stdout] | [INFO] [stdout] 279 | offset: offset, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/est.rs:521:17 [INFO] [stdout] | [INFO] [stdout] 521 | args: args, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | out += &format!("\tmov fp, sp\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tmov fp, sp\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/arm.rs:51:16 [INFO] [stdout] | [INFO] [stdout] 51 | if name != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:138:49 [INFO] [stdout] | [INFO] [stdout] 138 | ... out += &format!("\tfadd d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfadd d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:142:49 [INFO] [stdout] | [INFO] [stdout] 142 | ... out += &format!("\tfsub d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfsub d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:146:49 [INFO] [stdout] | [INFO] [stdout] 146 | ... out += &format!("\tfdiv d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfdiv d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:150:49 [INFO] [stdout] | [INFO] [stdout] 150 | ... out += &format!("\tfmul d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfmul d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:154:49 [INFO] [stdout] | [INFO] [stdout] 154 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:158:49 [INFO] [stdout] | [INFO] [stdout] 158 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:162:49 [INFO] [stdout] | [INFO] [stdout] 162 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:166:49 [INFO] [stdout] | [INFO] [stdout] 166 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:170:49 [INFO] [stdout] | [INFO] [stdout] 170 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:174:49 [INFO] [stdout] | [INFO] [stdout] 174 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/asm.rs:115:29 [INFO] [stdout] | [INFO] [stdout] 115 | Self::Reg(x) => format!("{}", x.name_arm()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `x.name_arm().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/asm.rs:121:29 [INFO] [stdout] | [INFO] [stdout] 121 | Self::Reg(x) => format!("{}", x.name_x86()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `x.name_x86().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/asm.rs:324:32 [INFO] [stdout] | [INFO] [stdout] 324 | index: variable.stack_offset as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `variable.stack_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/asm.rs:367:32 [INFO] [stdout] | [INFO] [stdout] 367 | index: variable.stack_offset as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `variable.stack_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/asm.rs:481:5 [INFO] [stdout] | [INFO] [stdout] 481 | for (name, bl) in &func.blocks { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, (name, bl)) in func.blocks.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx` is used as a loop counter [INFO] [stdout] --> src/asm.rs:581:21 [INFO] [stdout] | [INFO] [stdout] 581 | for i in arguments { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx, i) in arguments.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/est.rs:65:31 [INFO] [stdout] | [INFO] [stdout] 65 | let mut out = format!("(EstroWord[]){{"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(EstroWord[]){".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/est.rs:76:31 [INFO] [stdout] | [INFO] [stdout] 76 | let mut out = format!("(EstroByte[]){{"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(EstroByte[]){".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/est.rs:155:35 [INFO] [stdout] | [INFO] [stdout] 155 | let mut out = format!("(EstroWord[]){{"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(EstroWord[]){".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/est.rs:166:35 [INFO] [stdout] | [INFO] [stdout] 166 | let mut out = format!("(EstroByte[]){{"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(EstroByte[]){".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/est.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | format!("{}", v.name) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `v.name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/est.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 340 | / if let Some(t) = stream.peek() { [INFO] [stdout] 341 | | if t.text == "(" { [INFO] [stdout] 342 | | let mut bytes = false; [INFO] [stdout] 343 | | let mut list = Vec::new(); [INFO] [stdout] ... | [INFO] [stdout] 360 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 340 ~ if let Some(t) = stream.peek() [INFO] [stdout] 341 ~ && t.text == "(" { [INFO] [stdout] 342 | let mut bytes = false; [INFO] [stdout] ... [INFO] [stdout] 358 | } [INFO] [stdout] 359 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/est.rs:351:23 [INFO] [stdout] | [INFO] [stdout] 351 | while let Some(_) = x.peek() { [INFO] [stdout] | ----------^^^^^^^----------- help: try: `while x.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/est.rs:407:13 [INFO] [stdout] | [INFO] [stdout] 407 | / return Ok(( [INFO] [stdout] 408 | | name, [INFO] [stdout] 409 | | Static { [INFO] [stdout] 410 | | variable: var, [INFO] [stdout] ... | [INFO] [stdout] 414 | | }, [INFO] [stdout] 415 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 407 ~ Ok(( [INFO] [stdout] 408 + name, [INFO] [stdout] 409 + Static { [INFO] [stdout] 410 + variable: var, [INFO] [stdout] 411 + literal: x, [INFO] [stdout] 412 + inline: is_inline, [INFO] [stdout] 413 + external: is_external, [INFO] [stdout] 414 + }, [INFO] [stdout] 415 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/est.rs:994:24 [INFO] [stdout] | [INFO] [stdout] 994 | if !cmd_toks.peek().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cmd_toks.peek().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/est.rs:1124:16 [INFO] [stdout] | [INFO] [stdout] 1124 | out += &name; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/est.rs:1154:16 [INFO] [stdout] | [INFO] [stdout] 1154 | out += &name; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/rtils.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | / loop { [INFO] [stdout] 44 | | let Some(i) = fmt.next() else { [INFO] [stdout] 45 | | break; [INFO] [stdout] 46 | | }; [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(i) = fmt.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/rtils.rs:2227:17 [INFO] [stdout] | [INFO] [stdout] 2227 | / for i in 0..self.len { [INFO] [stdout] 2228 | | buf2[i] = self.buf[i]; [INFO] [stdout] 2229 | | } [INFO] [stdout] | |_________________^ help: try replacing the loop by: `buf2[..self.len].copy_from_slice(&self.buf[..self.len]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/rtils.rs:2299:9 [INFO] [stdout] | [INFO] [stdout] 2299 | / loop { [INFO] [stdout] 2300 | | let Some(c) = it.next() else { [INFO] [stdout] 2301 | | break; [INFO] [stdout] 2302 | | }; [INFO] [stdout] ... | [INFO] [stdout] 2330 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(c) = it.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/rtils.rs:2309:37 [INFO] [stdout] | [INFO] [stdout] 2309 | } else if c1 == 'd' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2310 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2311 | | index += 1; [INFO] [stdout] 2312 | | } else if c1 == 'f' { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/rtils.rs:2312:37 [INFO] [stdout] | [INFO] [stdout] 2312 | } else if c1 == 'f' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2313 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2314 | | index += 1; [INFO] [stdout] 2315 | | } else if c1 == 's' { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/rtils.rs:2312:37 [INFO] [stdout] | [INFO] [stdout] 2312 | } else if c1 == 'f' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2313 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2314 | | index += 1; [INFO] [stdout] 2315 | | } else if c1 == 's' { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/rtils.rs:2315:37 [INFO] [stdout] | [INFO] [stdout] 2315 | } else if c1 == 's' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2316 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2317 | | index += 1; [INFO] [stdout] 2318 | | } else if c1 == 'u' { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/rtils.rs:2315:37 [INFO] [stdout] | [INFO] [stdout] 2315 | } else if c1 == 's' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2316 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2317 | | index += 1; [INFO] [stdout] 2318 | | } else if c1 == 'u' { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/rtils.rs:2318:37 [INFO] [stdout] | [INFO] [stdout] 2318 | } else if c1 == 'u' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2319 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2320 | | index += 1; [INFO] [stdout] 2321 | | } else if c1 == '*' { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/rtils.rs:2318:37 [INFO] [stdout] | [INFO] [stdout] 2318 | } else if c1 == 'u' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2319 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2320 | | index += 1; [INFO] [stdout] 2321 | | } else if c1 == '*' { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/rtils.rs:2321:37 [INFO] [stdout] | [INFO] [stdout] 2321 | } else if c1 == '*' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2322 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2323 | | index += 1; [INFO] [stdout] 2324 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> src/rtils.rs:2348:33 [INFO] [stdout] | [INFO] [stdout] 2348 | fn clone(&self) -> Self { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 2349 | | Self { ptr: self.ptr } [INFO] [stdout] 2350 | | } [INFO] [stdout] | |_________^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | out += &format!("\tmov fp, sp\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tmov fp, sp\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/arm.rs:51:16 [INFO] [stdout] | [INFO] [stdout] 51 | if name != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:138:49 [INFO] [stdout] | [INFO] [stdout] 138 | ... out += &format!("\tfadd d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfadd d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:142:49 [INFO] [stdout] | [INFO] [stdout] 142 | ... out += &format!("\tfsub d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfsub d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:146:49 [INFO] [stdout] | [INFO] [stdout] 146 | ... out += &format!("\tfdiv d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfdiv d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:150:49 [INFO] [stdout] | [INFO] [stdout] 150 | ... out += &format!("\tfmul d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfmul d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:154:49 [INFO] [stdout] | [INFO] [stdout] 154 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:158:49 [INFO] [stdout] | [INFO] [stdout] 158 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:162:49 [INFO] [stdout] | [INFO] [stdout] 162 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:166:49 [INFO] [stdout] | [INFO] [stdout] 166 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:170:49 [INFO] [stdout] | [INFO] [stdout] 170 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/arm.rs:174:49 [INFO] [stdout] | [INFO] [stdout] 174 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/asm.rs:115:29 [INFO] [stdout] | [INFO] [stdout] 115 | Self::Reg(x) => format!("{}", x.name_arm()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `x.name_arm().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/asm.rs:121:29 [INFO] [stdout] | [INFO] [stdout] 121 | Self::Reg(x) => format!("{}", x.name_x86()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `x.name_x86().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/asm.rs:324:32 [INFO] [stdout] | [INFO] [stdout] 324 | index: variable.stack_offset as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `variable.stack_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/asm.rs:367:32 [INFO] [stdout] | [INFO] [stdout] 367 | index: variable.stack_offset as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `variable.stack_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/asm.rs:481:5 [INFO] [stdout] | [INFO] [stdout] 481 | for (name, bl) in &func.blocks { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, (name, bl)) in func.blocks.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx` is used as a loop counter [INFO] [stdout] --> src/asm.rs:581:21 [INFO] [stdout] | [INFO] [stdout] 581 | for i in arguments { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx, i) in arguments.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/est.rs:65:31 [INFO] [stdout] | [INFO] [stdout] 65 | let mut out = format!("(EstroWord[]){{"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(EstroWord[]){".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/est.rs:76:31 [INFO] [stdout] | [INFO] [stdout] 76 | let mut out = format!("(EstroByte[]){{"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(EstroByte[]){".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/est.rs:155:35 [INFO] [stdout] | [INFO] [stdout] 155 | let mut out = format!("(EstroWord[]){{"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(EstroWord[]){".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/est.rs:166:35 [INFO] [stdout] | [INFO] [stdout] 166 | let mut out = format!("(EstroByte[]){{"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(EstroByte[]){".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/est.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | format!("{}", v.name) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `v.name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/est.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 340 | / if let Some(t) = stream.peek() { [INFO] [stdout] 341 | | if t.text == "(" { [INFO] [stdout] 342 | | let mut bytes = false; [INFO] [stdout] 343 | | let mut list = Vec::new(); [INFO] [stdout] ... | [INFO] [stdout] 360 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 340 ~ if let Some(t) = stream.peek() [INFO] [stdout] 341 ~ && t.text == "(" { [INFO] [stdout] 342 | let mut bytes = false; [INFO] [stdout] ... [INFO] [stdout] 358 | } [INFO] [stdout] 359 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/est.rs:351:23 [INFO] [stdout] | [INFO] [stdout] 351 | while let Some(_) = x.peek() { [INFO] [stdout] | ----------^^^^^^^----------- help: try: `while x.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/est.rs:407:13 [INFO] [stdout] | [INFO] [stdout] 407 | / return Ok(( [INFO] [stdout] 408 | | name, [INFO] [stdout] 409 | | Static { [INFO] [stdout] 410 | | variable: var, [INFO] [stdout] ... | [INFO] [stdout] 414 | | }, [INFO] [stdout] 415 | | )); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 407 ~ Ok(( [INFO] [stdout] 408 + name, [INFO] [stdout] 409 + Static { [INFO] [stdout] 410 + variable: var, [INFO] [stdout] 411 + literal: x, [INFO] [stdout] 412 + inline: is_inline, [INFO] [stdout] 413 + external: is_external, [INFO] [stdout] 414 + }, [INFO] [stdout] 415 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/x86.rs:50:16 [INFO] [stdout] | [INFO] [stdout] 50 | if name != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/est.rs:994:24 [INFO] [stdout] | [INFO] [stdout] 994 | if !cmd_toks.peek().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cmd_toks.peek().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:137:49 [INFO] [stdout] | [INFO] [stdout] 137 | ... out += &format!("\tfadd d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfadd d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:141:49 [INFO] [stdout] | [INFO] [stdout] 141 | ... out += &format!("\tfsub d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfsub d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:145:49 [INFO] [stdout] | [INFO] [stdout] 145 | ... out += &format!("\tfdiv d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfdiv d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:149:49 [INFO] [stdout] | [INFO] [stdout] 149 | ... out += &format!("\tfmul d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfmul d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:153:49 [INFO] [stdout] | [INFO] [stdout] 153 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:157:49 [INFO] [stdout] | [INFO] [stdout] 157 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:161:49 [INFO] [stdout] | [INFO] [stdout] 161 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:165:49 [INFO] [stdout] | [INFO] [stdout] 165 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:169:49 [INFO] [stdout] | [INFO] [stdout] 169 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:173:49 [INFO] [stdout] | [INFO] [stdout] 173 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/est.rs:1124:16 [INFO] [stdout] | [INFO] [stdout] 1124 | out += &name; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/est.rs:1154:16 [INFO] [stdout] | [INFO] [stdout] 1154 | out += &name; [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/rtils.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | / loop { [INFO] [stdout] 44 | | let Some(i) = fmt.next() else { [INFO] [stdout] 45 | | break; [INFO] [stdout] 46 | | }; [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(i) = fmt.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/rtils.rs:2227:17 [INFO] [stdout] | [INFO] [stdout] 2227 | / for i in 0..self.len { [INFO] [stdout] 2228 | | buf2[i] = self.buf[i]; [INFO] [stdout] 2229 | | } [INFO] [stdout] | |_________________^ help: try replacing the loop by: `buf2[..self.len].copy_from_slice(&self.buf[..self.len]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/rtils.rs:2299:9 [INFO] [stdout] | [INFO] [stdout] 2299 | / loop { [INFO] [stdout] 2300 | | let Some(c) = it.next() else { [INFO] [stdout] 2301 | | break; [INFO] [stdout] 2302 | | }; [INFO] [stdout] ... | [INFO] [stdout] 2330 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(c) = it.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/rtils.rs:2309:37 [INFO] [stdout] | [INFO] [stdout] 2309 | } else if c1 == 'd' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2310 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2311 | | index += 1; [INFO] [stdout] 2312 | | } else if c1 == 'f' { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/rtils.rs:2312:37 [INFO] [stdout] | [INFO] [stdout] 2312 | } else if c1 == 'f' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2313 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2314 | | index += 1; [INFO] [stdout] 2315 | | } else if c1 == 's' { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/rtils.rs:2312:37 [INFO] [stdout] | [INFO] [stdout] 2312 | } else if c1 == 'f' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2313 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2314 | | index += 1; [INFO] [stdout] 2315 | | } else if c1 == 's' { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/rtils.rs:2315:37 [INFO] [stdout] | [INFO] [stdout] 2315 | } else if c1 == 's' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2316 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2317 | | index += 1; [INFO] [stdout] 2318 | | } else if c1 == 'u' { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/rtils.rs:2315:37 [INFO] [stdout] | [INFO] [stdout] 2315 | } else if c1 == 's' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2316 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2317 | | index += 1; [INFO] [stdout] 2318 | | } else if c1 == 'u' { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/rtils.rs:2318:37 [INFO] [stdout] | [INFO] [stdout] 2318 | } else if c1 == 'u' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2319 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2320 | | index += 1; [INFO] [stdout] 2321 | | } else if c1 == '*' { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/rtils.rs:2318:37 [INFO] [stdout] | [INFO] [stdout] 2318 | } else if c1 == 'u' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2319 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2320 | | index += 1; [INFO] [stdout] 2321 | | } else if c1 == '*' { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/rtils.rs:2321:37 [INFO] [stdout] | [INFO] [stdout] 2321 | } else if c1 == '*' { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 2322 | | out.concat_writeable(&args[index]); [INFO] [stdout] 2323 | | index += 1; [INFO] [stdout] 2324 | | } else { [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> src/rtils.rs:2348:33 [INFO] [stdout] | [INFO] [stdout] 2348 | fn clone(&self) -> Self { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 2349 | | Self { ptr: self.ptr } [INFO] [stdout] 2350 | | } [INFO] [stdout] | |_________^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/x86.rs:50:16 [INFO] [stdout] | [INFO] [stdout] 50 | if name != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:137:49 [INFO] [stdout] | [INFO] [stdout] 137 | ... out += &format!("\tfadd d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfadd d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:141:49 [INFO] [stdout] | [INFO] [stdout] 141 | ... out += &format!("\tfsub d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfsub d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:145:49 [INFO] [stdout] | [INFO] [stdout] 145 | ... out += &format!("\tfdiv d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfdiv d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:149:49 [INFO] [stdout] | [INFO] [stdout] 149 | ... out += &format!("\tfmul d0, d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfmul d0, d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:153:49 [INFO] [stdout] | [INFO] [stdout] 153 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:157:49 [INFO] [stdout] | [INFO] [stdout] 157 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:161:49 [INFO] [stdout] | [INFO] [stdout] 161 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:165:49 [INFO] [stdout] | [INFO] [stdout] 165 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:169:49 [INFO] [stdout] | [INFO] [stdout] 169 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/x86.rs:173:49 [INFO] [stdout] | [INFO] [stdout] 173 | ... out += &format!("\tfcmp,d1, d2\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\tfcmp,d1, d2\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.14s [INFO] running `Command { std: "docker" "inspect" "2815fc82096a00c581129246657cf32d2a98976a05e206483ae474d2e3c7fcf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2815fc82096a00c581129246657cf32d2a98976a05e206483ae474d2e3c7fcf7", kill_on_drop: false }` [INFO] [stdout] 2815fc82096a00c581129246657cf32d2a98976a05e206483ae474d2e3c7fcf7