[INFO] cloning repository https://github.com/Maykeye/AoC2022 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Maykeye/AoC2022" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMaykeye%2FAoC2022", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMaykeye%2FAoC2022'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1798e29f5abace46c4cb6f7f5b895867a1be487e [INFO] linting Maykeye/AoC2022 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMaykeye%2FAoC2022" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Maykeye/AoC2022 [INFO] finished tweaking git repo https://github.com/Maykeye/AoC2022 [INFO] tweaked toml for git repo https://github.com/Maykeye/AoC2022 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Maykeye/AoC2022 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Maykeye/AoC2022 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a86e91845ecc1bb835238833646386b1b143bed4e5770c804e9cf48b0f00389c [INFO] running `Command { std: "docker" "start" "-a" "a86e91845ecc1bb835238833646386b1b143bed4e5770c804e9cf48b0f00389c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a86e91845ecc1bb835238833646386b1b143bed4e5770c804e9cf48b0f00389c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a86e91845ecc1bb835238833646386b1b143bed4e5770c804e9cf48b0f00389c", kill_on_drop: false }` [INFO] [stdout] a86e91845ecc1bb835238833646386b1b143bed4e5770c804e9cf48b0f00389c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa97f204471b2e2a0e8fb5dfe9ffc3f0b8cef3449370f520795b90ff6f095480 [INFO] running `Command { std: "docker" "start" "-a" "aa97f204471b2e2a0e8fb5dfe9ffc3f0b8cef3449370f520795b90ff6f095480", kill_on_drop: false }` [INFO] [stderr] Checking helloworld v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/aoc2.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 100 | let round_score = Action::round_points(round.opponent, me); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 101 | round_score [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 100 ~ [INFO] [stdout] 101 ~ Action::round_points(round.opponent, me) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/aoc2.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 118 | let round_score = Action::round_points(round.opponent, me); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 119 | round_score [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 118 ~ [INFO] [stdout] 119 ~ Action::round_points(round.opponent, me) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/aoc3.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | if 'a' <= item && item <= 'z' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `('a'..='z').contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/aoc3.rs:42:35 [INFO] [stdout] | [INFO] [stdout] 42 | .map(|line| Backpack::new(&line)) [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/aoc7.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 228 | if line == &"$ cd /"{ [INFO] [stdout] | ^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `"$ cd /"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/aoc7.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 233 | if line == &"$ ls" { [INFO] [stdout] | ^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `"$ ls"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/aoc7.rs:237:12 [INFO] [stdout] | [INFO] [stdout] 237 | if line == &"$ cd .."{ [INFO] [stdout] | ^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `"$ cd .."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/aoc7.rs:243:29 [INFO] [stdout] | [INFO] [stdout] 243 | if line.starts_with(&cd_prefix){ [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `cd_prefix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return format!("input/aoc{}.txt", aoc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return format!("input/aoc{}.txt", aoc); [INFO] [stdout] 9 + format!("input/aoc{}.txt", aoc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | ! std::env::var("P2").is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("P2").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/utils.rs:21:38 [INFO] [stdout] | [INFO] [stdout] 21 | io::BufReader::new(file).lines().flatten().collect() [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/utils.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | io::BufReader::new(file).lines().flatten().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/aoc2.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 100 | let round_score = Action::round_points(round.opponent, me); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 101 | round_score [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 100 ~ [INFO] [stdout] 101 ~ Action::round_points(round.opponent, me) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/aoc2.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 118 | let round_score = Action::round_points(round.opponent, me); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 119 | round_score [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 118 ~ [INFO] [stdout] 119 ~ Action::round_points(round.opponent, me) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/aoc3.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | if 'a' <= item && item <= 'z' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `('a'..='z').contains(&item)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/aoc3.rs:42:35 [INFO] [stdout] | [INFO] [stdout] 42 | .map(|line| Backpack::new(&line)) [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/aoc7.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 228 | if line == &"$ cd /"{ [INFO] [stdout] | ^^^^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `"$ cd /"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/aoc7.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 233 | if line == &"$ ls" { [INFO] [stdout] | ^^^^^^^^------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `"$ ls"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/aoc7.rs:237:12 [INFO] [stdout] | [INFO] [stdout] 237 | if line == &"$ cd .."{ [INFO] [stdout] | ^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `"$ cd .."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/aoc7.rs:243:29 [INFO] [stdout] | [INFO] [stdout] 243 | if line.starts_with(&cd_prefix){ [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `cd_prefix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return format!("input/aoc{}.txt", aoc); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return format!("input/aoc{}.txt", aoc); [INFO] [stdout] 9 + format!("input/aoc{}.txt", aoc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | ! std::env::var("P2").is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("P2").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/utils.rs:21:38 [INFO] [stdout] | [INFO] [stdout] 21 | io::BufReader::new(file).lines().flatten().collect() [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/utils.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | io::BufReader::new(file).lines().flatten().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.46s [INFO] running `Command { std: "docker" "inspect" "aa97f204471b2e2a0e8fb5dfe9ffc3f0b8cef3449370f520795b90ff6f095480", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa97f204471b2e2a0e8fb5dfe9ffc3f0b8cef3449370f520795b90ff6f095480", kill_on_drop: false }` [INFO] [stdout] aa97f204471b2e2a0e8fb5dfe9ffc3f0b8cef3449370f520795b90ff6f095480