[INFO] cloning repository https://github.com/MaximShildyakov/FileSearcher [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MaximShildyakov/FileSearcher" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMaximShildyakov%2FFileSearcher", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMaximShildyakov%2FFileSearcher'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c007afda34b0c6e12b44bd190a710f98a3e35d4d [INFO] linting MaximShildyakov/FileSearcher against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMaximShildyakov%2FFileSearcher" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MaximShildyakov/FileSearcher [INFO] finished tweaking git repo https://github.com/MaximShildyakov/FileSearcher [INFO] tweaked toml for git repo https://github.com/MaximShildyakov/FileSearcher written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MaximShildyakov/FileSearcher on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MaximShildyakov/FileSearcher already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b9f7cb1bcb1e163d6d5d6978bb096ab68d48e57121626b986752b5c466df9d0 [INFO] running `Command { std: "docker" "start" "-a" "8b9f7cb1bcb1e163d6d5d6978bb096ab68d48e57121626b986752b5c466df9d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b9f7cb1bcb1e163d6d5d6978bb096ab68d48e57121626b986752b5c466df9d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b9f7cb1bcb1e163d6d5d6978bb096ab68d48e57121626b986752b5c466df9d0", kill_on_drop: false }` [INFO] [stdout] 8b9f7cb1bcb1e163d6d5d6978bb096ab68d48e57121626b986752b5c466df9d0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5f052519d89f303cf37eb084762a235235a61aca6cf6a60efab386c024d31186 [INFO] running `Command { std: "docker" "start" "-a" "5f052519d89f303cf37eb084762a235235a61aca6cf6a60efab386c024d31186", kill_on_drop: false }` [INFO] [stderr] Checking FileSearcher2 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:74:19 [INFO] [stdout] | [INFO] [stdout] 74 | if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 - if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions{ [INFO] [stdout] 74 + if !(!is_no_extensions && !extensions.contains(&file_extension)){ [INFO] [stdout] | [INFO] [stdout] 74 - if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions{ [INFO] [stdout] 74 + if is_no_extensions || extensions.contains(&file_extension){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | / for entry in files{ [INFO] [stdout] 54 | | if let Ok(entry) = entry{ [INFO] [stdout] 55 | | let path = entry.path(); [INFO] [stdout] 56 | | let file_name = convert_os_str(path.file_stem()); [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | / if let Ok(entry) = entry{ [INFO] [stdout] 55 | | let path = entry.path(); [INFO] [stdout] 56 | | let file_name = convert_os_str(path.file_stem()); [INFO] [stdout] 57 | | let file_extension = convert_os_str(path.extension()); [INFO] [stdout] ... | [INFO] [stdout] 78 | | } [INFO] [stdout] | |________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 ~ for entry in files.flatten(){ [INFO] [stdout] 54 + let path = entry.path(); [INFO] [stdout] 55 + let file_name = convert_os_str(path.file_stem()); [INFO] [stdout] 56 + let file_extension = convert_os_str(path.extension()); [INFO] [stdout] 57 + [INFO] [stdout] 58 + if path.is_dir(){ [INFO] [stdout] 59 + if is_no_extensions && file_name.contains(filename){ [INFO] [stdout] 60 + file_found(&path, now, results_count) [INFO] [stdout] 61 + } [INFO] [stdout] 62 + [INFO] [stdout] 63 + search_files( [INFO] [stdout] 64 + path.to_str().unwrap_or_default(), [INFO] [stdout] 65 + filename, [INFO] [stdout] 66 + extensions, [INFO] [stdout] 67 + now, [INFO] [stdout] 68 + results_count [INFO] [stdout] 69 + ); [INFO] [stdout] 70 + } else if is_empty_filename && extensions.contains(&file_extension){ [INFO] [stdout] 71 + file_found(&path, now, results_count); [INFO] [stdout] 72 + } else if path.is_file() && file_name.contains(filename){ [INFO] [stdout] 73 + if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions{ [INFO] [stdout] 74 + file_found(&path, now, results_count); [INFO] [stdout] 75 + } [INFO] [stdout] 76 + } [INFO] [stdout] 77 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:73:19 [INFO] [stdout] | [INFO] [stdout] 73 | } else if path.is_file() && file_name.contains(filename){ [INFO] [stdout] | ___________________^ [INFO] [stdout] 74 | | if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions{ [INFO] [stdout] 75 | | file_found(&path, now, results_count); [INFO] [stdout] 76 | | } [INFO] [stdout] 77 | | } [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 73 ~ } else if path.is_file() && file_name.contains(filename) [INFO] [stdout] 74 ~ && ((!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions){ [INFO] [stdout] 75 | file_found(&path, now, results_count); [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | print!(" - {} MB\n", metadata.len() as f64 / FILE_SIZE_BASE) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 107 - print!(" - {} MB\n", metadata.len() as f64 / FILE_SIZE_BASE) [INFO] [stdout] 107 + println!(" - {} MB", metadata.len() as f64 / FILE_SIZE_BASE) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:74:19 [INFO] [stdout] | [INFO] [stdout] 74 | if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 - if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions{ [INFO] [stdout] 74 + if !(!is_no_extensions && !extensions.contains(&file_extension)){ [INFO] [stdout] | [INFO] [stdout] 74 - if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions{ [INFO] [stdout] 74 + if is_no_extensions || extensions.contains(&file_extension){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | / for entry in files{ [INFO] [stdout] 54 | | if let Ok(entry) = entry{ [INFO] [stdout] 55 | | let path = entry.path(); [INFO] [stdout] 56 | | let file_name = convert_os_str(path.file_stem()); [INFO] [stdout] ... | [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | / if let Ok(entry) = entry{ [INFO] [stdout] 55 | | let path = entry.path(); [INFO] [stdout] 56 | | let file_name = convert_os_str(path.file_stem()); [INFO] [stdout] 57 | | let file_extension = convert_os_str(path.extension()); [INFO] [stdout] ... | [INFO] [stdout] 78 | | } [INFO] [stdout] | |________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 ~ for entry in files.flatten(){ [INFO] [stdout] 54 + let path = entry.path(); [INFO] [stdout] 55 + let file_name = convert_os_str(path.file_stem()); [INFO] [stdout] 56 + let file_extension = convert_os_str(path.extension()); [INFO] [stdout] 57 + [INFO] [stdout] 58 + if path.is_dir(){ [INFO] [stdout] 59 + if is_no_extensions && file_name.contains(filename){ [INFO] [stdout] 60 + file_found(&path, now, results_count) [INFO] [stdout] 61 + } [INFO] [stdout] 62 + [INFO] [stdout] 63 + search_files( [INFO] [stdout] 64 + path.to_str().unwrap_or_default(), [INFO] [stdout] 65 + filename, [INFO] [stdout] 66 + extensions, [INFO] [stdout] 67 + now, [INFO] [stdout] 68 + results_count [INFO] [stdout] 69 + ); [INFO] [stdout] 70 + } else if is_empty_filename && extensions.contains(&file_extension){ [INFO] [stdout] 71 + file_found(&path, now, results_count); [INFO] [stdout] 72 + } else if path.is_file() && file_name.contains(filename){ [INFO] [stdout] 73 + if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions{ [INFO] [stdout] 74 + file_found(&path, now, results_count); [INFO] [stdout] 75 + } [INFO] [stdout] 76 + } [INFO] [stdout] 77 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:73:19 [INFO] [stdout] | [INFO] [stdout] 73 | } else if path.is_file() && file_name.contains(filename){ [INFO] [stdout] | ___________________^ [INFO] [stdout] 74 | | if (!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions{ [INFO] [stdout] 75 | | file_found(&path, now, results_count); [INFO] [stdout] 76 | | } [INFO] [stdout] 77 | | } [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 73 ~ } else if path.is_file() && file_name.contains(filename) [INFO] [stdout] 74 ~ && ((!is_no_extensions && extensions.contains(&file_extension)) || is_no_extensions){ [INFO] [stdout] 75 | file_found(&path, now, results_count); [INFO] [stdout] 76 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | print!(" - {} MB\n", metadata.len() as f64 / FILE_SIZE_BASE) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 107 - print!(" - {} MB\n", metadata.len() as f64 / FILE_SIZE_BASE) [INFO] [stdout] 107 + println!(" - {} MB", metadata.len() as f64 / FILE_SIZE_BASE) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.16s [INFO] running `Command { std: "docker" "inspect" "5f052519d89f303cf37eb084762a235235a61aca6cf6a60efab386c024d31186", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f052519d89f303cf37eb084762a235235a61aca6cf6a60efab386c024d31186", kill_on_drop: false }` [INFO] [stdout] 5f052519d89f303cf37eb084762a235235a61aca6cf6a60efab386c024d31186