[INFO] cloning repository https://github.com/MaxRong/Rustoku [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MaxRong/Rustoku" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMaxRong%2FRustoku", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMaxRong%2FRustoku'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b95c08256b59cc97a99cfdd212263ab51d466e20 [INFO] linting MaxRong/Rustoku against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMaxRong%2FRustoku" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MaxRong/Rustoku [INFO] finished tweaking git repo https://github.com/MaxRong/Rustoku [INFO] tweaked toml for git repo https://github.com/MaxRong/Rustoku written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MaxRong/Rustoku on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MaxRong/Rustoku already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c69ea99c7606ed95ec17411e8658f14931c6723b0a72c1a5b5969b5eff398393 [INFO] running `Command { std: "docker" "start" "-a" "c69ea99c7606ed95ec17411e8658f14931c6723b0a72c1a5b5969b5eff398393", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c69ea99c7606ed95ec17411e8658f14931c6723b0a72c1a5b5969b5eff398393", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c69ea99c7606ed95ec17411e8658f14931c6723b0a72c1a5b5969b5eff398393", kill_on_drop: false }` [INFO] [stdout] c69ea99c7606ed95ec17411e8658f14931c6723b0a72c1a5b5969b5eff398393 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ed80a8f53ed7292a121303ecee7fd0ca430334092eb6e5e4e5768dbfe0b64feb [INFO] running `Command { std: "docker" "start" "-a" "ed80a8f53ed7292a121303ecee7fd0ca430334092eb6e5e4e5768dbfe0b64feb", kill_on_drop: false }` [INFO] [stderr] Checking rust_sudoku v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | let mut board: SudokuBoard = SudokuBoard::from(config).expect("Build failed"); // will panic if config is invalid. [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | let mut solved_board = BacktrackingSolver::run(&board).unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_board` is never used [INFO] [stdout] --> src/sudoku_board.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl SudokuBoard { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 43 | pub fn get_board(&self) -> &[[u8; 9]; 9] { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sudoku_board.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return &self.board; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return &self.board; [INFO] [stdout] 44 + &self.board [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `config` [INFO] [stdout] --> src/sudoku_board.rs:140:18 [INFO] [stdout] | [INFO] [stdout] 140 | for i in 0..9 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 140 - for i in 0..9 { [INFO] [stdout] 140 + for in config.iter().take(9) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `config` [INFO] [stdout] --> src/sudoku_board.rs:143:22 [INFO] [stdout] | [INFO] [stdout] 143 | for j in 0..9 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 143 - for j in 0..9 { [INFO] [stdout] 143 + for in config.iter().take(9) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sudoku_board.rs:152:17 [INFO] [stdout] | [INFO] [stdout] 152 | / if config[j][i] != 0 { [INFO] [stdout] 153 | | if !col_seen.insert(config[j][i]) { [INFO] [stdout] 154 | | return false; [INFO] [stdout] 155 | | } [INFO] [stdout] 156 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 152 ~ if config[j][i] != 0 [INFO] [stdout] 153 ~ && !col_seen.insert(config[j][i]) { [INFO] [stdout] 154 | return false; [INFO] [stdout] 155 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `r` is only used to index `config` [INFO] [stdout] --> src/sudoku_board.rs:164:26 [INFO] [stdout] | [INFO] [stdout] 164 | for r in box_row..box_row + 3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 164 - for r in box_row..box_row + 3 { [INFO] [stdout] 164 + for in config.iter().skip(box_row).take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is only used to index `config` [INFO] [stdout] --> src/sudoku_board.rs:165:30 [INFO] [stdout] | [INFO] [stdout] 165 | for c in box_col..box_col + 3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 165 - for c in box_col..box_col + 3 { [INFO] [stdout] 165 + for in config.iter().skip(box_col).take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sudoku_board.rs:166:25 [INFO] [stdout] | [INFO] [stdout] 166 | / if config[r][c] != 0 { [INFO] [stdout] 167 | | if !box_seen.insert(config[r][c]) { [INFO] [stdout] 168 | | return false; [INFO] [stdout] 169 | | } [INFO] [stdout] 170 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 166 ~ if config[r][c] != 0 [INFO] [stdout] 167 ~ && !box_seen.insert(config[r][c]) { [INFO] [stdout] 168 | return false; [INFO] [stdout] 169 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sudoku_board.rs:285:17 [INFO] [stdout] | [INFO] [stdout] 285 | assert!(!board.try_place((0, 0), 4).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `board.try_place((0, 0), 4).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/sudoku_board.rs:284:9 [INFO] [stdout] | [INFO] [stdout] 284 | board.try_place((0, 0), 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 284 | let _ = board.try_place((0, 0), 3); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/sudoku_board.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 287 | board.try_place((0, 0), 0); // clear placed number from previous test. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 287 | let _ = board.try_place((0, 0), 0); // clear placed number from previous test. [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | let mut board: SudokuBoard = SudokuBoard::from(config).expect("Build failed"); // will panic if config is invalid. [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | let mut solved_board = BacktrackingSolver::run(&board).unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `initial_mask` is never read [INFO] [stdout] --> src/sudoku_board.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct SudokuBoard { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 6 | board: [[u8; 9]; 9], [INFO] [stdout] 7 | initial_mask: [[bool; 9]; 9], [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SudokuBoard` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_board` and `try_place` are never used [INFO] [stdout] --> src/sudoku_board.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 10 | impl SudokuBoard { [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 43 | pub fn get_board(&self) -> &[[u8; 9]; 9] { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 47 | pub fn try_place(&mut self, cell: (u8, u8), num: u8) -> Result<(), &'static str> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sudoku_board.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return &self.board; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return &self.board; [INFO] [stdout] 44 + &self.board [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `config` [INFO] [stdout] --> src/sudoku_board.rs:140:18 [INFO] [stdout] | [INFO] [stdout] 140 | for i in 0..9 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 140 - for i in 0..9 { [INFO] [stdout] 140 + for in config.iter().take(9) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `config` [INFO] [stdout] --> src/sudoku_board.rs:143:22 [INFO] [stdout] | [INFO] [stdout] 143 | for j in 0..9 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 143 - for j in 0..9 { [INFO] [stdout] 143 + for in config.iter().take(9) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sudoku_board.rs:152:17 [INFO] [stdout] | [INFO] [stdout] 152 | / if config[j][i] != 0 { [INFO] [stdout] 153 | | if !col_seen.insert(config[j][i]) { [INFO] [stdout] 154 | | return false; [INFO] [stdout] 155 | | } [INFO] [stdout] 156 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 152 ~ if config[j][i] != 0 [INFO] [stdout] 153 ~ && !col_seen.insert(config[j][i]) { [INFO] [stdout] 154 | return false; [INFO] [stdout] 155 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `r` is only used to index `config` [INFO] [stdout] --> src/sudoku_board.rs:164:26 [INFO] [stdout] | [INFO] [stdout] 164 | for r in box_row..box_row + 3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 164 - for r in box_row..box_row + 3 { [INFO] [stdout] 164 + for in config.iter().skip(box_row).take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is only used to index `config` [INFO] [stdout] --> src/sudoku_board.rs:165:30 [INFO] [stdout] | [INFO] [stdout] 165 | for c in box_col..box_col + 3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 165 - for c in box_col..box_col + 3 { [INFO] [stdout] 165 + for in config.iter().skip(box_col).take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sudoku_board.rs:166:25 [INFO] [stdout] | [INFO] [stdout] 166 | / if config[r][c] != 0 { [INFO] [stdout] 167 | | if !box_seen.insert(config[r][c]) { [INFO] [stdout] 168 | | return false; [INFO] [stdout] 169 | | } [INFO] [stdout] 170 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 166 ~ if config[r][c] != 0 [INFO] [stdout] 167 ~ && !box_seen.insert(config[r][c]) { [INFO] [stdout] 168 | return false; [INFO] [stdout] 169 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.28s [INFO] running `Command { std: "docker" "inspect" "ed80a8f53ed7292a121303ecee7fd0ca430334092eb6e5e4e5768dbfe0b64feb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed80a8f53ed7292a121303ecee7fd0ca430334092eb6e5e4e5768dbfe0b64feb", kill_on_drop: false }` [INFO] [stdout] ed80a8f53ed7292a121303ecee7fd0ca430334092eb6e5e4e5768dbfe0b64feb