[INFO] cloning repository https://github.com/MatchaChoco010/vulkanalia-descriptor-heap-test [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MatchaChoco010/vulkanalia-descriptor-heap-test" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMatchaChoco010%2Fvulkanalia-descriptor-heap-test", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMatchaChoco010%2Fvulkanalia-descriptor-heap-test'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 894136953135294ad09b9283adf801c425ba58d3 [INFO] linting MatchaChoco010/vulkanalia-descriptor-heap-test against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMatchaChoco010%2Fvulkanalia-descriptor-heap-test" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MatchaChoco010/vulkanalia-descriptor-heap-test [INFO] finished tweaking git repo https://github.com/MatchaChoco010/vulkanalia-descriptor-heap-test [INFO] tweaked toml for git repo https://github.com/MatchaChoco010/vulkanalia-descriptor-heap-test written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MatchaChoco010/vulkanalia-descriptor-heap-test on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MatchaChoco010/vulkanalia-descriptor-heap-test already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded imgui-winit-support v0.13.0 [INFO] [stderr] Downloaded clap v4.5.59 [INFO] [stderr] Downloaded chlorine v1.0.13 [INFO] [stderr] Downloaded imgui v0.12.0 [INFO] [stderr] Downloaded clap_builder v4.5.59 [INFO] [stderr] Downloaded vulkanalia-sys v0.35.0 [INFO] [stderr] Downloaded vulkanalia v0.35.0 [INFO] [stderr] Downloaded glam v0.32.0 [INFO] [stderr] Downloaded imgui-sys v0.12.0 [INFO] [stderr] Downloaded vulkanalia-vma v0.9.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4cd2f39640121cddbaa8d3e697e7dec2f7e6bb5506a254a7eac5dd6d289c037a [INFO] running `Command { std: "docker" "start" "-a" "4cd2f39640121cddbaa8d3e697e7dec2f7e6bb5506a254a7eac5dd6d289c037a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4cd2f39640121cddbaa8d3e697e7dec2f7e6bb5506a254a7eac5dd6d289c037a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4cd2f39640121cddbaa8d3e697e7dec2f7e6bb5506a254a7eac5dd6d289c037a", kill_on_drop: false }` [INFO] [stdout] 4cd2f39640121cddbaa8d3e697e7dec2f7e6bb5506a254a7eac5dd6d289c037a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7be105dc46d1403e3a65c815a83482b1e021759cdaf3115b88bb330539ffe835 [INFO] running `Command { std: "docker" "start" "-a" "7be105dc46d1403e3a65c815a83482b1e021759cdaf3115b88bb330539ffe835", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling wayland-sys v0.31.8 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling wayland-backend v0.3.12 [INFO] [stderr] Compiling quick-xml v0.38.4 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Compiling wayland-client v0.31.12 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking vulkanalia-sys v0.35.0 [INFO] [stderr] Compiling vulkanalia-vma v0.9.0 [INFO] [stderr] Compiling syn v2.0.116 [INFO] [stderr] Compiling imgui-sys v0.12.0 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling wayland-scanner v0.31.8 [INFO] [stderr] Checking chlorine v1.0.13 [INFO] [stderr] Checking mint v0.5.9 [INFO] [stderr] Checking zune-core v0.5.1 [INFO] [stderr] Checking zune-jpeg v0.5.12 [INFO] [stderr] Checking png v0.18.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking memmap2 v0.9.10 [INFO] [stderr] Checking clap_builder v4.5.59 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Compiling inflections v1.1.1 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.39 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking wayland-protocols v0.32.10 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking wayland-cursor v0.31.12 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Compiling gltf-derive v1.4.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking glam v0.32.0 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Compiling gltf-viewer-descriptor-heap v0.1.0 (/opt/rustwide/workdir/gltf-viewer-descriptor-heap) [INFO] [stderr] Compiling ibl-baker v0.1.0 (/opt/rustwide/workdir/ibl-baker) [INFO] [stderr] Checking clap v4.5.59 [INFO] [stderr] Compiling gltf-viewer v0.1.0 (/opt/rustwide/workdir/gltf-viewer) [INFO] [stderr] warning: gltf-viewer@0.1.0: slangc was not found; generating placeholder SPIR-V files. Set SLANGC or PATH to resolve this. [INFO] [stderr] warning: gltf-viewer-descriptor-heap@0.1.0: glslangValidator was not found; generating placeholder SPIR-V files. Set GLSLANG_VALIDATOR or PATH to resolve this. [INFO] [stderr] warning: ibl-baker@0.1.0: slangc was not found; generating placeholder SPIR-V files. Set SLANGC or PATH to resolve this. [INFO] [stderr] Checking imgui v0.12.0 [INFO] [stderr] Checking gltf-json v1.4.1 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.10 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.10 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking vulkanalia v0.35.0 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking gltf v1.4.1 [INFO] [stderr] Checking imgui-winit-support v0.13.0 [INFO] [stderr] Checking imgui-rs-vulkanalia-renderer v0.1.0 (/opt/rustwide/workdir/imgui-rs-vulkanalia-renderer) [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> imgui-rs-vulkanalia-renderer/src/renderer.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | / pub fn new( [INFO] [stdout] 90 | | instance: &Instance, [INFO] [stdout] 91 | | physical_device: vk::PhysicalDevice, [INFO] [stdout] 92 | | device: Device, [INFO] [stdout] ... | [INFO] [stdout] 97 | | max_frames_in_flight: usize, [INFO] [stdout] 98 | | ) -> Result { [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> imgui-rs-vulkanalia-renderer/src/renderer.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | / pub fn new( [INFO] [stdout] 90 | | instance: &Instance, [INFO] [stdout] 91 | | physical_device: vk::PhysicalDevice, [INFO] [stdout] 92 | | device: Device, [INFO] [stdout] ... | [INFO] [stdout] 97 | | max_frames_in_flight: usize, [INFO] [stdout] 98 | | ) -> Result { [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> imgui-rs-vulkanalia-renderer/src/vulkan.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 79 | if code.len() % std::mem::size_of::() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!code.len().is_multiple_of(std::mem::size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> imgui-rs-vulkanalia-renderer/src/vulkan.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 79 | if code.len() % std::mem::size_of::() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!code.len().is_multiple_of(std::mem::size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `channel` is used to index `out` [INFO] [stdout] --> ibl-baker/src/main.rs:591:24 [INFO] [stdout] | [INFO] [stdout] 591 | for channel in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 591 - for channel in 0..4 { [INFO] [stdout] 591 + for (channel, ) in out.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `channel` is used to index `out` [INFO] [stdout] --> ibl-baker/src/main.rs:591:24 [INFO] [stdout] | [INFO] [stdout] 591 | for channel in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 591 - for channel in 0..4 { [INFO] [stdout] 591 + for (channel, ) in out.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> ibl-baker/src/main.rs:894:12 [INFO] [stdout] | [INFO] [stdout] 894 | if code.len() % std::mem::size_of::() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!code.len().is_multiple_of(std::mem::size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> ibl-baker/src/main.rs:894:12 [INFO] [stdout] | [INFO] [stdout] 894 | if code.len() % std::mem::size_of::() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!code.len().is_multiple_of(std::mem::size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> gltf-viewer/src/app.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 173 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 171 ~ WindowEvent::MouseInput { state, button, .. } [INFO] [stdout] 172 ~ if !self.imgui_wants_mouse_capture() => { [INFO] [stdout] 173 | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 | } [INFO] [stdout] 176 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> gltf-viewer/src/app.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 180 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 | | } [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 178 ~ WindowEvent::CursorMoved { position, .. } [INFO] [stdout] 179 ~ if !self.imgui_wants_mouse_capture() => { [INFO] [stdout] 180 | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 | } [INFO] [stdout] 183 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> gltf-viewer/src/app.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 186 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 187 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 | | } [INFO] [stdout] 190 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 185 ~ WindowEvent::MouseWheel { delta, .. } [INFO] [stdout] 186 ~ if !self.imgui_wants_mouse_capture() => { [INFO] [stdout] 187 | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 | } [INFO] [stdout] 190 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer/src/app.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 173 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ if !self.imgui_wants_mouse_capture() [INFO] [stdout] 173 ~ && let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer/src/app.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 180 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 | | } [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 179 ~ if !self.imgui_wants_mouse_capture() [INFO] [stdout] 180 ~ && let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer/src/app.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 186 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 187 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 | | } [INFO] [stdout] 190 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 186 ~ if !self.imgui_wants_mouse_capture() [INFO] [stdout] 187 ~ && let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer/src/app.rs:224:17 [INFO] [stdout] | [INFO] [stdout] 224 | / if !self.exiting { [INFO] [stdout] 225 | | if let Some(window) = &self.window { [INFO] [stdout] 226 | | window.request_redraw(); [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 224 ~ if !self.exiting [INFO] [stdout] 225 ~ && let Some(window) = &self.window { [INFO] [stdout] 226 | window.request_redraw(); [INFO] [stdout] 227 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer/src/camera.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / if self.dragging { [INFO] [stdout] 56 | | if let Some((last_x, last_y)) = self.last_cursor_position { [INFO] [stdout] 57 | | let delta_x = (x - last_x) as f32; [INFO] [stdout] 58 | | let delta_y = (y - last_y) as f32; [INFO] [stdout] ... | [INFO] [stdout] 64 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 55 ~ if self.dragging [INFO] [stdout] 56 ~ && let Some((last_x, last_y)) = self.last_cursor_position { [INFO] [stdout] 57 | let delta_x = (x - last_x) as f32; [INFO] [stdout] ... [INFO] [stdout] 62 | self.pitch = self.pitch.clamp(-1.5, 1.5); [INFO] [stdout] 63 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> gltf-viewer/src/renderer/passes/geometry_pass.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / pub(in crate::renderer) fn create( [INFO] [stdout] 25 | | device: &Device, [INFO] [stdout] 26 | | allocator: &Allocator, [INFO] [stdout] 27 | | max_frames_in_flight: usize, [INFO] [stdout] ... | [INFO] [stdout] 32 | | ibl_textures: &IblTextures, [INFO] [stdout] 33 | | ) -> Result { [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> gltf-viewer/src/renderer/passes/tone_mapping_pass.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 212 | / pub(in crate::renderer) fn record( [INFO] [stdout] 213 | | &self, [INFO] [stdout] 214 | | device: &Device, [INFO] [stdout] 215 | | command_buffer: vk::CommandBuffer, [INFO] [stdout] ... | [INFO] [stdout] 220 | | exposure: f32, [INFO] [stdout] 221 | | ) -> Result<()> { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> gltf-viewer/src/renderer.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub(crate) mod renderer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> gltf-viewer/src/renderer/resources.rs:214:8 [INFO] [stdout] | [INFO] [stdout] 214 | if code.len() % std::mem::size_of::() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!code.len().is_multiple_of(std::mem::size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> gltf-viewer/src/renderer/resources.rs:417:1 [INFO] [stdout] | [INFO] [stdout] 417 | / pub(in crate::renderer) fn create_texture_image( [INFO] [stdout] 418 | | device: &Device, [INFO] [stdout] 419 | | allocator: &Allocator, [INFO] [stdout] 420 | | graphics_queue: vk::Queue, [INFO] [stdout] ... | [INFO] [stdout] 425 | | format: vk::Format, [INFO] [stdout] 426 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> gltf-viewer/src/renderer/resources.rs:574:1 [INFO] [stdout] | [INFO] [stdout] 574 | / pub(in crate::renderer) fn create_texture_image_f32( [INFO] [stdout] 575 | | device: &Device, [INFO] [stdout] 576 | | allocator: &Allocator, [INFO] [stdout] 577 | | graphics_queue: vk::Queue, [INFO] [stdout] ... | [INFO] [stdout] 582 | | format: vk::Format, [INFO] [stdout] 583 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> gltf-viewer/src/renderer/renderer.rs:377:31 [INFO] [stdout] | [INFO] [stdout] 377 | let required_layers = vec![ [INFO] [stdout] | _______________________________^ [INFO] [stdout] 378 | | #[cfg(feature = "validation-enabled")] [INFO] [stdout] 379 | | CString::new("VK_LAYER_KHRONOS_validation")?, [INFO] [stdout] 380 | | ]; [INFO] [stdout] | |_________^ help: you can use an array directly: `[CString::new("VK_LAYER_KHRONOS_validation")?]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 173 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 171 ~ WindowEvent::MouseInput { state, button, .. } [INFO] [stdout] 172 ~ if !self.imgui_wants_mouse_capture() => { [INFO] [stdout] 173 | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 | } [INFO] [stdout] 176 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 180 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 | | } [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 178 ~ WindowEvent::CursorMoved { position, .. } [INFO] [stdout] 179 ~ if !self.imgui_wants_mouse_capture() => { [INFO] [stdout] 180 | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 | } [INFO] [stdout] 183 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 186 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 187 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 | | } [INFO] [stdout] 190 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 185 ~ WindowEvent::MouseWheel { delta, .. } [INFO] [stdout] 186 ~ if !self.imgui_wants_mouse_capture() => { [INFO] [stdout] 187 | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 | } [INFO] [stdout] 190 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 173 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ if !self.imgui_wants_mouse_capture() [INFO] [stdout] 173 ~ && let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 180 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 | | } [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 179 ~ if !self.imgui_wants_mouse_capture() [INFO] [stdout] 180 ~ && let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 186 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 187 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 | | } [INFO] [stdout] 190 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 186 ~ if !self.imgui_wants_mouse_capture() [INFO] [stdout] 187 ~ && let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:224:17 [INFO] [stdout] | [INFO] [stdout] 224 | / if !self.exiting { [INFO] [stdout] 225 | | if let Some(window) = &self.window { [INFO] [stdout] 226 | | window.request_redraw(); [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 224 ~ if !self.exiting [INFO] [stdout] 225 ~ && let Some(window) = &self.window { [INFO] [stdout] 226 | window.request_redraw(); [INFO] [stdout] 227 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> gltf-viewer/src/app.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 173 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 171 ~ WindowEvent::MouseInput { state, button, .. } [INFO] [stdout] 172 ~ if !self.imgui_wants_mouse_capture() => { [INFO] [stdout] 173 | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 | } [INFO] [stdout] 176 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/camera.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / if self.dragging { [INFO] [stdout] 56 | | if let Some((last_x, last_y)) = self.last_cursor_position { [INFO] [stdout] 57 | | let delta_x = (x - last_x) as f32; [INFO] [stdout] 58 | | let delta_y = (y - last_y) as f32; [INFO] [stdout] ... | [INFO] [stdout] 64 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 55 ~ if self.dragging [INFO] [stdout] 56 ~ && let Some((last_x, last_y)) = self.last_cursor_position { [INFO] [stdout] 57 | let delta_x = (x - last_x) as f32; [INFO] [stdout] ... [INFO] [stdout] 62 | self.pitch = self.pitch.clamp(-1.5, 1.5); [INFO] [stdout] 63 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> gltf-viewer/src/app.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 180 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 | | } [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 178 ~ WindowEvent::CursorMoved { position, .. } [INFO] [stdout] 179 ~ if !self.imgui_wants_mouse_capture() => { [INFO] [stdout] 180 | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 | } [INFO] [stdout] 183 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> gltf-viewer/src/app.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 186 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 187 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 | | } [INFO] [stdout] 190 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 185 ~ WindowEvent::MouseWheel { delta, .. } [INFO] [stdout] 186 ~ if !self.imgui_wants_mouse_capture() => { [INFO] [stdout] 187 | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 | } [INFO] [stdout] 190 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer/src/app.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 173 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ if !self.imgui_wants_mouse_capture() [INFO] [stdout] 173 ~ && let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer/src/app.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 180 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 | | } [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 179 ~ if !self.imgui_wants_mouse_capture() [INFO] [stdout] 180 ~ && let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer/src/app.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 186 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 187 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 | | } [INFO] [stdout] 190 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 186 ~ if !self.imgui_wants_mouse_capture() [INFO] [stdout] 187 ~ && let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer/src/app.rs:224:17 [INFO] [stdout] | [INFO] [stdout] 224 | / if !self.exiting { [INFO] [stdout] 225 | | if let Some(window) = &self.window { [INFO] [stdout] 226 | | window.request_redraw(); [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 224 ~ if !self.exiting [INFO] [stdout] 225 ~ && let Some(window) = &self.window { [INFO] [stdout] 226 | window.request_redraw(); [INFO] [stdout] 227 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer/src/camera.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / if self.dragging { [INFO] [stdout] 56 | | if let Some((last_x, last_y)) = self.last_cursor_position { [INFO] [stdout] 57 | | let delta_x = (x - last_x) as f32; [INFO] [stdout] 58 | | let delta_y = (y - last_y) as f32; [INFO] [stdout] ... | [INFO] [stdout] 64 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 55 ~ if self.dragging [INFO] [stdout] 56 ~ && let Some((last_x, last_y)) = self.last_cursor_position { [INFO] [stdout] 57 | let delta_x = (x - last_x) as f32; [INFO] [stdout] ... [INFO] [stdout] 62 | self.pitch = self.pitch.clamp(-1.5, 1.5); [INFO] [stdout] 63 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 173 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 171 ~ WindowEvent::MouseInput { state, button, .. } [INFO] [stdout] 172 ~ if !self.imgui_wants_mouse_capture() => { [INFO] [stdout] 173 | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 | } [INFO] [stdout] 176 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 180 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 | | } [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 178 ~ WindowEvent::CursorMoved { position, .. } [INFO] [stdout] 179 ~ if !self.imgui_wants_mouse_capture() => { [INFO] [stdout] 180 | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 | } [INFO] [stdout] 183 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 186 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 187 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 | | } [INFO] [stdout] 190 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 185 ~ WindowEvent::MouseWheel { delta, .. } [INFO] [stdout] 186 ~ if !self.imgui_wants_mouse_capture() => { [INFO] [stdout] 187 | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 | } [INFO] [stdout] 190 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 173 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 | | } [INFO] [stdout] 176 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ if !self.imgui_wants_mouse_capture() [INFO] [stdout] 173 ~ && let Some(renderer) = &mut self.renderer { [INFO] [stdout] 174 | renderer.on_mouse_input(state, button); [INFO] [stdout] 175 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 180 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 | | } [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 179 ~ if !self.imgui_wants_mouse_capture() [INFO] [stdout] 180 ~ && let Some(renderer) = &mut self.renderer { [INFO] [stdout] 181 | renderer.on_cursor_moved(position.x, position.y); [INFO] [stdout] 182 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 186 | / if !self.imgui_wants_mouse_capture() { [INFO] [stdout] 187 | | if let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 | | } [INFO] [stdout] 190 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 186 ~ if !self.imgui_wants_mouse_capture() [INFO] [stdout] 187 ~ && let Some(renderer) = &mut self.renderer { [INFO] [stdout] 188 | renderer.on_mouse_wheel(delta); [INFO] [stdout] 189 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/app.rs:224:17 [INFO] [stdout] | [INFO] [stdout] 224 | / if !self.exiting { [INFO] [stdout] 225 | | if let Some(window) = &self.window { [INFO] [stdout] 226 | | window.request_redraw(); [INFO] [stdout] 227 | | } [INFO] [stdout] 228 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 224 ~ if !self.exiting [INFO] [stdout] 225 ~ && let Some(window) = &self.window { [INFO] [stdout] 226 | window.request_redraw(); [INFO] [stdout] 227 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/camera.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / if self.dragging { [INFO] [stdout] 56 | | if let Some((last_x, last_y)) = self.last_cursor_position { [INFO] [stdout] 57 | | let delta_x = (x - last_x) as f32; [INFO] [stdout] 58 | | let delta_y = (y - last_y) as f32; [INFO] [stdout] ... | [INFO] [stdout] 64 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 55 ~ if self.dragging [INFO] [stdout] 56 ~ && let Some((last_x, last_y)) = self.last_cursor_position { [INFO] [stdout] 57 | let delta_x = (x - last_x) as f32; [INFO] [stdout] ... [INFO] [stdout] 62 | self.pitch = self.pitch.clamp(-1.5, 1.5); [INFO] [stdout] 63 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> gltf-viewer/src/renderer/passes/geometry_pass.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / pub(in crate::renderer) fn create( [INFO] [stdout] 25 | | device: &Device, [INFO] [stdout] 26 | | allocator: &Allocator, [INFO] [stdout] 27 | | max_frames_in_flight: usize, [INFO] [stdout] ... | [INFO] [stdout] 32 | | ibl_textures: &IblTextures, [INFO] [stdout] 33 | | ) -> Result { [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/renderer.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub(crate) mod renderer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/renderer.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub(crate) mod renderer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> gltf-viewer/src/renderer/passes/tone_mapping_pass.rs:212:5 [INFO] [stdout] | [INFO] [stdout] 212 | / pub(in crate::renderer) fn record( [INFO] [stdout] 213 | | &self, [INFO] [stdout] 214 | | device: &Device, [INFO] [stdout] 215 | | command_buffer: vk::CommandBuffer, [INFO] [stdout] ... | [INFO] [stdout] 220 | | exposure: f32, [INFO] [stdout] 221 | | ) -> Result<()> { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> gltf-viewer/src/renderer.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | pub(crate) mod renderer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> gltf-viewer/src/renderer/resources.rs:214:8 [INFO] [stdout] | [INFO] [stdout] 214 | if code.len() % std::mem::size_of::() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!code.len().is_multiple_of(std::mem::size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> gltf-viewer/src/renderer/resources.rs:417:1 [INFO] [stdout] | [INFO] [stdout] 417 | / pub(in crate::renderer) fn create_texture_image( [INFO] [stdout] 418 | | device: &Device, [INFO] [stdout] 419 | | allocator: &Allocator, [INFO] [stdout] 420 | | graphics_queue: vk::Queue, [INFO] [stdout] ... | [INFO] [stdout] 425 | | format: vk::Format, [INFO] [stdout] 426 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/renderer/resources.rs:253:8 [INFO] [stdout] | [INFO] [stdout] 253 | if code.len() % std::mem::size_of::() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!code.len().is_multiple_of(std::mem::size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> gltf-viewer/src/renderer/resources.rs:574:1 [INFO] [stdout] | [INFO] [stdout] 574 | / pub(in crate::renderer) fn create_texture_image_f32( [INFO] [stdout] 575 | | device: &Device, [INFO] [stdout] 576 | | allocator: &Allocator, [INFO] [stdout] 577 | | graphics_queue: vk::Queue, [INFO] [stdout] ... | [INFO] [stdout] 582 | | format: vk::Format, [INFO] [stdout] 583 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/renderer/resources.rs:505:1 [INFO] [stdout] | [INFO] [stdout] 505 | / pub(in crate::renderer) fn create_texture_image( [INFO] [stdout] 506 | | device: &Device, [INFO] [stdout] 507 | | allocator: &Allocator, [INFO] [stdout] 508 | | graphics_queue: vk::Queue, [INFO] [stdout] ... | [INFO] [stdout] 513 | | format: vk::Format, [INFO] [stdout] 514 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/renderer/resources.rs:664:1 [INFO] [stdout] | [INFO] [stdout] 664 | / pub(in crate::renderer) fn create_texture_image_f32( [INFO] [stdout] 665 | | device: &Device, [INFO] [stdout] 666 | | allocator: &Allocator, [INFO] [stdout] 667 | | graphics_queue: vk::Queue, [INFO] [stdout] ... | [INFO] [stdout] 672 | | format: vk::Format, [INFO] [stdout] 673 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> gltf-viewer/src/renderer/renderer.rs:377:31 [INFO] [stdout] | [INFO] [stdout] 377 | let required_layers = vec![ [INFO] [stdout] | _______________________________^ [INFO] [stdout] 378 | | #[cfg(feature = "validation-enabled")] [INFO] [stdout] 379 | | CString::new("VK_LAYER_KHRONOS_validation")?, [INFO] [stdout] 380 | | ]; [INFO] [stdout] | |_________^ help: you can use an array directly: `[CString::new("VK_LAYER_KHRONOS_validation")?]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/renderer/renderer.rs:876:31 [INFO] [stdout] | [INFO] [stdout] 876 | let required_layers = vec![ [INFO] [stdout] | _______________________________^ [INFO] [stdout] 877 | | #[cfg(feature = "validation-enabled")] [INFO] [stdout] 878 | | CString::new("VK_LAYER_KHRONOS_validation")?, [INFO] [stdout] 879 | | ]; [INFO] [stdout] | |_________^ help: you can use an array directly: `[CString::new("VK_LAYER_KHRONOS_validation")?]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/renderer/resources.rs:253:8 [INFO] [stdout] | [INFO] [stdout] 253 | if code.len() % std::mem::size_of::() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!code.len().is_multiple_of(std::mem::size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/renderer/resources.rs:505:1 [INFO] [stdout] | [INFO] [stdout] 505 | / pub(in crate::renderer) fn create_texture_image( [INFO] [stdout] 506 | | device: &Device, [INFO] [stdout] 507 | | allocator: &Allocator, [INFO] [stdout] 508 | | graphics_queue: vk::Queue, [INFO] [stdout] ... | [INFO] [stdout] 513 | | format: vk::Format, [INFO] [stdout] 514 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/renderer/resources.rs:664:1 [INFO] [stdout] | [INFO] [stdout] 664 | / pub(in crate::renderer) fn create_texture_image_f32( [INFO] [stdout] 665 | | device: &Device, [INFO] [stdout] 666 | | allocator: &Allocator, [INFO] [stdout] 667 | | graphics_queue: vk::Queue, [INFO] [stdout] ... | [INFO] [stdout] 672 | | format: vk::Format, [INFO] [stdout] 673 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> gltf-viewer-descriptor-heap/src/renderer/renderer.rs:876:31 [INFO] [stdout] | [INFO] [stdout] 876 | let required_layers = vec![ [INFO] [stdout] | _______________________________^ [INFO] [stdout] 877 | | #[cfg(feature = "validation-enabled")] [INFO] [stdout] 878 | | CString::new("VK_LAYER_KHRONOS_validation")?, [INFO] [stdout] 879 | | ]; [INFO] [stdout] | |_________^ help: you can use an array directly: `[CString::new("VK_LAYER_KHRONOS_validation")?]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 01s [INFO] running `Command { std: "docker" "inspect" "7be105dc46d1403e3a65c815a83482b1e021759cdaf3115b88bb330539ffe835", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7be105dc46d1403e3a65c815a83482b1e021759cdaf3115b88bb330539ffe835", kill_on_drop: false }` [INFO] [stdout] 7be105dc46d1403e3a65c815a83482b1e021759cdaf3115b88bb330539ffe835