[INFO] cloning repository https://github.com/Masoom-Wahid/filio [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Masoom-Wahid/filio" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMasoom-Wahid%2Ffilio", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMasoom-Wahid%2Ffilio'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0b06899e82aec66e2625f1aa3f72939cb5d708b2 [INFO] linting Masoom-Wahid/filio against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMasoom-Wahid%2Ffilio" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Masoom-Wahid/filio [INFO] finished tweaking git repo https://github.com/Masoom-Wahid/filio [INFO] tweaked toml for git repo https://github.com/Masoom-Wahid/filio written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Masoom-Wahid/filio on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Masoom-Wahid/filio already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anyhow v1.0.83 [INFO] [stderr] Downloaded syn v2.0.62 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7f90c97fe4082a6f8ebe36a7f2aaffe70fff833a3fe00d032d68c44b7f527bce [INFO] running `Command { std: "docker" "start" "-a" "7f90c97fe4082a6f8ebe36a7f2aaffe70fff833a3fe00d032d68c44b7f527bce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7f90c97fe4082a6f8ebe36a7f2aaffe70fff833a3fe00d032d68c44b7f527bce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f90c97fe4082a6f8ebe36a7f2aaffe70fff833a3fe00d032d68c44b7f527bce", kill_on_drop: false }` [INFO] [stdout] 7f90c97fe4082a6f8ebe36a7f2aaffe70fff833a3fe00d032d68c44b7f527bce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2441fa37a001d8b74b280c780723b5800c0966d4cd1f612588ccb94cd193105c [INFO] running `Command { std: "docker" "start" "-a" "2441fa37a001d8b74b280c780723b5800c0966d4cd1f612588ccb94cd193105c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling serde v1.0.201 [INFO] [stderr] Compiling anyhow v1.0.83 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling syn v2.0.62 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling serde_derive v1.0.201 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking filio v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/filio.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / return Self{ [INFO] [stdout] 41 | | input, [INFO] [stdout] 42 | | output, [INFO] [stdout] 43 | | extensions : str_to_vec(&extensions), [INFO] [stdout] ... | [INFO] [stdout] 46 | | names : str_to_vec(&names) [INFO] [stdout] 47 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ Self{ [INFO] [stdout] 41 + input, [INFO] [stdout] 42 + output, [INFO] [stdout] 43 + extensions : str_to_vec(&extensions), [INFO] [stdout] 44 + action, [INFO] [stdout] 45 + prefix, [INFO] [stdout] 46 + names : str_to_vec(&names) [INFO] [stdout] 47 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/core/filio.rs:72:41 [INFO] [stdout] | [INFO] [stdout] 72 | fn get_file_name(&self,event_path : &PathBuf) -> Result{ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 72 - fn get_file_name(&self,event_path : &PathBuf) -> Result{ [INFO] [stdout] 72 + fn get_file_name(&self,event_path : &Path) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/core/filio.rs:105:36 [INFO] [stdout] | [INFO] [stdout] 105 | if file_name.contains(&*name){ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 105 - if file_name.contains(&*name){ [INFO] [stdout] 105 + if file_name.contains(name){ [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 105 | if file_name.contains(&**name){ [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/filio.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / return Self{ [INFO] [stdout] 41 | | input, [INFO] [stdout] 42 | | output, [INFO] [stdout] 43 | | extensions : str_to_vec(&extensions), [INFO] [stdout] ... | [INFO] [stdout] 46 | | names : str_to_vec(&names) [INFO] [stdout] 47 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ Self{ [INFO] [stdout] 41 + input, [INFO] [stdout] 42 + output, [INFO] [stdout] 43 + extensions : str_to_vec(&extensions), [INFO] [stdout] 44 + action, [INFO] [stdout] 45 + prefix, [INFO] [stdout] 46 + names : str_to_vec(&names) [INFO] [stdout] 47 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/core/fil.rs:105:31 [INFO] [stdout] | [INFO] [stdout] 105 | for (_, filio) in &self.filios { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 105 - for (_, filio) in &self.filios { [INFO] [stdout] 105 + for filio in self.filios.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/core/filio.rs:72:41 [INFO] [stdout] | [INFO] [stdout] 72 | fn get_file_name(&self,event_path : &PathBuf) -> Result{ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 72 - fn get_file_name(&self,event_path : &PathBuf) -> Result{ [INFO] [stdout] 72 + fn get_file_name(&self,event_path : &Path) -> Result{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/core/filio.rs:105:36 [INFO] [stdout] | [INFO] [stdout] 105 | if file_name.contains(&*name){ [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 105 - if file_name.contains(&*name){ [INFO] [stdout] 105 + if file_name.contains(name){ [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 105 | if file_name.contains(&**name){ [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/tests/get_abs_path.rs:11:30 [INFO] [stdout] | [INFO] [stdout] 11 | ... .try_into()?; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&str` to `String` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 11 - .try_into()?; [INFO] [stdout] 11 + .into()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/core/fil.rs:105:31 [INFO] [stdout] | [INFO] [stdout] 105 | for (_, filio) in &self.filios { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 105 - for (_, filio) in &self.filios { [INFO] [stdout] 105 + for filio in self.filios.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests/fil_test.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | assert!(!fil.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `fil.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/tests/fil_test.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/tests/get_abs_path.rs:11:30 [INFO] [stdout] | [INFO] [stdout] 11 | ... .try_into()?; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&str` to `String` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 11 - .try_into()?; [INFO] [stdout] 11 + .into()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.56s [INFO] running `Command { std: "docker" "inspect" "2441fa37a001d8b74b280c780723b5800c0966d4cd1f612588ccb94cd193105c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2441fa37a001d8b74b280c780723b5800c0966d4cd1f612588ccb94cd193105c", kill_on_drop: false }` [INFO] [stdout] 2441fa37a001d8b74b280c780723b5800c0966d4cd1f612588ccb94cd193105c