[INFO] cloning repository https://github.com/Masoom-Wahid/Neoqlite
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Masoom-Wahid/Neoqlite" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMasoom-Wahid%2FNeoqlite", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMasoom-Wahid%2FNeoqlite'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 640ec7a14aef7ba3ba4fd0e42eb1ddb9a248ede1
[INFO] linting Masoom-Wahid/Neoqlite against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMasoom-Wahid%2FNeoqlite" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Masoom-Wahid/Neoqlite
[INFO] finished tweaking git repo https://github.com/Masoom-Wahid/Neoqlite
[INFO] tweaked toml for git repo https://github.com/Masoom-Wahid/Neoqlite written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Masoom-Wahid/Neoqlite on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Masoom-Wahid/Neoqlite already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] e41d8713dc463e79577584ad05117737ece3bd5df247a8d9389a97d0e0bf00ad
[INFO] running `Command { std: "docker" "start" "-a" "e41d8713dc463e79577584ad05117737ece3bd5df247a8d9389a97d0e0bf00ad", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "e41d8713dc463e79577584ad05117737ece3bd5df247a8d9389a97d0e0bf00ad", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "e41d8713dc463e79577584ad05117737ece3bd5df247a8d9389a97d0e0bf00ad", kill_on_drop: false }`
[INFO] [stdout] e41d8713dc463e79577584ad05117737ece3bd5df247a8d9389a97d0e0bf00ad
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 12a428b8ae6324de2727210b9d7d96ea3ca348fc8cd728fb799d6e2088d93dc7
[INFO] running `Command { std: "docker" "start" "-a" "12a428b8ae6324de2727210b9d7d96ea3ca348fc8cd728fb799d6e2088d93dc7", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.167
[INFO] [stderr]     Checking pin-project-lite v0.2.15
[INFO] [stderr]    Compiling tokio-macros v2.4.0
[INFO] [stderr]     Checking parking_lot_core v0.9.10
[INFO] [stderr]     Checking socket2 v0.5.8
[INFO] [stderr]     Checking signal-hook-registry v1.4.2
[INFO] [stderr]     Checking mio v1.0.3
[INFO] [stderr]     Checking parking_lot v0.12.3
[INFO] [stderr]     Checking tokio v1.42.0
[INFO] [stderr]     Checking neoqlite v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`)
[INFO] [stdout]   --> src/core/btree.rs:33:28
[INFO] [stdout]    |
[INFO] [stdout] 33 |         self.keys.len() == (self.order * 2 - 1) as usize
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.order * 2 - 1)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `extend` instead of `append` for adding the full range of a second vector
[INFO] [stdout]   --> src/core/btree.rs:97:13
[INFO] [stdout]    |
[INFO] [stdout] 97 |             child.children.extend(sibling.children.drain(..));
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `child.children.append(&mut sibling.children)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extend_with_drain
[INFO] [stdout]    = note: `#[warn(clippy::extend_with_drain)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: importing legacy numeric constants
[INFO] [stdout]  --> src/core/db.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 | use std::i64;
[INFO] [stdout]   |     ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: remove this import
[INFO] [stdout]   = note: then `i64::<CONST>` will resolve to the respective associated constant
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]   = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Schema`
[INFO] [stdout]   --> src/core/db.rs:73:5
[INFO] [stdout]    |
[INFO] [stdout] 73 | /     pub fn new() -> Self {
[INFO] [stdout] 74 | |         Self {
[INFO] [stdout] 75 | |             columns: HashSet::new(),
[INFO] [stdout] 76 | |             curr_order: 1,
[INFO] [stdout] 77 | |         }
[INFO] [stdout] 78 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 72 + impl Default for Schema {
[INFO] [stdout] 73 +     fn default() -> Self {
[INFO] [stdout] 74 +         Self::new()
[INFO] [stdout] 75 +     }
[INFO] [stdout] 76 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`)
[INFO] [stdout]   --> src/core/btree.rs:33:28
[INFO] [stdout]    |
[INFO] [stdout] 33 |         self.keys.len() == (self.order * 2 - 1) as usize
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.order * 2 - 1)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/core/db.rs:111:18
[INFO] [stdout]     |
[INFO] [stdout] 111 |         columns: &Vec<String>,
[INFO] [stdout]     |                  ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 111 -         columns: &Vec<String>,
[INFO] [stdout] 111 +         columns: &[String],
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/core/db.rs:112:17
[INFO] [stdout]     |
[INFO] [stdout] 112 |         values: &Vec<Expr>,
[INFO] [stdout]     |                 ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 112 -         values: &Vec<Expr>,
[INFO] [stdout] 112 +         values: &[Expr],
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/core/db.rs:116:35
[INFO] [stdout]     |
[INFO] [stdout] 116 |             match self.get_column(&col) {
[INFO] [stdout]     |                                   ^^^^ help: change this to: `col`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/core/db.rs:147:21
[INFO] [stdout]     |
[INFO] [stdout] 147 | /                     if col.constraints.contains(&Constraints::NotNull) {
[INFO] [stdout] 148 | |                         return Err(format!(
[INFO] [stdout] 149 | |                             "NOT NULL Constraint Failed on Column {}",
[INFO] [stdout] 150 | |                             &missing_key
[INFO] [stdout] 151 | |                         ));
[INFO] [stdout] 152 | |                     }
[INFO] [stdout]     | |_____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 146 ~                 Some(col)
[INFO] [stdout] 147 ~                     if col.constraints.contains(&Constraints::NotNull) => {
[INFO] [stdout] 148 |                         return Err(format!(
[INFO] [stdout] ...
[INFO] [stdout] 151 |                         ));
[INFO] [stdout] 152 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/core/db.rs:145:13
[INFO] [stdout]     |
[INFO] [stdout] 145 | /             match self.get_column(&missing_key) {
[INFO] [stdout] 146 | |                 Some(col) => {
[INFO] [stdout] 147 | |                     if col.constraints.contains(&Constraints::NotNull) {
[INFO] [stdout] 148 | |                         return Err(format!(
[INFO] [stdout] ...   |
[INFO] [stdout] 154 | |                 None => {}
[INFO] [stdout] 155 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 145 ~             if let Some(col) = self.get_column(&missing_key) {
[INFO] [stdout] 146 +                 if col.constraints.contains(&Constraints::NotNull) {
[INFO] [stdout] 147 +                     return Err(format!(
[INFO] [stdout] 148 +                         "NOT NULL Constraint Failed on Column {}",
[INFO] [stdout] 149 +                         &missing_key
[INFO] [stdout] 150 +                     ));
[INFO] [stdout] 151 +                 }
[INFO] [stdout] 152 +             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `extend` instead of `append` for adding the full range of a second vector
[INFO] [stdout]   --> src/core/btree.rs:97:13
[INFO] [stdout]    |
[INFO] [stdout] 97 |             child.children.extend(sibling.children.drain(..));
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `child.children.append(&mut sibling.children)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extend_with_drain
[INFO] [stdout]    = note: `#[warn(clippy::extend_with_drain)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/core/db.rs:145:35
[INFO] [stdout]     |
[INFO] [stdout] 145 |             match self.get_column(&missing_key) {
[INFO] [stdout]     |                                   ^^^^^^^^^^^^ help: change this to: `missing_key`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/core/db.rs:160:40
[INFO] [stdout]     |
[INFO] [stdout] 160 |     pub fn validate_row(&self, values: &Vec<String>) -> Result<(), String> {
[INFO] [stdout]     |                                        ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 160 -     pub fn validate_row(&self, values: &Vec<String>) -> Result<(), String> {
[INFO] [stdout] 160 +     pub fn validate_row(&self, values: &[String]) -> Result<(), String> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Table`
[INFO] [stdout]    --> src/core/db.rs:185:5
[INFO] [stdout]     |
[INFO] [stdout] 185 | /     pub fn new() -> Self {
[INFO] [stdout] 186 | |         Self {
[INFO] [stdout] 187 | |             schema: Schema::new(),
[INFO] [stdout] 188 | |             rows: BTree::new(2),
[INFO] [stdout] 189 | |         }
[INFO] [stdout] 190 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 184 + impl Default for Table {
[INFO] [stdout] 185 +     fn default() -> Self {
[INFO] [stdout] 186 +         Self::new()
[INFO] [stdout] 187 +     }
[INFO] [stdout] 188 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/core/db.rs:281:16
[INFO] [stdout]     |
[INFO] [stdout] 281 |             Ok(row.ok_or_else(|| "Couldnt find a row").cloned()?)
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 281 -             Ok(row.ok_or_else(|| "Couldnt find a row").cloned()?)
[INFO] [stdout] 281 +             Ok(row.ok_or("Couldnt find a row").cloned()?)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/core/db.rs:300:13
[INFO] [stdout]     |
[INFO] [stdout] 300 |             return Some(vec![result]);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 300 -             return Some(vec![result]);
[INFO] [stdout] 300 +             Some(vec![result])
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/core/db.rs:322:17
[INFO] [stdout]     |
[INFO] [stdout] 322 |                 return Some(result);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 322 -                 return Some(result);
[INFO] [stdout] 322 +                 Some(result)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Neoqlite`
[INFO] [stdout]    --> src/core/db.rs:337:5
[INFO] [stdout]     |
[INFO] [stdout] 337 | /     pub fn new() -> Self {
[INFO] [stdout] 338 | |         let mut tables = HashMap::new();
[INFO] [stdout] 339 | |         let mut user_table = Table::new();
[INFO] [stdout] 340 | |         user_table
[INFO] [stdout] ...   |
[INFO] [stdout] 369 | |         Self { tables, debug }
[INFO] [stdout] 370 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 336 + impl Default for Neoqlite {
[INFO] [stdout] 337 +     fn default() -> Self {
[INFO] [stdout] 338 +         Self::new()
[INFO] [stdout] 339 +     }
[INFO] [stdout] 340 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: importing legacy numeric constants
[INFO] [stdout]  --> src/core/db.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 | use std::i64;
[INFO] [stdout]   |     ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: remove this import
[INFO] [stdout]   = note: then `i64::<CONST>` will resolve to the respective associated constant
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]   = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary use of `get(&query.table).is_some()`
[INFO] [stdout]    --> src/core/db.rs:425:24
[INFO] [stdout]     |
[INFO] [stdout] 425 |         if self.tables.get(&query.table).is_some() {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&query.table)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/core/db.rs:436:32
[INFO] [stdout]     |
[INFO] [stdout] 436 |                     return Err(format!("Expected 'id' to be an int"));
[INFO] [stdout]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expected 'id' to be an int".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]     = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/core/db.rs:448:24
[INFO] [stdout]     |
[INFO] [stdout] 448 |             return Err(format!("Expected an 'id' column"));
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expected an 'id' column".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Schema`
[INFO] [stdout]   --> src/core/db.rs:73:5
[INFO] [stdout]    |
[INFO] [stdout] 73 | /     pub fn new() -> Self {
[INFO] [stdout] 74 | |         Self {
[INFO] [stdout] 75 | |             columns: HashSet::new(),
[INFO] [stdout] 76 | |             curr_order: 1,
[INFO] [stdout] 77 | |         }
[INFO] [stdout] 78 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 72 + impl Default for Schema {
[INFO] [stdout] 73 +     fn default() -> Self {
[INFO] [stdout] 74 +         Self::new()
[INFO] [stdout] 75 +     }
[INFO] [stdout] 76 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/core/db.rs:111:18
[INFO] [stdout]     |
[INFO] [stdout] 111 |         columns: &Vec<String>,
[INFO] [stdout]     |                  ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 111 -         columns: &Vec<String>,
[INFO] [stdout] 111 +         columns: &[String],
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10
[INFO] [stdout]    --> src/parser/lexer.rs:119:28
[INFO] [stdout]     |
[INFO] [stdout] 119 |                         if next.is_digit(10) {
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^ help: try: `next.is_ascii_digit()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
[INFO] [stdout]     = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/core/db.rs:112:17
[INFO] [stdout]     |
[INFO] [stdout] 112 |         values: &Vec<Expr>,
[INFO] [stdout]     |                 ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 112 -         values: &Vec<Expr>,
[INFO] [stdout] 112 +         values: &[Expr],
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/core/db.rs:116:35
[INFO] [stdout]     |
[INFO] [stdout] 116 |             match self.get_column(&col) {
[INFO] [stdout]     |                                   ^^^^ help: change this to: `col`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: module has the same name as its containing module
[INFO] [stdout]  --> src/parser/mod.rs:2:1
[INFO] [stdout]   |
[INFO] [stdout] 2 | pub mod parser;
[INFO] [stdout]   | ^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stdout]   = note: `#[warn(clippy::module_inception)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]    --> src/core/db.rs:147:21
[INFO] [stdout]     |
[INFO] [stdout] 147 | /                     if col.constraints.contains(&Constraints::NotNull) {
[INFO] [stdout] 148 | |                         return Err(format!(
[INFO] [stdout] 149 | |                             "NOT NULL Constraint Failed on Column {}",
[INFO] [stdout] 150 | |                             &missing_key
[INFO] [stdout] 151 | |                         ));
[INFO] [stdout] 152 | |                     }
[INFO] [stdout]     | |_____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 146 ~                 Some(col)
[INFO] [stdout] 147 ~                     if col.constraints.contains(&Constraints::NotNull) => {
[INFO] [stdout] 148 |                         return Err(format!(
[INFO] [stdout] ...
[INFO] [stdout] 151 |                         ));
[INFO] [stdout] 152 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/core/db.rs:145:13
[INFO] [stdout]     |
[INFO] [stdout] 145 | /             match self.get_column(&missing_key) {
[INFO] [stdout] 146 | |                 Some(col) => {
[INFO] [stdout] 147 | |                     if col.constraints.contains(&Constraints::NotNull) {
[INFO] [stdout] 148 | |                         return Err(format!(
[INFO] [stdout] ...   |
[INFO] [stdout] 154 | |                 None => {}
[INFO] [stdout] 155 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 145 ~             if let Some(col) = self.get_column(&missing_key) {
[INFO] [stdout] 146 +                 if col.constraints.contains(&Constraints::NotNull) {
[INFO] [stdout] 147 +                     return Err(format!(
[INFO] [stdout] 148 +                         "NOT NULL Constraint Failed on Column {}",
[INFO] [stdout] 149 +                         &missing_key
[INFO] [stdout] 150 +                     ));
[INFO] [stdout] 151 +                 }
[INFO] [stdout] 152 +             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/core/db.rs:145:35
[INFO] [stdout]     |
[INFO] [stdout] 145 |             match self.get_column(&missing_key) {
[INFO] [stdout]     |                                   ^^^^^^^^^^^^ help: change this to: `missing_key`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/core/db.rs:160:40
[INFO] [stdout]     |
[INFO] [stdout] 160 |     pub fn validate_row(&self, values: &Vec<String>) -> Result<(), String> {
[INFO] [stdout]     |                                        ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 160 -     pub fn validate_row(&self, values: &Vec<String>) -> Result<(), String> {
[INFO] [stdout] 160 +     pub fn validate_row(&self, values: &[String]) -> Result<(), String> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Table`
[INFO] [stdout]    --> src/core/db.rs:185:5
[INFO] [stdout]     |
[INFO] [stdout] 185 | /     pub fn new() -> Self {
[INFO] [stdout] 186 | |         Self {
[INFO] [stdout] 187 | |             schema: Schema::new(),
[INFO] [stdout] 188 | |             rows: BTree::new(2),
[INFO] [stdout] 189 | |         }
[INFO] [stdout] 190 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 184 + impl Default for Table {
[INFO] [stdout] 185 +     fn default() -> Self {
[INFO] [stdout] 186 +         Self::new()
[INFO] [stdout] 187 +     }
[INFO] [stdout] 188 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None`
[INFO] [stdout]    --> src/core/db.rs:281:16
[INFO] [stdout]     |
[INFO] [stdout] 281 |             Ok(row.ok_or_else(|| "Couldnt find a row").cloned()?)
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
[INFO] [stdout] help: use `ok_or` instead
[INFO] [stdout]     |
[INFO] [stdout] 281 -             Ok(row.ok_or_else(|| "Couldnt find a row").cloned()?)
[INFO] [stdout] 281 +             Ok(row.ok_or("Couldnt find a row").cloned()?)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/core/db.rs:300:13
[INFO] [stdout]     |
[INFO] [stdout] 300 |             return Some(vec![result]);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 300 -             return Some(vec![result]);
[INFO] [stdout] 300 +             Some(vec![result])
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/core/db.rs:322:17
[INFO] [stdout]     |
[INFO] [stdout] 322 |                 return Some(result);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 322 -                 return Some(result);
[INFO] [stdout] 322 +                 Some(result)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Neoqlite`
[INFO] [stdout]    --> src/core/db.rs:337:5
[INFO] [stdout]     |
[INFO] [stdout] 337 | /     pub fn new() -> Self {
[INFO] [stdout] 338 | |         let mut tables = HashMap::new();
[INFO] [stdout] 339 | |         let mut user_table = Table::new();
[INFO] [stdout] 340 | |         user_table
[INFO] [stdout] ...   |
[INFO] [stdout] 369 | |         Self { tables, debug }
[INFO] [stdout] 370 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 336 + impl Default for Neoqlite {
[INFO] [stdout] 337 +     fn default() -> Self {
[INFO] [stdout] 338 +         Self::new()
[INFO] [stdout] 339 +     }
[INFO] [stdout] 340 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary use of `get(&query.table).is_some()`
[INFO] [stdout]    --> src/core/db.rs:425:24
[INFO] [stdout]     |
[INFO] [stdout] 425 |         if self.tables.get(&query.table).is_some() {
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&query.table)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/core/db.rs:436:32
[INFO] [stdout]     |
[INFO] [stdout] 436 |                     return Err(format!("Expected 'id' to be an int"));
[INFO] [stdout]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expected 'id' to be an int".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]     = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/parser/parser.rs:228:17
[INFO] [stdout]     |
[INFO] [stdout] 228 | /                 match self.peek_token() {
[INFO] [stdout] 229 | |                     Some(Token::RParen) => {
[INFO] [stdout] 230 | |                         //self.advance();
[INFO] [stdout] 231 | |                         break;
[INFO] [stdout] 232 | |                     }
[INFO] [stdout] 233 | |                     _ => {}
[INFO] [stdout] 234 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 228 ~                 if let Some(Token::RParen) = self.peek_token() {
[INFO] [stdout] 229 +                     //self.advance();
[INFO] [stdout] 230 +                     break;
[INFO] [stdout] 231 +                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/core/db.rs:448:24
[INFO] [stdout]     |
[INFO] [stdout] 448 |             return Err(format!("Expected an 'id' column"));
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Expected an 'id' column".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/parser/parser.rs:292:9
[INFO] [stdout]     |
[INFO] [stdout] 278 | /         let where_clause = {
[INFO] [stdout] 279 | |             if does_have_where.is_ok() {
[INFO] [stdout] 280 | |                 let left = self.parse_expr().ok()?;
[INFO] [stdout] 281 | |                 let _ = self.expect_token(Token::Operator("=".to_string())).ok()?;
[INFO] [stdout] ...   |
[INFO] [stdout] 291 | |         };
[INFO] [stdout]     | |__________- unnecessary `let` binding
[INFO] [stdout] 292 |           where_clause
[INFO] [stdout]     |           ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 278 ~         
[INFO] [stdout] 279 ~         {
[INFO] [stdout] 280 +             if does_have_where.is_ok() {
[INFO] [stdout] 281 +                 let left = self.parse_expr().ok()?;
[INFO] [stdout] 282 +                 let _ = self.expect_token(Token::Operator("=".to_string())).ok()?;
[INFO] [stdout] 283 +                 let right = self.parse_expr().ok()?;
[INFO] [stdout] 284 +                 Some(WhereClause {
[INFO] [stdout] 285 +                     left,
[INFO] [stdout] 286 +                     operator: "=".to_string(),
[INFO] [stdout] 287 +                     right,
[INFO] [stdout] 288 +                 })
[INFO] [stdout] 289 +             } else {
[INFO] [stdout] 290 +                 None
[INFO] [stdout] 291 +             }
[INFO] [stdout] 292 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this let-binding has unit value
[INFO] [stdout]    --> src/parser/parser.rs:281:17
[INFO] [stdout]     |
[INFO] [stdout] 281 |                 let _ = self.expect_token(Token::Operator("=".to_string())).ok()?;
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stdout]     = note: `#[warn(clippy::let_unit_value)]` on by default
[INFO] [stdout] help: omit the `let` binding
[INFO] [stdout]     |
[INFO] [stdout] 281 -                 let _ = self.expect_token(Token::Operator("=".to_string())).ok()?;
[INFO] [stdout] 281 +                 self.expect_token(Token::Operator("=".to_string())).ok()?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10
[INFO] [stdout]    --> src/parser/lexer.rs:119:28
[INFO] [stdout]     |
[INFO] [stdout] 119 |                         if next.is_digit(10) {
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^ help: try: `next.is_ascii_digit()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix
[INFO] [stdout]     = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: module has the same name as its containing module
[INFO] [stdout]  --> src/parser/mod.rs:2:1
[INFO] [stdout]   |
[INFO] [stdout] 2 | pub mod parser;
[INFO] [stdout]   | ^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stdout]   = note: `#[warn(clippy::module_inception)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/parser/parser.rs:228:17
[INFO] [stdout]     |
[INFO] [stdout] 228 | /                 match self.peek_token() {
[INFO] [stdout] 229 | |                     Some(Token::RParen) => {
[INFO] [stdout] 230 | |                         //self.advance();
[INFO] [stdout] 231 | |                         break;
[INFO] [stdout] 232 | |                     }
[INFO] [stdout] 233 | |                     _ => {}
[INFO] [stdout] 234 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 228 ~                 if let Some(Token::RParen) = self.peek_token() {
[INFO] [stdout] 229 +                     //self.advance();
[INFO] [stdout] 230 +                     break;
[INFO] [stdout] 231 +                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/parser/parser.rs:292:9
[INFO] [stdout]     |
[INFO] [stdout] 278 | /         let where_clause = {
[INFO] [stdout] 279 | |             if does_have_where.is_ok() {
[INFO] [stdout] 280 | |                 let left = self.parse_expr().ok()?;
[INFO] [stdout] 281 | |                 let _ = self.expect_token(Token::Operator("=".to_string())).ok()?;
[INFO] [stdout] ...   |
[INFO] [stdout] 291 | |         };
[INFO] [stdout]     | |__________- unnecessary `let` binding
[INFO] [stdout] 292 |           where_clause
[INFO] [stdout]     |           ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 278 ~         
[INFO] [stdout] 279 ~         {
[INFO] [stdout] 280 +             if does_have_where.is_ok() {
[INFO] [stdout] 281 +                 let left = self.parse_expr().ok()?;
[INFO] [stdout] 282 +                 let _ = self.expect_token(Token::Operator("=".to_string())).ok()?;
[INFO] [stdout] 283 +                 let right = self.parse_expr().ok()?;
[INFO] [stdout] 284 +                 Some(WhereClause {
[INFO] [stdout] 285 +                     left,
[INFO] [stdout] 286 +                     operator: "=".to_string(),
[INFO] [stdout] 287 +                     right,
[INFO] [stdout] 288 +                 })
[INFO] [stdout] 289 +             } else {
[INFO] [stdout] 290 +                 None
[INFO] [stdout] 291 +             }
[INFO] [stdout] 292 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this let-binding has unit value
[INFO] [stdout]    --> src/parser/parser.rs:281:17
[INFO] [stdout]     |
[INFO] [stdout] 281 |                 let _ = self.expect_token(Token::Operator("=".to_string())).ok()?;
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stdout]     = note: `#[warn(clippy::let_unit_value)]` on by default
[INFO] [stdout] help: omit the `let` binding
[INFO] [stdout]     |
[INFO] [stdout] 281 -                 let _ = self.expect_token(Token::Operator("=".to_string())).ok()?;
[INFO] [stdout] 281 +                 self.expect_token(Token::Operator("=".to_string())).ok()?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:47:12
[INFO] [stdout]    |
[INFO] [stdout] 47 |         if !res.is_ok() {
[INFO] [stdout]    |            ^^^^^^^^^^^^ help: try: `res.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:47:12
[INFO] [stdout]    |
[INFO] [stdout] 47 |         if !res.is_ok() {
[INFO] [stdout]    |            ^^^^^^^^^^^^ help: try: `res.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.40s
[INFO] running `Command { std: "docker" "inspect" "12a428b8ae6324de2727210b9d7d96ea3ca348fc8cd728fb799d6e2088d93dc7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "12a428b8ae6324de2727210b9d7d96ea3ca348fc8cd728fb799d6e2088d93dc7", kill_on_drop: false }`
[INFO] [stdout] 12a428b8ae6324de2727210b9d7d96ea3ca348fc8cd728fb799d6e2088d93dc7