[INFO] cloning repository https://github.com/Martijang/Super-simple-text-editor-in-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Martijang/Super-simple-text-editor-in-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMartijang%2FSuper-simple-text-editor-in-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMartijang%2FSuper-simple-text-editor-in-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f7c893be652281bed6dbce7e6cf8342a524d2697 [INFO] linting Martijang/Super-simple-text-editor-in-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMartijang%2FSuper-simple-text-editor-in-rust" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Martijang/Super-simple-text-editor-in-rust [INFO] finished tweaking git repo https://github.com/Martijang/Super-simple-text-editor-in-rust [INFO] tweaked toml for git repo https://github.com/Martijang/Super-simple-text-editor-in-rust written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Martijang/Super-simple-text-editor-in-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Martijang/Super-simple-text-editor-in-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clipboard_x11 v0.4.2 [INFO] [stderr] Downloaded window_clipboard v0.4.1 [INFO] [stderr] Downloaded clipboard_wayland v0.2.2 [INFO] [stderr] Downloaded toml_datetime v0.7.2 [INFO] [stderr] Downloaded iced_renderer v0.13.0 [INFO] [stderr] Downloaded find-msvc-tools v0.1.2 [INFO] [stderr] Downloaded iced_tiny_skia v0.13.0 [INFO] [stderr] Downloaded dconf_rs v0.3.0 [INFO] [stderr] Downloaded iced_runtime v0.13.2 [INFO] [stderr] Downloaded toml_parser v1.0.3 [INFO] [stderr] Downloaded iced_winit v0.13.0 [INFO] [stderr] Downloaded dark-light v1.1.1 [INFO] [stderr] Downloaded iced_futures v0.13.2 [INFO] [stderr] Downloaded clipboard_macos v0.1.1 [INFO] [stderr] Downloaded toml_edit v0.23.6 [INFO] [stderr] Downloaded iced_wgpu v0.13.5 [INFO] [stderr] Downloaded cc v1.2.39 [INFO] [stderr] Downloaded iced_core v0.13.2 [INFO] [stderr] Downloaded iced_widget v0.13.4 [INFO] [stderr] Downloaded iced_glyphon v0.6.0 [INFO] [stderr] Downloaded iced_graphics v0.13.0 [INFO] [stderr] Downloaded iced v0.13.1 [INFO] [stderr] Downloaded detect-desktop-environment v0.2.0 [INFO] [stderr] Downloaded kurbo v0.10.4 [INFO] [stderr] Downloaded windows-sys v0.61.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b1e3f9e339983dfdfbbcef50ea9e2d29d0aa539869e84d8bd0380341b6daf113 [INFO] running `Command { std: "docker" "start" "-a" "b1e3f9e339983dfdfbbcef50ea9e2d29d0aa539869e84d8bd0380341b6daf113", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b1e3f9e339983dfdfbbcef50ea9e2d29d0aa539869e84d8bd0380341b6daf113", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b1e3f9e339983dfdfbbcef50ea9e2d29d0aa539869e84d8bd0380341b6daf113", kill_on_drop: false }` [INFO] [stdout] b1e3f9e339983dfdfbbcef50ea9e2d29d0aa539869e84d8bd0380341b6daf113 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 43783a5b487f0f3a979afaad032bd32c1ea3d5a7e0442bb9d0f947c150919549 [INFO] running `Command { std: "docker" "start" "-a" "43783a5b487f0f3a979afaad032bd32c1ea3d5a7e0442bb9d0f947c150919549", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling find-msvc-tools v0.1.2 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling cc v1.2.39 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Checking wayland-sys v0.31.7 [INFO] [stderr] Compiling hashbrown v0.16.0 [INFO] [stderr] Compiling toml_parser v1.0.3 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Compiling toml_datetime v0.7.2 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling indexmap v2.11.4 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling toml_edit v0.23.6 [INFO] [stderr] Checking memmap2 v0.9.8 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking ahash v0.7.8 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking dlv-list v0.3.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking ordered-multimap v0.4.3 [INFO] [stderr] Checking async-fs v2.2.0 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Compiling palette v0.7.6 [INFO] [stderr] Compiling dark-light v1.1.1 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking rust-ini v0.18.0 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking detect-desktop-environment v0.2.0 [INFO] [stderr] Checking fast-srgb8 v1.0.0 [INFO] [stderr] Checking dconf_rs v0.3.0 [INFO] [stderr] Checking roxmltree v0.20.0 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking glam v0.25.0 [INFO] [stderr] Checking unicode-bidi-mirroring v0.2.0 [INFO] [stderr] Checking ttf-parser v0.20.0 [INFO] [stderr] Checking yazi v0.1.6 [INFO] [stderr] Compiling zvariant_utils v2.1.0 [INFO] [stderr] Checking fontconfig-parser v0.5.8 [INFO] [stderr] Checking zeno v0.2.3 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Checking unicode-ccc v0.2.0 [INFO] [stderr] Checking unicode-script v0.5.7 [INFO] [stderr] Checking unicode-properties v0.1.3 [INFO] [stderr] Compiling ash v0.37.3+1.3.251 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.0.2 [INFO] [stderr] Checking fontdb v0.16.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling bytemuck_derive v1.10.1 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Checking wayland-client v0.31.11 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking bytemuck v1.23.2 [INFO] [stderr] Compiling zvariant_derive v4.2.0 [INFO] [stderr] Checking font-types v0.7.3 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling phf_macros v0.11.3 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling zbus_macros v4.4.0 [INFO] [stderr] Checking read-fonts v0.22.7 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Compiling palette_derive v0.7.6 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking rustybuzz v0.14.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking zvariant v4.2.0 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Compiling wgpu-hal v0.19.5 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking gpu-descriptor-types v0.1.2 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking unicode-xid v0.2.6 [INFO] [stderr] Compiling drm-sys v0.7.0 [INFO] [stderr] Checking rangemap v1.6.0 [INFO] [stderr] Checking sys-locale v0.3.2 [INFO] [stderr] Checking self_cell v1.2.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking naga v0.19.2 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking gpu-descriptor v0.2.4 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking skrifa v0.22.3 [INFO] [stderr] Checking zbus v4.4.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Compiling wgpu-core v0.19.4 [INFO] [stderr] Checking wgpu-types v0.19.2 [INFO] [stderr] Checking glow v0.13.1 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Compiling drm-fourcc v2.2.0 [INFO] [stderr] Checking linux-raw-sys v0.6.5 [INFO] [stderr] Checking swash v0.1.19 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Compiling wgpu v0.19.4 [INFO] [stderr] Compiling tiny-xlib v0.2.4 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking svg_fmt v0.4.5 [INFO] [stderr] Checking drm-ffi v0.8.0 [INFO] [stderr] Compiling softbuffer v0.4.6 [INFO] [stderr] Checking drm v0.12.0 [INFO] [stderr] Checking etagere v0.2.15 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking guillotiere v0.6.2 [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stderr] Checking kurbo v0.10.4 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking clipboard_wayland v0.2.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking clipboard_x11 v0.4.2 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking window_clipboard v0.4.1 [INFO] [stderr] Checking cosmic-text v0.12.1 [INFO] [stderr] Checking iced_core v0.13.2 [INFO] [stderr] Checking iced_futures v0.13.2 [INFO] [stderr] Checking iced_graphics v0.13.0 [INFO] [stderr] Checking iced_runtime v0.13.2 [INFO] [stderr] Checking iced_tiny_skia v0.13.0 [INFO] [stderr] Checking iced_winit v0.13.0 [INFO] [stderr] Checking iced_glyphon v0.6.0 [INFO] [stderr] Checking iced_wgpu v0.13.5 [INFO] [stderr] Checking iced_renderer v0.13.0 [INFO] [stderr] Checking iced_widget v0.13.4 [INFO] [stderr] Checking iced v0.13.1 [INFO] [stderr] Checking rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/Editor.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | Message::Save =>{ [INFO] [stdout] | _____________________________^ [INFO] [stdout] 41 | | match Editor::save_file(self, true){ [INFO] [stdout] 42 | | Ok(_) => self.statue = "Saved!".to_string(), [INFO] [stdout] 43 | | Err(e) => self.statue = format!("Failed to save file: {}. With error: {:?}", [INFO] [stdout] ... | [INFO] [stdout] 46 | | }.into(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 40 ~ Message::Save =>{ [INFO] [stdout] 41 + let _: () = { [INFO] [stdout] 42 + match Editor::save_file(self, true){ [INFO] [stdout] 43 + Ok(_) => self.statue = "Saved!".to_string(), [INFO] [stdout] 44 + Err(e) => self.statue = format!("Failed to save file: {}. With error: {:?}", [INFO] [stdout] 45 + self.path, e), [INFO] [stdout] 46 + } [INFO] [stdout] 47 + }; [INFO] [stdout] 48 + ().into() [INFO] [stdout] 49 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/Editor.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | Message::Save =>{ [INFO] [stdout] | _____________________________^ [INFO] [stdout] 41 | | match Editor::save_file(self, true){ [INFO] [stdout] 42 | | Ok(_) => self.statue = "Saved!".to_string(), [INFO] [stdout] 43 | | Err(e) => self.statue = format!("Failed to save file: {}. With error: {:?}", [INFO] [stdout] ... | [INFO] [stdout] 46 | | }.into(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 40 ~ Message::Save =>{ [INFO] [stdout] 41 + let _: () = { [INFO] [stdout] 42 + match Editor::save_file(self, true){ [INFO] [stdout] 43 + Ok(_) => self.statue = "Saved!".to_string(), [INFO] [stdout] 44 + Err(e) => self.statue = format!("Failed to save file: {}. With error: {:?}", [INFO] [stdout] 45 + self.path, e), [INFO] [stdout] 46 + } [INFO] [stdout] 47 + }; [INFO] [stdout] 48 + ().into() [INFO] [stdout] 49 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/Editor.rs:48:45 [INFO] [stdout] | [INFO] [stdout] 48 | Message::FilePathInput(path) => (self.path = path).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 48 ~ Message::FilePathInput(path) => { [INFO] [stdout] 49 + let _: () = self.path = path; [INFO] [stdout] 50 + (()).into() [INFO] [stdout] 51 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/Editor.rs:50:36 [INFO] [stdout] | [INFO] [stdout] 50 | Message::SubmitFile => { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 51 | | match Editor::get_file(&self.path) { [INFO] [stdout] 52 | | Ok(content) => { [INFO] [stdout] 53 | | self.file_content = content; [INFO] [stdout] ... | [INFO] [stdout] 69 | | }.into(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 50 ~ Message::SubmitFile => { [INFO] [stdout] 51 + let _: () = { [INFO] [stdout] 52 + match Editor::get_file(&self.path) { [INFO] [stdout] 53 + Ok(content) => { [INFO] [stdout] 54 + self.file_content = content; [INFO] [stdout] 55 + self.statue = format!("{} loaded.", self.path); [INFO] [stdout] 56 + } [INFO] [stdout] 57 + [INFO] [stdout] 58 + Err(e) => { [INFO] [stdout] 59 + match Editor::save_file(self, false){ [INFO] [stdout] 60 + Ok(_) => self.statue = "Saved!".to_string(), [INFO] [stdout] 61 + [INFO] [stdout] 62 + Err(e) => self.statue = format!("Failed to create file at: {}, [INFO] [stdout] 63 + with error: {:?}", self.path, e), [INFO] [stdout] 64 + }; [INFO] [stdout] 65 + [INFO] [stdout] 66 + self.statue = format!("Failed to load file. New file created at '{}'. [INFO] [stdout] 67 + Error message: {:?},", self.path, e); [INFO] [stdout] 68 + } [INFO] [stdout] 69 + } [INFO] [stdout] 70 + }; [INFO] [stdout] 71 + ().into() [INFO] [stdout] 72 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/Editor.rs:48:45 [INFO] [stdout] | [INFO] [stdout] 48 | Message::FilePathInput(path) => (self.path = path).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 48 ~ Message::FilePathInput(path) => { [INFO] [stdout] 49 + let _: () = self.path = path; [INFO] [stdout] 50 + (()).into() [INFO] [stdout] 51 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/Editor.rs:50:36 [INFO] [stdout] | [INFO] [stdout] 50 | Message::SubmitFile => { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 51 | | match Editor::get_file(&self.path) { [INFO] [stdout] 52 | | Ok(content) => { [INFO] [stdout] 53 | | self.file_content = content; [INFO] [stdout] ... | [INFO] [stdout] 69 | | }.into(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 50 ~ Message::SubmitFile => { [INFO] [stdout] 51 + let _: () = { [INFO] [stdout] 52 + match Editor::get_file(&self.path) { [INFO] [stdout] 53 + Ok(content) => { [INFO] [stdout] 54 + self.file_content = content; [INFO] [stdout] 55 + self.statue = format!("{} loaded.", self.path); [INFO] [stdout] 56 + } [INFO] [stdout] 57 + [INFO] [stdout] 58 + Err(e) => { [INFO] [stdout] 59 + match Editor::save_file(self, false){ [INFO] [stdout] 60 + Ok(_) => self.statue = "Saved!".to_string(), [INFO] [stdout] 61 + [INFO] [stdout] 62 + Err(e) => self.statue = format!("Failed to create file at: {}, [INFO] [stdout] 63 + with error: {:?}", self.path, e), [INFO] [stdout] 64 + }; [INFO] [stdout] 65 + [INFO] [stdout] 66 + self.statue = format!("Failed to load file. New file created at '{}'. [INFO] [stdout] 67 + Error message: {:?},", self.path, e); [INFO] [stdout] 68 + } [INFO] [stdout] 69 + } [INFO] [stdout] 70 + }; [INFO] [stdout] 71 + ().into() [INFO] [stdout] 72 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/Editor.rs:71:32 [INFO] [stdout] | [INFO] [stdout] 71 | Message::Delete => { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 72 | | match Editor::delete_file(&self.path){ [INFO] [stdout] 73 | | Ok(_) => { [INFO] [stdout] 74 | | self.statue = format!("{} has been deleted.", self.path); [INFO] [stdout] ... | [INFO] [stdout] 80 | | }.into(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 71 ~ Message::Delete => { [INFO] [stdout] 72 + let _: () = { [INFO] [stdout] 73 + match Editor::delete_file(&self.path){ [INFO] [stdout] 74 + Ok(_) => { [INFO] [stdout] 75 + self.statue = format!("{} has been deleted.", self.path); [INFO] [stdout] 76 + }, [INFO] [stdout] 77 + Err(e) => { [INFO] [stdout] 78 + self.statue = format!("Failed to delete file: {} with error: {:?}", self.path, e); [INFO] [stdout] 79 + } [INFO] [stdout] 80 + } [INFO] [stdout] 81 + }; [INFO] [stdout] 82 + ().into() [INFO] [stdout] 83 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/Editor.rs:71:32 [INFO] [stdout] | [INFO] [stdout] 71 | Message::Delete => { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 72 | | match Editor::delete_file(&self.path){ [INFO] [stdout] 73 | | Ok(_) => { [INFO] [stdout] 74 | | self.statue = format!("{} has been deleted.", self.path); [INFO] [stdout] ... | [INFO] [stdout] 80 | | }.into(), [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 71 ~ Message::Delete => { [INFO] [stdout] 72 + let _: () = { [INFO] [stdout] 73 + match Editor::delete_file(&self.path){ [INFO] [stdout] 74 + Ok(_) => { [INFO] [stdout] 75 + self.statue = format!("{} has been deleted.", self.path); [INFO] [stdout] 76 + }, [INFO] [stdout] 77 + Err(e) => { [INFO] [stdout] 78 + self.statue = format!("Failed to delete file: {} with error: {:?}", self.path, e); [INFO] [stdout] 79 + } [INFO] [stdout] 80 + } [INFO] [stdout] 81 + }; [INFO] [stdout] 82 + ().into() [INFO] [stdout] 83 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/Editor.rs:82:41 [INFO] [stdout] | [INFO] [stdout] 82 | Message::Editing(action) => { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 83 | | self.file_content.perform(action); [INFO] [stdout] 84 | | }.into() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: remove the semicolon from the last statement in the block [INFO] [stdout] | [INFO] [stdout] 83 - self.file_content.perform(action); [INFO] [stdout] 83 + self.file_content.perform(action) [INFO] [stdout] | [INFO] [stdout] help: or move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 82 ~ Message::Editing(action) => { [INFO] [stdout] 83 + { [INFO] [stdout] 84 + self.file_content.perform(action); [INFO] [stdout] 85 + }; [INFO] [stdout] 86 + ().into() [INFO] [stdout] 87 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/Editor.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 89 | if condition == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `!condition` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/Editor.rs:92:35 [INFO] [stdout] | [INFO] [stdout] 92 | fs::write(&self.path, &self.file_content.text())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.file_content.text()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/Editor.rs:82:41 [INFO] [stdout] | [INFO] [stdout] 82 | Message::Editing(action) => { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 83 | | self.file_content.perform(action); [INFO] [stdout] 84 | | }.into() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: remove the semicolon from the last statement in the block [INFO] [stdout] | [INFO] [stdout] 83 - self.file_content.perform(action); [INFO] [stdout] 83 + self.file_content.perform(action) [INFO] [stdout] | [INFO] [stdout] help: or move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 82 ~ Message::Editing(action) => { [INFO] [stdout] 83 + { [INFO] [stdout] 84 + self.file_content.perform(action); [INFO] [stdout] 85 + }; [INFO] [stdout] 86 + ().into() [INFO] [stdout] 87 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/Editor.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 89 | if condition == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `!condition` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/Editor.rs:92:35 [INFO] [stdout] | [INFO] [stdout] 92 | fs::write(&self.path, &self.file_content.text())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.file_content.text()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 52s [INFO] running `Command { std: "docker" "inspect" "43783a5b487f0f3a979afaad032bd32c1ea3d5a7e0442bb9d0f947c150919549", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43783a5b487f0f3a979afaad032bd32c1ea3d5a7e0442bb9d0f947c150919549", kill_on_drop: false }` [INFO] [stdout] 43783a5b487f0f3a979afaad032bd32c1ea3d5a7e0442bb9d0f947c150919549