[INFO] cloning repository https://github.com/MarquisLP/plaintext_to_manuscript [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MarquisLP/plaintext_to_manuscript" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarquisLP%2Fplaintext_to_manuscript", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarquisLP%2Fplaintext_to_manuscript'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8663c61c2e491d67767939cad37ca83b9c7d0f24 [INFO] linting MarquisLP/plaintext_to_manuscript against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarquisLP%2Fplaintext_to_manuscript" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MarquisLP/plaintext_to_manuscript [INFO] finished tweaking git repo https://github.com/MarquisLP/plaintext_to_manuscript [INFO] tweaked toml for git repo https://github.com/MarquisLP/plaintext_to_manuscript written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MarquisLP/plaintext_to_manuscript on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MarquisLP/plaintext_to_manuscript already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a7e06ee7dc4ebeb1da9f48ece8c7b8035932a7c65be5fdd68a5f6aa2d98a4ecb [INFO] running `Command { std: "docker" "start" "-a" "a7e06ee7dc4ebeb1da9f48ece8c7b8035932a7c65be5fdd68a5f6aa2d98a4ecb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a7e06ee7dc4ebeb1da9f48ece8c7b8035932a7c65be5fdd68a5f6aa2d98a4ecb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7e06ee7dc4ebeb1da9f48ece8c7b8035932a7c65be5fdd68a5f6aa2d98a4ecb", kill_on_drop: false }` [INFO] [stdout] a7e06ee7dc4ebeb1da9f48ece8c7b8035932a7c65be5fdd68a5f6aa2d98a4ecb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4cee7c9abfaea97c57b4d330f5426aca51d0f4be9ab8dca63ba79963c566f5fe [INFO] running `Command { std: "docker" "start" "-a" "4cee7c9abfaea97c57b4d330f5426aca51d0f4be9ab8dca63ba79963c566f5fe", kill_on_drop: false }` [INFO] [stderr] Checking plaintext_to_manuscript v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/text_manipulation/formatters/consecutive_chars_to_special_char_formatter.rs:42:38 [INFO] [stdout] | [INFO] [stdout] 42 | run_next_formatter = !_next_input_char.is_some_and(|character| *character == self.char_to_replace); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `_next_input_char.is_none_or(|character| *character != self.char_to_replace)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ApostropheFormatter` [INFO] [stdout] --> src/text_manipulation/formatters/apostrophe_formatter.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> ApostropheFormatter { [INFO] [stdout] 13 | | ApostropheFormatter { [INFO] [stdout] 14 | | previous_input_char: '\n', [INFO] [stdout] 15 | | } [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for ApostropheFormatter { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/text_manipulation/formatters/apostrophe_formatter.rs:25:112 [INFO] [stdout] | [INFO] [stdout] 25 | ...previous_input_char != ' ') && !_next_input_char.is_none() && !_next_input_char.is_some_and(|_next_input_char| (is_end_of_phrase(... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `_next_input_char.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/text_manipulation/formatters/consecutive_chars_to_special_char_formatter.rs:42:38 [INFO] [stdout] | [INFO] [stdout] 42 | run_next_formatter = !_next_input_char.is_some_and(|character| *character == self.char_to_replace); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `_next_input_char.is_none_or(|character| *character != self.char_to_replace)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/convert_file.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 22 | let converted_text = apply_formatters(&file_contents, text_formatters); [INFO] [stdout] | ----------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 23 | [INFO] [stdout] 24 | converted_text [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 22 ~ [INFO] [stdout] 23 | [INFO] [stdout] 24 ~ apply_formatters(&file_contents, text_formatters) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ApostropheFormatter` [INFO] [stdout] --> src/text_manipulation/formatters/apostrophe_formatter.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> ApostropheFormatter { [INFO] [stdout] 13 | | ApostropheFormatter { [INFO] [stdout] 14 | | previous_input_char: '\n', [INFO] [stdout] 15 | | } [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for ApostropheFormatter { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/convert_file.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | let file_contents: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `file_contents` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 9 ~ [INFO] [stdout] 10 ~ let file_contents: String = match fs::read_to_string(file_path) { [INFO] [stdout] 11 | Ok(result) => { [INFO] [stdout] 12 ~ result [INFO] [stdout] 13 | }, [INFO] [stdout] ... [INFO] [stdout] 17 | } [INFO] [stdout] 18 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/text_manipulation/formatters/apostrophe_formatter.rs:25:112 [INFO] [stdout] | [INFO] [stdout] 25 | ...previous_input_char != ' ') && !_next_input_char.is_none() && !_next_input_char.is_some_and(|_next_input_char| (is_end_of_phrase(... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `_next_input_char.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/convert_file.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 22 | let converted_text = apply_formatters(&file_contents, text_formatters); [INFO] [stdout] | ----------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 23 | [INFO] [stdout] 24 | converted_text [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 22 ~ [INFO] [stdout] 23 | [INFO] [stdout] 24 ~ apply_formatters(&file_contents, text_formatters) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/convert_file.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | let file_contents: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `file_contents` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 9 ~ [INFO] [stdout] 10 ~ let file_contents: String = match fs::read_to_string(file_path) { [INFO] [stdout] 11 | Ok(result) => { [INFO] [stdout] 12 ~ result [INFO] [stdout] 13 | }, [INFO] [stdout] ... [INFO] [stdout] 17 | } [INFO] [stdout] 18 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.41s [INFO] running `Command { std: "docker" "inspect" "4cee7c9abfaea97c57b4d330f5426aca51d0f4be9ab8dca63ba79963c566f5fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4cee7c9abfaea97c57b4d330f5426aca51d0f4be9ab8dca63ba79963c566f5fe", kill_on_drop: false }` [INFO] [stdout] 4cee7c9abfaea97c57b4d330f5426aca51d0f4be9ab8dca63ba79963c566f5fe