[INFO] cloning repository https://github.com/Markyparky56/rust-by-example [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Markyparky56/rust-by-example" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarkyparky56%2Frust-by-example", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarkyparky56%2Frust-by-example'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ab3ac55bd86e01549677638bc5f33b31e9eccbfe [INFO] linting Markyparky56/rust-by-example against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMarkyparky56%2Frust-by-example" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Markyparky56/rust-by-example [INFO] finished tweaking git repo https://github.com/Markyparky56/rust-by-example [INFO] tweaked toml for git repo https://github.com/Markyparky56/rust-by-example written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Markyparky56/rust-by-example on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Markyparky56/rust-by-example already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 18d560e0bc511702a7db2de528bfd9761253730addaa3e4bd1b398a0d756a110 [INFO] running `Command { std: "docker" "start" "-a" "18d560e0bc511702a7db2de528bfd9761253730addaa3e4bd1b398a0d756a110", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "18d560e0bc511702a7db2de528bfd9761253730addaa3e4bd1b398a0d756a110", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18d560e0bc511702a7db2de528bfd9761253730addaa3e4bd1b398a0d756a110", kill_on_drop: false }` [INFO] [stdout] 18d560e0bc511702a7db2de528bfd9761253730addaa3e4bd1b398a0d756a110 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 752436fed2e4b9914395b5a38af1ff21371628dfaf4a6e9bd011053a3df87d7b [INFO] running `Command { std: "docker" "start" "-a" "752436fed2e4b9914395b5a38af1ff21371628dfaf4a6e9bd011053a3df87d7b", kill_on_drop: false }` [INFO] [stderr] Checking rust-by-example v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/literals-and-operators.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | println!("true AND false is {}", true && false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/literals-and-operators.rs:19:37 [INFO] [stdout] | [INFO] [stdout] 19 | println!("true OR false is {}", true || false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/literals-and-operators.rs:20:32 [INFO] [stdout] | [INFO] [stdout] 20 | println!("NOT true is {}", !true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DebugPrintable` is never constructed [INFO] [stdout] --> src/print-debug.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | struct DebugPrintable(i32); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/print-debug.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | struct Structure(i32); [INFO] [stdout] | --------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Structure` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/print-debug.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | struct Deep(Structure); [INFO] [stdout] | ---- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Deep` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/tuples.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | writeln!(f, "")?; [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/print.rs:12:18 [INFO] [stdout] | [INFO] [stdout] 12 | object = "the lazy dog", [INFO] [stdout] | __________________^ [INFO] [stdout] 13 | | subject = "the quick brown fox", [INFO] [stdout] 14 | | verb = "jumps over" [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 11 - "{subject} {verb} {object}", [INFO] [stdout] 12 - object = "the lazy dog", [INFO] [stdout] 13 - subject = "the quick brown fox", [INFO] [stdout] 14 - verb = "jumps over" [INFO] [stdout] 11 + "the quick brown fox jumps over the lazy dog" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/print.rs:36:41 [INFO] [stdout] | [INFO] [stdout] 36 | println!("My name is {1}, {0} {1}", "James", "Bond"); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 - println!("My name is {1}, {0} {1}", "James", "Bond"); [INFO] [stdout] 36 + println!("My name is {0}, James {0}", "Bond"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/literals-and-operators.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | println!("true AND false is {}", true && false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/literals-and-operators.rs:19:37 [INFO] [stdout] | [INFO] [stdout] 19 | println!("true OR false is {}", true || false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/literals-and-operators.rs:20:32 [INFO] [stdout] | [INFO] [stdout] 20 | println!("NOT true is {}", !true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DebugPrintable` is never constructed [INFO] [stdout] --> src/print-debug.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | struct DebugPrintable(i32); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/print-debug.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | struct Structure(i32); [INFO] [stdout] | --------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Structure` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/print-debug.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | struct Deep(Structure); [INFO] [stdout] | ---- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Deep` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Structure` is never constructed [INFO] [stdout] --> src/print-display.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | struct Structure(i32); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/print.rs:12:18 [INFO] [stdout] | [INFO] [stdout] 12 | object = "the lazy dog", [INFO] [stdout] | __________________^ [INFO] [stdout] 13 | | subject = "the quick brown fox", [INFO] [stdout] 14 | | verb = "jumps over" [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 11 - "{subject} {verb} {object}", [INFO] [stdout] 12 - object = "the lazy dog", [INFO] [stdout] 13 - subject = "the quick brown fox", [INFO] [stdout] 14 - verb = "jumps over" [INFO] [stdout] 11 + "the quick brown fox jumps over the lazy dog" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/print.rs:36:41 [INFO] [stdout] | [INFO] [stdout] 36 | println!("My name is {1}, {0} {1}", "James", "Bond"); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 - println!("My name is {1}, {0} {1}", "James", "Bond"); [INFO] [stdout] 36 + println!("My name is {0}, James {0}", "Bond"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Structure` is never constructed [INFO] [stdout] --> src/print-display.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | struct Structure(i32); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/tuples.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | writeln!(f, "")?; [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.44s [INFO] running `Command { std: "docker" "inspect" "752436fed2e4b9914395b5a38af1ff21371628dfaf4a6e9bd011053a3df87d7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "752436fed2e4b9914395b5a38af1ff21371628dfaf4a6e9bd011053a3df87d7b", kill_on_drop: false }` [INFO] [stdout] 752436fed2e4b9914395b5a38af1ff21371628dfaf4a6e9bd011053a3df87d7b