[INFO] cloning repository https://github.com/Mandragorian/fake_youki [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Mandragorian/fake_youki" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMandragorian%2Ffake_youki", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMandragorian%2Ffake_youki'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 73e289be45aa32a579b964106ef476c416e5e54e [INFO] linting Mandragorian/fake_youki against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMandragorian%2Ffake_youki" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Mandragorian/fake_youki [INFO] finished tweaking git repo https://github.com/Mandragorian/fake_youki [INFO] tweaked toml for git repo https://github.com/Mandragorian/fake_youki written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Mandragorian/fake_youki on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Mandragorian/fake_youki already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded errno-dragonfly v0.1.1 [INFO] [stderr] Downloaded errno v0.2.7 [INFO] [stderr] Downloaded caps v0.5.2 [INFO] [stderr] Downloaded nix v0.21.0 [INFO] [stderr] Downloaded libc v0.2.96 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b47b9854e0c22b4f9ba8aaae1e75dc74681d6ec41689ac08f37e5a4146b70f5d [INFO] running `Command { std: "docker" "start" "-a" "b47b9854e0c22b4f9ba8aaae1e75dc74681d6ec41689ac08f37e5a4146b70f5d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b47b9854e0c22b4f9ba8aaae1e75dc74681d6ec41689ac08f37e5a4146b70f5d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b47b9854e0c22b4f9ba8aaae1e75dc74681d6ec41689ac08f37e5a4146b70f5d", kill_on_drop: false }` [INFO] [stdout] b47b9854e0c22b4f9ba8aaae1e75dc74681d6ec41689ac08f37e5a4146b70f5d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a270e9d111ff8aee49b2d6c69e152fe9da089a03e2f5ac7ccfb68bd4b56252fb [INFO] running `Command { std: "docker" "start" "-a" "a270e9d111ff8aee49b2d6c69e152fe9da089a03e2f5ac7ccfb68bd4b56252fb", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.96 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking errno v0.2.7 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.21.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Compiling thiserror-impl v1.0.25 [INFO] [stderr] Checking thiserror v1.0.25 [INFO] [stderr] Checking caps v0.5.2 [INFO] [stderr] Checking fake_youki v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:11:16 [INFO] [stdout] | [INFO] [stdout] 11 | const SUITS: [&'static str; 4] = ["swords", "wands", "pentacles", "cups"]; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | const MINOR: [&'static str; 14] = [ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:16:16 [INFO] [stdout] | [INFO] [stdout] 16 | const MAJOR: [&'static str; 22] = [ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/lib.rs:390:12 [INFO] [stdout] | [INFO] [stdout] 383 | / nix::unistd::execve( [INFO] [stdout] 384 | | args[0].as_c_str(), [INFO] [stdout] 385 | | args.as_slice(), [INFO] [stdout] 386 | | &[CStr::from_bytes_with_nul(&[0]).unwrap()], [INFO] [stdout] 387 | | ) [INFO] [stdout] 388 | | .unwrap(); [INFO] [stdout] | |_____________- any code following this expression is unreachable [INFO] [stdout] 389 | [INFO] [stdout] 390 | return 0; [INFO] [stdout] | ^ unreachable expression [INFO] [stdout] | [INFO] [stdout] note: this expression has type `std::convert::Infallible`, which is uninhabited [INFO] [stdout] --> src/lib.rs:383:5 [INFO] [stdout] | [INFO] [stdout] 383 | / nix::unistd::execve( [INFO] [stdout] 384 | | args[0].as_c_str(), [INFO] [stdout] 385 | | args.as_slice(), [INFO] [stdout] 386 | | &[CStr::from_bytes_with_nul(&[0]).unwrap()], [INFO] [stdout] 387 | | ) [INFO] [stdout] 388 | | .unwrap(); [INFO] [stdout] | |_____________^ [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `size` is never read [INFO] [stdout] --> src/lib.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 116 | struct Stack { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 117 | internal_vec: Vec, [INFO] [stdout] 118 | size: usize, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:87:8 [INFO] [stdout] | [INFO] [stdout] 87 | if !(uts_name.machine() == "x86_64") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(uts_name.machine() != "x86_64")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:11:16 [INFO] [stdout] | [INFO] [stdout] 11 | const SUITS: [&'static str; 4] = ["swords", "wands", "pentacles", "cups"]; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | const MINOR: [&'static str; 14] = [ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:16:16 [INFO] [stdout] | [INFO] [stdout] 16 | const MAJOR: [&'static str; 22] = [ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/lib.rs:123:32 [INFO] [stdout] | [INFO] [stdout] 123 | let mut internal_vec = Vec::new(); [INFO] [stdout] | ________________________________^ [INFO] [stdout] 124 | | internal_vec.resize(size, 0); [INFO] [stdout] | |____________________________________^ help: consider replacing this with: `vec![0; size]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] = note: `#[warn(clippy::slow_vector_initialization)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/lib.rs:367:17 [INFO] [stdout] | [INFO] [stdout] 366 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Err() = res` [INFO] [stdout] 367 | let s = res.unwrap_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:390:5 [INFO] [stdout] | [INFO] [stdout] 390 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 390 - return 0; [INFO] [stdout] 390 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:440:5 [INFO] [stdout] | [INFO] [stdout] 440 | / match check_linux_version() { [INFO] [stdout] 441 | | Err(msg) => { [INFO] [stdout] 442 | | println!("{}", msg); [INFO] [stdout] 443 | | return; [INFO] [stdout] 444 | | } [INFO] [stdout] 445 | | Ok(_) => (), [INFO] [stdout] 446 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 440 ~ if let Err(msg) = check_linux_version() { [INFO] [stdout] 441 + println!("{}", msg); [INFO] [stdout] 442 + return; [INFO] [stdout] 443 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/lib.rs:390:12 [INFO] [stdout] | [INFO] [stdout] 383 | / nix::unistd::execve( [INFO] [stdout] 384 | | args[0].as_c_str(), [INFO] [stdout] 385 | | args.as_slice(), [INFO] [stdout] 386 | | &[CStr::from_bytes_with_nul(&[0]).unwrap()], [INFO] [stdout] 387 | | ) [INFO] [stdout] 388 | | .unwrap(); [INFO] [stdout] | |_____________- any code following this expression is unreachable [INFO] [stdout] 389 | [INFO] [stdout] 390 | return 0; [INFO] [stdout] | ^ unreachable expression [INFO] [stdout] | [INFO] [stdout] note: this expression has type `std::convert::Infallible`, which is uninhabited [INFO] [stdout] --> src/lib.rs:383:5 [INFO] [stdout] | [INFO] [stdout] 383 | / nix::unistd::execve( [INFO] [stdout] 384 | | args[0].as_c_str(), [INFO] [stdout] 385 | | args.as_slice(), [INFO] [stdout] 386 | | &[CStr::from_bytes_with_nul(&[0]).unwrap()], [INFO] [stdout] 387 | | ) [INFO] [stdout] 388 | | .unwrap(); [INFO] [stdout] | |_____________^ [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `size` is never read [INFO] [stdout] --> src/lib.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 116 | struct Stack { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 117 | internal_vec: Vec, [INFO] [stdout] 118 | size: usize, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:87:8 [INFO] [stdout] | [INFO] [stdout] 87 | if !(uts_name.machine() == "x86_64") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(uts_name.machine() != "x86_64")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: slow zero-filling initialization [INFO] [stdout] --> src/lib.rs:123:32 [INFO] [stdout] | [INFO] [stdout] 123 | let mut internal_vec = Vec::new(); [INFO] [stdout] | ________________________________^ [INFO] [stdout] 124 | | internal_vec.resize(size, 0); [INFO] [stdout] | |____________________________________^ help: consider replacing this with: `vec![0; size]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stdout] = note: `#[warn(clippy::slow_vector_initialization)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/lib.rs:367:17 [INFO] [stdout] | [INFO] [stdout] 366 | if res.is_err() { [INFO] [stdout] | --------------- help: try: `if let Err() = res` [INFO] [stdout] 367 | let s = res.unwrap_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:390:5 [INFO] [stdout] | [INFO] [stdout] 390 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 390 - return 0; [INFO] [stdout] 390 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:440:5 [INFO] [stdout] | [INFO] [stdout] 440 | / match check_linux_version() { [INFO] [stdout] 441 | | Err(msg) => { [INFO] [stdout] 442 | | println!("{}", msg); [INFO] [stdout] 443 | | return; [INFO] [stdout] 444 | | } [INFO] [stdout] 445 | | Ok(_) => (), [INFO] [stdout] 446 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 440 ~ if let Err(msg) = check_linux_version() { [INFO] [stdout] 441 + println!("{}", msg); [INFO] [stdout] 442 + return; [INFO] [stdout] 443 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.28s [INFO] running `Command { std: "docker" "inspect" "a270e9d111ff8aee49b2d6c69e152fe9da089a03e2f5ac7ccfb68bd4b56252fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a270e9d111ff8aee49b2d6c69e152fe9da089a03e2f5ac7ccfb68bd4b56252fb", kill_on_drop: false }` [INFO] [stdout] a270e9d111ff8aee49b2d6c69e152fe9da089a03e2f5ac7ccfb68bd4b56252fb