[INFO] cloning repository https://github.com/MalteHerrmann/battleship-commonware [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MalteHerrmann/battleship-commonware" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMalteHerrmann%2Fbattleship-commonware", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMalteHerrmann%2Fbattleship-commonware'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c263173718f319928c75558a50250588d1b6dd01 [INFO] linting MalteHerrmann/battleship-commonware against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMalteHerrmann%2Fbattleship-commonware" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MalteHerrmann/battleship-commonware [INFO] finished tweaking git repo https://github.com/MalteHerrmann/battleship-commonware [INFO] tweaked toml for git repo https://github.com/MalteHerrmann/battleship-commonware written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MalteHerrmann/battleship-commonware on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MalteHerrmann/battleship-commonware already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/malteherrmann/parrot` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded opentelemetry-http v0.28.0 [INFO] [stderr] Downloaded commonware-macros v0.0.63 [INFO] [stderr] Downloaded commonware-codec v0.0.63 [INFO] [stderr] Downloaded opentelemetry-otlp v0.28.0 [INFO] [stderr] Downloaded commonware-stream v0.0.63 [INFO] [stderr] Downloaded prometheus-client v0.22.3 [INFO] [stderr] Downloaded opentelemetry v0.28.0 [INFO] [stderr] Downloaded commonware-runtime v0.0.63 [INFO] [stderr] Downloaded opentelemetry_sdk v0.28.0 [INFO] [stderr] Downloaded opentelemetry-proto v0.28.0 [INFO] [stderr] Downloaded tracing-opentelemetry v0.29.0 [INFO] [stderr] Downloaded commonware-utils v0.0.63 [INFO] [stderr] Downloaded commonware-cryptography v0.0.63 [INFO] [stderr] Downloaded commonware-p2p v0.0.63 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6ddbb9754bdf0c109c02a5ff7e031eddcdcb4187bc8c41904c73451cf2b7fdcf [INFO] running `Command { std: "docker" "start" "-a" "6ddbb9754bdf0c109c02a5ff7e031eddcdcb4187bc8c41904c73451cf2b7fdcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6ddbb9754bdf0c109c02a5ff7e031eddcdcb4187bc8c41904c73451cf2b7fdcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ddbb9754bdf0c109c02a5ff7e031eddcdcb4187bc8c41904c73451cf2b7fdcf", kill_on_drop: false }` [INFO] [stdout] 6ddbb9754bdf0c109c02a5ff7e031eddcdcb4187bc8c41904c73451cf2b7fdcf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 72b9e4ec060649b000f5ecbdee0f0ef4c03a47709ecc3422194667b60549abd5 [INFO] running `Command { std: "docker" "start" "-a" "72b9e4ec060649b000f5ecbdee0f0ef4c03a47709ecc3422194667b60549abd5", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking tracing-core v0.1.35 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling cc v1.2.49 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Compiling futures-sink v0.3.31 [INFO] [stderr] Compiling pin-project-lite v0.2.16 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Compiling futures-io v0.3.31 [INFO] [stderr] Checking iri-string v0.7.9 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling slab v0.4.11 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling toml_parser v1.0.4 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Compiling sharded-slab v0.1.7 [INFO] [stderr] Compiling thread_local v1.1.9 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling tracing-log v0.2.0 [INFO] [stderr] Compiling toml_edit v0.23.9 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Compiling blst v0.3.16 [INFO] [stderr] Compiling blake3 v1.8.2 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking raw-cpuid v11.6.0 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling prometheus-client v0.22.3 [INFO] [stderr] Compiling nu-ansi-term v0.50.3 [INFO] [stderr] Checking subtle-ng v2.5.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Compiling tracing-subscriber v0.3.22 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking spinning_top v0.3.0 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking dtoa v1.0.10 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking quanta v0.12.6 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking nonzero_ext v0.3.0 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Checking sysinfo v0.33.1 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling instability v0.3.10 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking tracing v0.1.43 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking opentelemetry v0.28.0 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Compiling prost-derive v0.13.5 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking commonware-codec v0.0.63 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking prost v0.13.5 [INFO] [stderr] Checking commonware-utils v0.0.63 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking opentelemetry_sdk v0.28.0 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking tonic v0.12.3 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking curve25519-dalek-ng v4.1.1 [INFO] [stderr] Checking axum-core v0.5.5 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling prometheus-client-derive-encode v0.4.2 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking ed25519-consensus v2.1.0 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking governor v0.6.3 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking opentelemetry-proto v0.28.0 [INFO] [stderr] Checking tracing-opentelemetry v0.29.0 [INFO] [stderr] Checking commonware-cryptography v0.0.63 [INFO] [stderr] Checking reqwest v0.12.25 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling commonware-macros v0.0.63 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling indoc v2.0.7 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking opentelemetry-http v0.28.0 [INFO] [stderr] Checking axum v0.8.7 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking opentelemetry-otlp v0.28.0 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Checking indenter v0.3.4 [INFO] [stderr] Checking eyre v0.6.12 [INFO] [stderr] Checking parrot v0.0.2 (https://github.com/malteherrmann/parrot#35f22f06) [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking commonware-runtime v0.0.63 [INFO] [stderr] Checking commonware-stream v0.0.63 [INFO] [stderr] Checking commonware-p2p v0.0.63 [INFO] [stderr] Checking battleship-commonware v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `crypto` is never read [INFO] [stdout] --> src/application/actor.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct GameStateActor { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 30 | context: ContextCell, [INFO] [stdout] 31 | crypto: C, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual saturating arithmetic [INFO] [stdout] --> src/game/grid.rs:61:21 [INFO] [stdout] | [INFO] [stdout] 61 | let index = self.x.checked_sub(1).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `saturating_sub`: `self.x.saturating_sub(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic [INFO] [stdout] = note: `#[warn(clippy::manual_saturating_arithmetic)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `crypto` is never read [INFO] [stdout] --> src/application/actor.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct GameStateActor { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 30 | context: ContextCell, [INFO] [stdout] 31 | crypto: C, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/config/mod.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | "127.0.0.1:5671".into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"127.0.0.1:5671"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/config/mod.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | "9a3744504560639ec670b7a17d492b273e077b0a96bef58ba7760779e544546e".into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"9a3744504560639ec670b7a17d492b273e077b0a96bef58ba7760779e544546e"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config/mod.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | / !Config::new( [INFO] [stdout] 133 | | &PrivateKey::from_seed(0), [INFO] [stdout] 134 | | 5670, [INFO] [stdout] 135 | | "abc", [INFO] [stdout] ... | [INFO] [stdout] 138 | | .validate() [INFO] [stdout] 139 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 132 ~ Config::new( [INFO] [stdout] 133 + &PrivateKey::from_seed(0), [INFO] [stdout] 134 + 5670, [INFO] [stdout] 135 + "abc", [INFO] [stdout] 136 + "9a3744504560639ec670b7a17d492b273e077b0a96bef58ba7760779e544546e", [INFO] [stdout] 137 + ) [INFO] [stdout] 138 + .validate().is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/config/mod.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | / !Config::new(&PrivateKey::from_seed(0), 5671, "127.0.0.1:5670", "hij0123",) [INFO] [stdout] 144 | | .validate() [INFO] [stdout] 145 | | .is_ok() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 143 ~ Config::new(&PrivateKey::from_seed(0), 5671, "127.0.0.1:5670", "hij0123",) [INFO] [stdout] 144 + .validate().is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/config/mod.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | "127.0.0.1:5671".into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"127.0.0.1:5671"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/config/mod.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | "9a3744504560639ec670b7a17d492b273e077b0a96bef58ba7760779e544546e".into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"9a3744504560639ec670b7a17d492b273e077b0a96bef58ba7760779e544546e"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual saturating arithmetic [INFO] [stdout] --> src/game/grid.rs:61:21 [INFO] [stdout] | [INFO] [stdout] 61 | let index = self.x.checked_sub(1).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `saturating_sub`: `self.x.saturating_sub(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic [INFO] [stdout] = note: `#[warn(clippy::manual_saturating_arithmetic)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 19s [INFO] running `Command { std: "docker" "inspect" "72b9e4ec060649b000f5ecbdee0f0ef4c03a47709ecc3422194667b60549abd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72b9e4ec060649b000f5ecbdee0f0ef4c03a47709ecc3422194667b60549abd5", kill_on_drop: false }` [INFO] [stdout] 72b9e4ec060649b000f5ecbdee0f0ef4c03a47709ecc3422194667b60549abd5