[INFO] cloning repository https://github.com/MajidAbdelilah/Unreal_Majid [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MajidAbdelilah/Unreal_Majid" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMajidAbdelilah%2FUnreal_Majid", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMajidAbdelilah%2FUnreal_Majid'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8e91e7317cce339621096487aace7ae21db98891 [INFO] linting MajidAbdelilah/Unreal_Majid against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMajidAbdelilah%2FUnreal_Majid" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MajidAbdelilah/Unreal_Majid [INFO] finished tweaking git repo https://github.com/MajidAbdelilah/Unreal_Majid [INFO] tweaked toml for git repo https://github.com/MajidAbdelilah/Unreal_Majid written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MajidAbdelilah/Unreal_Majid on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MajidAbdelilah/Unreal_Majid already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8fb3b8e73a4c84ad30df7c33f1aca55bca869a6d49dccd7b84fec5dcb8da0d95 [INFO] running `Command { std: "docker" "start" "-a" "8fb3b8e73a4c84ad30df7c33f1aca55bca869a6d49dccd7b84fec5dcb8da0d95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8fb3b8e73a4c84ad30df7c33f1aca55bca869a6d49dccd7b84fec5dcb8da0d95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8fb3b8e73a4c84ad30df7c33f1aca55bca869a6d49dccd7b84fec5dcb8da0d95", kill_on_drop: false }` [INFO] [stdout] 8fb3b8e73a4c84ad30df7c33f1aca55bca869a6d49dccd7b84fec5dcb8da0d95 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f5d53e67c4c9d1dab3be6b5b3cc76dfa1219bd9a29c248c69f9935d7f9ad16e [INFO] running `Command { std: "docker" "start" "-a" "2f5d53e67c4c9d1dab3be6b5b3cc76dfa1219bd9a29c248c69f9935d7f9ad16e", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling cc v1.2.50 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Compiling naga v27.0.3 [INFO] [stderr] Checking wayland-sys v0.31.7 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking codespan-reporting v0.12.0 [INFO] [stderr] Compiling wgpu-hal v27.0.4 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking gpu-descriptor v0.3.2 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking ash v0.38.0+1.3.281 [INFO] [stderr] Checking glow v0.16.0 [INFO] [stderr] Compiling wgpu-core v27.0.3 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling wgpu v27.0.1 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking ordered-float v5.1.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking wgpu-types v27.0.1 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking wayland-client v0.31.11 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking wgpu-core-deps-windows-linux-android v27.0.0 [INFO] [stderr] Checking particle-system v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `default` [INFO] [stdout] --> src/core/renderer.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{default, process::exit, sync::Arc}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `wgpu::util::DeviceExt` [INFO] [stdout] --> src/core/renderer.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use wgpu::util::DeviceExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `EventLoop`, `PhysicalKey`, `application::ApplicationHandler`, and `event::*` [INFO] [stdout] --> src/core/renderer.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | application::ApplicationHandler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 6 | event::*, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | event_loop::{ActiveEventLoop, EventLoop}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 8 | keyboard::{KeyCode, PhysicalKey}, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `KeyCode` [INFO] [stdout] --> src/core/window.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | keyboard::{KeyCode, PhysicalKey}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `default` [INFO] [stdout] --> src/core/renderer.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{default, process::exit, sync::Arc}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `wgpu::util::DeviceExt` [INFO] [stdout] --> src/core/renderer.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use wgpu::util::DeviceExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `EventLoop`, `PhysicalKey`, `application::ApplicationHandler`, and `event::*` [INFO] [stdout] --> src/core/renderer.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | application::ApplicationHandler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 6 | event::*, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | event_loop::{ActiveEventLoop, EventLoop}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 8 | keyboard::{KeyCode, PhysicalKey}, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `KeyCode` [INFO] [stdout] --> src/core/window.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | keyboard::{KeyCode, PhysicalKey}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/renderer.rs:593:21 [INFO] [stdout] | [INFO] [stdout] 593 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/renderer.rs:610:25 [INFO] [stdout] | [INFO] [stdout] 610 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/renderer.rs:632:25 [INFO] [stdout] | [INFO] [stdout] 632 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/window.rs:89:79 [INFO] [stdout] | [INFO] [stdout] 89 | fn user_event(&mut self, event_loop: &winit::event_loop::ActiveEventLoop, mut event: Ren) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_loop` [INFO] [stdout] --> src/core/window.rs:89:30 [INFO] [stdout] | [INFO] [stdout] 89 | fn user_event(&mut self, event_loop: &winit::event_loop::ActiveEventLoop, mut event: Ren) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_loop` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `window_id` [INFO] [stdout] --> src/core/window.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | window_id: winit::window::WindowId, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_window_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `device_id` [INFO] [stdout] --> src/core/window.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 166 | device_id, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `device_id: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_loop` [INFO] [stdout] --> src/core/window.rs:196:33 [INFO] [stdout] | [INFO] [stdout] 196 | fn about_to_wait(&mut self, event_loop: &winit::event_loop::ActiveEventLoop) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_loop` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `core::renderer::Mat4f` is more private than the item `core::renderer::Camera::get_view_matrix` [INFO] [stdout] --> src/core/renderer.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn get_view_matrix(&self) -> Mat4f { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `core::renderer::Camera::get_view_matrix` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `core::renderer::Mat4f` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/core/renderer.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | struct Mat4f { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `run` is never used [INFO] [stdout] --> src/core/entry_point.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn run() -> anyhow::Result<()> { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `InputState` is never constructed [INFO] [stdout] --> src/core/renderer.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct InputState { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Camera` is never constructed [INFO] [stdout] --> src/core/renderer.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | pub struct Camera { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `get_view_matrix`, `get_forward`, and `get_right` are never used [INFO] [stdout] --> src/core/renderer.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 77 | impl Camera { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 78 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 89 | pub fn get_view_matrix(&self) -> Mat4f { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 105 | pub fn get_forward(&self) -> [f32; 3] { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | pub fn get_right(&self) -> [f32; 3] { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `vec3_add` is never used [INFO] [stdout] --> src/core/renderer.rs:119:4 [INFO] [stdout] | [INFO] [stdout] 119 | fn vec3_add(a: &[f32; 3], b: &[f32; 3]) -> [f32; 3] { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `vec3_sub` is never used [INFO] [stdout] --> src/core/renderer.rs:123:4 [INFO] [stdout] | [INFO] [stdout] 123 | fn vec3_sub(a: &[f32; 3], b: &[f32; 3]) -> [f32; 3] { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `vec3_scale` is never used [INFO] [stdout] --> src/core/renderer.rs:127:4 [INFO] [stdout] | [INFO] [stdout] 127 | fn vec3_scale(a: &[f32; 3], s: f32) -> [f32; 3] { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dot` is never used [INFO] [stdout] --> src/core/renderer.rs:141:4 [INFO] [stdout] | [INFO] [stdout] 141 | fn dot(a: &[f32; 3], b: &[f32; 3]) -> f32 { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `cross` is never used [INFO] [stdout] --> src/core/renderer.rs:146:4 [INFO] [stdout] | [INFO] [stdout] 146 | fn cross(a: &[f32; 3], b: &[f32; 3]) -> [f32; 3] { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `vec3_normalize` is never used [INFO] [stdout] --> src/core/renderer.rs:154:8 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn vec3_normalize(v: [f32; 3]) -> [f32; 3] { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `look_at` is never used [INFO] [stdout] --> src/core/renderer.rs:163:4 [INFO] [stdout] | [INFO] [stdout] 163 | fn look_at(&position: &[f32; 3], &lookat: &[f32; 3], &up: &[f32; 3]) -> Mat4f { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `perspective` is never used [INFO] [stdout] --> src/core/renderer.rs:218:4 [INFO] [stdout] | [INFO] [stdout] 218 | fn perspective(fov_y: f32, aspect: f32, near: f32, far: f32) -> Mat4f { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Ren` is never constructed [INFO] [stdout] --> src/core/renderer.rs:256:12 [INFO] [stdout] | [INFO] [stdout] 256 | pub struct Ren { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/core/renderer.rs:292:12 [INFO] [stdout] | [INFO] [stdout] 291 | impl Ren { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] 292 | pub fn run_init_sphere_compute_shader(&self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 345 | fn run_init_cube_compute_shader(&self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 398 | pub async fn new(window: Arc) -> anyhow::Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 763 | pub fn resize(&mut self, width: u32, height: u32) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 817 | pub fn handle_key(&mut self, event_loop: &ActiveEventLoop, code: KeyCode, is_pressed: bool) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 854 | pub fn handle_mouse_motion(&mut self, delta_x: f64, delta_y: f64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 863 | pub fn update(&mut self) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 890 | pub fn render( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Win` is never constructed [INFO] [stdout] --> src/core/window.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Win { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/core/window.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 29 | impl Win { [INFO] [stdout] | -------- associated function in this implementation [INFO] [stdout] 30 | pub fn new(#[cfg(target_arch = "wasm32")] event_loop: &EventLoop) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `data` [INFO] [stdout] --> src/core/renderer.rs:26:18 [INFO] [stdout] | [INFO] [stdout] 26 | for c in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 26 - for c in 0..4 { [INFO] [stdout] 26 + for (c, ) in data.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `r` is used to index `data` [INFO] [stdout] --> src/core/renderer.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | for r in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 27 - for r in 0..4 { [INFO] [stdout] 27 + for (r, ) in data.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 142 | return a[0] * b[0] + a[1] * b[1] + a[2] * b[2]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return a[0] * b[0] + a[1] * b[1] + a[2] * b[2]; [INFO] [stdout] 142 + a[0] * b[0] + a[1] * b[1] + a[2] * b[2] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | / return [ [INFO] [stdout] 148 | | a[1] * b[2] - a[2] * b[1], [INFO] [stdout] 149 | | a[2] * b[0] - a[0] * b[2], [INFO] [stdout] 150 | | a[0] * b[1] - a[1] * b[0], [INFO] [stdout] 151 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 ~ [ [INFO] [stdout] 148 + a[1] * b[2] - a[2] * b[1], [INFO] [stdout] 149 + a[2] * b[0] - a[0] * b[2], [INFO] [stdout] 150 + a[0] * b[1] - a[1] * b[0], [INFO] [stdout] 151 ~ ] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return result; [INFO] [stdout] 201 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[f32; 3]` which implements the `Copy` trait [INFO] [stdout] --> src/core/renderer.rs:164:23 [INFO] [stdout] | [INFO] [stdout] 164 | let mut look_at = lookat.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `lookat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:338:28 [INFO] [stdout] | [INFO] [stdout] 338 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/renderer.rs:593:21 [INFO] [stdout] | [INFO] [stdout] 593 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/renderer.rs:610:25 [INFO] [stdout] | [INFO] [stdout] 610 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/renderer.rs:632:25 [INFO] [stdout] | [INFO] [stdout] 632 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:391:28 [INFO] [stdout] | [INFO] [stdout] 391 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:712:28 [INFO] [stdout] | [INFO] [stdout] 712 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:826:17 [INFO] [stdout] | [INFO] [stdout] 826 | / if is_pressed { [INFO] [stdout] 827 | | event_loop.exit() [INFO] [stdout] 828 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 825 ~ KeyCode::Escape [INFO] [stdout] 826 ~ if is_pressed => { [INFO] [stdout] 827 | event_loop.exit() [INFO] [stdout] 828 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:831:17 [INFO] [stdout] | [INFO] [stdout] 831 | / if is_pressed { [INFO] [stdout] 832 | | self.run_init_sphere_compute_shader(); [INFO] [stdout] 833 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 830 ~ KeyCode::KeyR [INFO] [stdout] 831 ~ if is_pressed => { [INFO] [stdout] 832 | self.run_init_sphere_compute_shader(); [INFO] [stdout] 833 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/window.rs:89:79 [INFO] [stdout] | [INFO] [stdout] 89 | fn user_event(&mut self, event_loop: &winit::event_loop::ActiveEventLoop, mut event: Ren) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:836:17 [INFO] [stdout] | [INFO] [stdout] 836 | / if is_pressed { [INFO] [stdout] 837 | | self.run_init_cube_compute_shader(); [INFO] [stdout] 838 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 835 ~ KeyCode::KeyT [INFO] [stdout] 836 ~ if is_pressed => { [INFO] [stdout] 837 | self.run_init_cube_compute_shader(); [INFO] [stdout] 838 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:841:17 [INFO] [stdout] | [INFO] [stdout] 841 | / if is_pressed { [INFO] [stdout] 842 | | self.is_gravity_on = !self.is_gravity_on; [INFO] [stdout] 843 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 840 ~ KeyCode::KeyG [INFO] [stdout] 841 ~ if is_pressed => { [INFO] [stdout] 842 | self.is_gravity_on = !self.is_gravity_on; [INFO] [stdout] 843 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_loop` [INFO] [stdout] --> src/core/window.rs:89:30 [INFO] [stdout] | [INFO] [stdout] 89 | fn user_event(&mut self, event_loop: &winit::event_loop::ActiveEventLoop, mut event: Ren) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_loop` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:846:17 [INFO] [stdout] | [INFO] [stdout] 846 | / if is_pressed { [INFO] [stdout] 847 | | self.gravity_follow_mouse = !self.gravity_follow_mouse; [INFO] [stdout] 848 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 845 ~ KeyCode::KeyF [INFO] [stdout] 846 ~ if is_pressed => { [INFO] [stdout] 847 | self.gravity_follow_mouse = !self.gravity_follow_mouse; [INFO] [stdout] 848 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `window_id` [INFO] [stdout] --> src/core/window.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | window_id: winit::window::WindowId, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_window_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:1114:9 [INFO] [stdout] | [INFO] [stdout] 1114 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1114 - return Ok(()); [INFO] [stdout] 1114 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `device_id` [INFO] [stdout] --> src/core/window.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 166 | device_id, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `device_id: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_loop` [INFO] [stdout] --> src/core/window.rs:196:33 [INFO] [stdout] | [INFO] [stdout] 196 | fn about_to_wait(&mut self, event_loop: &winit::event_loop::ActiveEventLoop) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_loop` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `core::renderer::Mat4f` is more private than the item `core::renderer::Camera::get_view_matrix` [INFO] [stdout] --> src/core/renderer.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn get_view_matrix(&self) -> Mat4f { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `core::renderer::Camera::get_view_matrix` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `core::renderer::Mat4f` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/core/renderer.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | struct Mat4f { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `run` is never used [INFO] [stdout] --> src/core/entry_point.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn run() -> anyhow::Result<()> { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `InputState` is never constructed [INFO] [stdout] --> src/core/renderer.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct InputState { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Camera` is never constructed [INFO] [stdout] --> src/core/renderer.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | pub struct Camera { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `get_view_matrix`, `get_forward`, and `get_right` are never used [INFO] [stdout] --> src/core/renderer.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 77 | impl Camera { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] 78 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 89 | pub fn get_view_matrix(&self) -> Mat4f { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 105 | pub fn get_forward(&self) -> [f32; 3] { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 112 | pub fn get_right(&self) -> [f32; 3] { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `vec3_add` is never used [INFO] [stdout] --> src/core/renderer.rs:119:4 [INFO] [stdout] | [INFO] [stdout] 119 | fn vec3_add(a: &[f32; 3], b: &[f32; 3]) -> [f32; 3] { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `vec3_sub` is never used [INFO] [stdout] --> src/core/renderer.rs:123:4 [INFO] [stdout] | [INFO] [stdout] 123 | fn vec3_sub(a: &[f32; 3], b: &[f32; 3]) -> [f32; 3] { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `vec3_scale` is never used [INFO] [stdout] --> src/core/renderer.rs:127:4 [INFO] [stdout] | [INFO] [stdout] 127 | fn vec3_scale(a: &[f32; 3], s: f32) -> [f32; 3] { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dot` is never used [INFO] [stdout] --> src/core/renderer.rs:141:4 [INFO] [stdout] | [INFO] [stdout] 141 | fn dot(a: &[f32; 3], b: &[f32; 3]) -> f32 { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `cross` is never used [INFO] [stdout] --> src/core/renderer.rs:146:4 [INFO] [stdout] | [INFO] [stdout] 146 | fn cross(a: &[f32; 3], b: &[f32; 3]) -> [f32; 3] { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `vec3_normalize` is never used [INFO] [stdout] --> src/core/renderer.rs:154:8 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn vec3_normalize(v: [f32; 3]) -> [f32; 3] { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `look_at` is never used [INFO] [stdout] --> src/core/renderer.rs:163:4 [INFO] [stdout] | [INFO] [stdout] 163 | fn look_at(&position: &[f32; 3], &lookat: &[f32; 3], &up: &[f32; 3]) -> Mat4f { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `perspective` is never used [INFO] [stdout] --> src/core/renderer.rs:218:4 [INFO] [stdout] | [INFO] [stdout] 218 | fn perspective(fov_y: f32, aspect: f32, near: f32, far: f32) -> Mat4f { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Ren` is never constructed [INFO] [stdout] --> src/core/renderer.rs:256:12 [INFO] [stdout] | [INFO] [stdout] 256 | pub struct Ren { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/core/renderer.rs:292:12 [INFO] [stdout] | [INFO] [stdout] 291 | impl Ren { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] 292 | pub fn run_init_sphere_compute_shader(&self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 345 | fn run_init_cube_compute_shader(&self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 398 | pub async fn new(window: Arc) -> anyhow::Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 763 | pub fn resize(&mut self, width: u32, height: u32) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 817 | pub fn handle_key(&mut self, event_loop: &ActiveEventLoop, code: KeyCode, is_pressed: bool) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 854 | pub fn handle_mouse_motion(&mut self, delta_x: f64, delta_y: f64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 863 | pub fn update(&mut self) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 890 | pub fn render( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Win` is never constructed [INFO] [stdout] --> src/core/window.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct Win { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/core/window.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 29 | impl Win { [INFO] [stdout] | -------- associated function in this implementation [INFO] [stdout] 30 | pub fn new(#[cfg(target_arch = "wasm32")] event_loop: &EventLoop) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:1007:28 [INFO] [stdout] | [INFO] [stdout] 1007 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `data` [INFO] [stdout] --> src/core/renderer.rs:26:18 [INFO] [stdout] | [INFO] [stdout] 26 | for c in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 26 - for c in 0..4 { [INFO] [stdout] 26 + for (c, ) in data.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/window.rs:117:20 [INFO] [stdout] | [INFO] [stdout] 117 | if !self.last_frame_time.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.last_frame_time.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.last_frame_time` after checking its variant with `is_none` [INFO] [stdout] --> src/core/window.rs:119:54 [INFO] [stdout] | [INFO] [stdout] 117 | if !self.last_frame_time.is_none() { [INFO] [stdout] | ------------------------------ the check is happening here [INFO] [stdout] 118 | let now = Instant::now(); [INFO] [stdout] 119 | let elapsed = now.duration_since(self.last_frame_time.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `r` is used to index `data` [INFO] [stdout] --> src/core/renderer.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | for r in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 27 - for r in 0..4 { [INFO] [stdout] 27 + for (r, ) in data.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/window.rs:173:17 [INFO] [stdout] | [INFO] [stdout] 173 | / if button == MouseButton::Left { [INFO] [stdout] 174 | | self.mouse_right_pressed = state == ElementState::Pressed; [INFO] [stdout] 175 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ WindowEvent::MouseInput { state, button, .. } [INFO] [stdout] 173 ~ if button == MouseButton::Left => { [INFO] [stdout] 174 | self.mouse_right_pressed = state == ElementState::Pressed; [INFO] [stdout] 175 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/window.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | / if let Some(ren) = &mut self.ren { [INFO] [stdout] 188 | | if let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 189 | | if self.mouse_right_pressed { [INFO] [stdout] 190 | | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] ... | [INFO] [stdout] 193 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 187 ~ if let Some(ren) = &mut self.ren [INFO] [stdout] 188 ~ && let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 189 | if self.mouse_right_pressed { [INFO] [stdout] 190 | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] 191 | } [INFO] [stdout] 192 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/window.rs:188:13 [INFO] [stdout] | [INFO] [stdout] 188 | / if let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 189 | | if self.mouse_right_pressed { [INFO] [stdout] 190 | | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] 191 | | } [INFO] [stdout] 192 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 188 ~ if let DeviceEvent::MouseMotion { delta } = event [INFO] [stdout] 189 ~ && self.mouse_right_pressed { [INFO] [stdout] 190 | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] 191 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 142 | return a[0] * b[0] + a[1] * b[1] + a[2] * b[2]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return a[0] * b[0] + a[1] * b[1] + a[2] * b[2]; [INFO] [stdout] 142 + a[0] * b[0] + a[1] * b[1] + a[2] * b[2] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | / return [ [INFO] [stdout] 148 | | a[1] * b[2] - a[2] * b[1], [INFO] [stdout] 149 | | a[2] * b[0] - a[0] * b[2], [INFO] [stdout] 150 | | a[0] * b[1] - a[1] * b[0], [INFO] [stdout] 151 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 ~ [ [INFO] [stdout] 148 + a[1] * b[2] - a[2] * b[1], [INFO] [stdout] 149 + a[2] * b[0] - a[0] * b[2], [INFO] [stdout] 150 + a[0] * b[1] - a[1] * b[0], [INFO] [stdout] 151 ~ ] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return result; [INFO] [stdout] 201 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[f32; 3]` which implements the `Copy` trait [INFO] [stdout] --> src/core/renderer.rs:164:23 [INFO] [stdout] | [INFO] [stdout] 164 | let mut look_at = lookat.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `lookat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:338:28 [INFO] [stdout] | [INFO] [stdout] 338 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:391:28 [INFO] [stdout] | [INFO] [stdout] 391 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:712:28 [INFO] [stdout] | [INFO] [stdout] 712 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:826:17 [INFO] [stdout] | [INFO] [stdout] 826 | / if is_pressed { [INFO] [stdout] 827 | | event_loop.exit() [INFO] [stdout] 828 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 825 ~ KeyCode::Escape [INFO] [stdout] 826 ~ if is_pressed => { [INFO] [stdout] 827 | event_loop.exit() [INFO] [stdout] 828 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:831:17 [INFO] [stdout] | [INFO] [stdout] 831 | / if is_pressed { [INFO] [stdout] 832 | | self.run_init_sphere_compute_shader(); [INFO] [stdout] 833 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 830 ~ KeyCode::KeyR [INFO] [stdout] 831 ~ if is_pressed => { [INFO] [stdout] 832 | self.run_init_sphere_compute_shader(); [INFO] [stdout] 833 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:836:17 [INFO] [stdout] | [INFO] [stdout] 836 | / if is_pressed { [INFO] [stdout] 837 | | self.run_init_cube_compute_shader(); [INFO] [stdout] 838 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 835 ~ KeyCode::KeyT [INFO] [stdout] 836 ~ if is_pressed => { [INFO] [stdout] 837 | self.run_init_cube_compute_shader(); [INFO] [stdout] 838 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:841:17 [INFO] [stdout] | [INFO] [stdout] 841 | / if is_pressed { [INFO] [stdout] 842 | | self.is_gravity_on = !self.is_gravity_on; [INFO] [stdout] 843 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 840 ~ KeyCode::KeyG [INFO] [stdout] 841 ~ if is_pressed => { [INFO] [stdout] 842 | self.is_gravity_on = !self.is_gravity_on; [INFO] [stdout] 843 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:846:17 [INFO] [stdout] | [INFO] [stdout] 846 | / if is_pressed { [INFO] [stdout] 847 | | self.gravity_follow_mouse = !self.gravity_follow_mouse; [INFO] [stdout] 848 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 845 ~ KeyCode::KeyF [INFO] [stdout] 846 ~ if is_pressed => { [INFO] [stdout] 847 | self.gravity_follow_mouse = !self.gravity_follow_mouse; [INFO] [stdout] 848 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:1114:9 [INFO] [stdout] | [INFO] [stdout] 1114 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1114 - return Ok(()); [INFO] [stdout] 1114 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:1007:28 [INFO] [stdout] | [INFO] [stdout] 1007 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/window.rs:117:20 [INFO] [stdout] | [INFO] [stdout] 117 | if !self.last_frame_time.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.last_frame_time.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.last_frame_time` after checking its variant with `is_none` [INFO] [stdout] --> src/core/window.rs:119:54 [INFO] [stdout] | [INFO] [stdout] 117 | if !self.last_frame_time.is_none() { [INFO] [stdout] | ------------------------------ the check is happening here [INFO] [stdout] 118 | let now = Instant::now(); [INFO] [stdout] 119 | let elapsed = now.duration_since(self.last_frame_time.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/window.rs:173:17 [INFO] [stdout] | [INFO] [stdout] 173 | / if button == MouseButton::Left { [INFO] [stdout] 174 | | self.mouse_right_pressed = state == ElementState::Pressed; [INFO] [stdout] 175 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ WindowEvent::MouseInput { state, button, .. } [INFO] [stdout] 173 ~ if button == MouseButton::Left => { [INFO] [stdout] 174 | self.mouse_right_pressed = state == ElementState::Pressed; [INFO] [stdout] 175 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/window.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | / if let Some(ren) = &mut self.ren { [INFO] [stdout] 188 | | if let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 189 | | if self.mouse_right_pressed { [INFO] [stdout] 190 | | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] ... | [INFO] [stdout] 193 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 187 ~ if let Some(ren) = &mut self.ren [INFO] [stdout] 188 ~ && let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 189 | if self.mouse_right_pressed { [INFO] [stdout] 190 | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] 191 | } [INFO] [stdout] 192 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/window.rs:188:13 [INFO] [stdout] | [INFO] [stdout] 188 | / if let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 189 | | if self.mouse_right_pressed { [INFO] [stdout] 190 | | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] 191 | | } [INFO] [stdout] 192 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 188 ~ if let DeviceEvent::MouseMotion { delta } = event [INFO] [stdout] 189 ~ && self.mouse_right_pressed { [INFO] [stdout] 190 | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] 191 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `default` [INFO] [stdout] --> src/core/renderer.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{default, process::exit, sync::Arc}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `wgpu::util::DeviceExt` [INFO] [stdout] --> src/core/renderer.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use wgpu::util::DeviceExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `EventLoop`, `PhysicalKey`, `application::ApplicationHandler`, and `event::*` [INFO] [stdout] --> src/core/renderer.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | application::ApplicationHandler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 6 | event::*, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | event_loop::{ActiveEventLoop, EventLoop}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 8 | keyboard::{KeyCode, PhysicalKey}, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `KeyCode` [INFO] [stdout] --> src/core/window.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | keyboard::{KeyCode, PhysicalKey}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `default` [INFO] [stdout] --> src/core/renderer.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{default, process::exit, sync::Arc}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `wgpu::util::DeviceExt` [INFO] [stdout] --> src/core/renderer.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use wgpu::util::DeviceExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `EventLoop`, `PhysicalKey`, `application::ApplicationHandler`, and `event::*` [INFO] [stdout] --> src/core/renderer.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | application::ApplicationHandler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 6 | event::*, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | event_loop::{ActiveEventLoop, EventLoop}, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 8 | keyboard::{KeyCode, PhysicalKey}, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `KeyCode` [INFO] [stdout] --> src/core/window.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | keyboard::{KeyCode, PhysicalKey}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/renderer.rs:593:21 [INFO] [stdout] | [INFO] [stdout] 593 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/renderer.rs:610:25 [INFO] [stdout] | [INFO] [stdout] 610 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/renderer.rs:632:25 [INFO] [stdout] | [INFO] [stdout] 632 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/window.rs:89:79 [INFO] [stdout] | [INFO] [stdout] 89 | fn user_event(&mut self, event_loop: &winit::event_loop::ActiveEventLoop, mut event: Ren) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_loop` [INFO] [stdout] --> src/core/window.rs:89:30 [INFO] [stdout] | [INFO] [stdout] 89 | fn user_event(&mut self, event_loop: &winit::event_loop::ActiveEventLoop, mut event: Ren) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_loop` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `window_id` [INFO] [stdout] --> src/core/window.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | window_id: winit::window::WindowId, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_window_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `device_id` [INFO] [stdout] --> src/core/window.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 166 | device_id, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `device_id: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_loop` [INFO] [stdout] --> src/core/window.rs:196:33 [INFO] [stdout] | [INFO] [stdout] 196 | fn about_to_wait(&mut self, event_loop: &winit::event_loop::ActiveEventLoop) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_loop` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `core::renderer::Mat4f` is more private than the item `core::renderer::Camera::get_view_matrix` [INFO] [stdout] --> src/core/renderer.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn get_view_matrix(&self) -> Mat4f { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `core::renderer::Camera::get_view_matrix` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `core::renderer::Mat4f` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/core/renderer.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | struct Mat4f { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `is_particles_generated` is never read [INFO] [stdout] --> src/core/renderer.rs:281:5 [INFO] [stdout] | [INFO] [stdout] 256 | pub struct Ren { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 281 | is_particles_generated: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `data` [INFO] [stdout] --> src/core/renderer.rs:26:18 [INFO] [stdout] | [INFO] [stdout] 26 | for c in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 26 - for c in 0..4 { [INFO] [stdout] 26 + for (c, ) in data.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `r` is used to index `data` [INFO] [stdout] --> src/core/renderer.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | for r in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 27 - for r in 0..4 { [INFO] [stdout] 27 + for (r, ) in data.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/renderer.rs:593:21 [INFO] [stdout] | [INFO] [stdout] 593 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/renderer.rs:610:25 [INFO] [stdout] | [INFO] [stdout] 610 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/core/renderer.rs:632:25 [INFO] [stdout] | [INFO] [stdout] 632 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 142 | return a[0] * b[0] + a[1] * b[1] + a[2] * b[2]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return a[0] * b[0] + a[1] * b[1] + a[2] * b[2]; [INFO] [stdout] 142 + a[0] * b[0] + a[1] * b[1] + a[2] * b[2] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | / return [ [INFO] [stdout] 148 | | a[1] * b[2] - a[2] * b[1], [INFO] [stdout] 149 | | a[2] * b[0] - a[0] * b[2], [INFO] [stdout] 150 | | a[0] * b[1] - a[1] * b[0], [INFO] [stdout] 151 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 ~ [ [INFO] [stdout] 148 + a[1] * b[2] - a[2] * b[1], [INFO] [stdout] 149 + a[2] * b[0] - a[0] * b[2], [INFO] [stdout] 150 + a[0] * b[1] - a[1] * b[0], [INFO] [stdout] 151 ~ ] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return result; [INFO] [stdout] 201 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[f32; 3]` which implements the `Copy` trait [INFO] [stdout] --> src/core/renderer.rs:164:23 [INFO] [stdout] | [INFO] [stdout] 164 | let mut look_at = lookat.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `lookat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/window.rs:89:79 [INFO] [stdout] | [INFO] [stdout] 89 | fn user_event(&mut self, event_loop: &winit::event_loop::ActiveEventLoop, mut event: Ren) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_loop` [INFO] [stdout] --> src/core/window.rs:89:30 [INFO] [stdout] | [INFO] [stdout] 89 | fn user_event(&mut self, event_loop: &winit::event_loop::ActiveEventLoop, mut event: Ren) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_loop` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `window_id` [INFO] [stdout] --> src/core/window.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | window_id: winit::window::WindowId, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_window_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `device_id` [INFO] [stdout] --> src/core/window.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 166 | device_id, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `device_id: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_loop` [INFO] [stdout] --> src/core/window.rs:196:33 [INFO] [stdout] | [INFO] [stdout] 196 | fn about_to_wait(&mut self, event_loop: &winit::event_loop::ActiveEventLoop) { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_loop` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `core::renderer::Mat4f` is more private than the item `core::renderer::Camera::get_view_matrix` [INFO] [stdout] --> src/core/renderer.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn get_view_matrix(&self) -> Mat4f { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `core::renderer::Camera::get_view_matrix` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `core::renderer::Mat4f` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/core/renderer.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | struct Mat4f { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `is_particles_generated` is never read [INFO] [stdout] --> src/core/renderer.rs:281:5 [INFO] [stdout] | [INFO] [stdout] 256 | pub struct Ren { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 281 | is_particles_generated: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:338:28 [INFO] [stdout] | [INFO] [stdout] 338 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:391:28 [INFO] [stdout] | [INFO] [stdout] 391 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `data` [INFO] [stdout] --> src/core/renderer.rs:26:18 [INFO] [stdout] | [INFO] [stdout] 26 | for c in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 26 - for c in 0..4 { [INFO] [stdout] 26 + for (c, ) in data.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `r` is used to index `data` [INFO] [stdout] --> src/core/renderer.rs:27:22 [INFO] [stdout] | [INFO] [stdout] 27 | for r in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 27 - for r in 0..4 { [INFO] [stdout] 27 + for (r, ) in data.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:712:28 [INFO] [stdout] | [INFO] [stdout] 712 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:826:17 [INFO] [stdout] | [INFO] [stdout] 826 | / if is_pressed { [INFO] [stdout] 827 | | event_loop.exit() [INFO] [stdout] 828 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 825 ~ KeyCode::Escape [INFO] [stdout] 826 ~ if is_pressed => { [INFO] [stdout] 827 | event_loop.exit() [INFO] [stdout] 828 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:831:17 [INFO] [stdout] | [INFO] [stdout] 831 | / if is_pressed { [INFO] [stdout] 832 | | self.run_init_sphere_compute_shader(); [INFO] [stdout] 833 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 830 ~ KeyCode::KeyR [INFO] [stdout] 831 ~ if is_pressed => { [INFO] [stdout] 832 | self.run_init_sphere_compute_shader(); [INFO] [stdout] 833 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:836:17 [INFO] [stdout] | [INFO] [stdout] 836 | / if is_pressed { [INFO] [stdout] 837 | | self.run_init_cube_compute_shader(); [INFO] [stdout] 838 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 835 ~ KeyCode::KeyT [INFO] [stdout] 836 ~ if is_pressed => { [INFO] [stdout] 837 | self.run_init_cube_compute_shader(); [INFO] [stdout] 838 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:841:17 [INFO] [stdout] | [INFO] [stdout] 841 | / if is_pressed { [INFO] [stdout] 842 | | self.is_gravity_on = !self.is_gravity_on; [INFO] [stdout] 843 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 840 ~ KeyCode::KeyG [INFO] [stdout] 841 ~ if is_pressed => { [INFO] [stdout] 842 | self.is_gravity_on = !self.is_gravity_on; [INFO] [stdout] 843 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:846:17 [INFO] [stdout] | [INFO] [stdout] 846 | / if is_pressed { [INFO] [stdout] 847 | | self.gravity_follow_mouse = !self.gravity_follow_mouse; [INFO] [stdout] 848 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 845 ~ KeyCode::KeyF [INFO] [stdout] 846 ~ if is_pressed => { [INFO] [stdout] 847 | self.gravity_follow_mouse = !self.gravity_follow_mouse; [INFO] [stdout] 848 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:1114:9 [INFO] [stdout] | [INFO] [stdout] 1114 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1114 - return Ok(()); [INFO] [stdout] 1114 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 142 | return a[0] * b[0] + a[1] * b[1] + a[2] * b[2]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 142 - return a[0] * b[0] + a[1] * b[1] + a[2] * b[2]; [INFO] [stdout] 142 + a[0] * b[0] + a[1] * b[1] + a[2] * b[2] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | / return [ [INFO] [stdout] 148 | | a[1] * b[2] - a[2] * b[1], [INFO] [stdout] 149 | | a[2] * b[0] - a[0] * b[2], [INFO] [stdout] 150 | | a[0] * b[1] - a[1] * b[0], [INFO] [stdout] 151 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 ~ [ [INFO] [stdout] 148 + a[1] * b[2] - a[2] * b[1], [INFO] [stdout] 149 + a[2] * b[0] - a[0] * b[2], [INFO] [stdout] 150 + a[0] * b[1] - a[1] * b[0], [INFO] [stdout] 151 ~ ] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return result; [INFO] [stdout] 201 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[f32; 3]` which implements the `Copy` trait [INFO] [stdout] --> src/core/renderer.rs:164:23 [INFO] [stdout] | [INFO] [stdout] 164 | let mut look_at = lookat.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `lookat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:1007:28 [INFO] [stdout] | [INFO] [stdout] 1007 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/window.rs:117:20 [INFO] [stdout] | [INFO] [stdout] 117 | if !self.last_frame_time.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.last_frame_time.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.last_frame_time` after checking its variant with `is_none` [INFO] [stdout] --> src/core/window.rs:119:54 [INFO] [stdout] | [INFO] [stdout] 117 | if !self.last_frame_time.is_none() { [INFO] [stdout] | ------------------------------ the check is happening here [INFO] [stdout] 118 | let now = Instant::now(); [INFO] [stdout] 119 | let elapsed = now.duration_since(self.last_frame_time.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/window.rs:173:17 [INFO] [stdout] | [INFO] [stdout] 173 | / if button == MouseButton::Left { [INFO] [stdout] 174 | | self.mouse_right_pressed = state == ElementState::Pressed; [INFO] [stdout] 175 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ WindowEvent::MouseInput { state, button, .. } [INFO] [stdout] 173 ~ if button == MouseButton::Left => { [INFO] [stdout] 174 | self.mouse_right_pressed = state == ElementState::Pressed; [INFO] [stdout] 175 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/window.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | / if let Some(ren) = &mut self.ren { [INFO] [stdout] 188 | | if let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 189 | | if self.mouse_right_pressed { [INFO] [stdout] 190 | | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] ... | [INFO] [stdout] 193 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 187 ~ if let Some(ren) = &mut self.ren [INFO] [stdout] 188 ~ && let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 189 | if self.mouse_right_pressed { [INFO] [stdout] 190 | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] 191 | } [INFO] [stdout] 192 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/window.rs:188:13 [INFO] [stdout] | [INFO] [stdout] 188 | / if let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 189 | | if self.mouse_right_pressed { [INFO] [stdout] 190 | | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] 191 | | } [INFO] [stdout] 192 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 188 ~ if let DeviceEvent::MouseMotion { delta } = event [INFO] [stdout] 189 ~ && self.mouse_right_pressed { [INFO] [stdout] 190 | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] 191 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:338:28 [INFO] [stdout] | [INFO] [stdout] 338 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:391:28 [INFO] [stdout] | [INFO] [stdout] 391 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:712:28 [INFO] [stdout] | [INFO] [stdout] 712 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:826:17 [INFO] [stdout] | [INFO] [stdout] 826 | / if is_pressed { [INFO] [stdout] 827 | | event_loop.exit() [INFO] [stdout] 828 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 825 ~ KeyCode::Escape [INFO] [stdout] 826 ~ if is_pressed => { [INFO] [stdout] 827 | event_loop.exit() [INFO] [stdout] 828 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:831:17 [INFO] [stdout] | [INFO] [stdout] 831 | / if is_pressed { [INFO] [stdout] 832 | | self.run_init_sphere_compute_shader(); [INFO] [stdout] 833 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 830 ~ KeyCode::KeyR [INFO] [stdout] 831 ~ if is_pressed => { [INFO] [stdout] 832 | self.run_init_sphere_compute_shader(); [INFO] [stdout] 833 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:836:17 [INFO] [stdout] | [INFO] [stdout] 836 | / if is_pressed { [INFO] [stdout] 837 | | self.run_init_cube_compute_shader(); [INFO] [stdout] 838 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 835 ~ KeyCode::KeyT [INFO] [stdout] 836 ~ if is_pressed => { [INFO] [stdout] 837 | self.run_init_cube_compute_shader(); [INFO] [stdout] 838 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:841:17 [INFO] [stdout] | [INFO] [stdout] 841 | / if is_pressed { [INFO] [stdout] 842 | | self.is_gravity_on = !self.is_gravity_on; [INFO] [stdout] 843 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 840 ~ KeyCode::KeyG [INFO] [stdout] 841 ~ if is_pressed => { [INFO] [stdout] 842 | self.is_gravity_on = !self.is_gravity_on; [INFO] [stdout] 843 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/renderer.rs:846:17 [INFO] [stdout] | [INFO] [stdout] 846 | / if is_pressed { [INFO] [stdout] 847 | | self.gravity_follow_mouse = !self.gravity_follow_mouse; [INFO] [stdout] 848 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 845 ~ KeyCode::KeyF [INFO] [stdout] 846 ~ if is_pressed => { [INFO] [stdout] 847 | self.gravity_follow_mouse = !self.gravity_follow_mouse; [INFO] [stdout] 848 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/core/renderer.rs:1114:9 [INFO] [stdout] | [INFO] [stdout] 1114 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1114 - return Ok(()); [INFO] [stdout] 1114 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/core/renderer.rs:1007:28 [INFO] [stdout] | [INFO] [stdout] 1007 | let x_groups = (size + 255) / 256; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `size.div_ceil(256)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/window.rs:117:20 [INFO] [stdout] | [INFO] [stdout] 117 | if !self.last_frame_time.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.last_frame_time.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.last_frame_time` after checking its variant with `is_none` [INFO] [stdout] --> src/core/window.rs:119:54 [INFO] [stdout] | [INFO] [stdout] 117 | if !self.last_frame_time.is_none() { [INFO] [stdout] | ------------------------------ the check is happening here [INFO] [stdout] 118 | let now = Instant::now(); [INFO] [stdout] 119 | let elapsed = now.duration_since(self.last_frame_time.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/core/window.rs:173:17 [INFO] [stdout] | [INFO] [stdout] 173 | / if button == MouseButton::Left { [INFO] [stdout] 174 | | self.mouse_right_pressed = state == ElementState::Pressed; [INFO] [stdout] 175 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 172 ~ WindowEvent::MouseInput { state, button, .. } [INFO] [stdout] 173 ~ if button == MouseButton::Left => { [INFO] [stdout] 174 | self.mouse_right_pressed = state == ElementState::Pressed; [INFO] [stdout] 175 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/window.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | / if let Some(ren) = &mut self.ren { [INFO] [stdout] 188 | | if let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 189 | | if self.mouse_right_pressed { [INFO] [stdout] 190 | | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] ... | [INFO] [stdout] 193 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 187 ~ if let Some(ren) = &mut self.ren [INFO] [stdout] 188 ~ && let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 189 | if self.mouse_right_pressed { [INFO] [stdout] 190 | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] 191 | } [INFO] [stdout] 192 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/window.rs:188:13 [INFO] [stdout] | [INFO] [stdout] 188 | / if let DeviceEvent::MouseMotion { delta } = event { [INFO] [stdout] 189 | | if self.mouse_right_pressed { [INFO] [stdout] 190 | | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] 191 | | } [INFO] [stdout] 192 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 188 ~ if let DeviceEvent::MouseMotion { delta } = event [INFO] [stdout] 189 ~ && self.mouse_right_pressed { [INFO] [stdout] 190 | ren.handle_mouse_motion(delta.0, delta.1); [INFO] [stdout] 191 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 50.75s [INFO] running `Command { std: "docker" "inspect" "2f5d53e67c4c9d1dab3be6b5b3cc76dfa1219bd9a29c248c69f9935d7f9ad16e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f5d53e67c4c9d1dab3be6b5b3cc76dfa1219bd9a29c248c69f9935d7f9ad16e", kill_on_drop: false }` [INFO] [stdout] 2f5d53e67c4c9d1dab3be6b5b3cc76dfa1219bd9a29c248c69f9935d7f9ad16e