[INFO] cloning repository https://github.com/MMJ21/AdventOfCode2024 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MMJ21/AdventOfCode2024" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMMJ21%2FAdventOfCode2024", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMMJ21%2FAdventOfCode2024'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9fa0c0beb5d0a00b8bf58b9d267bfdded5aeed9c [INFO] linting MMJ21/AdventOfCode2024 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMMJ21%2FAdventOfCode2024" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-5-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/MMJ21/AdventOfCode2024 [INFO] finished tweaking git repo https://github.com/MMJ21/AdventOfCode2024 [INFO] tweaked toml for git repo https://github.com/MMJ21/AdventOfCode2024 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MMJ21/AdventOfCode2024 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MMJ21/AdventOfCode2024 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ffff3a586ed193ca42b0e9a768b388069184310df4b45e9339c2ab07cc92a4c9 [INFO] running `Command { std: "docker" "start" "-a" "ffff3a586ed193ca42b0e9a768b388069184310df4b45e9339c2ab07cc92a4c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ffff3a586ed193ca42b0e9a768b388069184310df4b45e9339c2ab07cc92a4c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ffff3a586ed193ca42b0e9a768b388069184310df4b45e9339c2ab07cc92a4c9", kill_on_drop: false }` [INFO] [stdout] ffff3a586ed193ca42b0e9a768b388069184310df4b45e9339c2ab07cc92a4c9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 986d8d8b6ab1181385c4f6e0819e831640afb79524afece3e991c104ed1c216c [INFO] running `Command { std: "docker" "start" "-a" "986d8d8b6ab1181385c4f6e0819e831640afb79524afece3e991c104ed1c216c", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking tinyjson v2.5.1 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking advent_of_code v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/template/run_multi.rs:173:26 [INFO] [stdout] | [INFO] [stdout] 173 | let str_timing = line [INFO] [stdout] | __________________________^ [INFO] [stdout] 174 | | .split(" samples)") [INFO] [stdout] 175 | | .next()? [INFO] [stdout] 176 | | .split('(') [INFO] [stdout] 177 | | .last()? [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 177 - .last()? [INFO] [stdout] 177 + .next_back()? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/template/timings.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | data.sort_unstable_by(|a, b| a.day.cmp(&b.day)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 54 - data.sort_unstable_by(|a, b| a.day.cmp(&b.day)); [INFO] [stdout] 54 + data.sort_unstable_by_key(|a| a.day); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/template/run_multi.rs:173:26 [INFO] [stdout] | [INFO] [stdout] 173 | let str_timing = line [INFO] [stdout] | __________________________^ [INFO] [stdout] 174 | | .split(" samples)") [INFO] [stdout] 175 | | .next()? [INFO] [stdout] 176 | | .split('(') [INFO] [stdout] 177 | | .last()? [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 177 - .last()? [INFO] [stdout] 177 + .next_back()? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/template/timings.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | data.sort_unstable_by(|a, b| a.day.cmp(&b.day)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 54 - data.sort_unstable_by(|a, b| a.day.cmp(&b.day)); [INFO] [stdout] 54 + data.sort_unstable_by_key(|a| a.day); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Lines<'_>` [INFO] [stdout] --> src/bin/02.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | input.lines().into_iter().map(|line| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.lines()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Lines<'_>` [INFO] [stdout] --> src/bin/02.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | input.lines().into_iter().map(|line| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.lines()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/03.rs:8:52 [INFO] [stdout] | [INFO] [stdout] 8 | for (_, [first, second]) in ptrn.captures_iter(&input).map(|elem| elem.extract()) { [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/03.rs:20:39 [INFO] [stdout] | [INFO] [stdout] 20 | for capture in ptrn.captures_iter(&input) { [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/bin/03.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | sum += &capture["first"].parse::().unwrap() * &capture["second"].parse::().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 28 - sum += &capture["first"].parse::().unwrap() * &capture["second"].parse::().unwrap(); [INFO] [stdout] 28 + sum += capture["first"].parse::().unwrap() * capture["second"].parse::().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/bin/05.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/bin/07.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | let sum: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 15 | / sum = input_as_vector [INFO] [stdout] 16 | | .into_iter() [INFO] [stdout] 17 | | .filter(|(result, terms)| is_result_achievable_with_terms(*result, terms)) [INFO] [stdout] 18 | | .map(|(result, _)| result) [INFO] [stdout] 19 | | .sum(); [INFO] [stdout] | |______________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `sum` here [INFO] [stdout] | [INFO] [stdout] 5 ~ [INFO] [stdout] 6 | // Parse input in vector [INFO] [stdout] ... [INFO] [stdout] 14 | [INFO] [stdout] 15 ~ let sum: usize = input_as_vector [INFO] [stdout] 16 + .into_iter() [INFO] [stdout] 17 + .filter(|(result, terms)| is_result_achievable_with_terms(*result, terms)) [INFO] [stdout] 18 + .map(|(result, _)| result) [INFO] [stdout] 19 ~ .sum(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/bin/07.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | let sum: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 36 | / sum = input_as_vector [INFO] [stdout] 37 | | .into_iter() [INFO] [stdout] 38 | | .filter(|(result, terms)| is_result_achievable_with_terms_part2 (*result, terms)) [INFO] [stdout] 39 | | .map(|(result, _)| result) [INFO] [stdout] 40 | | .sum(); [INFO] [stdout] | |______________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `sum` here [INFO] [stdout] | [INFO] [stdout] 26 ~ [INFO] [stdout] 27 | // Parse input in vector [INFO] [stdout] ... [INFO] [stdout] 35 | [INFO] [stdout] 36 ~ let sum: usize = input_as_vector [INFO] [stdout] 37 + .into_iter() [INFO] [stdout] 38 + .filter(|(result, terms)| is_result_achievable_with_terms_part2 (*result, terms)) [INFO] [stdout] 39 + .map(|(result, _)| result) [INFO] [stdout] 40 ~ .sum(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/07.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | if result % last == 0 && is_result_achievable_with_terms(result / last, rest) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `result.is_multiple_of(last)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/07.rs:69:8 [INFO] [stdout] | [INFO] [stdout] 69 | if result % last_term == 0 && is_result_achievable_with_terms_part2(result / last_term, rest) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `result.is_multiple_of(last_term)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual absolute difference pattern without using `abs_diff` [INFO] [stdout] --> src/bin/01.rs:22:34 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|(left, right)| if left > right { left - right } else { right - left }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with `abs_diff`: `left.abs_diff(*right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_abs_diff [INFO] [stdout] = note: `#[warn(clippy::manual_abs_diff)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/01.rs:46:45 [INFO] [stdout] | [INFO] [stdout] 46 | .map(|left| match right_map.get(&left) { [INFO] [stdout] | ^^^^^ help: change this to: `left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/03.rs:8:52 [INFO] [stdout] | [INFO] [stdout] 8 | for (_, [first, second]) in ptrn.captures_iter(&input).map(|elem| elem.extract()) { [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/03.rs:20:39 [INFO] [stdout] | [INFO] [stdout] 20 | for capture in ptrn.captures_iter(&input) { [INFO] [stdout] | ^^^^^^ help: change this to: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/bin/03.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | sum += &capture["first"].parse::().unwrap() * &capture["second"].parse::().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 28 - sum += &capture["first"].parse::().unwrap() * &capture["second"].parse::().unwrap(); [INFO] [stdout] 28 + sum += capture["first"].parse::().unwrap() * capture["second"].parse::().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/bin/08.rs:24:38 [INFO] [stdout] | [INFO] [stdout] 24 | let antinode_y = (2 * y0 - y1) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(2 * y0 - y1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/bin/08.rs:25:38 [INFO] [stdout] | [INFO] [stdout] 25 | let antinode_x = (2 * x0 - x1) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(2 * x0 - x1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual absolute difference pattern without using `abs_diff` [INFO] [stdout] --> src/bin/01.rs:22:34 [INFO] [stdout] | [INFO] [stdout] 22 | .map(|(left, right)| if left > right { left - right } else { right - left }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with `abs_diff`: `left.abs_diff(*right)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_abs_diff [INFO] [stdout] = note: `#[warn(clippy::manual_abs_diff)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/01.rs:46:45 [INFO] [stdout] | [INFO] [stdout] 46 | .map(|left| match right_map.get(&left) { [INFO] [stdout] | ^^^^^ help: change this to: `left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GuardPos` which implements the `Copy` trait [INFO] [stdout] --> src/bin/06.rs:135:35 [INFO] [stdout] | [INFO] [stdout] 135 | let mut current_pos = start_pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `start_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/06.rs:157:31 [INFO] [stdout] | [INFO] [stdout] 157 | fn check_if_exit(test_matrix: &Vec>, guard_position: &mut GuardPos) -> Option<(usize, usize)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 157 - fn check_if_exit(test_matrix: &Vec>, guard_position: &mut GuardPos) -> Option<(usize, usize)> { [INFO] [stdout] 157 + fn check_if_exit(test_matrix: &[Vec], guard_position: &mut GuardPos) -> Option<(usize, usize)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GuardPos` which implements the `Copy` trait [INFO] [stdout] --> src/bin/06.rs:135:35 [INFO] [stdout] | [INFO] [stdout] 135 | let mut current_pos = start_pos.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `start_pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/06.rs:157:31 [INFO] [stdout] | [INFO] [stdout] 157 | fn check_if_exit(test_matrix: &Vec>, guard_position: &mut GuardPos) -> Option<(usize, usize)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 157 - fn check_if_exit(test_matrix: &Vec>, guard_position: &mut GuardPos) -> Option<(usize, usize)> { [INFO] [stdout] 157 + fn check_if_exit(test_matrix: &[Vec], guard_position: &mut GuardPos) -> Option<(usize, usize)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:30:24 [INFO] [stdout] | [INFO] [stdout] 30 | if !(matrix[i][j + k] == XMAS.chars().nth(k).unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i][j + k] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 48 | if !(matrix[i][j - k] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i][j - k] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:67:24 [INFO] [stdout] | [INFO] [stdout] 67 | if !(matrix[i + k][j] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i + k][j] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:86:24 [INFO] [stdout] | [INFO] [stdout] 86 | if !(matrix[i - k][j] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i - k][j] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:105:24 [INFO] [stdout] | [INFO] [stdout] 105 | if !(matrix[i + k][j + k] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i + k][j + k] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:124:24 [INFO] [stdout] | [INFO] [stdout] 124 | if !(matrix[i + k][j - k] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i + k][j - k] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:143:24 [INFO] [stdout] | [INFO] [stdout] 143 | if !(matrix[i - k][j + k] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i - k][j + k] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:162:24 [INFO] [stdout] | [INFO] [stdout] 162 | if !(matrix[i - k][j - k] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i - k][j - k] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/bin/08.rs:24:38 [INFO] [stdout] | [INFO] [stdout] 24 | let antinode_y = (2 * y0 - y1) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(2 * y0 - y1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Lines<'_>` [INFO] [stdout] --> src/bin/02.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | input.lines().into_iter().map(|line| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.lines()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/bin/08.rs:25:38 [INFO] [stdout] | [INFO] [stdout] 25 | let antinode_x = (2 * x0 - x1) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(2 * x0 - x1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Lines<'_>` [INFO] [stdout] --> src/bin/02.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | input.lines().into_iter().map(|line| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.lines()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/bin/04.rs:201:141 [INFO] [stdout] | [INFO] [stdout] 201 | if matrix[i - 1][j - 1] == 'M' && matrix[i - 1][j + 1] == 'M' && matrix[i + 1][j - 1] == 'S' && matrix[i + 1][j + 1] == 'S' { [INFO] [stdout] | _____________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 202 | | sum += 1; [INFO] [stdout] 203 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/bin/04.rs:207:146 [INFO] [stdout] | [INFO] [stdout] 207 | else if matrix[i - 1][j - 1] == 'M' && matrix[i - 1][j + 1] == 'S' && matrix[i + 1][j - 1] == 'M' && matrix[i + 1][j + 1] == 'S' { [INFO] [stdout] | __________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 208 | | sum += 1; [INFO] [stdout] 209 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/bin/04.rs:207:146 [INFO] [stdout] | [INFO] [stdout] 207 | else if matrix[i - 1][j - 1] == 'M' && matrix[i - 1][j + 1] == 'S' && matrix[i + 1][j - 1] == 'M' && matrix[i + 1][j + 1] == 'S' { [INFO] [stdout] | __________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 208 | | sum += 1; [INFO] [stdout] 209 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/bin/04.rs:213:146 [INFO] [stdout] | [INFO] [stdout] 213 | else if matrix[i - 1][j - 1] == 'S' && matrix[i - 1][j + 1] == 'M' && matrix[i + 1][j - 1] == 'S' && matrix[i + 1][j + 1] == 'M' { [INFO] [stdout] | __________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 214 | | sum += 1; [INFO] [stdout] 215 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/bin/04.rs:213:146 [INFO] [stdout] | [INFO] [stdout] 213 | else if matrix[i - 1][j - 1] == 'S' && matrix[i - 1][j + 1] == 'M' && matrix[i + 1][j - 1] == 'S' && matrix[i + 1][j + 1] == 'M' { [INFO] [stdout] | __________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 214 | | sum += 1; [INFO] [stdout] 215 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/bin/04.rs:219:146 [INFO] [stdout] | [INFO] [stdout] 219 | else if matrix[i - 1][j - 1] == 'S' && matrix[i - 1][j + 1] == 'S' && matrix[i + 1][j - 1] == 'M' && matrix[i + 1][j + 1] == 'M' { [INFO] [stdout] | __________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 220 | | sum += 1; [INFO] [stdout] 221 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/bin/07.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | let sum: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 15 | / sum = input_as_vector [INFO] [stdout] 16 | | .into_iter() [INFO] [stdout] 17 | | .filter(|(result, terms)| is_result_achievable_with_terms(*result, terms)) [INFO] [stdout] 18 | | .map(|(result, _)| result) [INFO] [stdout] 19 | | .sum(); [INFO] [stdout] | |______________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `sum` here [INFO] [stdout] | [INFO] [stdout] 5 ~ [INFO] [stdout] 6 | // Parse input in vector [INFO] [stdout] ... [INFO] [stdout] 14 | [INFO] [stdout] 15 ~ let sum: usize = input_as_vector [INFO] [stdout] 16 + .into_iter() [INFO] [stdout] 17 + .filter(|(result, terms)| is_result_achievable_with_terms(*result, terms)) [INFO] [stdout] 18 + .map(|(result, _)| result) [INFO] [stdout] 19 ~ .sum(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/bin/07.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | let sum: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 36 | / sum = input_as_vector [INFO] [stdout] 37 | | .into_iter() [INFO] [stdout] 38 | | .filter(|(result, terms)| is_result_achievable_with_terms_part2 (*result, terms)) [INFO] [stdout] 39 | | .map(|(result, _)| result) [INFO] [stdout] 40 | | .sum(); [INFO] [stdout] | |______________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `sum` here [INFO] [stdout] | [INFO] [stdout] 26 ~ [INFO] [stdout] 27 | // Parse input in vector [INFO] [stdout] ... [INFO] [stdout] 35 | [INFO] [stdout] 36 ~ let sum: usize = input_as_vector [INFO] [stdout] 37 + .into_iter() [INFO] [stdout] 38 + .filter(|(result, terms)| is_result_achievable_with_terms_part2 (*result, terms)) [INFO] [stdout] 39 + .map(|(result, _)| result) [INFO] [stdout] 40 ~ .sum(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/07.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | if result % last == 0 && is_result_achievable_with_terms(result / last, rest) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `result.is_multiple_of(last)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/bin/07.rs:69:8 [INFO] [stdout] | [INFO] [stdout] 69 | if result % last_term == 0 && is_result_achievable_with_terms_part2(result / last_term, rest) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `result.is_multiple_of(last_term)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:30:24 [INFO] [stdout] | [INFO] [stdout] 30 | if !(matrix[i][j + k] == XMAS.chars().nth(k).unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i][j + k] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 48 | if !(matrix[i][j - k] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i][j - k] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:67:24 [INFO] [stdout] | [INFO] [stdout] 67 | if !(matrix[i + k][j] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i + k][j] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:86:24 [INFO] [stdout] | [INFO] [stdout] 86 | if !(matrix[i - k][j] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i - k][j] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:105:24 [INFO] [stdout] | [INFO] [stdout] 105 | if !(matrix[i + k][j + k] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i + k][j + k] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:124:24 [INFO] [stdout] | [INFO] [stdout] 124 | if !(matrix[i + k][j - k] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i + k][j - k] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:143:24 [INFO] [stdout] | [INFO] [stdout] 143 | if !(matrix[i - k][j + k] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i - k][j + k] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/04.rs:162:24 [INFO] [stdout] | [INFO] [stdout] 162 | if !(matrix[i - k][j - k] == XMAS.chars().nth(k).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(matrix[i - k][j - k] != XMAS.chars().nth(k).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/bin/04.rs:201:141 [INFO] [stdout] | [INFO] [stdout] 201 | if matrix[i - 1][j - 1] == 'M' && matrix[i - 1][j + 1] == 'M' && matrix[i + 1][j - 1] == 'S' && matrix[i + 1][j + 1] == 'S' { [INFO] [stdout] | _____________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 202 | | sum += 1; [INFO] [stdout] 203 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/bin/04.rs:207:146 [INFO] [stdout] | [INFO] [stdout] 207 | else if matrix[i - 1][j - 1] == 'M' && matrix[i - 1][j + 1] == 'S' && matrix[i + 1][j - 1] == 'M' && matrix[i + 1][j + 1] == 'S' { [INFO] [stdout] | __________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 208 | | sum += 1; [INFO] [stdout] 209 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/bin/04.rs:207:146 [INFO] [stdout] | [INFO] [stdout] 207 | else if matrix[i - 1][j - 1] == 'M' && matrix[i - 1][j + 1] == 'S' && matrix[i + 1][j - 1] == 'M' && matrix[i + 1][j + 1] == 'S' { [INFO] [stdout] | __________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 208 | | sum += 1; [INFO] [stdout] 209 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/bin/04.rs:213:146 [INFO] [stdout] | [INFO] [stdout] 213 | else if matrix[i - 1][j - 1] == 'S' && matrix[i - 1][j + 1] == 'M' && matrix[i + 1][j - 1] == 'S' && matrix[i + 1][j + 1] == 'M' { [INFO] [stdout] | __________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 214 | | sum += 1; [INFO] [stdout] 215 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/bin/04.rs:213:146 [INFO] [stdout] | [INFO] [stdout] 213 | else if matrix[i - 1][j - 1] == 'S' && matrix[i - 1][j + 1] == 'M' && matrix[i + 1][j - 1] == 'S' && matrix[i + 1][j + 1] == 'M' { [INFO] [stdout] | __________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 214 | | sum += 1; [INFO] [stdout] 215 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/bin/04.rs:219:146 [INFO] [stdout] | [INFO] [stdout] 219 | else if matrix[i - 1][j - 1] == 'S' && matrix[i - 1][j + 1] == 'S' && matrix[i + 1][j - 1] == 'M' && matrix[i + 1][j + 1] == 'M' { [INFO] [stdout] | __________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 220 | | sum += 1; [INFO] [stdout] 221 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.99s [INFO] running `Command { std: "docker" "inspect" "986d8d8b6ab1181385c4f6e0819e831640afb79524afece3e991c104ed1c216c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "986d8d8b6ab1181385c4f6e0819e831640afb79524afece3e991c104ed1c216c", kill_on_drop: false }` [INFO] [stdout] 986d8d8b6ab1181385c4f6e0819e831640afb79524afece3e991c104ed1c216c