[INFO] cloning repository https://github.com/MJRob1/fx_sim_agg_gui [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MJRob1/fx_sim_agg_gui" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMJRob1%2Ffx_sim_agg_gui", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMJRob1%2Ffx_sim_agg_gui'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 746700f0dd724631776517077d41c2c4dfcc1b18 [INFO] linting MJRob1/fx_sim_agg_gui against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMJRob1%2Ffx_sim_agg_gui" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MJRob1/fx_sim_agg_gui [INFO] finished tweaking git repo https://github.com/MJRob1/fx_sim_agg_gui [INFO] tweaked toml for git repo https://github.com/MJRob1/fx_sim_agg_gui written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MJRob1/fx_sim_agg_gui on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MJRob1/fx_sim_agg_gui already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded egui_grid v0.5.1 [INFO] [stderr] Downloaded egui_extras v0.27.2 [INFO] [stderr] Downloaded emath v0.32.1 [INFO] [stderr] Downloaded mime_guess2 v2.3.1 [INFO] [stderr] Downloaded ecolor v0.32.1 [INFO] [stderr] Downloaded zbus_xml v5.0.2 [INFO] [stderr] Downloaded zvariant_utils v3.2.0 [INFO] [stderr] Downloaded zbus-lockstep-macros v0.5.1 [INFO] [stderr] Downloaded zvariant_derive v5.6.0 [INFO] [stderr] Downloaded async-process v2.4.0 [INFO] [stderr] Downloaded zbus-lockstep v0.5.1 [INFO] [stderr] Downloaded egui-wgpu v0.32.1 [INFO] [stderr] Downloaded egui-winit v0.32.1 [INFO] [stderr] Downloaded epaint v0.32.1 [INFO] [stderr] Downloaded zvariant v5.6.0 [INFO] [stderr] Downloaded egui_glow v0.32.1 [INFO] [stderr] Downloaded egui_extras v0.32.1 [INFO] [stderr] Downloaded zbus_macros v5.9.0 [INFO] [stderr] Downloaded zbus v5.9.0 [INFO] [stderr] Downloaded eframe v0.32.1 [INFO] [stderr] Downloaded egui v0.32.1 [INFO] [stderr] Downloaded epaint_default_fonts v0.32.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3c26acef0b1ef395135ab9c7f5e5b0da9e7e407c1d20ea1236011a8b458aed6a [INFO] running `Command { std: "docker" "start" "-a" "3c26acef0b1ef395135ab9c7f5e5b0da9e7e407c1d20ea1236011a8b458aed6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3c26acef0b1ef395135ab9c7f5e5b0da9e7e407c1d20ea1236011a8b458aed6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c26acef0b1ef395135ab9c7f5e5b0da9e7e407c1d20ea1236011a8b458aed6a", kill_on_drop: false }` [INFO] [stdout] 3c26acef0b1ef395135ab9c7f5e5b0da9e7e407c1d20ea1236011a8b458aed6a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 51811878b542defa31753c817a5c9a96bf818852f10ce93e2148ab0eac3b32d9 [INFO] running `Command { std: "docker" "start" "-a" "51811878b542defa31753c817a5c9a96bf818852f10ce93e2148ab0eac3b32d9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Checking cfg-if v1.0.3 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Checking bitflags v2.9.3 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Compiling toml_datetime v0.6.11 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking libloading v0.8.8 [INFO] [stderr] Compiling zerocopy v0.8.26 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Compiling cc v1.2.34 [INFO] [stderr] Checking unicode-ident v1.0.18 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling indexmap v2.11.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling endi v1.1.0 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling toml_edit v0.22.27 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Compiling wayland-client v0.31.11 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Checking ab_glyph v0.2.31 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Compiling proc-macro-crate v3.3.0 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking async-executor v1.13.2 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Compiling xml-rs v0.8.27 [INFO] [stderr] Checking polling v3.10.0 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking async-io v2.5.0 [INFO] [stderr] Checking cursor-icon v1.2.0 [INFO] [stderr] Checking accesskit v0.19.0 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Checking async-signal v0.2.12 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking async-process v2.4.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking memmap2 v0.9.8 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Checking as-raw-xcb-connection v1.0.1 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling phf v0.11.3 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking epaint_default_fonts v0.32.1 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Compiling mime_guess2 v2.3.1 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking accesskit_consumer v0.28.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling bytemuck_derive v1.10.1 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Checking bytemuck v1.23.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking emath v0.32.1 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking ecolor v0.32.1 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking dpi v0.1.2 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Compiling glutin v0.32.3 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking image v0.25.6 [INFO] [stderr] Compiling anyhow v1.0.99 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.143 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking glow v0.16.0 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking zvariant_utils v3.2.0 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking quick-xml v0.36.2 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking epaint v0.32.1 [INFO] [stderr] Compiling zvariant_derive v5.6.0 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking emath v0.27.2 [INFO] [stderr] Compiling zvariant v5.6.0 [INFO] [stderr] Checking egui v0.32.1 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking ecolor v0.27.2 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking epaint v0.27.2 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking webbrowser v1.0.5 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Compiling zbus_names v4.2.0 [INFO] [stderr] Checking arboard v3.6.0 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking egui v0.27.2 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Compiling zbus_xml v5.0.2 [INFO] [stderr] Compiling zbus_macros v5.9.0 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking zbus-lockstep v0.5.1 [INFO] [stderr] Compiling zbus-lockstep-macros v0.5.1 [INFO] [stderr] Checking egui_glow v0.32.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Checking thread-id v4.2.2 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking egui_extras v0.32.1 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking log4rs v1.3.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking zbus v5.9.0 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking egui_extras v0.27.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.7.2 [INFO] [stderr] Checking egui_grid v0.5.1 [INFO] [stderr] Checking atspi-common v0.9.0 [INFO] [stderr] Checking atspi-proxies v0.9.0 [INFO] [stderr] Checking accesskit_atspi_common v0.12.0 [INFO] [stderr] Checking atspi-connection v0.9.0 [INFO] [stderr] Checking atspi v0.25.0 [INFO] [stderr] Checking accesskit_unix v0.15.0 [INFO] [stderr] Checking accesskit_winit v0.27.0 [INFO] [stderr] Checking egui-winit v0.32.1 [INFO] [stderr] Checking eframe v0.32.1 [INFO] [stderr] Checking fx_sim_agg_gui v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/lib.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | //! that yields values in the order they arrive from the source market data streams. Also incudes the FxViewerApp structure which in... [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 10 | //! that yields values in the order they arrive from the source market data streams. Also incudes the FxViewerApp structure which initiates and updates the GUI. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/lib.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | //! Various utilities used by the other modules are also in this library. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 11 | //! Various utilities used by the other modules are also in this library. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/aggregator.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | / match check_books_crossed(self) { [INFO] [stdout] 49 | | Some(index) => { [INFO] [stdout] 50 | | info!( [INFO] [stdout] 51 | | "books crossed at sell book index {} with sell price {}", [INFO] [stdout] ... | [INFO] [stdout] 56 | | None => (), [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 48 ~ if let Some(index) = check_books_crossed(self) { [INFO] [stdout] 49 + info!( [INFO] [stdout] 50 + "books crossed at sell book index {} with sell price {}", [INFO] [stdout] 51 + index.0, index.1 [INFO] [stdout] 52 + ); [INFO] [stdout] 53 + correct_crossed_books(self, index)?; [INFO] [stdout] 54 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/aggregator.rs:61:24 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn new(config: &Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 61 - pub fn new(config: &Vec) -> Self { [INFO] [stdout] 61 + pub fn new(config: &[Config]) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/aggregator.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | for val in vol_prices_vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, val) in vol_prices_vec.into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/aggregator.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | / match check_expired_quotes(fx_book_side, liquidity_provider, val.0) { [INFO] [stdout] 140 | | Some(entry_to_remove) => remove_single_entry(fx_book, "Buy", entry_to_remove), [INFO] [stdout] 141 | | None => (), [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(entry_to_remove) = check_expired_quotes(fx_book_side, liquidity_provider, val.0) { remove_single_entry(fx_book, "Buy", entry_to_remove) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/aggregator.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | / match check_expired_quotes(fx_book_side, liquidity_provider, val.0) { [INFO] [stdout] 147 | | // match check_expired_quotes(fx_book, liquidity_provider, "Sell", val.0) { [INFO] [stdout] 148 | | Some(entry_to_remove) => remove_single_entry(fx_book, "Sell", entry_to_remove), [INFO] [stdout] 149 | | None => (), [INFO] [stdout] 150 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(entry_to_remove) = check_expired_quotes(fx_book_side, liquidity_provider, val.0) { remove_single_entry(fx_book, "Sell", entry_to_remove) }` [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | return Some(index_to_remove); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 194 - return Some(index_to_remove); [INFO] [stdout] 194 + Some(index_to_remove) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 - return None; [INFO] [stdout] 196 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/aggregator.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 170 | for entry in fx_book_side { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, entry) in fx_book_side.iter_mut().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/aggregator.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 175 | / (lp_vol.0 != liquidity_provider) [INFO] [stdout] 176 | | || ((lp_vol.0 == liquidity_provider) && (lp_vol.1 != volume)) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 175 - (lp_vol.0 != liquidity_provider) [INFO] [stdout] 176 - || ((lp_vol.0 == liquidity_provider) && (lp_vol.1 != volume)) [INFO] [stdout] 175 + !(lp_vol.0 == liquidity_provider && lp_vol.1 == volume) [INFO] [stdout] | [INFO] [stdout] 175 - (lp_vol.0 != liquidity_provider) [INFO] [stdout] 176 - || ((lp_vol.0 == liquidity_provider) && (lp_vol.1 != volume)) [INFO] [stdout] 175 + (lp_vol.0 != liquidity_provider) || (lp_vol.1 != volume) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/aggregator.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 181 | if lp_vol_vec.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lp_vol_vec.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 221 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - println!("{fx_book:?}"); [INFO] [stdout] 221 - return; [INFO] [stdout] 220 + println!("{fx_book:?}"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - error!("first entry should not be on sell side in current configuration"); [INFO] [stdout] 224 - return; [INFO] [stdout] 223 + error!("first entry should not be on sell side in current configuration"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 247 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 246 - fx_book_side.push(new_agg_book_entry); [INFO] [stdout] 247 - return; [INFO] [stdout] 246 + fx_book_side.push(new_agg_book_entry); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/aggregator.rs:212:8 [INFO] [stdout] | [INFO] [stdout] 212 | if fx_book.buy_book.len() == 0 && side == "Buy" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fx_book.buy_book.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/aggregator.rs:222:15 [INFO] [stdout] | [INFO] [stdout] 222 | } else if fx_book.buy_book.len() == 0 && fx_book.sell_book.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fx_book.buy_book.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/aggregator.rs:222:46 [INFO] [stdout] | [INFO] [stdout] 222 | } else if fx_book.buy_book.len() == 0 && fx_book.sell_book.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fx_book.sell_book.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/aggregator.rs:262:35 [INFO] [stdout] | [INFO] [stdout] 262 | pub fn sort_buy_book(fx_buy_book: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 262 - pub fn sort_buy_book(fx_buy_book: &mut Vec) { [INFO] [stdout] 262 + pub fn sort_buy_book(fx_buy_book: &mut [FxAggBookEntry]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/aggregator.rs:271:37 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn sort_sell_book(fx_sell_book: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 271 - pub fn sort_sell_book(fx_sell_book: &mut Vec) { [INFO] [stdout] 271 + pub fn sort_sell_book(fx_sell_book: &mut [FxAggBookEntry]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:288:5 [INFO] [stdout] | [INFO] [stdout] 288 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 288 - return None; [INFO] [stdout] 288 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/aggregator.rs:276:18 [INFO] [stdout] | [INFO] [stdout] 276 | fx_buy_book: &mut Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 276 - fx_buy_book: &mut Vec, [INFO] [stdout] 276 + fx_buy_book: &mut [FxAggBookEntry], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/aggregator.rs:283:5 [INFO] [stdout] | [INFO] [stdout] 283 | / for i in (0..fx_buy_book.len()).rev() { [INFO] [stdout] 284 | | if fx_buy_book[i].price >= sell_price { [INFO] [stdout] 285 | | return Some(i); [INFO] [stdout] ... | [INFO] [stdout] 288 | | return None; [INFO] [stdout] | |________________^ help: replace with an iterator: `(0..fx_buy_book.len()).rev().find(|&i| fx_buy_book[i].price >= sell_price)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:302:5 [INFO] [stdout] | [INFO] [stdout] 302 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 302 - return None; [INFO] [stdout] 302 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/aggregator.rs:346:8 [INFO] [stdout] | [INFO] [stdout] 346 | if String::from(side) == String::from("Buy") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `side` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/aggregator.rs:346:30 [INFO] [stdout] | [INFO] [stdout] 346 | if String::from(side) == String::from("Buy") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"Buy"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/aggregator.rs:360:48 [INFO] [stdout] | [INFO] [stdout] 360 | datetime.format("%Y-%m-%d %H:%M:%S.%f").to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/aggregator.rs:376:9 [INFO] [stdout] | [INFO] [stdout] 376 | for val in lp_vol_vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, val) in lp_vol_vec.iter_mut().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/aggregator.rs:392:9 [INFO] [stdout] | [INFO] [stdout] 392 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 392 - print!("\n"); [INFO] [stdout] 392 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/aggregator.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 407 | for val in lp_vol_vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, val) in lp_vol_vec.iter_mut().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/aggregator.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 423 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 423 - print!("\n"); [INFO] [stdout] 423 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/gui.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | for val in lp_vol_vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, val) in lp_vol_vec.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/simulator.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | for i in ¶meters { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, i) in parameters.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulator.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | spread = spread / 10000.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `spread /= 10000.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulator.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | three_mill_markup = three_mill_markup / 10000.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `three_mill_markup /= 10000.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulator.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | five_mill_markup = five_mill_markup / 10000.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `five_mill_markup /= 10000.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/simulator.rs:129:46 [INFO] [stdout] | [INFO] [stdout] 129 | if let Err(send_error) = tx.send(format!("{marketdata}")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `marketdata.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/simulator.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | for i in config { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using: `for (index, i) in config.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/tests.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / mod tests { [INFO] [stdout] 3 | | [INFO] [stdout] 4 | | use crate::aggregator::FxAggBookEntry; [INFO] [stdout] 5 | | use crate::aggregator::{self, FxBook}; [INFO] [stdout] ... | [INFO] [stdout] 547 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/tests.rs:424:9 [INFO] [stdout] | [INFO] [stdout] 424 | / match aggregator::check_expired_quotes(&mut fx_buy_book, liquidity_provider, volume) { [INFO] [stdout] 425 | | Some(entry_to_remove) => { [INFO] [stdout] 426 | | println!("test check expired quotes, index to remove is {entry_to_remove}") [INFO] [stdout] ... | [INFO] [stdout] 429 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 424 ~ if let Some(entry_to_remove) = aggregator::check_expired_quotes(&mut fx_buy_book, liquidity_provider, volume) { [INFO] [stdout] 425 + println!("test check expired quotes, index to remove is {entry_to_remove}") [INFO] [stdout] 426 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:181:29 [INFO] [stdout] | [INFO] [stdout] 181 | let file = File::create(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | return Err(AppError::NumParams); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 197 - return Err(AppError::NumParams); [INFO] [stdout] 197 + Err(AppError::NumParams) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | return Err(AppError::IsEmpty); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 206 - return Err(AppError::IsEmpty); [INFO] [stdout] 206 + Err(AppError::IsEmpty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/lib.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | //! that yields values in the order they arrive from the source market data streams. Also incudes the FxViewerApp structure which in... [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 10 | //! that yields values in the order they arrive from the source market data streams. Also incudes the FxViewerApp structure which initiates and updates the GUI. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/lib.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | //! Various utilities used by the other modules are also in this library. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 11 | //! Various utilities used by the other modules are also in this library. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/aggregator.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | / match check_books_crossed(self) { [INFO] [stdout] 49 | | Some(index) => { [INFO] [stdout] 50 | | info!( [INFO] [stdout] 51 | | "books crossed at sell book index {} with sell price {}", [INFO] [stdout] ... | [INFO] [stdout] 56 | | None => (), [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 48 ~ if let Some(index) = check_books_crossed(self) { [INFO] [stdout] 49 + info!( [INFO] [stdout] 50 + "books crossed at sell book index {} with sell price {}", [INFO] [stdout] 51 + index.0, index.1 [INFO] [stdout] 52 + ); [INFO] [stdout] 53 + correct_crossed_books(self, index)?; [INFO] [stdout] 54 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/aggregator.rs:61:24 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn new(config: &Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 61 - pub fn new(config: &Vec) -> Self { [INFO] [stdout] 61 + pub fn new(config: &[Config]) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/aggregator.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | for val in vol_prices_vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, val) in vol_prices_vec.into_iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/aggregator.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | / match check_expired_quotes(fx_book_side, liquidity_provider, val.0) { [INFO] [stdout] 140 | | Some(entry_to_remove) => remove_single_entry(fx_book, "Buy", entry_to_remove), [INFO] [stdout] 141 | | None => (), [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(entry_to_remove) = check_expired_quotes(fx_book_side, liquidity_provider, val.0) { remove_single_entry(fx_book, "Buy", entry_to_remove) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/aggregator.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | / match check_expired_quotes(fx_book_side, liquidity_provider, val.0) { [INFO] [stdout] 147 | | // match check_expired_quotes(fx_book, liquidity_provider, "Sell", val.0) { [INFO] [stdout] 148 | | Some(entry_to_remove) => remove_single_entry(fx_book, "Sell", entry_to_remove), [INFO] [stdout] 149 | | None => (), [INFO] [stdout] 150 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(entry_to_remove) = check_expired_quotes(fx_book_side, liquidity_provider, val.0) { remove_single_entry(fx_book, "Sell", entry_to_remove) }` [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | return Some(index_to_remove); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 194 - return Some(index_to_remove); [INFO] [stdout] 194 + Some(index_to_remove) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 - return None; [INFO] [stdout] 196 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/aggregator.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 170 | for entry in fx_book_side { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, entry) in fx_book_side.iter_mut().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/aggregator.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 175 | / (lp_vol.0 != liquidity_provider) [INFO] [stdout] 176 | | || ((lp_vol.0 == liquidity_provider) && (lp_vol.1 != volume)) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 175 - (lp_vol.0 != liquidity_provider) [INFO] [stdout] 176 - || ((lp_vol.0 == liquidity_provider) && (lp_vol.1 != volume)) [INFO] [stdout] 175 + !(lp_vol.0 == liquidity_provider && lp_vol.1 == volume) [INFO] [stdout] | [INFO] [stdout] 175 - (lp_vol.0 != liquidity_provider) [INFO] [stdout] 176 - || ((lp_vol.0 == liquidity_provider) && (lp_vol.1 != volume)) [INFO] [stdout] 175 + (lp_vol.0 != liquidity_provider) || (lp_vol.1 != volume) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/aggregator.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 181 | if lp_vol_vec.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lp_vol_vec.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 221 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - println!("{fx_book:?}"); [INFO] [stdout] 221 - return; [INFO] [stdout] 220 + println!("{fx_book:?}"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 - error!("first entry should not be on sell side in current configuration"); [INFO] [stdout] 224 - return; [INFO] [stdout] 223 + error!("first entry should not be on sell side in current configuration"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 247 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 246 - fx_book_side.push(new_agg_book_entry); [INFO] [stdout] 247 - return; [INFO] [stdout] 246 + fx_book_side.push(new_agg_book_entry); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/aggregator.rs:212:8 [INFO] [stdout] | [INFO] [stdout] 212 | if fx_book.buy_book.len() == 0 && side == "Buy" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fx_book.buy_book.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/aggregator.rs:222:15 [INFO] [stdout] | [INFO] [stdout] 222 | } else if fx_book.buy_book.len() == 0 && fx_book.sell_book.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fx_book.buy_book.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/aggregator.rs:222:46 [INFO] [stdout] | [INFO] [stdout] 222 | } else if fx_book.buy_book.len() == 0 && fx_book.sell_book.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fx_book.sell_book.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/aggregator.rs:262:35 [INFO] [stdout] | [INFO] [stdout] 262 | pub fn sort_buy_book(fx_buy_book: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 262 - pub fn sort_buy_book(fx_buy_book: &mut Vec) { [INFO] [stdout] 262 + pub fn sort_buy_book(fx_buy_book: &mut [FxAggBookEntry]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/aggregator.rs:271:37 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn sort_sell_book(fx_sell_book: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 271 - pub fn sort_sell_book(fx_sell_book: &mut Vec) { [INFO] [stdout] 271 + pub fn sort_sell_book(fx_sell_book: &mut [FxAggBookEntry]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:288:5 [INFO] [stdout] | [INFO] [stdout] 288 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 288 - return None; [INFO] [stdout] 288 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/aggregator.rs:276:18 [INFO] [stdout] | [INFO] [stdout] 276 | fx_buy_book: &mut Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 276 - fx_buy_book: &mut Vec, [INFO] [stdout] 276 + fx_buy_book: &mut [FxAggBookEntry], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/aggregator.rs:283:5 [INFO] [stdout] | [INFO] [stdout] 283 | / for i in (0..fx_buy_book.len()).rev() { [INFO] [stdout] 284 | | if fx_buy_book[i].price >= sell_price { [INFO] [stdout] 285 | | return Some(i); [INFO] [stdout] ... | [INFO] [stdout] 288 | | return None; [INFO] [stdout] | |________________^ help: replace with an iterator: `(0..fx_buy_book.len()).rev().find(|&i| fx_buy_book[i].price >= sell_price)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/aggregator.rs:302:5 [INFO] [stdout] | [INFO] [stdout] 302 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 302 - return None; [INFO] [stdout] 302 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/aggregator.rs:346:8 [INFO] [stdout] | [INFO] [stdout] 346 | if String::from(side) == String::from("Buy") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `side` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/aggregator.rs:346:30 [INFO] [stdout] | [INFO] [stdout] 346 | if String::from(side) == String::from("Buy") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"Buy"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/aggregator.rs:360:48 [INFO] [stdout] | [INFO] [stdout] 360 | datetime.format("%Y-%m-%d %H:%M:%S.%f").to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/aggregator.rs:376:9 [INFO] [stdout] | [INFO] [stdout] 376 | for val in lp_vol_vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, val) in lp_vol_vec.iter_mut().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/aggregator.rs:392:9 [INFO] [stdout] | [INFO] [stdout] 392 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 392 - print!("\n"); [INFO] [stdout] 392 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/aggregator.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 407 | for val in lp_vol_vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, val) in lp_vol_vec.iter_mut().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/aggregator.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 423 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 423 - print!("\n"); [INFO] [stdout] 423 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/gui.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | for val in lp_vol_vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, val) in lp_vol_vec.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/simulator.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | for i in ¶meters { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, i) in parameters.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulator.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | spread = spread / 10000.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `spread /= 10000.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulator.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | three_mill_markup = three_mill_markup / 10000.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `three_mill_markup /= 10000.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulator.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | five_mill_markup = five_mill_markup / 10000.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `five_mill_markup /= 10000.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/simulator.rs:129:46 [INFO] [stdout] | [INFO] [stdout] 129 | if let Err(send_error) = tx.send(format!("{marketdata}")) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `marketdata.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/simulator.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | for i in config { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using: `for (index, i) in config.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:181:29 [INFO] [stdout] | [INFO] [stdout] 181 | let file = File::create(&path)?; [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | return Err(AppError::NumParams); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 197 - return Err(AppError::NumParams); [INFO] [stdout] 197 + Err(AppError::NumParams) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | return Err(AppError::IsEmpty); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 206 - return Err(AppError::IsEmpty); [INFO] [stdout] 206 + Err(AppError::IsEmpty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | //! that yields values in the order they arrive from the source market data streams. Also incudes the FxViewerApp structure which in... [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 10 | //! that yields values in the order they arrive from the source market data streams. Also incudes the FxViewerApp structure which initiates and updates the GUI. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | //! Various utilities used by the other modules are also in this library. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 11 | //! Various utilities used by the other modules are also in this library. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | //! that yields values in the order they arrive from the source market data streams. Also incudes the FxViewerApp structure which in... [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 10 | //! that yields values in the order they arrive from the source market data streams. Also incudes the FxViewerApp structure which initiates and updates the GUI. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | //! Various utilities used by the other modules are also in this library. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 11 | //! Various utilities used by the other modules are also in this library. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 08s [INFO] running `Command { std: "docker" "inspect" "51811878b542defa31753c817a5c9a96bf818852f10ce93e2148ab0eac3b32d9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51811878b542defa31753c817a5c9a96bf818852f10ce93e2148ab0eac3b32d9", kill_on_drop: false }` [INFO] [stdout] 51811878b542defa31753c817a5c9a96bf818852f10ce93e2148ab0eac3b32d9