[INFO] cloning repository https://github.com/MJLW/shet_score_vcfs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MJLW/shet_score_vcfs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMJLW%2Fshet_score_vcfs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMJLW%2Fshet_score_vcfs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a48a91d7f8ac456db0152724f73e92825ea4880e [INFO] linting MJLW/shet_score_vcfs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMJLW%2Fshet_score_vcfs" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/MJLW/shet_score_vcfs [INFO] finished tweaking git repo https://github.com/MJLW/shet_score_vcfs [INFO] tweaked toml for git repo https://github.com/MJLW/shet_score_vcfs written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/MJLW/shet_score_vcfs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/MJLW/shet_score_vcfs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded noodles-core v0.18.0 [INFO] [stderr] Downloaded libz-rs-sys v0.5.4 [INFO] [stderr] Downloaded noodles v0.101.0 [INFO] [stderr] Downloaded noodles-csi v0.51.0 [INFO] [stderr] Downloaded noodles-bgzf v0.43.0 [INFO] [stderr] Downloaded noodles-tabix v0.57.0 [INFO] [stderr] Downloaded noodles-vcf v0.81.0 [INFO] [stderr] Downloaded zlib-rs v0.5.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3011441e758b0d14880175478f01ac4a461a17275dcab36a5d0bb31cad153354 [INFO] running `Command { std: "docker" "start" "-a" "3011441e758b0d14880175478f01ac4a461a17275dcab36a5d0bb31cad153354", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3011441e758b0d14880175478f01ac4a461a17275dcab36a5d0bb31cad153354", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3011441e758b0d14880175478f01ac4a461a17275dcab36a5d0bb31cad153354", kill_on_drop: false }` [INFO] [stdout] 3011441e758b0d14880175478f01ac4a461a17275dcab36a5d0bb31cad153354 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f83da27c9d6ffd59a20f5ee94eec021a65aad30be71eb04b3a7f0e1fb0ceebb [INFO] running `Command { std: "docker" "start" "-a" "1f83da27c9d6ffd59a20f5ee94eec021a65aad30be71eb04b3a7f0e1fb0ceebb", kill_on_drop: false }` [INFO] [stderr] Checking zlib-rs v0.5.4 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Checking humantime v2.3.0 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking glob v0.3.3 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking noodles-core v0.18.0 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking libz-rs-sys v0.5.4 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking noodles-bgzf v0.43.0 [INFO] [stderr] Checking noodles-csi v0.51.0 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking noodles-tabix v0.57.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking noodles-vcf v0.81.0 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking noodles v0.101.0 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking shet v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:89:17 [INFO] [stdout] | [INFO] [stdout] 89 | return Ok(float_value.to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Ok(float_value.to_owned()); [INFO] [stdout] 89 + Ok(float_value.to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:99:44 [INFO] [stdout] | [INFO] [stdout] 99 | Value::String(string_value) => return Ok(string_value.to_owned()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - Value::String(string_value) => return Ok(string_value.to_owned()), [INFO] [stdout] 99 + Value::String(string_value) => Ok(string_value.to_owned()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `to_owned` call clones the `Cow<'_, str>` itself and does not cause its contents to become owned [INFO] [stdout] --> src/main.rs:99:54 [INFO] [stdout] | [INFO] [stdout] 99 | Value::String(string_value) => return Ok(string_value.to_owned()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_to_owned [INFO] [stdout] = note: `#[warn(clippy::suspicious_to_owned)]` on by default [INFO] [stdout] help: depending on intent, either make the `Cow` an `Owned` variant [INFO] [stdout] | [INFO] [stdout] 99 | Value::String(string_value) => return Ok(string_value.into_owned()), [INFO] [stdout] | ++ [INFO] [stdout] help: or clone the `Cow` itself [INFO] [stdout] | [INFO] [stdout] 99 - Value::String(string_value) => return Ok(string_value.to_owned()), [INFO] [stdout] 99 + Value::String(string_value) => return Ok(string_value.clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:110:42 [INFO] [stdout] | [INFO] [stdout] 110 | Value::Array(array_value) => match array_value { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 111 | | Array::Float(float_values) => Some(Box::new(float_values.iter())), [INFO] [stdout] 112 | | _ => None, [INFO] [stdout] 113 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:110:26 [INFO] [stdout] | [INFO] [stdout] 110 | Value::Array(array_value) => match array_value { [INFO] [stdout] | ^^^^^^^^^^^ replace this binding [INFO] [stdout] 111 | Array::Float(float_values) => Some(Box::new(float_values.iter())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:124:42 [INFO] [stdout] | [INFO] [stdout] 124 | Value::Array(array_value) => match array_value { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 125 | | Array::String(string_values) => { [INFO] [stdout] 126 | | Some(Box::new(string_values.iter().map(|s| match s { [INFO] [stdout] 127 | | Ok(Some(cow)) => Ok(Some(cow.to_string())), [INFO] [stdout] ... | [INFO] [stdout] 132 | | _ => None, [INFO] [stdout] 133 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:124:26 [INFO] [stdout] | [INFO] [stdout] 124 | Value::Array(array_value) => match array_value { [INFO] [stdout] | ^^^^^^^^^^^ replace this binding [INFO] [stdout] 125 | Array::String(string_values) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:140:11 [INFO] [stdout] | [INFO] [stdout] 140 | value.expect(&format!( [INFO] [stdout] | ___________^ [INFO] [stdout] 141 | | "Missing value in INFO/{}, these are required for this program.", [INFO] [stdout] 142 | | tag [INFO] [stdout] 143 | | )) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 140 ~ value.unwrap_or_else(|| panic!("Missing value in INFO/{}, these are required for this program.", [INFO] [stdout] 141 + tag)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `csv::DeserializeRecordsIter<'_, std::io::BufReader, Row>` [INFO] [stdout] --> src/main.rs:152:26 [INFO] [stdout] | [INFO] [stdout] 152 | let rows: Vec = reader [INFO] [stdout] | __________________________^ [INFO] [stdout] 153 | | .deserialize() [INFO] [stdout] 154 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 152 ~ let rows: Vec = reader [INFO] [stdout] 153 + .deserialize() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `csv::DeserializeRecordsIter<'_, std::io::BufReader, GeneSHET>` [INFO] [stdout] --> src/main.rs:173:31 [INFO] [stdout] | [INFO] [stdout] 173 | let rows: Vec = reader [INFO] [stdout] | _______________________________^ [INFO] [stdout] 174 | | .deserialize() [INFO] [stdout] 175 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 173 ~ let rows: Vec = reader [INFO] [stdout] 174 + .deserialize() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 195 | / return match tag_value { [INFO] [stdout] 196 | | Some(Ok(Some(tag))) => Some(tag), [INFO] [stdout] 197 | | _ => None, [INFO] [stdout] 198 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 ~ match tag_value { [INFO] [stdout] 196 + Some(Ok(Some(tag))) => Some(tag), [INFO] [stdout] 197 + _ => None, [INFO] [stdout] 198 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:224:25 [INFO] [stdout] | [INFO] [stdout] 224 | writer.write_record(&["ID", "PATERNAL_HAPLOTYPE", "MATERNAL_HAPLOTYPE"])?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["ID", "PATERNAL_HAPLOTYPE", "MATERNAL_HAPLOTYPE"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:345:42 [INFO] [stdout] | [INFO] [stdout] 345 | let possible_paternal_call = (is_phased && paternal_call > 0) [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 346 | | || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 345 - let possible_paternal_call = (is_phased && paternal_call > 0) [INFO] [stdout] 346 - || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] 345 + let possible_paternal_call = !(is_phased && paternal_call <= 0 || paternal_call <= 0 && maternal_call <= 0); [INFO] [stdout] | [INFO] [stdout] 345 - let possible_paternal_call = (is_phased && paternal_call > 0) [INFO] [stdout] 346 - || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] 345 + let possible_paternal_call = (maternal_call > 0 || paternal_call > 0) && (paternal_call > 0 || !is_phased); [INFO] [stdout] | [INFO] [stdout] 345 - let possible_paternal_call = (is_phased && paternal_call > 0) [INFO] [stdout] 346 - || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] 345 + let possible_paternal_call = paternal_call > 0 || !is_phased && maternal_call > 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:347:42 [INFO] [stdout] | [INFO] [stdout] 347 | let possible_maternal_call = (is_phased && maternal_call > 0) [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 348 | | || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 347 - let possible_maternal_call = (is_phased && maternal_call > 0) [INFO] [stdout] 348 - || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] 347 + let possible_maternal_call = !(is_phased && maternal_call <= 0 || maternal_call <= 0 && paternal_call <= 0); [INFO] [stdout] | [INFO] [stdout] 347 - let possible_maternal_call = (is_phased && maternal_call > 0) [INFO] [stdout] 348 - || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] 347 + let possible_maternal_call = (paternal_call > 0 || maternal_call > 0) && (maternal_call > 0 || !is_phased); [INFO] [stdout] | [INFO] [stdout] 347 - let possible_maternal_call = (is_phased && maternal_call > 0) [INFO] [stdout] 348 - || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] 347 + let possible_maternal_call = maternal_call > 0 || !is_phased && paternal_call > 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `gt [INFO] [stdout] .as_ref().get(0)` [INFO] [stdout] --> src/main.rs:325:40 [INFO] [stdout] | [INFO] [stdout] 325 | let paternal_gt: &Allele = gt [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 326 | | .as_ref() [INFO] [stdout] 327 | | .get(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 325 ~ let paternal_gt: &Allele = gt [INFO] [stdout] 326 + .as_ref().first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/main.rs:411:21 [INFO] [stdout] | [INFO] [stdout] 411 | / if let Some(rescue_tuple) = rescue { [INFO] [stdout] 412 | | paternal_rescued = rescue_tuple.0 > 0; [INFO] [stdout] 413 | | maternal_rescued = rescue_tuple.1 > 0; [INFO] [stdout] 414 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:410:29 [INFO] [stdout] | [INFO] [stdout] 410 | if let Some(rescue) = rescues.get(i) { [INFO] [stdout] | ^^^^^^ replace this binding [INFO] [stdout] 411 | if let Some(rescue_tuple) = rescue { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:410:17 [INFO] [stdout] | [INFO] [stdout] 410 | / if let Some(rescue) = rescues.get(i) { [INFO] [stdout] 411 | | if let Some(rescue_tuple) = rescue { [INFO] [stdout] 412 | | paternal_rescued = rescue_tuple.0 > 0; [INFO] [stdout] 413 | | maternal_rescued = rescue_tuple.1 > 0; [INFO] [stdout] 414 | | } [INFO] [stdout] 415 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 410 ~ if let Some(rescue) = rescues.get(i) [INFO] [stdout] 411 ~ && let Some(rescue_tuple) = rescue { [INFO] [stdout] 412 | paternal_rescued = rescue_tuple.0 > 0; [INFO] [stdout] 413 | maternal_rescued = rescue_tuple.1 > 0; [INFO] [stdout] 414 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/main.rs:420:21 [INFO] [stdout] | [INFO] [stdout] 420 | / if let Some(ptv_tuple) = ptv { [INFO] [stdout] 421 | | paternal_ptv = ptv_tuple.0 > 0; [INFO] [stdout] 422 | | maternal_ptv = ptv_tuple.1 > 0; [INFO] [stdout] 423 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:419:29 [INFO] [stdout] | [INFO] [stdout] 419 | if let Some(ptv) = ptvs.get(i) { [INFO] [stdout] | ^^^ replace this binding [INFO] [stdout] 420 | if let Some(ptv_tuple) = ptv { [INFO] [stdout] | ^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:419:17 [INFO] [stdout] | [INFO] [stdout] 419 | / if let Some(ptv) = ptvs.get(i) { [INFO] [stdout] 420 | | if let Some(ptv_tuple) = ptv { [INFO] [stdout] 421 | | paternal_ptv = ptv_tuple.0 > 0; [INFO] [stdout] 422 | | maternal_ptv = ptv_tuple.1 > 0; [INFO] [stdout] 423 | | } [INFO] [stdout] 424 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 419 ~ if let Some(ptv) = ptvs.get(i) [INFO] [stdout] 420 ~ && let Some(ptv_tuple) = ptv { [INFO] [stdout] 421 | paternal_ptv = ptv_tuple.0 > 0; [INFO] [stdout] 422 | maternal_ptv = ptv_tuple.1 > 0; [INFO] [stdout] 423 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: order comparisons between booleans can be simplified [INFO] [stdout] --> src/main.rs:445:28 [INFO] [stdout] | [INFO] [stdout] 445 | if paternal_affected > haplotypes.0 || maternal_affected > haplotypes.1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `paternal_affected & !haplotypes.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: order comparisons between booleans can be simplified [INFO] [stdout] --> src/main.rs:445:64 [INFO] [stdout] | [INFO] [stdout] 445 | if paternal_affected > haplotypes.0 || maternal_affected > haplotypes.1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `maternal_affected & !haplotypes.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:89:17 [INFO] [stdout] | [INFO] [stdout] 89 | return Ok(float_value.to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Ok(float_value.to_owned()); [INFO] [stdout] 89 + Ok(float_value.to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:99:44 [INFO] [stdout] | [INFO] [stdout] 99 | Value::String(string_value) => return Ok(string_value.to_owned()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - Value::String(string_value) => return Ok(string_value.to_owned()), [INFO] [stdout] 99 + Value::String(string_value) => Ok(string_value.to_owned()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `to_owned` call clones the `Cow<'_, str>` itself and does not cause its contents to become owned [INFO] [stdout] --> src/main.rs:99:54 [INFO] [stdout] | [INFO] [stdout] 99 | Value::String(string_value) => return Ok(string_value.to_owned()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_to_owned [INFO] [stdout] = note: `#[warn(clippy::suspicious_to_owned)]` on by default [INFO] [stdout] help: depending on intent, either make the `Cow` an `Owned` variant [INFO] [stdout] | [INFO] [stdout] 99 | Value::String(string_value) => return Ok(string_value.into_owned()), [INFO] [stdout] | ++ [INFO] [stdout] help: or clone the `Cow` itself [INFO] [stdout] | [INFO] [stdout] 99 - Value::String(string_value) => return Ok(string_value.to_owned()), [INFO] [stdout] 99 + Value::String(string_value) => return Ok(string_value.clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:110:42 [INFO] [stdout] | [INFO] [stdout] 110 | Value::Array(array_value) => match array_value { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 111 | | Array::Float(float_values) => Some(Box::new(float_values.iter())), [INFO] [stdout] 112 | | _ => None, [INFO] [stdout] 113 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:110:26 [INFO] [stdout] | [INFO] [stdout] 110 | Value::Array(array_value) => match array_value { [INFO] [stdout] | ^^^^^^^^^^^ replace this binding [INFO] [stdout] 111 | Array::Float(float_values) => Some(Box::new(float_values.iter())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:124:42 [INFO] [stdout] | [INFO] [stdout] 124 | Value::Array(array_value) => match array_value { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 125 | | Array::String(string_values) => { [INFO] [stdout] 126 | | Some(Box::new(string_values.iter().map(|s| match s { [INFO] [stdout] 127 | | Ok(Some(cow)) => Ok(Some(cow.to_string())), [INFO] [stdout] ... | [INFO] [stdout] 132 | | _ => None, [INFO] [stdout] 133 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:124:26 [INFO] [stdout] | [INFO] [stdout] 124 | Value::Array(array_value) => match array_value { [INFO] [stdout] | ^^^^^^^^^^^ replace this binding [INFO] [stdout] 125 | Array::String(string_values) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:140:11 [INFO] [stdout] | [INFO] [stdout] 140 | value.expect(&format!( [INFO] [stdout] | ___________^ [INFO] [stdout] 141 | | "Missing value in INFO/{}, these are required for this program.", [INFO] [stdout] 142 | | tag [INFO] [stdout] 143 | | )) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 140 ~ value.unwrap_or_else(|| panic!("Missing value in INFO/{}, these are required for this program.", [INFO] [stdout] 141 + tag)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `csv::DeserializeRecordsIter<'_, std::io::BufReader, Row>` [INFO] [stdout] --> src/main.rs:152:26 [INFO] [stdout] | [INFO] [stdout] 152 | let rows: Vec = reader [INFO] [stdout] | __________________________^ [INFO] [stdout] 153 | | .deserialize() [INFO] [stdout] 154 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 152 ~ let rows: Vec = reader [INFO] [stdout] 153 + .deserialize() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `csv::DeserializeRecordsIter<'_, std::io::BufReader, GeneSHET>` [INFO] [stdout] --> src/main.rs:173:31 [INFO] [stdout] | [INFO] [stdout] 173 | let rows: Vec = reader [INFO] [stdout] | _______________________________^ [INFO] [stdout] 174 | | .deserialize() [INFO] [stdout] 175 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 173 ~ let rows: Vec = reader [INFO] [stdout] 174 + .deserialize() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 195 | / return match tag_value { [INFO] [stdout] 196 | | Some(Ok(Some(tag))) => Some(tag), [INFO] [stdout] 197 | | _ => None, [INFO] [stdout] 198 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 ~ match tag_value { [INFO] [stdout] 196 + Some(Ok(Some(tag))) => Some(tag), [INFO] [stdout] 197 + _ => None, [INFO] [stdout] 198 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:224:25 [INFO] [stdout] | [INFO] [stdout] 224 | writer.write_record(&["ID", "PATERNAL_HAPLOTYPE", "MATERNAL_HAPLOTYPE"])?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["ID", "PATERNAL_HAPLOTYPE", "MATERNAL_HAPLOTYPE"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:345:42 [INFO] [stdout] | [INFO] [stdout] 345 | let possible_paternal_call = (is_phased && paternal_call > 0) [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 346 | | || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 345 - let possible_paternal_call = (is_phased && paternal_call > 0) [INFO] [stdout] 346 - || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] 345 + let possible_paternal_call = !(is_phased && paternal_call <= 0 || paternal_call <= 0 && maternal_call <= 0); [INFO] [stdout] | [INFO] [stdout] 345 - let possible_paternal_call = (is_phased && paternal_call > 0) [INFO] [stdout] 346 - || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] 345 + let possible_paternal_call = (maternal_call > 0 || paternal_call > 0) && (paternal_call > 0 || !is_phased); [INFO] [stdout] | [INFO] [stdout] 345 - let possible_paternal_call = (is_phased && paternal_call > 0) [INFO] [stdout] 346 - || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] 345 + let possible_paternal_call = paternal_call > 0 || !is_phased && maternal_call > 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:347:42 [INFO] [stdout] | [INFO] [stdout] 347 | let possible_maternal_call = (is_phased && maternal_call > 0) [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 348 | | || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 347 - let possible_maternal_call = (is_phased && maternal_call > 0) [INFO] [stdout] 348 - || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] 347 + let possible_maternal_call = !(is_phased && maternal_call <= 0 || maternal_call <= 0 && paternal_call <= 0); [INFO] [stdout] | [INFO] [stdout] 347 - let possible_maternal_call = (is_phased && maternal_call > 0) [INFO] [stdout] 348 - || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] 347 + let possible_maternal_call = (paternal_call > 0 || maternal_call > 0) && (maternal_call > 0 || !is_phased); [INFO] [stdout] | [INFO] [stdout] 347 - let possible_maternal_call = (is_phased && maternal_call > 0) [INFO] [stdout] 348 - || (!is_phased && (maternal_call > 0 || paternal_call > 0)); [INFO] [stdout] 347 + let possible_maternal_call = maternal_call > 0 || !is_phased && paternal_call > 0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `gt [INFO] [stdout] .as_ref().get(0)` [INFO] [stdout] --> src/main.rs:325:40 [INFO] [stdout] | [INFO] [stdout] 325 | let paternal_gt: &Allele = gt [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 326 | | .as_ref() [INFO] [stdout] 327 | | .get(0) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 325 ~ let paternal_gt: &Allele = gt [INFO] [stdout] 326 + .as_ref().first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/main.rs:411:21 [INFO] [stdout] | [INFO] [stdout] 411 | / if let Some(rescue_tuple) = rescue { [INFO] [stdout] 412 | | paternal_rescued = rescue_tuple.0 > 0; [INFO] [stdout] 413 | | maternal_rescued = rescue_tuple.1 > 0; [INFO] [stdout] 414 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:410:29 [INFO] [stdout] | [INFO] [stdout] 410 | if let Some(rescue) = rescues.get(i) { [INFO] [stdout] | ^^^^^^ replace this binding [INFO] [stdout] 411 | if let Some(rescue_tuple) = rescue { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:410:17 [INFO] [stdout] | [INFO] [stdout] 410 | / if let Some(rescue) = rescues.get(i) { [INFO] [stdout] 411 | | if let Some(rescue_tuple) = rescue { [INFO] [stdout] 412 | | paternal_rescued = rescue_tuple.0 > 0; [INFO] [stdout] 413 | | maternal_rescued = rescue_tuple.1 > 0; [INFO] [stdout] 414 | | } [INFO] [stdout] 415 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 410 ~ if let Some(rescue) = rescues.get(i) [INFO] [stdout] 411 ~ && let Some(rescue_tuple) = rescue { [INFO] [stdout] 412 | paternal_rescued = rescue_tuple.0 > 0; [INFO] [stdout] 413 | maternal_rescued = rescue_tuple.1 > 0; [INFO] [stdout] 414 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/main.rs:420:21 [INFO] [stdout] | [INFO] [stdout] 420 | / if let Some(ptv_tuple) = ptv { [INFO] [stdout] 421 | | paternal_ptv = ptv_tuple.0 > 0; [INFO] [stdout] 422 | | maternal_ptv = ptv_tuple.1 > 0; [INFO] [stdout] 423 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/main.rs:419:29 [INFO] [stdout] | [INFO] [stdout] 419 | if let Some(ptv) = ptvs.get(i) { [INFO] [stdout] | ^^^ replace this binding [INFO] [stdout] 420 | if let Some(ptv_tuple) = ptv { [INFO] [stdout] | ^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:419:17 [INFO] [stdout] | [INFO] [stdout] 419 | / if let Some(ptv) = ptvs.get(i) { [INFO] [stdout] 420 | | if let Some(ptv_tuple) = ptv { [INFO] [stdout] 421 | | paternal_ptv = ptv_tuple.0 > 0; [INFO] [stdout] 422 | | maternal_ptv = ptv_tuple.1 > 0; [INFO] [stdout] 423 | | } [INFO] [stdout] 424 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 419 ~ if let Some(ptv) = ptvs.get(i) [INFO] [stdout] 420 ~ && let Some(ptv_tuple) = ptv { [INFO] [stdout] 421 | paternal_ptv = ptv_tuple.0 > 0; [INFO] [stdout] 422 | maternal_ptv = ptv_tuple.1 > 0; [INFO] [stdout] 423 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: order comparisons between booleans can be simplified [INFO] [stdout] --> src/main.rs:445:28 [INFO] [stdout] | [INFO] [stdout] 445 | if paternal_affected > haplotypes.0 || maternal_affected > haplotypes.1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `paternal_affected & !haplotypes.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: order comparisons between booleans can be simplified [INFO] [stdout] --> src/main.rs:445:64 [INFO] [stdout] | [INFO] [stdout] 445 | if paternal_affected > haplotypes.0 || maternal_affected > haplotypes.1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `maternal_affected & !haplotypes.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.85s [INFO] running `Command { std: "docker" "inspect" "1f83da27c9d6ffd59a20f5ee94eec021a65aad30be71eb04b3a7f0e1fb0ceebb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f83da27c9d6ffd59a20f5ee94eec021a65aad30be71eb04b3a7f0e1fb0ceebb", kill_on_drop: false }` [INFO] [stdout] 1f83da27c9d6ffd59a20f5ee94eec021a65aad30be71eb04b3a7f0e1fb0ceebb