[INFO] cloning repository https://github.com/LunaticHacker/lemmy-terminal-viewer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LunaticHacker/lemmy-terminal-viewer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLunaticHacker%2Flemmy-terminal-viewer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLunaticHacker%2Flemmy-terminal-viewer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e3e30663c390a4026e2e4fef714308b945090d15 [INFO] linting LunaticHacker/lemmy-terminal-viewer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLunaticHacker%2Flemmy-terminal-viewer" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/LunaticHacker/lemmy-terminal-viewer [INFO] finished tweaking git repo https://github.com/LunaticHacker/lemmy-terminal-viewer [INFO] tweaked toml for git repo https://github.com/LunaticHacker/lemmy-terminal-viewer written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/LunaticHacker/lemmy-terminal-viewer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/LunaticHacker/lemmy-terminal-viewer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/LunaticHacker/tui-rs` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded httpdate v1.0.1 [INFO] [stderr] Downloaded redox_users v0.4.0 [INFO] [stderr] Downloaded dirs-sys v0.3.6 [INFO] [stderr] Downloaded http-body v0.4.3 [INFO] [stderr] Downloaded futures-sink v0.3.17 [INFO] [stderr] Downloaded tinyvec v1.4.0 [INFO] [stderr] Downloaded unicode-bidi v0.3.6 [INFO] [stderr] Downloaded openssl-sys v0.9.67 [INFO] [stderr] Downloaded tokio-util v0.6.8 [INFO] [stderr] Downloaded reqwest v0.11.4 [INFO] [stderr] Downloaded openssl v0.10.36 [INFO] [stderr] Downloaded h2 v0.3.4 [INFO] [stderr] Downloaded hyper v0.14.13 [INFO] [stderr] Downloaded tokio v1.12.0 [INFO] [stderr] Downloaded libc v0.2.102 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 697f17e2ddd9cb596f52b1465cd65d124ec8a16cf8f8cd69f2e8b00b56435d65 [INFO] running `Command { std: "docker" "start" "-a" "697f17e2ddd9cb596f52b1465cd65d124ec8a16cf8f8cd69f2e8b00b56435d65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "697f17e2ddd9cb596f52b1465cd65d124ec8a16cf8f8cd69f2e8b00b56435d65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "697f17e2ddd9cb596f52b1465cd65d124ec8a16cf8f8cd69f2e8b00b56435d65", kill_on_drop: false }` [INFO] [stdout] 697f17e2ddd9cb596f52b1465cd65d124ec8a16cf8f8cd69f2e8b00b56435d65 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8923e207eecc6b9cbf313d749cb3f2cff4d591b1fb49b1f0d889c8bdf4c57b19 [INFO] running `Command { std: "docker" "start" "-a" "8923e207eecc6b9cbf313d749cb3f2cff4d591b1fb49b1f0d889c8bdf4c57b19", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.102 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling cc v1.0.70 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling tokio v1.12.0 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Compiling futures-task v0.3.17 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling openssl v0.10.36 [INFO] [stderr] Checking tracing-core v0.1.20 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Checking futures-sink v0.3.17 [INFO] [stderr] Compiling native-tls v0.2.8 [INFO] [stderr] Checking futures-io v0.3.17 [INFO] [stderr] Compiling futures-channel v0.3.17 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking tinyvec v1.4.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking openssl-probe v0.1.4 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking unicode-bidi v0.3.6 [INFO] [stderr] Checking tracing v0.1.28 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling encoding_rs v0.8.28 [INFO] [stderr] Checking httpdate v1.0.1 [INFO] [stderr] Checking http v0.2.5 [INFO] [stderr] Compiling serde_json v1.0.68 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking ipnet v2.3.1 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking unicode-segmentation v1.8.0 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking socket2 v0.4.2 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking directories v3.0.2 [INFO] [stderr] Checking rpassword v5.0.1 [INFO] [stderr] Compiling openssl-sys v0.9.67 [INFO] [stderr] Checking tui v0.16.0 (https://github.com/LunaticHacker/tui-rs?branch=for-ltv#2ebc0fb9) [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking http-body v0.4.3 [INFO] [stderr] Checking tokio-util v0.6.8 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking h2 v0.3.4 [INFO] [stderr] Checking hyper v0.14.13 [INFO] [stderr] Checking serde v1.0.130 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking reqwest v0.11.4 [INFO] [stderr] Checking ltv v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/auth.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use toml; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | params: params, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | theme: theme, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `theme` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/auth.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use toml; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | params: params, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | theme: theme, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `theme` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/api.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Post { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub creator_id: i32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 11 | pub community_id: i32, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 12 | pub removed: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 13 | pub locked: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 14 | pub published: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 15 | pub updated: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 16 | pub deleted: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 17 | pub nsfw: bool, [INFO] [stdout] | ^^^^ [INFO] [stdout] 18 | pub stickied: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 19 | pub embed_title: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 20 | pub embed_description: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 21 | pub embed_html: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 22 | pub thumbnail_url: Option, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 23 | pub ap_id: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 24 | pub local: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Post` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return self; [INFO] [stdout] 81 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/api.rs:73:42 [INFO] [stdout] | [INFO] [stdout] 73 | fn fill_children(mut self, comments: &Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 73 ~ fn fill_children(mut self, comments: &[CommentInfo]) -> Self { [INFO] [stdout] 74 | for i in 0..comments.len() { [INFO] [stdout] 75 ~ let clone = comments.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | return Ok(response.json::()?.posts); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return Ok(response.json::()?.posts); [INFO] [stdout] 126 + Ok(response.json::()?.posts) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/api.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | let response; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `response` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 120 ~ [INFO] [stdout] 121 ~ let response = if auth.is_empty() { [INFO] [stdout] 122 ~ reqwest::blocking::get(url + config)? [INFO] [stdout] 123 | } else { [INFO] [stdout] 124 ~ reqwest::blocking::get(url + "auth=" + &auth + config)? [INFO] [stdout] 125 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/api.rs:124:43 [INFO] [stdout] | [INFO] [stdout] 124 | response = reqwest::blocking::get(url + "auth=" + &auth + config)? [INFO] [stdout] | ^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `auth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/api.rs:124:59 [INFO] [stdout] | [INFO] [stdout] 124 | response = reqwest::blocking::get(url + "auth=" + &auth + config)? [INFO] [stdout] | ^^^^^ help: change this to: `auth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | / return Ok(result [INFO] [stdout] 144 | | .into_iter() [INFO] [stdout] 145 | | .map(|r| r.fill_children(&clone)) [INFO] [stdout] 146 | | .collect()); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ Ok(result [INFO] [stdout] 144 + .into_iter() [INFO] [stdout] 145 + .map(|r| r.fill_children(&clone)) [INFO] [stdout] 146 ~ .collect()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/api.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | let response; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `response` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 129 ~ [INFO] [stdout] 130 ~ let response = if auth.is_empty() { [INFO] [stdout] 131 ~ reqwest::blocking::get(url)? [INFO] [stdout] 132 | } else { [INFO] [stdout] 133 ~ reqwest::blocking::get(url + "auth=" + &auth)? [INFO] [stdout] 134 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/api.rs:133:43 [INFO] [stdout] | [INFO] [stdout] 133 | response = reqwest::blocking::get(url + "auth=" + &auth)? [INFO] [stdout] | ^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `auth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/api.rs:133:59 [INFO] [stdout] | [INFO] [stdout] 133 | response = reqwest::blocking::get(url + "auth=" + &auth)? [INFO] [stdout] | ^^^^^ help: change this to: `auth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/api.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | .filter(|c| !c.comment.parent_id.is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.comment.parent_id.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | return Ok(response.json::()?.jwt.unwrap_or_default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return Ok(response.json::()?.jwt.unwrap_or_default()); [INFO] [stdout] 152 + Ok(response.json::()?.jwt.unwrap_or_default()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/auth.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | reader.read_line(&mut instance).ok().expect(""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] = note: `#[warn(clippy::ok_expect)]` on by default [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 29 - reader.read_line(&mut instance).ok().expect(""); [INFO] [stdout] 29 + reader.read_line(&mut instance).expect(""); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/auth.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | reader.read_line(&mut login).ok().expect(""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 33 - reader.read_line(&mut login).ok().expect(""); [INFO] [stdout] 33 + reader.read_line(&mut login).expect(""); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/auth.rs:51:26 [INFO] [stdout] | [INFO] [stdout] 51 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/auth.rs:52:31 [INFO] [stdout] | [INFO] [stdout] 52 | .open(&proj_dirs.config_dir().join("auth.toml"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `proj_dirs.config_dir().join("auth.toml")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/auth.rs:53:53 [INFO] [stdout] | [INFO] [stdout] 53 | let config = fs::read_to_string(&proj_dirs.config_dir().join("auth.toml")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `proj_dirs.config_dir().join("auth.toml")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/auth.rs:59:26 [INFO] [stdout] | [INFO] [stdout] 59 | .or_insert(UserList::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/auth.rs:63:28 [INFO] [stdout] | [INFO] [stdout] 63 | if let Ok(_) = write!(config_file, "{}", new_config) { [INFO] [stdout] | -------^^^^^---------------------------------------- help: try: `if write!(config_file, "{}", new_config).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/auth.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | Err(Error::new(ErrorKind::Other, "Couldn't save login details")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 66 - Err(Error::new(ErrorKind::Other, "Couldn't save login details")) [INFO] [stdout] 66 + Err(Error::other("Couldn't save login details")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/auth.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | Err(Error::new(ErrorKind::Other, "Couldn't save login details")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 69 - Err(Error::new(ErrorKind::Other, "Couldn't save login details")) [INFO] [stdout] 69 + Err(Error::other("Couldn't save login details")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/auth.rs:72:21 [INFO] [stdout] | [INFO] [stdout] 72 | Err(Error::new(ErrorKind::Other, "Login Failed")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 72 - Err(Error::new(ErrorKind::Other, "Login Failed")) [INFO] [stdout] 72 + Err(Error::other("Login Failed")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/auth.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | Err(Error::new(ErrorKind::Other, e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 77 - Err(Error::new(ErrorKind::Other, e)) [INFO] [stdout] 77 + Err(Error::other(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return str; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return str; [INFO] [stdout] 32 + str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/event.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 47 | / for evt in stdin.keys() { [INFO] [stdout] 48 | | if let Ok(key) = evt { [INFO] [stdout] 49 | | if let Err(err) = tx.send(Event::Input(key)) { [INFO] [stdout] 50 | | eprintln!("{}", err); [INFO] [stdout] ... | [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/event.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | / if let Ok(key) = evt { [INFO] [stdout] 49 | | if let Err(err) = tx.send(Event::Input(key)) { [INFO] [stdout] 50 | | eprintln!("{}", err); [INFO] [stdout] 51 | | return; [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 ~ for key in stdin.keys().flatten() { [INFO] [stdout] 48 + if let Err(err) = tx.send(Event::Input(key)) { [INFO] [stdout] 49 + eprintln!("{}", err); [INFO] [stdout] 50 + return; [INFO] [stdout] 51 + } [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return str; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return str; [INFO] [stdout] 26 + str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return result; [INFO] [stdout] 37 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `colors.get(0)` [INFO] [stdout] --> src/utils.rs:60:51 [INFO] [stdout] | [INFO] [stdout] 60 | if let (Some(r), Some(g), Some(b)) = (colors.get(0), colors.get(1), colors.get(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `colors.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/utils.rs:134:6 [INFO] [stdout] | [INFO] [stdout] 134 | (10000 as f64 * max.log10()) / elapsed_base.powf(1.8) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `10000_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:54:41 [INFO] [stdout] | [INFO] [stdout] 54 | &fs::read_to_string(&proj_dirs.config_dir().join("ltv.toml")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `proj_dirs.config_dir().join("ltv.toml")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:84:45 [INFO] [stdout] | [INFO] [stdout] 84 | ui::draw_post(&mut app, &mut frame) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `frame` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:86:48 [INFO] [stdout] | [INFO] [stdout] 86 | ui::draw_comment(&mut app, &mut frame) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `frame` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:88:47 [INFO] [stdout] | [INFO] [stdout] 88 | ui::draw_normal(&mut app, &mut frame); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `frame` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:236:29 [INFO] [stdout] | [INFO] [stdout] 236 | / ... if !app.replies.is_empty() { [INFO] [stdout] 237 | | ... if !app.replies[app.replies_state.selected().unwrap_or_default()] [INFO] [stdout] 238 | | ... .children [INFO] [stdout] 239 | | ... .is_empty() [INFO] [stdout] ... | [INFO] [stdout] 249 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 236 ~ if !app.replies.is_empty() [INFO] [stdout] 237 ~ && !app.replies[app.replies_state.selected().unwrap_or_default()] [INFO] [stdout] 238 | .children [INFO] [stdout] ... [INFO] [stdout] 247 | app.r_unselect(); [INFO] [stdout] 248 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/api.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Post { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub creator_id: i32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 11 | pub community_id: i32, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 12 | pub removed: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 13 | pub locked: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 14 | pub published: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 15 | pub updated: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 16 | pub deleted: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 17 | pub nsfw: bool, [INFO] [stdout] | ^^^^ [INFO] [stdout] 18 | pub stickied: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 19 | pub embed_title: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 20 | pub embed_description: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 21 | pub embed_html: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 22 | pub thumbnail_url: Option, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 23 | pub ap_id: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 24 | pub local: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Post` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return self; [INFO] [stdout] 81 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/api.rs:73:42 [INFO] [stdout] | [INFO] [stdout] 73 | fn fill_children(mut self, comments: &Vec) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 73 ~ fn fill_children(mut self, comments: &[CommentInfo]) -> Self { [INFO] [stdout] 74 | for i in 0..comments.len() { [INFO] [stdout] 75 ~ let clone = comments.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | return Ok(response.json::()?.posts); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return Ok(response.json::()?.posts); [INFO] [stdout] 126 + Ok(response.json::()?.posts) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/api.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | let response; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `response` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 120 ~ [INFO] [stdout] 121 ~ let response = if auth.is_empty() { [INFO] [stdout] 122 ~ reqwest::blocking::get(url + config)? [INFO] [stdout] 123 | } else { [INFO] [stdout] 124 ~ reqwest::blocking::get(url + "auth=" + &auth + config)? [INFO] [stdout] 125 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/api.rs:124:43 [INFO] [stdout] | [INFO] [stdout] 124 | response = reqwest::blocking::get(url + "auth=" + &auth + config)? [INFO] [stdout] | ^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `auth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/api.rs:124:59 [INFO] [stdout] | [INFO] [stdout] 124 | response = reqwest::blocking::get(url + "auth=" + &auth + config)? [INFO] [stdout] | ^^^^^ help: change this to: `auth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | / return Ok(result [INFO] [stdout] 144 | | .into_iter() [INFO] [stdout] 145 | | .map(|r| r.fill_children(&clone)) [INFO] [stdout] 146 | | .collect()); [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 ~ Ok(result [INFO] [stdout] 144 + .into_iter() [INFO] [stdout] 145 + .map(|r| r.fill_children(&clone)) [INFO] [stdout] 146 ~ .collect()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/api.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | let response; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `response` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 129 ~ [INFO] [stdout] 130 ~ let response = if auth.is_empty() { [INFO] [stdout] 131 ~ reqwest::blocking::get(url)? [INFO] [stdout] 132 | } else { [INFO] [stdout] 133 ~ reqwest::blocking::get(url + "auth=" + &auth)? [INFO] [stdout] 134 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/api.rs:133:43 [INFO] [stdout] | [INFO] [stdout] 133 | response = reqwest::blocking::get(url + "auth=" + &auth)? [INFO] [stdout] | ^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `auth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/api.rs:133:59 [INFO] [stdout] | [INFO] [stdout] 133 | response = reqwest::blocking::get(url + "auth=" + &auth)? [INFO] [stdout] | ^^^^^ help: change this to: `auth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/api.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | .filter(|c| !c.comment.parent_id.is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `c.comment.parent_id.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | return Ok(response.json::()?.jwt.unwrap_or_default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return Ok(response.json::()?.jwt.unwrap_or_default()); [INFO] [stdout] 152 + Ok(response.json::()?.jwt.unwrap_or_default()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/auth.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | reader.read_line(&mut instance).ok().expect(""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] = note: `#[warn(clippy::ok_expect)]` on by default [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 29 - reader.read_line(&mut instance).ok().expect(""); [INFO] [stdout] 29 + reader.read_line(&mut instance).expect(""); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/auth.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | reader.read_line(&mut login).ok().expect(""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 33 - reader.read_line(&mut login).ok().expect(""); [INFO] [stdout] 33 + reader.read_line(&mut login).expect(""); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/auth.rs:51:26 [INFO] [stdout] | [INFO] [stdout] 51 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/auth.rs:52:31 [INFO] [stdout] | [INFO] [stdout] 52 | .open(&proj_dirs.config_dir().join("auth.toml"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `proj_dirs.config_dir().join("auth.toml")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/auth.rs:53:53 [INFO] [stdout] | [INFO] [stdout] 53 | let config = fs::read_to_string(&proj_dirs.config_dir().join("auth.toml")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `proj_dirs.config_dir().join("auth.toml")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/auth.rs:59:26 [INFO] [stdout] | [INFO] [stdout] 59 | .or_insert(UserList::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/auth.rs:63:28 [INFO] [stdout] | [INFO] [stdout] 63 | if let Ok(_) = write!(config_file, "{}", new_config) { [INFO] [stdout] | -------^^^^^---------------------------------------- help: try: `if write!(config_file, "{}", new_config).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/auth.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | Err(Error::new(ErrorKind::Other, "Couldn't save login details")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 66 - Err(Error::new(ErrorKind::Other, "Couldn't save login details")) [INFO] [stdout] 66 + Err(Error::other("Couldn't save login details")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/auth.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | Err(Error::new(ErrorKind::Other, "Couldn't save login details")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 69 - Err(Error::new(ErrorKind::Other, "Couldn't save login details")) [INFO] [stdout] 69 + Err(Error::other("Couldn't save login details")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/auth.rs:72:21 [INFO] [stdout] | [INFO] [stdout] 72 | Err(Error::new(ErrorKind::Other, "Login Failed")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 72 - Err(Error::new(ErrorKind::Other, "Login Failed")) [INFO] [stdout] 72 + Err(Error::other("Login Failed")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/auth.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | Err(Error::new(ErrorKind::Other, e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 77 - Err(Error::new(ErrorKind::Other, e)) [INFO] [stdout] 77 + Err(Error::other(e)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return str; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return str; [INFO] [stdout] 32 + str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/event.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 47 | / for evt in stdin.keys() { [INFO] [stdout] 48 | | if let Ok(key) = evt { [INFO] [stdout] 49 | | if let Err(err) = tx.send(Event::Input(key)) { [INFO] [stdout] 50 | | eprintln!("{}", err); [INFO] [stdout] ... | [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/event.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | / if let Ok(key) = evt { [INFO] [stdout] 49 | | if let Err(err) = tx.send(Event::Input(key)) { [INFO] [stdout] 50 | | eprintln!("{}", err); [INFO] [stdout] 51 | | return; [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 ~ for key in stdin.keys().flatten() { [INFO] [stdout] 48 + if let Err(err) = tx.send(Event::Input(key)) { [INFO] [stdout] 49 + eprintln!("{}", err); [INFO] [stdout] 50 + return; [INFO] [stdout] 51 + } [INFO] [stdout] 52 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return str; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return str; [INFO] [stdout] 26 + str [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return result; [INFO] [stdout] 37 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `colors.get(0)` [INFO] [stdout] --> src/utils.rs:60:51 [INFO] [stdout] | [INFO] [stdout] 60 | if let (Some(r), Some(g), Some(b)) = (colors.get(0), colors.get(1), colors.get(2)) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `colors.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/utils.rs:134:6 [INFO] [stdout] | [INFO] [stdout] 134 | (10000 as f64 * max.log10()) / elapsed_base.powf(1.8) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `10000_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:54:41 [INFO] [stdout] | [INFO] [stdout] 54 | &fs::read_to_string(&proj_dirs.config_dir().join("ltv.toml")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `proj_dirs.config_dir().join("ltv.toml")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:84:45 [INFO] [stdout] | [INFO] [stdout] 84 | ui::draw_post(&mut app, &mut frame) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `frame` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:86:48 [INFO] [stdout] | [INFO] [stdout] 86 | ui::draw_comment(&mut app, &mut frame) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `frame` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:88:47 [INFO] [stdout] | [INFO] [stdout] 88 | ui::draw_normal(&mut app, &mut frame); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `frame` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:236:29 [INFO] [stdout] | [INFO] [stdout] 236 | / ... if !app.replies.is_empty() { [INFO] [stdout] 237 | | ... if !app.replies[app.replies_state.selected().unwrap_or_default()] [INFO] [stdout] 238 | | ... .children [INFO] [stdout] 239 | | ... .is_empty() [INFO] [stdout] ... | [INFO] [stdout] 249 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 236 ~ if !app.replies.is_empty() [INFO] [stdout] 237 ~ && !app.replies[app.replies_state.selected().unwrap_or_default()] [INFO] [stdout] 238 | .children [INFO] [stdout] ... [INFO] [stdout] 247 | app.r_unselect(); [INFO] [stdout] 248 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.54s [INFO] running `Command { std: "docker" "inspect" "8923e207eecc6b9cbf313d749cb3f2cff4d591b1fb49b1f0d889c8bdf4c57b19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8923e207eecc6b9cbf313d749cb3f2cff4d591b1fb49b1f0d889c8bdf4c57b19", kill_on_drop: false }` [INFO] [stdout] 8923e207eecc6b9cbf313d749cb3f2cff4d591b1fb49b1f0d889c8bdf4c57b19