[INFO] cloning repository https://github.com/LuisDavid01/json-grabber [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LuisDavid01/json-grabber" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLuisDavid01%2Fjson-grabber", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLuisDavid01%2Fjson-grabber'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1373be3358afb35d64341180e665f255d8bc2c02 [INFO] linting LuisDavid01/json-grabber against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLuisDavid01%2Fjson-grabber" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/LuisDavid01/json-grabber [INFO] finished tweaking git repo https://github.com/LuisDavid01/json-grabber [INFO] tweaked toml for git repo https://github.com/LuisDavid01/json-grabber written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/LuisDavid01/json-grabber on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/LuisDavid01/json-grabber already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded collection_macros v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e0db19709be9caaf67ebf87ce1e69251c8381cd8fd0a75d917b51b0e9bfd6e0f [INFO] running `Command { std: "docker" "start" "-a" "e0db19709be9caaf67ebf87ce1e69251c8381cd8fd0a75d917b51b0e9bfd6e0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e0db19709be9caaf67ebf87ce1e69251c8381cd8fd0a75d917b51b0e9bfd6e0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0db19709be9caaf67ebf87ce1e69251c8381cd8fd0a75d917b51b0e9bfd6e0f", kill_on_drop: false }` [INFO] [stdout] e0db19709be9caaf67ebf87ce1e69251c8381cd8fd0a75d917b51b0e9bfd6e0f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 804e38ed73190ebbfe0206150e0aa3b87b57b46ec051fe0a1a1f59c0015116f3 [INFO] running `Command { std: "docker" "start" "-a" "804e38ed73190ebbfe0206150e0aa3b87b57b46ec051fe0a1a1f59c0015116f3", kill_on_drop: false }` [INFO] [stderr] Checking collection_macros v0.2.0 [INFO] [stderr] Checking clap_builder v4.5.46 [INFO] [stderr] Compiling clap_derive v4.5.45 [INFO] [stderr] Checking serde_json v1.0.143 [INFO] [stderr] Checking clap v4.5.46 [INFO] [stderr] Checking json-grabber v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/json_grabber.rs:102:1 [INFO] [stdout] | [INFO] [stdout] 102 | / #[cfg(test)] [INFO] [stdout] 103 | | [INFO] [stdout] | |_^ [INFO] [stdout] 104 | mod test { [INFO] [stdout] | -------- the attribute applies to this module [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/json_grabber.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | pwd: pwd, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pwd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return Ok(Config { [INFO] [stdout] 29 | | operation, [INFO] [stdout] 30 | | config, [INFO] [stdout] 31 | | pwd, [INFO] [stdout] 32 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ Ok(Config { [INFO] [stdout] 29 + operation, [INFO] [stdout] 30 + config, [INFO] [stdout] 31 + pwd, [INFO] [stdout] 32 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return Ok(Operation::Print(Some(arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Ok(Operation::Print(Some(arg))); [INFO] [stdout] 79 + Ok(Operation::Print(Some(arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/config.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if value.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `value.get(0)` [INFO] [stdout] --> src/config.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 45 | let term = value.get(0).expect("expects to exist"); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | return Ok(loc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return Ok(loc); [INFO] [stdout] 102 + Ok(loc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/config.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | let usr_env_dir; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `usr_env_dir` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 89 ~ [INFO] [stdout] 90 ~ let usr_env_dir = if os == "windows" { [INFO] [stdout] 91 ~ "APPDATA" [INFO] [stdout] 92 | } else { [INFO] [stdout] 93 ~ "HOME" [INFO] [stdout] 94 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | return Ok(loc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return Ok(loc); [INFO] [stdout] 111 + Ok(loc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/json_grabber.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / return Data { [INFO] [stdout] 18 | | projector: HashMap::new(), [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ Data { [INFO] [stdout] 18 + projector: HashMap::new(), [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/json_grabber.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | if !std::fs::metadata(p).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(p).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/json_grabber.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Ok(()); [INFO] [stdout] 33 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json_grabber.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / if let Some(p) = self.config.parent() { [INFO] [stdout] 25 | | if !std::fs::metadata(p).is_ok() { [INFO] [stdout] 26 | | std::fs::create_dir_all(p)?; [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 24 ~ if let Some(p) = self.config.parent() [INFO] [stdout] 25 ~ && !std::fs::metadata(p).is_ok() { [INFO] [stdout] 26 | std::fs::create_dir_all(p)?; [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/json_grabber.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / self.data.projector.get_mut(&self.pwd).map(|x| { [INFO] [stdout] 46 | | x.remove(key); [INFO] [stdout] 47 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 45 - self.data.projector.get_mut(&self.pwd).map(|x| { [INFO] [stdout] 46 - x.remove(key); [INFO] [stdout] 47 - }); [INFO] [stdout] 45 + if let Some(x) = self.data.projector.get_mut(&self.pwd) { x.remove(key); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/json_grabber.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return out; [INFO] [stdout] 67 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/json_grabber.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return out; [INFO] [stdout] 83 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json_grabber.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | / if let Some(dir) = self.data.projector.get(p) { [INFO] [stdout] 75 | | if let Some(value) = dir.get(key) { [INFO] [stdout] 76 | | out = Some(value); [INFO] [stdout] 77 | | break; [INFO] [stdout] 78 | | } [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if let Some(dir) = self.data.projector.get(p) [INFO] [stdout] 75 ~ && let Some(value) = dir.get(key) { [INFO] [stdout] 76 | out = Some(value); [INFO] [stdout] 77 | break; [INFO] [stdout] 78 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/json_grabber.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | / return Projector { [INFO] [stdout] 95 | | config, [INFO] [stdout] 96 | | pwd, [INFO] [stdout] 97 | | data: default_data(), [INFO] [stdout] 98 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 ~ Projector { [INFO] [stdout] 95 + config, [INFO] [stdout] 96 + pwd, [INFO] [stdout] 97 + data: default_data(), [INFO] [stdout] 98 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return Ok(Config { [INFO] [stdout] 29 | | operation, [INFO] [stdout] 30 | | config, [INFO] [stdout] 31 | | pwd, [INFO] [stdout] 32 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ Ok(Config { [INFO] [stdout] 29 + operation, [INFO] [stdout] 30 + config, [INFO] [stdout] 31 + pwd, [INFO] [stdout] 32 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return Ok(Operation::Print(Some(arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Ok(Operation::Print(Some(arg))); [INFO] [stdout] 79 + Ok(Operation::Print(Some(arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/config.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if value.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `value.get(0)` [INFO] [stdout] --> src/config.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 45 | let term = value.get(0).expect("expects to exist"); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | return Ok(loc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return Ok(loc); [INFO] [stdout] 102 + Ok(loc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/config.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | let usr_env_dir; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `usr_env_dir` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 89 ~ [INFO] [stdout] 90 ~ let usr_env_dir = if os == "windows" { [INFO] [stdout] 91 ~ "APPDATA" [INFO] [stdout] 92 | } else { [INFO] [stdout] 93 ~ "HOME" [INFO] [stdout] 94 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | return Ok(loc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return Ok(loc); [INFO] [stdout] 111 + Ok(loc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return Ok(()); [INFO] [stdout] 134 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return Ok(()); [INFO] [stdout] 148 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return Ok(()); [INFO] [stdout] 169 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 183 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 183 - return Ok(()); [INFO] [stdout] 183 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/json_grabber.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / return Data { [INFO] [stdout] 18 | | projector: HashMap::new(), [INFO] [stdout] 19 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 ~ Data { [INFO] [stdout] 18 + projector: HashMap::new(), [INFO] [stdout] 19 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/json_grabber.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | if !std::fs::metadata(p).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(p).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/json_grabber.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Ok(()); [INFO] [stdout] 33 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json_grabber.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | / if let Some(p) = self.config.parent() { [INFO] [stdout] 25 | | if !std::fs::metadata(p).is_ok() { [INFO] [stdout] 26 | | std::fs::create_dir_all(p)?; [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 24 ~ if let Some(p) = self.config.parent() [INFO] [stdout] 25 ~ && !std::fs::metadata(p).is_ok() { [INFO] [stdout] 26 | std::fs::create_dir_all(p)?; [INFO] [stdout] 27 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/json_grabber.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / self.data.projector.get_mut(&self.pwd).map(|x| { [INFO] [stdout] 46 | | x.remove(key); [INFO] [stdout] 47 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 45 - self.data.projector.get_mut(&self.pwd).map(|x| { [INFO] [stdout] 46 - x.remove(key); [INFO] [stdout] 47 - }); [INFO] [stdout] 45 + if let Some(x) = self.data.projector.get_mut(&self.pwd) { x.remove(key); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/json_grabber.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return out; [INFO] [stdout] 67 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/json_grabber.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return out; [INFO] [stdout] 83 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json_grabber.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | / if let Some(dir) = self.data.projector.get(p) { [INFO] [stdout] 75 | | if let Some(value) = dir.get(key) { [INFO] [stdout] 76 | | out = Some(value); [INFO] [stdout] 77 | | break; [INFO] [stdout] 78 | | } [INFO] [stdout] 79 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if let Some(dir) = self.data.projector.get(p) [INFO] [stdout] 75 ~ && let Some(value) = dir.get(key) { [INFO] [stdout] 76 | out = Some(value); [INFO] [stdout] 77 | break; [INFO] [stdout] 78 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/json_grabber.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | / return Projector { [INFO] [stdout] 95 | | config, [INFO] [stdout] 96 | | pwd, [INFO] [stdout] 97 | | data: default_data(), [INFO] [stdout] 98 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 ~ Projector { [INFO] [stdout] 95 + config, [INFO] [stdout] 96 + pwd, [INFO] [stdout] 97 + data: default_data(), [INFO] [stdout] 98 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/json_grabber.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | / return hashmap! { [INFO] [stdout] 113 | | [INFO] [stdout] 114 | | PathBuf::from("/") => hashmap! { [INFO] [stdout] 115 | | "foo".into() => "bar1".into(), [INFO] [stdout] ... | [INFO] [stdout] 125 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 ~ hashmap! { [INFO] [stdout] 113 + [INFO] [stdout] 114 + PathBuf::from("/") => hashmap! { [INFO] [stdout] 115 + "foo".into() => "bar1".into(), [INFO] [stdout] 116 + "fem".into() => "is_great".into() [INFO] [stdout] 117 + }, [INFO] [stdout] 118 + PathBuf::from("/foo") => hashmap! { [INFO] [stdout] 119 + "foo".into() => "bar2".into(), [INFO] [stdout] 120 + }, [INFO] [stdout] 121 + PathBuf::from("/foo/bar") => hashmap! { [INFO] [stdout] 122 + "foo".into() => "bar3".into(), [INFO] [stdout] 123 + } [INFO] [stdout] 124 + [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/json_grabber.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | / return Projector { [INFO] [stdout] 130 | | config: PathBuf::from(""), [INFO] [stdout] 131 | | pwd: pwd, [INFO] [stdout] 132 | | data: Data { [INFO] [stdout] 133 | | projector: get_data(), [INFO] [stdout] 134 | | }, [INFO] [stdout] 135 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 ~ Projector { [INFO] [stdout] 130 + config: PathBuf::from(""), [INFO] [stdout] 131 + pwd: pwd, [INFO] [stdout] 132 + data: Data { [INFO] [stdout] 133 + projector: get_data(), [INFO] [stdout] 134 + }, [INFO] [stdout] 135 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/jg.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return Ok(()); [INFO] [stdout] 52 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bin/jg.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | / proj.get_value(&k).map(|x| { [INFO] [stdout] 39 | | println!("{}", x); [INFO] [stdout] 40 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 38 - proj.get_value(&k).map(|x| { [INFO] [stdout] 39 - println!("{}", x); [INFO] [stdout] 40 - }); [INFO] [stdout] 38 + if let Some(x) = proj.get_value(&k) { println!("{}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/jg.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return Ok(()); [INFO] [stdout] 52 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bin/jg.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | / proj.get_value(&k).map(|x| { [INFO] [stdout] 39 | | println!("{}", x); [INFO] [stdout] 40 | | }); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 38 - proj.get_value(&k).map(|x| { [INFO] [stdout] 39 - println!("{}", x); [INFO] [stdout] 40 - }); [INFO] [stdout] 38 + if let Some(x) = proj.get_value(&k) { println!("{}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.10s [INFO] running `Command { std: "docker" "inspect" "804e38ed73190ebbfe0206150e0aa3b87b57b46ec051fe0a1a1f59c0015116f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "804e38ed73190ebbfe0206150e0aa3b87b57b46ec051fe0a1a1f59c0015116f3", kill_on_drop: false }` [INFO] [stdout] 804e38ed73190ebbfe0206150e0aa3b87b57b46ec051fe0a1a1f59c0015116f3