[INFO] cloning repository https://github.com/Loshido/explorer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Loshido/explorer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLoshido%2Fexplorer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLoshido%2Fexplorer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4d66b5a66c991605851b2ee6acfdbfb712e167b6 [INFO] linting Loshido/explorer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLoshido%2Fexplorer" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Loshido/explorer [INFO] finished tweaking git repo https://github.com/Loshido/explorer [INFO] tweaked toml for git repo https://github.com/Loshido/explorer written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Loshido/explorer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Loshido/explorer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d4396420955df8c00bcd32cb87714d684416091a0a81b142f14e8f7165a9678c [INFO] running `Command { std: "docker" "start" "-a" "d4396420955df8c00bcd32cb87714d684416091a0a81b142f14e8f7165a9678c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d4396420955df8c00bcd32cb87714d684416091a0a81b142f14e8f7165a9678c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4396420955df8c00bcd32cb87714d684416091a0a81b142f14e8f7165a9678c", kill_on_drop: false }` [INFO] [stdout] d4396420955df8c00bcd32cb87714d684416091a0a81b142f14e8f7165a9678c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 552584165f1d9a865c0670be5e46fecff5aacdc85962a622bbfc246ca7734f42 [INFO] running `Command { std: "docker" "start" "-a" "552584165f1d9a865c0670be5e46fecff5aacdc85962a622bbfc246ca7734f42", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.225 [INFO] [stderr] Compiling serde v1.0.225 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Compiling ref-cast v1.0.24 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling powerfmt v0.2.0 [INFO] [stderr] Compiling bytes v1.10.1 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Compiling tracing-core v0.1.34 [INFO] [stderr] Compiling uncased v0.9.10 [INFO] [stderr] Compiling bitflags v2.9.4 [INFO] [stderr] Compiling deranged v0.5.3 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling cc v1.2.37 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling futures-io v0.3.31 [INFO] [stderr] Compiling thiserror v2.0.16 [INFO] [stderr] Compiling inlinable_string v0.1.15 [INFO] [stderr] Compiling tower-service v0.3.3 [INFO] [stderr] Compiling indexmap v2.11.3 [INFO] [stderr] Compiling stable-pattern v0.1.0 [INFO] [stderr] Compiling http v0.2.12 [INFO] [stderr] Compiling multer v3.1.0 [INFO] [stderr] Compiling state v0.6.0 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling rocket v0.5.1 [INFO] [stderr] Compiling mio v1.0.4 [INFO] [stderr] Compiling socket2 v0.6.0 [INFO] [stderr] Compiling socket2 v0.5.10 [INFO] [stderr] Checking rustix v1.1.2 [INFO] [stderr] Compiling glob v0.3.3 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking pem v3.0.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Compiling tokio v1.47.1 [INFO] [stderr] Checking atomic v0.5.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking binascii v0.1.4 [INFO] [stderr] Compiling http-body v0.4.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling time v0.3.43 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking tempfile v3.22.0 [INFO] [stderr] Compiling futures v0.3.31 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Compiling hyper v0.14.32 [INFO] [stderr] Compiling devise_core v0.4.2 [INFO] [stderr] Compiling serde_derive v1.0.225 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling pear_codegen v0.2.9 [INFO] [stderr] Compiling ref-cast-impl v1.0.24 [INFO] [stderr] Compiling thiserror-impl v2.0.16 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling devise_codegen v0.4.2 [INFO] [stderr] Compiling pear v0.2.9 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Compiling devise v0.4.2 [INFO] [stderr] Checking simple_asn1 v0.6.3 [INFO] [stderr] Compiling rocket_http v0.5.1 [INFO] [stderr] Compiling rocket_codegen v0.5.1 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking ubyte v0.10.4 [INFO] [stderr] Checking jsonwebtoken v9.3.1 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking figment v0.10.19 [INFO] [stderr] Checking explorer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: name `HTML` contains a capitalized acronym [INFO] [stdout] --> src/endpoints/index.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | HTML(String), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HTML` contains a capitalized acronym [INFO] [stdout] --> src/endpoints/index.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | HTML(String), [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Html` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/endpoints/index.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if !token.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/endpoints/index.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if !token.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/endpoints/auth.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / pub enum Response { [INFO] [stdout] 8 | | #[response(status = 200)] [INFO] [stdout] 9 | | Logged(String), [INFO] [stdout] | | -------------- the second-largest variant contains at least 24 bytes [INFO] [stdout] ... | [INFO] [stdout] 15 | | AlreadyLogged(Redirect) [INFO] [stdout] | | ----------------------- the largest variant contains at least 272 bytes [INFO] [stdout] 16 | | } [INFO] [stdout] | |_^ the entire enum is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 15 - AlreadyLogged(Redirect) [INFO] [stdout] 15 + AlreadyLogged(Box) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/endpoints/auth.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / pub enum Response { [INFO] [stdout] 8 | | #[response(status = 200)] [INFO] [stdout] 9 | | Logged(String), [INFO] [stdout] | | -------------- the second-largest variant contains at least 24 bytes [INFO] [stdout] ... | [INFO] [stdout] 15 | | AlreadyLogged(Redirect) [INFO] [stdout] | | ----------------------- the largest variant contains at least 272 bytes [INFO] [stdout] 16 | | } [INFO] [stdout] | |_^ the entire enum is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 15 - AlreadyLogged(Redirect) [INFO] [stdout] 15 + AlreadyLogged(Box) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/endpoints/files.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | if !token.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/endpoints/files.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | if !token.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/auth/store.rs:34:1 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn exists(pass: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/auth/store.rs:34:1 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn exists(pass: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth/jwt.rs:45:34 [INFO] [stdout] | [INFO] [stdout] 45 | let token = decode::(&token, &key, &Validation::default()); [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth/jwt.rs:45:34 [INFO] [stdout] | [INFO] [stdout] 45 | let token = decode::(&token, &key, &Validation::default()); [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 46.90s [INFO] running `Command { std: "docker" "inspect" "552584165f1d9a865c0670be5e46fecff5aacdc85962a622bbfc246ca7734f42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "552584165f1d9a865c0670be5e46fecff5aacdc85962a622bbfc246ca7734f42", kill_on_drop: false }` [INFO] [stdout] 552584165f1d9a865c0670be5e46fecff5aacdc85962a622bbfc246ca7734f42