[INFO] cloning repository https://github.com/LorenzoFerri/ai_cup_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LorenzoFerri/ai_cup_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLorenzoFerri%2Fai_cup_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLorenzoFerri%2Fai_cup_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5d26b4fcf31aeaa05cbb9784c5ba343553ba30a6 [INFO] linting LorenzoFerri/ai_cup_rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLorenzoFerri%2Fai_cup_rust" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/LorenzoFerri/ai_cup_rust [INFO] finished tweaking git repo https://github.com/LorenzoFerri/ai_cup_rust [INFO] tweaked toml for git repo https://github.com/LorenzoFerri/ai_cup_rust written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/LorenzoFerri/ai_cup_rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/LorenzoFerri/ai_cup_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rand_pcg v0.3.0 [INFO] [stderr] Downloaded rand_seeder v0.2.2 [INFO] [stderr] Downloaded paste v1.0.5 [INFO] [stderr] Downloaded matrixmultiply v0.3.1 [INFO] [stderr] Downloaded simba v0.4.0 [INFO] [stderr] Downloaded nalgebra v0.26.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5a54535017abcd5e563c8c7c5c1d21a716253f80c095a1295d29a6150301ffa6 [INFO] running `Command { std: "docker" "start" "-a" "5a54535017abcd5e563c8c7c5c1d21a716253f80c095a1295d29a6150301ffa6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5a54535017abcd5e563c8c7c5c1d21a716253f80c095a1295d29a6150301ffa6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a54535017abcd5e563c8c7c5c1d21a716253f80c095a1295d29a6150301ffa6", kill_on_drop: false }` [INFO] [stdout] 5a54535017abcd5e563c8c7c5c1d21a716253f80c095a1295d29a6150301ffa6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a130bd554612fc3db251fd243e3904b050714f91fdff96ba3047189582f969a [INFO] running `Command { std: "docker" "start" "-a" "8a130bd554612fc3db251fd243e3904b050714f91fdff96ba3047189582f969a", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling paste v1.0.5 [INFO] [stderr] Checking matrixmultiply v0.3.1 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand_seeder v0.2.2 [INFO] [stderr] Checking rand_pcg v0.3.0 [INFO] [stderr] Checking num-rational v0.3.2 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking simba v0.4.0 [INFO] [stderr] Checking nalgebra v0.26.1 [INFO] [stderr] Checking ai_cup v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/point.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Point { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 3 | id: u16, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Point` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `comment` are never read [INFO] [stdout] --> src/problem.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Problem { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 6 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | pub comment: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Problem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/point.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | return sum_squared.sqrt() as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return sum_squared.sqrt() as i32; [INFO] [stdout] 17 + sum_squared.sqrt() as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/problem.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return &self.points[id - 1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return &self.points[id - 1]; [INFO] [stdout] 57 + &self.points[id - 1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulated_annealing.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | return 1f32; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return 1f32; [INFO] [stdout] 51 + 1f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulated_annealing.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | return ((energy - new_energy) as f32 / temperature).exp(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return ((energy - new_energy) as f32 / temperature).exp(); [INFO] [stdout] 53 + ((energy - new_energy) as f32 / temperature).exp() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/two_opt.rs:21:24 [INFO] [stdout] | [INFO] [stdout] 21 | if !(self.distance_matrix[(a, b)] > self.distance_matrix[(b, c)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.distance_matrix[(a, b)] <= self.distance_matrix[(b, c)])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/two_opt.rs:22:28 [INFO] [stdout] | [INFO] [stdout] 22 | && !(self.distance_matrix[(c, d)] > self.distance_matrix[(c, a)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.distance_matrix[(c, d)] <= self.distance_matrix[(c, a)])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/two_opt.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return total_gain; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return total_gain; [INFO] [stdout] 46 + total_gain [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/solution.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | let size = problem.dimension as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `problem.dimension` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solution.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return sum; [INFO] [stdout] 38 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/point.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Point { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 3 | id: u16, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Point` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `comment` are never read [INFO] [stdout] --> src/problem.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Problem { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 6 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | pub comment: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Problem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/point.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | return sum_squared.sqrt() as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return sum_squared.sqrt() as i32; [INFO] [stdout] 17 + sum_squared.sqrt() as i32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/problem.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return &self.points[id - 1]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return &self.points[id - 1]; [INFO] [stdout] 57 + &self.points[id - 1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulated_annealing.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | return 1f32; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return 1f32; [INFO] [stdout] 51 + 1f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/simulated_annealing.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | return ((energy - new_energy) as f32 / temperature).exp(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return ((energy - new_energy) as f32 / temperature).exp(); [INFO] [stdout] 53 + ((energy - new_energy) as f32 / temperature).exp() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/two_opt.rs:21:24 [INFO] [stdout] | [INFO] [stdout] 21 | if !(self.distance_matrix[(a, b)] > self.distance_matrix[(b, c)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.distance_matrix[(a, b)] <= self.distance_matrix[(b, c)])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/two_opt.rs:22:28 [INFO] [stdout] | [INFO] [stdout] 22 | && !(self.distance_matrix[(c, d)] > self.distance_matrix[(c, a)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.distance_matrix[(c, d)] <= self.distance_matrix[(c, a)])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/two_opt.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return total_gain; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return total_gain; [INFO] [stdout] 46 + total_gain [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/solution.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | let size = problem.dimension as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `problem.dimension` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/solution.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return sum; [INFO] [stdout] 38 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.67s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nalgebra v0.26.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "8a130bd554612fc3db251fd243e3904b050714f91fdff96ba3047189582f969a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a130bd554612fc3db251fd243e3904b050714f91fdff96ba3047189582f969a", kill_on_drop: false }` [INFO] [stdout] 8a130bd554612fc3db251fd243e3904b050714f91fdff96ba3047189582f969a