[INFO] cloning repository https://github.com/LordGoatius/jimmy_portion [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/LordGoatius/jimmy_portion" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLordGoatius%2Fjimmy_portion", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLordGoatius%2Fjimmy_portion'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 372c138285d1868c9498742bbca0916e3b060bfb [INFO] linting LordGoatius/jimmy_portion against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FLordGoatius%2Fjimmy_portion" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/LordGoatius/jimmy_portion [INFO] finished tweaking git repo https://github.com/LordGoatius/jimmy_portion [INFO] tweaked toml for git repo https://github.com/LordGoatius/jimmy_portion written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/LordGoatius/jimmy_portion on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/LordGoatius/jimmy_portion already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded unindent v0.1.11 [INFO] [stderr] Downloaded pyo3-macros v0.19.2 [INFO] [stderr] Downloaded target-lexicon v0.12.12 [INFO] [stderr] Downloaded pyo3-build-config v0.19.2 [INFO] [stderr] Downloaded pyo3-ffi v0.19.2 [INFO] [stderr] Downloaded permutator v0.4.3 [INFO] [stderr] Downloaded pyo3-macros-backend v0.19.2 [INFO] [stderr] Downloaded pyo3 v0.19.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a5e723f9aef37a31f3dc35390d2eae872938681af0a98fa5748ca1f6419ae39f [INFO] running `Command { std: "docker" "start" "-a" "a5e723f9aef37a31f3dc35390d2eae872938681af0a98fa5748ca1f6419ae39f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a5e723f9aef37a31f3dc35390d2eae872938681af0a98fa5748ca1f6419ae39f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5e723f9aef37a31f3dc35390d2eae872938681af0a98fa5748ca1f6419ae39f", kill_on_drop: false }` [INFO] [stdout] a5e723f9aef37a31f3dc35390d2eae872938681af0a98fa5748ca1f6419ae39f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 020b1d9ef7e193648bd5417acf4e4962441ce63b92385fd5b45f484b7714ec33 [INFO] running `Command { std: "docker" "start" "-a" "020b1d9ef7e193648bd5417acf4e4962441ce63b92385fd5b45f484b7714ec33", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.12 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking hashbrown v0.14.2 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking unindent v0.1.11 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling pyo3-build-config v0.19.2 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking petgraph v0.6.4 [INFO] [stderr] Compiling pyo3-ffi v0.19.2 [INFO] [stderr] Compiling pyo3 v0.19.2 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking permutator v0.4.3 [INFO] [stderr] Compiling pyo3-macros-backend v0.19.2 [INFO] [stderr] Compiling pyo3-macros v0.19.2 [INFO] [stderr] Checking jimmy_portion v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 30 | map.insert(i as usize, *color); [INFO] [stdout] | ^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 81 | if !(edge_amount > (node_amount)*(node_amount - 1) / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(edge_amount <= (node_amount)*(node_amount - 1) / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/lib.rs:203:54 [INFO] [stdout] | [INFO] [stdout] 203 | ...eighbors(*i).map(|node| if coloring.contains_key(&node) { Some(coloring[&node]) } else { None }).flatten().collect_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `filter_map` and remove the `.flatten()`: `filter_map(|node| if coloring.contains_key(&node) { Some(coloring[&node]) } else { None })` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lib.rs:244:138 [INFO] [stdout] | [INFO] [stdout] 244 | if graph.nodes().map(|elem| graph.neighbors(elem).count() == 2).filter(|item| !item).count() == 0 && graph.node_count() % 2 == 1 { [INFO] [stdout] | __________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 245 | | brooks + 1 [INFO] [stdout] 246 | | } else if graph.nodes().map(|elem| graph.neighbors(elem).count() == graph.node_count() - 1).filter(|item| !item).count() == 0 { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lib.rs:246:135 [INFO] [stdout] | [INFO] [stdout] 246 | } else if graph.nodes().map(|elem| graph.neighbors(elem).count() == graph.node_count() - 1).filter(|item| !item).count() == 0 { [INFO] [stdout] | _______________________________________________________________________________________________________________________________________^ [INFO] [stdout] 247 | | brooks + 1 [INFO] [stdout] 248 | | } else { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:270:54 [INFO] [stdout] | [INFO] [stdout] 270 | if check_if_valid_coloring(coloring.clone(), &graph) { [INFO] [stdout] | ^^^^^^ help: change this to: `graph` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:286:32 [INFO] [stdout] | [INFO] [stdout] 286 | index_vec.push(index as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 30 | map.insert(i as usize, *color); [INFO] [stdout] | ^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 81 | if !(edge_amount > (node_amount)*(node_amount - 1) / 2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(edge_amount <= (node_amount)*(node_amount - 1) / 2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/lib.rs:203:54 [INFO] [stdout] | [INFO] [stdout] 203 | ...eighbors(*i).map(|node| if coloring.contains_key(&node) { Some(coloring[&node]) } else { None }).flatten().collect_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `filter_map` and remove the `.flatten()`: `filter_map(|node| if coloring.contains_key(&node) { Some(coloring[&node]) } else { None })` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/lib.rs:244:138 [INFO] [stdout] | [INFO] [stdout] 244 | if graph.nodes().map(|elem| graph.neighbors(elem).count() == 2).filter(|item| !item).count() == 0 && graph.node_count() % 2 == 1 { [INFO] [stdout] | __________________________________________________________________________________________________________________________________________^ [INFO] [stdout] 245 | | brooks + 1 [INFO] [stdout] 246 | | } else if graph.nodes().map(|elem| graph.neighbors(elem).count() == graph.node_count() - 1).filter(|item| !item).count() == 0 { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/lib.rs:246:135 [INFO] [stdout] | [INFO] [stdout] 246 | } else if graph.nodes().map(|elem| graph.neighbors(elem).count() == graph.node_count() - 1).filter(|item| !item).count() == 0 { [INFO] [stdout] | _______________________________________________________________________________________________________________________________________^ [INFO] [stdout] 247 | | brooks + 1 [INFO] [stdout] 248 | | } else { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:270:54 [INFO] [stdout] | [INFO] [stdout] 270 | if check_if_valid_coloring(coloring.clone(), &graph) { [INFO] [stdout] | ^^^^^^ help: change this to: `graph` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:286:32 [INFO] [stdout] | [INFO] [stdout] 286 | index_vec.push(index as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.81s [INFO] running `Command { std: "docker" "inspect" "020b1d9ef7e193648bd5417acf4e4962441ce63b92385fd5b45f484b7714ec33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "020b1d9ef7e193648bd5417acf4e4962441ce63b92385fd5b45f484b7714ec33", kill_on_drop: false }` [INFO] [stdout] 020b1d9ef7e193648bd5417acf4e4962441ce63b92385fd5b45f484b7714ec33